René's URL Explorer Experiment


Title: Fix arrow functions inside ternary expressions by MaximSokolov · Pull Request #408 · atom/language-javascript · GitHub

Open Graph Title: Fix arrow functions inside ternary expressions by MaximSokolov · Pull Request #408 · atom/language-javascript

X Title: Fix arrow functions inside ternary expressions by MaximSokolov · Pull Request #408 · atom/language-javascript

Description: Fixes #406 by using begin/end matching for ternary expressions result = condition ? something : (a, b) => a + b Fixes #279 by matching case statements only in switch block (replaces #405 fix) switc...

Open Graph Description: Fixes #406 by using begin/end matching for ternary expressions result = condition ? something : (a, b) => a + b Fixes #279 by matching case statements only in switch block (replaces #405 fix) sw...

X Description: Fixes #406 by using begin/end matching for ternary expressions result = condition ? something : (a, b) => a + b Fixes #279 by matching case statements only in switch block (replaces #405 fix...

Opengraph URL: https://github.com/atom/language-javascript/pull/408

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5cc24d33-3144-b7f1-bc8b-60ff5454f85a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA07A:18A62A:97982A7:C44225E:697615C9
html-safe-noncee597c5b252461d145b6e744d60c23bd18480e00ba73158a43358118dba03a03f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDdBOjE4QTYyQTo5Nzk4MkE3OkM0NDIyNUU6Njk3NjE1QzkiLCJ2aXNpdG9yX2lkIjoiMjg5MDUwNzA2OTIxNzQ0NTMyMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac97d625411978d8d13556826da494860b8d2ed2bc282554fe5bc79222133f5dc2
hovercard-subject-tagpull_request:82077667
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/atom/language-javascript/408/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a06bf77e0c3e3284599b663dd24d3524868b46e08cc7b7f1eb86cd06fd3d2f9f/atom/language-javascript/pull/408
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a06bf77e0c3e3284599b663dd24d3524868b46e08cc7b7f1eb86cd06fd3d2f9f/atom/language-javascript/pull/408
og:image:altFixes #406 by using begin/end matching for ternary expressions result = condition ? something : (a, b) => a + b Fixes #279 by matching case statements only in switch block (replaces #405 fix) sw...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMaximSokolov
hostnamegithub.com
expected-hostnamegithub.com
Nonec6814b4cc7afd45cd6e64525d0cff0e76dd802f315a5b0e55a7abda1d1d070d0
turbo-cache-controlno-preview
go-importgithub.com/atom/language-javascript git https://github.com/atom/language-javascript.git
octolytics-dimension-user_id1089146
octolytics-dimension-user_loginatom
octolytics-dimension-repository_id13712111
octolytics-dimension-repository_nwoatom/language-javascript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id13712111
octolytics-dimension-repository_network_root_nwoatom/language-javascript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4ea235bfed58ef16c8a5642b3ac64b74f10c9f52
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fatom%2Flanguage-javascript%2Fpull%2F408
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fatom%2Flanguage-javascript%2Fpull%2F408
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=atom%2Flanguage-javascript
Reloadhttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/408
Reloadhttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/408
Reloadhttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/408
atom https://patch-diff.githubusercontent.com/atom
language-javascripthttps://patch-diff.githubusercontent.com/atom/language-javascript
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fatom%2Flanguage-javascript
Fork 235 https://patch-diff.githubusercontent.com/login?return_to=%2Fatom%2Flanguage-javascript
Star 197 https://patch-diff.githubusercontent.com/login?return_to=%2Fatom%2Flanguage-javascript
Code https://patch-diff.githubusercontent.com/atom/language-javascript
Issues 82 https://patch-diff.githubusercontent.com/atom/language-javascript/issues
Pull requests 12 https://patch-diff.githubusercontent.com/atom/language-javascript/pulls
Actions https://patch-diff.githubusercontent.com/atom/language-javascript/actions
Projects 0 https://patch-diff.githubusercontent.com/atom/language-javascript/projects
Wiki https://patch-diff.githubusercontent.com/atom/language-javascript/wiki
Security 0 https://patch-diff.githubusercontent.com/atom/language-javascript/security
Insights https://patch-diff.githubusercontent.com/atom/language-javascript/pulse
Code https://patch-diff.githubusercontent.com/atom/language-javascript
Issues https://patch-diff.githubusercontent.com/atom/language-javascript/issues
Pull requests https://patch-diff.githubusercontent.com/atom/language-javascript/pulls
Actions https://patch-diff.githubusercontent.com/atom/language-javascript/actions
Projects https://patch-diff.githubusercontent.com/atom/language-javascript/projects
Wiki https://patch-diff.githubusercontent.com/atom/language-javascript/wiki
Security https://patch-diff.githubusercontent.com/atom/language-javascript/security
Insights https://patch-diff.githubusercontent.com/atom/language-javascript/pulse
winstliuhttps://patch-diff.githubusercontent.com/winstliu
atom:masterhttps://patch-diff.githubusercontent.com/atom/language-javascript/tree/master
Fix arrow functions inside ternary expressions https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#top
winstliuhttps://patch-diff.githubusercontent.com/winstliu
atom:masterhttps://patch-diff.githubusercontent.com/atom/language-javascript/tree/master
Conversation 9 https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408
Commits 6 https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/commits
Checks 0 https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/checks
Files changed https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/files
Please reload this pagehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/408
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/atom/language-javascript/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/MaximSokolov
MaximSokolovhttps://patch-diff.githubusercontent.com/MaximSokolov
Aug 20, 2016https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#issue-172269181
#406https://github.com/atom/language-javascript/issues/406
#279https://github.com/atom/language-javascript/issues/279
#405https://github.com/atom/language-javascript/pull/405
Please reload this pagehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/408
https://patch-diff.githubusercontent.com/MaximSokolov
🐛 Fix arrow functions inside ternary expressionshttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/commits/2329ef23fc25f90e5801ed305fccf23a658b333c
2329ef2https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/commits/2329ef23fc25f90e5801ed305fccf23a658b333c
https://patch-diff.githubusercontent.com/Alhadis
Alhadishttps://patch-diff.githubusercontent.com/Alhadis
Aug 20, 2016https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#issuecomment-241206094
Please reload this pagehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/408
https://patch-diff.githubusercontent.com/Alhadis
Alhadishttps://patch-diff.githubusercontent.com/Alhadis
Aug 20, 2016https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#issuecomment-241206493
#279https://github.com/atom/language-javascript/issues/279
Please reload this pagehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/408
https://patch-diff.githubusercontent.com/MaximSokolov
MaximSokolovhttps://patch-diff.githubusercontent.com/MaximSokolov
Aug 20, 2016https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#issuecomment-241207444
#307https://github.com/atom/language-javascript/pull/307
Please reload this pagehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/408
https://patch-diff.githubusercontent.com/Alhadis
Alhadishttps://patch-diff.githubusercontent.com/Alhadis
Aug 20, 2016https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#issuecomment-241207734
Please reload this pagehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/408
https://patch-diff.githubusercontent.com/MaximSokolov
🔥 Remove unneeded codehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/commits/a2ae4660408c88f6094fa02cb2eb728ae98eac0f
a2ae466https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/commits/a2ae4660408c88f6094fa02cb2eb728ae98eac0f
https://patch-diff.githubusercontent.com/Alhadis
Alhadishttps://patch-diff.githubusercontent.com/Alhadis
Aug 22, 2016https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#issuecomment-241312932
new version of Linguisthttps://github.com/github/linguist/pull/2773#issuecomment-241062154
@pchaignohttps://github.com/pchaigno
@arfonhttps://github.com/arfon
Please reload this pagehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/408
https://patch-diff.githubusercontent.com/winstliu
winstliuhttps://patch-diff.githubusercontent.com/winstliu
Aug 23, 2016https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#issuecomment-241600437
Please reload this pagehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/408
winstliuhttps://patch-diff.githubusercontent.com/winstliu
Aug 23, 2016 https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#discussion-diff-75789698
View reviewed changes https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/files/a2ae4660408c88f6094fa02cb2eb728ae98eac0f#diff-eb4d6a651ba24caf4dd09a5759907caa8599306654fc5cf8d25c695248e565cd
grammars/javascript.csonhttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/files#diff-eb4d6a651ba24caf4dd09a5759907caa8599306654fc5cf8d25c695248e565cd
winstliuhttps://patch-diff.githubusercontent.com/winstliu
Aug 23, 2016https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#discussion_r75789698
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/408
MaximSokolovhttps://patch-diff.githubusercontent.com/MaximSokolov
Aug 23, 2016https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#discussion_r75825314
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
157241dhttps://github.com/atom/language-javascript/commit/157241d0fd3c8804f15a4387e1275d5fdbb050dc
Please reload this pagehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/408
MaximSokolovhttps://patch-diff.githubusercontent.com/MaximSokolov
August 23, 2016 10:26https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#commits-pushed-3d1f8f3
https://patch-diff.githubusercontent.com/MaximSokolov
✅ Add test for debugger statementhttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/commits/3d1f8f38c3f91e85dd0cb8b3348a8783c652d6ef
3d1f8f3https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/commits/3d1f8f38c3f91e85dd0cb8b3348a8783c652d6ef
https://patch-diff.githubusercontent.com/MaximSokolov
🔥 Remove unneeded codehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/commits/7296d5df7a242f4d99831f7e35c4fbfc39db4bc8
7296d5dhttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/commits/7296d5df7a242f4d99831f7e35c4fbfc39db4bc8
https://patch-diff.githubusercontent.com/MaximSokolov
Add subscope for debugger keywordhttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/commits/9945c23c937f0c52f8bce9c5ad923149f67a15b2
9945c23https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/commits/9945c23c937f0c52f8bce9c5ad923149f67a15b2
https://patch-diff.githubusercontent.com/MaximSokolov
🎨 Move rule to the repohttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/commits/157241d0fd3c8804f15a4387e1275d5fdbb050dc
157241dhttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/commits/157241d0fd3c8804f15a4387e1275d5fdbb050dc
https://patch-diff.githubusercontent.com/MaximSokolov
MaximSokolovhttps://patch-diff.githubusercontent.com/MaximSokolov
Aug 23, 2016 https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#ref-pullrequest-172672175
Modernise grammar and fix bugs #415 https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415
https://patch-diff.githubusercontent.com/winstliu
winstliuhttps://patch-diff.githubusercontent.com/winstliu
Aug 23, 2016https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#issuecomment-241789620
7296d5dhttps://github.com/atom/language-javascript/commit/7296d5df7a242f4d99831f7e35c4fbfc39db4bc8
@MaximSokolovhttps://github.com/MaximSokolov
Please reload this pagehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/408
https://patch-diff.githubusercontent.com/winstliu
winstliuhttps://patch-diff.githubusercontent.com/winstliu
0b4b99chttps://patch-diff.githubusercontent.com/atom/language-javascript/commit/0b4b99cb1a542a6a7e2da3f68a27e9c2b1f1a334
Aug 23, 2016https://github.com/atom/language-javascript/pull/408#event-764736471
https://patch-diff.githubusercontent.com/MaximSokolov
MaximSokolovhttps://patch-diff.githubusercontent.com/MaximSokolov
August 23, 2016 16:21https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#event-764737386
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fatom%2Flanguage-javascript%2Fpull%2F408
Arrow functions at the end of ternary expressions are not recognized https://github.com/atom/language-javascript/issues/406
no highlight for case null: inside switch block https://github.com/atom/language-javascript/issues/279
Please reload this pagehttps://patch-diff.githubusercontent.com/atom/language-javascript/pull/408
https://patch-diff.githubusercontent.com/MaximSokolov
https://patch-diff.githubusercontent.com/Alhadis
https://patch-diff.githubusercontent.com/winstliu
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.