| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:5cc24d33-3144-b7f1-bc8b-60ff5454f85a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A07A:18A62A:97982A7:C44225E:697615C9 |
| html-safe-nonce | e597c5b252461d145b6e744d60c23bd18480e00ba73158a43358118dba03a03f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDdBOjE4QTYyQTo5Nzk4MkE3OkM0NDIyNUU6Njk3NjE1QzkiLCJ2aXNpdG9yX2lkIjoiMjg5MDUwNzA2OTIxNzQ0NTMyMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 97d625411978d8d13556826da494860b8d2ed2bc282554fe5bc79222133f5dc2 |
| hovercard-subject-tag | pull_request:82077667 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/atom/language-javascript/408/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a06bf77e0c3e3284599b663dd24d3524868b46e08cc7b7f1eb86cd06fd3d2f9f/atom/language-javascript/pull/408 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a06bf77e0c3e3284599b663dd24d3524868b46e08cc7b7f1eb86cd06fd3d2f9f/atom/language-javascript/pull/408 |
| og:image:alt | Fixes #406 by using begin/end matching for ternary expressions
result = condition ? something : (a, b) => a + b
Fixes #279 by matching case statements only in switch block (replaces #405 fix)
sw... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | MaximSokolov |
| hostname | github.com |
| expected-hostname | github.com |
| None | c6814b4cc7afd45cd6e64525d0cff0e76dd802f315a5b0e55a7abda1d1d070d0 |
| turbo-cache-control | no-preview |
| go-import | github.com/atom/language-javascript git https://github.com/atom/language-javascript.git |
| octolytics-dimension-user_id | 1089146 |
| octolytics-dimension-user_login | atom |
| octolytics-dimension-repository_id | 13712111 |
| octolytics-dimension-repository_nwo | atom/language-javascript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 13712111 |
| octolytics-dimension-repository_network_root_nwo | atom/language-javascript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4ea235bfed58ef16c8a5642b3ac64b74f10c9f52 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fatom%2Flanguage-javascript%2Fpull%2F408 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fatom%2Flanguage-javascript%2Fpull%2F408 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=atom%2Flanguage-javascript |
| Reload | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408 |
| Reload | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408 |
| Reload | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408 |
|
atom
| https://patch-diff.githubusercontent.com/atom |
| language-javascript | https://patch-diff.githubusercontent.com/atom/language-javascript |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2Fatom%2Flanguage-javascript |
|
Fork
235
| https://patch-diff.githubusercontent.com/login?return_to=%2Fatom%2Flanguage-javascript |
|
Star
197
| https://patch-diff.githubusercontent.com/login?return_to=%2Fatom%2Flanguage-javascript |
|
Code
| https://patch-diff.githubusercontent.com/atom/language-javascript |
|
Issues
82
| https://patch-diff.githubusercontent.com/atom/language-javascript/issues |
|
Pull requests
12
| https://patch-diff.githubusercontent.com/atom/language-javascript/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/atom/language-javascript/actions |
|
Projects
0
| https://patch-diff.githubusercontent.com/atom/language-javascript/projects |
|
Wiki
| https://patch-diff.githubusercontent.com/atom/language-javascript/wiki |
|
Security
0
| https://patch-diff.githubusercontent.com/atom/language-javascript/security |
|
Insights
| https://patch-diff.githubusercontent.com/atom/language-javascript/pulse |
|
Code
| https://patch-diff.githubusercontent.com/atom/language-javascript |
|
Issues
| https://patch-diff.githubusercontent.com/atom/language-javascript/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/atom/language-javascript/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/atom/language-javascript/actions |
|
Projects
| https://patch-diff.githubusercontent.com/atom/language-javascript/projects |
|
Wiki
| https://patch-diff.githubusercontent.com/atom/language-javascript/wiki |
|
Security
| https://patch-diff.githubusercontent.com/atom/language-javascript/security |
|
Insights
| https://patch-diff.githubusercontent.com/atom/language-javascript/pulse |
| winstliu | https://patch-diff.githubusercontent.com/winstliu |
| atom:master | https://patch-diff.githubusercontent.com/atom/language-javascript/tree/master |
|
Fix arrow functions inside ternary expressions
| https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#top |
| winstliu | https://patch-diff.githubusercontent.com/winstliu |
| atom:master | https://patch-diff.githubusercontent.com/atom/language-javascript/tree/master |
|
Conversation
9
| https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408 |
|
Commits
6
| https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/commits |
|
Checks
0
| https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/checks |
|
Files changed
| https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/files |
| Please reload this page | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408 |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/atom/language-javascript/pull/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/MaximSokolov |
| MaximSokolov | https://patch-diff.githubusercontent.com/MaximSokolov |
| Aug 20, 2016 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#issue-172269181 |
| #406 | https://github.com/atom/language-javascript/issues/406 |
| #279 | https://github.com/atom/language-javascript/issues/279 |
| #405 | https://github.com/atom/language-javascript/pull/405 |
| Please reload this page | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408 |
|
| https://patch-diff.githubusercontent.com/MaximSokolov |
| 🐛 Fix arrow functions inside ternary expressions | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/commits/2329ef23fc25f90e5801ed305fccf23a658b333c |
| 2329ef2 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/commits/2329ef23fc25f90e5801ed305fccf23a658b333c |
| https://patch-diff.githubusercontent.com/Alhadis |
| Alhadis | https://patch-diff.githubusercontent.com/Alhadis |
| Aug 20, 2016 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#issuecomment-241206094 |
| Please reload this page | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408 |
| https://patch-diff.githubusercontent.com/Alhadis |
| Alhadis | https://patch-diff.githubusercontent.com/Alhadis |
| Aug 20, 2016 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#issuecomment-241206493 |
| #279 | https://github.com/atom/language-javascript/issues/279 |
| Please reload this page | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408 |
| https://patch-diff.githubusercontent.com/MaximSokolov |
| MaximSokolov | https://patch-diff.githubusercontent.com/MaximSokolov |
| Aug 20, 2016 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#issuecomment-241207444 |
| #307 | https://github.com/atom/language-javascript/pull/307 |
| Please reload this page | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408 |
| https://patch-diff.githubusercontent.com/Alhadis |
| Alhadis | https://patch-diff.githubusercontent.com/Alhadis |
| Aug 20, 2016 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#issuecomment-241207734 |
| Please reload this page | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408 |
|
| https://patch-diff.githubusercontent.com/MaximSokolov |
| 🔥 Remove unneeded code | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/commits/a2ae4660408c88f6094fa02cb2eb728ae98eac0f |
| a2ae466 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/commits/a2ae4660408c88f6094fa02cb2eb728ae98eac0f |
| https://patch-diff.githubusercontent.com/Alhadis |
| Alhadis | https://patch-diff.githubusercontent.com/Alhadis |
| Aug 22, 2016 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#issuecomment-241312932 |
| new version of Linguist | https://github.com/github/linguist/pull/2773#issuecomment-241062154 |
| @pchaigno | https://github.com/pchaigno |
| @arfon | https://github.com/arfon |
| Please reload this page | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408 |
| https://patch-diff.githubusercontent.com/winstliu |
| winstliu | https://patch-diff.githubusercontent.com/winstliu |
| Aug 23, 2016 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#issuecomment-241600437 |
| Please reload this page | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408 |
| winstliu | https://patch-diff.githubusercontent.com/winstliu |
|
Aug 23, 2016
| https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#discussion-diff-75789698 |
| View reviewed changes
| https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/files/a2ae4660408c88f6094fa02cb2eb728ae98eac0f#diff-eb4d6a651ba24caf4dd09a5759907caa8599306654fc5cf8d25c695248e565cd |
| grammars/javascript.cson | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/files#diff-eb4d6a651ba24caf4dd09a5759907caa8599306654fc5cf8d25c695248e565cd |
| winstliu | https://patch-diff.githubusercontent.com/winstliu |
| Aug 23, 2016 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#discussion_r75789698 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408 |
| MaximSokolov | https://patch-diff.githubusercontent.com/MaximSokolov |
| Aug 23, 2016 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#discussion_r75825314 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| 157241d | https://github.com/atom/language-javascript/commit/157241d0fd3c8804f15a4387e1275d5fdbb050dc |
| Please reload this page | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408 |
| MaximSokolov | https://patch-diff.githubusercontent.com/MaximSokolov |
| August 23, 2016 10:26 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#commits-pushed-3d1f8f3 |
|
| https://patch-diff.githubusercontent.com/MaximSokolov |
| ✅ Add test for debugger statement | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/commits/3d1f8f38c3f91e85dd0cb8b3348a8783c652d6ef |
| 3d1f8f3 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/commits/3d1f8f38c3f91e85dd0cb8b3348a8783c652d6ef |
|
| https://patch-diff.githubusercontent.com/MaximSokolov |
| 🔥 Remove unneeded code | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/commits/7296d5df7a242f4d99831f7e35c4fbfc39db4bc8 |
| 7296d5d | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/commits/7296d5df7a242f4d99831f7e35c4fbfc39db4bc8 |
|
| https://patch-diff.githubusercontent.com/MaximSokolov |
| Add subscope for debugger keyword | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/commits/9945c23c937f0c52f8bce9c5ad923149f67a15b2 |
| 9945c23 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/commits/9945c23c937f0c52f8bce9c5ad923149f67a15b2 |
|
| https://patch-diff.githubusercontent.com/MaximSokolov |
| 🎨 Move rule to the repo | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/commits/157241d0fd3c8804f15a4387e1275d5fdbb050dc |
| 157241d | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408/commits/157241d0fd3c8804f15a4387e1275d5fdbb050dc |
| https://patch-diff.githubusercontent.com/MaximSokolov |
| MaximSokolov | https://patch-diff.githubusercontent.com/MaximSokolov |
|
Aug 23, 2016
| https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#ref-pullrequest-172672175 |
|
Modernise grammar and fix bugs
#415
| https://patch-diff.githubusercontent.com/atom/language-javascript/pull/415 |
| https://patch-diff.githubusercontent.com/winstliu |
| winstliu | https://patch-diff.githubusercontent.com/winstliu |
| Aug 23, 2016 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#issuecomment-241789620 |
| 7296d5d | https://github.com/atom/language-javascript/commit/7296d5df7a242f4d99831f7e35c4fbfc39db4bc8 |
| @MaximSokolov | https://github.com/MaximSokolov |
| Please reload this page | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408 |
| https://patch-diff.githubusercontent.com/winstliu |
| winstliu | https://patch-diff.githubusercontent.com/winstliu |
| 0b4b99c | https://patch-diff.githubusercontent.com/atom/language-javascript/commit/0b4b99cb1a542a6a7e2da3f68a27e9c2b1f1a334 |
| Aug 23, 2016 | https://github.com/atom/language-javascript/pull/408#event-764736471 |
| https://patch-diff.githubusercontent.com/MaximSokolov |
| MaximSokolov | https://patch-diff.githubusercontent.com/MaximSokolov |
| August 23, 2016 16:21 | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408#event-764737386 |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fatom%2Flanguage-javascript%2Fpull%2F408 |
|
Arrow functions at the end of ternary expressions are not recognized
| https://github.com/atom/language-javascript/issues/406 |
|
no highlight for case null: inside switch block
| https://github.com/atom/language-javascript/issues/279 |
| Please reload this page | https://patch-diff.githubusercontent.com/atom/language-javascript/pull/408 |
|
| https://patch-diff.githubusercontent.com/MaximSokolov |
|
| https://patch-diff.githubusercontent.com/Alhadis |
|
| https://patch-diff.githubusercontent.com/winstliu |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |