| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e3d3e0ab-8c42-be72-dd42-5faf40d2986d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B254:330DBF:16DF34F:1FDD47C:697272CB |
| html-safe-nonce | ab0bce9294dc15d804bc9de675a7052ee770fd3cdf354dadc782064aea4d0955 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjU0OjMzMERCRjoxNkRGMzRGOjFGREQ0N0M6Njk3MjcyQ0IiLCJ2aXNpdG9yX2lkIjoiNTMzODk0ODQ5MzI1MzMxMTQ4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 5c0177c159093a31ce79ec186434abefa653a0e3617a333d7c417156c7e31df4 |
| hovercard-subject-tag | pull_request:80007755 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/aspnet/JavaScriptServices/243/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/67280989ffd5ec26648e77da7bb0ab391a2c98da23b2e3fcf251408077565960/aspnet/JavaScriptServices/pull/243 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/67280989ffd5ec26648e77da7bb0ab391a2c98da23b2e3fcf251408077565960/aspnet/JavaScriptServices/pull/243 |
| og:image:alt | I noticed that there was some room for improvement in the Dockerfiles created by the Yeomen generator. There are two parts to it:
Run the apt-get commands before any project-specific commands.
Cop... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | aidansteele |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3be355d8ea7ca74c4edec03a70ecaa8211862649e90886d88a4db13e6778e4c3 |
| turbo-cache-control | no-preview |
| go-import | github.com/aspnet/JavaScriptServices git https://github.com/aspnet/JavaScriptServices.git |
| octolytics-dimension-user_id | 6476660 |
| octolytics-dimension-user_login | aspnet |
| octolytics-dimension-repository_id | 45365298 |
| octolytics-dimension-repository_nwo | aspnet/JavaScriptServices |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45365298 |
| octolytics-dimension-repository_network_root_nwo | aspnet/JavaScriptServices |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4ae5b6c1e16519c3e3ad37a388f7cca2192a79a8 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/243#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Faspnet%2FJavaScriptServices%2Fpull%2F243 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Faspnet%2FJavaScriptServices%2Fpull%2F243 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=aspnet%2FJavaScriptServices |
| Reload | https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/243 |
| Reload | https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/243 |
| Reload | https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/243 |
|
aspnet
| https://patch-diff.githubusercontent.com/aspnet |
| JavaScriptServices | https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2Faspnet%2FJavaScriptServices |
|
Fork
516
| https://patch-diff.githubusercontent.com/login?return_to=%2Faspnet%2FJavaScriptServices |
|
Star
3k
| https://patch-diff.githubusercontent.com/login?return_to=%2Faspnet%2FJavaScriptServices |
|
Code
| https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices |
|
Issues
0
| https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/issues |
|
Pull requests
0
| https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pulls |
|
Projects
0
| https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/projects |
|
Wiki
| https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/wiki |
|
Security
0
| https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/security |
|
Insights
| https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pulse |
|
Code
| https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices |
|
Issues
| https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pulls |
|
Projects
| https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/projects |
|
Wiki
| https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/wiki |
|
Security
| https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/security |
|
Insights
| https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pulse |
| aidansteele | https://patch-diff.githubusercontent.com/aidansteele |
| aspnet:dev | https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/tree/dev |
| aidansteele:dev | https://patch-diff.githubusercontent.com/aidansteele/JavaScriptServices/tree/dev |
|
Dockerfile best practices to speed up builds
| https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/243#top |
| aidansteele | https://patch-diff.githubusercontent.com/aidansteele |
| aspnet:dev | https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/tree/dev |
| aidansteele:dev | https://patch-diff.githubusercontent.com/aidansteele/JavaScriptServices/tree/dev |
|
Conversation
3
| https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/243 |
|
Commits
2
| https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/243/commits |
|
Checks
0
| https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/243/checks |
|
Files changed
| https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/243/files |
| Please reload this page | https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/243 |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/aidansteele |
| aidansteele | https://patch-diff.githubusercontent.com/aidansteele |
| Aug 4, 2016 | https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/243#issue-169274998 |
| Please reload this page | https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/243 |
| rationale | https://docs.docker.com/engine/userguide/eng-image/dockerfile_best-practices/#/build-cache |
| Please reload this page | https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/243 |
| aidansteele | https://patch-diff.githubusercontent.com/aidansteele |
| August 4, 2016 11:42 | https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/243#commits-pushed-ca054f1 |
|
| https://patch-diff.githubusercontent.com/aidansteele |
| Perform nodejs installation before COPY in Dockerfile templates | https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/243/commits/ca054f1e522ce8f6f9bfb54fd6ff7d54a366c3cc |
| ca054f1 | https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/243/commits/ca054f1e522ce8f6f9bfb54fd6ff7d54a366c3cc |
|
| https://patch-diff.githubusercontent.com/aidansteele |
| Copy only project.json before dotnet restore in Dockerfile templates | https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/243/commits/5f742f0a7cbd8ba41a8e1c0f04c62f8541652d84 |
| 5f742f0 | https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/243/commits/5f742f0a7cbd8ba41a8e1c0f04c62f8541652d84 |
| https://patch-diff.githubusercontent.com/dnfclas |
| dnfclas | https://patch-diff.githubusercontent.com/dnfclas |
| Aug 4, 2016 | https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/243#issuecomment-237431647 |
| @aidansteele | https://github.com/aidansteele |
| https://cla2.dotnetfoundation.org | https://cla2.dotnetfoundation.org |
| Please reload this page | https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/243 |
| https://patch-diff.githubusercontent.com/dnfclas |
| dnfclas | https://patch-diff.githubusercontent.com/dnfclas |
|
cla-required
| https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/issues?q=state%3Aopen%20label%3Acla-required |
| Aug 4, 2016 | https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/243#event-744700255 |
| https://patch-diff.githubusercontent.com/dnfclas |
| dnfclas | https://patch-diff.githubusercontent.com/dnfclas |
| Aug 4, 2016 | https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/243#issuecomment-237432011 |
| @aidansteele | https://github.com/aidansteele |
| Please reload this page | https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/243 |
| https://patch-diff.githubusercontent.com/dnfclas |
| dnfclas | https://patch-diff.githubusercontent.com/dnfclas |
|
cla-signed
| https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/issues?q=state%3Aopen%20label%3Acla-signed |
|
cla-required
| https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/issues?q=state%3Aopen%20label%3Acla-required |
| Aug 4, 2016 | https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/243#event-744701558 |
| https://patch-diff.githubusercontent.com/SteveSandersonMS |
| SteveSandersonMS | https://patch-diff.githubusercontent.com/SteveSandersonMS |
| Aug 4, 2016 | https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/243#issuecomment-237479507 |
| Please reload this page | https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/243 |
| https://patch-diff.githubusercontent.com/SteveSandersonMS |
| SteveSandersonMS | https://patch-diff.githubusercontent.com/SteveSandersonMS |
| Aug 4, 2016 | https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/243#event-744917239 |
| https://patch-diff.githubusercontent.com/snyk-bot |
| snyk-bot | https://patch-diff.githubusercontent.com/snyk-bot |
|
Nov 10, 2021
| https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/243#ref-pullrequest-1049286897 |
|
[Snyk] Fix for 1 vulnerabilities
harunpehlivan/JavaScriptServices#59
| https://patch-diff.githubusercontent.com/harunpehlivan/JavaScriptServices/pull/59 |
| https://patch-diff.githubusercontent.com/harunpehlivan |
| harunpehlivan | https://patch-diff.githubusercontent.com/harunpehlivan |
|
Nov 5, 2022
| https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/243#ref-pullrequest-1436812391 |
|
[Snyk] Fix for 1 vulnerabilities
harunpehlivan/JavaScriptServices#82
| https://patch-diff.githubusercontent.com/harunpehlivan/JavaScriptServices/pull/82 |
| https://patch-diff.githubusercontent.com/snyk-bot |
| snyk-bot | https://patch-diff.githubusercontent.com/snyk-bot |
|
Dec 26, 2022
| https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/243#ref-pullrequest-1510467064 |
|
[Snyk] Fix for 1 vulnerabilities
harunpehlivan/JavaScriptServices#90
| https://patch-diff.githubusercontent.com/harunpehlivan/JavaScriptServices/pull/90 |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Faspnet%2FJavaScriptServices%2Fpull%2F243 |
| Please reload this page | https://patch-diff.githubusercontent.com/aspnet/JavaScriptServices/pull/243 |
|
| https://patch-diff.githubusercontent.com/aidansteele |
|
| https://patch-diff.githubusercontent.com/dnfclas |
|
| https://patch-diff.githubusercontent.com/SteveSandersonMS |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |