René's URL Explorer Experiment


Title: Fix bounds check for FAST Nonmax by jlaxson · Pull Request #3357 · arrayfire/arrayfire · GitHub

Open Graph Title: Fix bounds check for FAST Nonmax by jlaxson · Pull Request #3357 · arrayfire/arrayfire

X Title: Fix bounds check for FAST Nonmax by jlaxson · Pull Request #3357 · arrayfire/arrayfire

Description: This bounds check was broken in two ways: It happened after memory access already occurred, meaning it didn't really protect anything It swapped x/y checks in the dimension order. The result was ...

Open Graph Description: This bounds check was broken in two ways: It happened after memory access already occurred, meaning it didn't really protect anything It swapped x/y checks in the dimension order. The result ...

X Description: This bounds check was broken in two ways: It happened after memory access already occurred, meaning it didn't really protect anything It swapped x/y checks in the dimension order. The res...

Opengraph URL: https://github.com/arrayfire/arrayfire/pull/3357

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:069f47ff-c1c0-3847-af5c-4a40cc787fab
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8A1C:1C03C1:DCBAF2:1380B7B:696E459D
html-safe-nonce95e76f7df288162a1dbe4a7d550b9e5746fc33dd05638f21541f2ab8324a0274
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTFDOjFDMDNDMTpEQ0JBRjI6MTM4MEI3Qjo2OTZFNDU5RCIsInZpc2l0b3JfaWQiOiIyNTg3NDEzNjA2NTUwMDk1MjYxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac10d0c655b80e91ab8b5341c9995ceda73502719189733348f7986387bfc08ea7
hovercard-subject-tagpull_request:1215848708
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/arrayfire/arrayfire/3357/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/18f14cb4194756806f1d3903a4972a6b912973f1d629d1a2bd605581ab08aced/arrayfire/arrayfire/pull/3357
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/18f14cb4194756806f1d3903a4972a6b912973f1d629d1a2bd605581ab08aced/arrayfire/arrayfire/pull/3357
og:image:altThis bounds check was broken in two ways: It happened after memory access already occurred, meaning it didn't really protect anything It swapped x/y checks in the dimension order. The result ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejlaxson
hostnamegithub.com
expected-hostnamegithub.com
None3d96554e55b469c47dbcd31f74dc86278872b170531e84c6ce7f3389673e01d1
turbo-cache-controlno-preview
go-importgithub.com/arrayfire/arrayfire git https://github.com/arrayfire/arrayfire.git
octolytics-dimension-user_id5395442
octolytics-dimension-user_loginarrayfire
octolytics-dimension-repository_id25889802
octolytics-dimension-repository_nwoarrayfire/arrayfire
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id25889802
octolytics-dimension-repository_network_root_nwoarrayfire/arrayfire
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseef576694863a4c791d0a5cc9d2b84384d4414bcd
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/arrayfire/arrayfire/pull/3357#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Farrayfire%2Farrayfire%2Fpull%2F3357
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Farrayfire%2Farrayfire%2Fpull%2F3357
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=arrayfire%2Farrayfire
Reloadhttps://patch-diff.githubusercontent.com/arrayfire/arrayfire/pull/3357
Reloadhttps://patch-diff.githubusercontent.com/arrayfire/arrayfire/pull/3357
Reloadhttps://patch-diff.githubusercontent.com/arrayfire/arrayfire/pull/3357
arrayfire https://patch-diff.githubusercontent.com/arrayfire
arrayfirehttps://patch-diff.githubusercontent.com/arrayfire/arrayfire
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Farrayfire%2Farrayfire
Fork 549 https://patch-diff.githubusercontent.com/login?return_to=%2Farrayfire%2Farrayfire
Star 4.8k https://patch-diff.githubusercontent.com/login?return_to=%2Farrayfire%2Farrayfire
Code https://patch-diff.githubusercontent.com/arrayfire/arrayfire
Issues 285 https://patch-diff.githubusercontent.com/arrayfire/arrayfire/issues
Pull requests 18 https://patch-diff.githubusercontent.com/arrayfire/arrayfire/pulls
Actions https://patch-diff.githubusercontent.com/arrayfire/arrayfire/actions
Projects 0 https://patch-diff.githubusercontent.com/arrayfire/arrayfire/projects
Wiki https://patch-diff.githubusercontent.com/arrayfire/arrayfire/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/arrayfire/arrayfire/security
Please reload this pagehttps://patch-diff.githubusercontent.com/arrayfire/arrayfire/pull/3357
Insights https://patch-diff.githubusercontent.com/arrayfire/arrayfire/pulse
Code https://patch-diff.githubusercontent.com/arrayfire/arrayfire
Issues https://patch-diff.githubusercontent.com/arrayfire/arrayfire/issues
Pull requests https://patch-diff.githubusercontent.com/arrayfire/arrayfire/pulls
Actions https://patch-diff.githubusercontent.com/arrayfire/arrayfire/actions
Projects https://patch-diff.githubusercontent.com/arrayfire/arrayfire/projects
Wiki https://patch-diff.githubusercontent.com/arrayfire/arrayfire/wiki
Security https://patch-diff.githubusercontent.com/arrayfire/arrayfire/security
Insights https://patch-diff.githubusercontent.com/arrayfire/arrayfire/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Farrayfire%2Farrayfire%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Farrayfire%2Farrayfire%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/arrayfire/arrayfire/pull/3357#issue-comment-box
jlaxsonhttps://patch-diff.githubusercontent.com/jlaxson
arrayfire:masterhttps://patch-diff.githubusercontent.com/arrayfire/arrayfire/tree/master
jlaxson:fix-cpu-fast-dimshttps://patch-diff.githubusercontent.com/jlaxson/arrayfire/tree/fix-cpu-fast-dims
Fix bounds check for FAST Nonmax https://patch-diff.githubusercontent.com/arrayfire/arrayfire/pull/3357#top
jlaxsonhttps://patch-diff.githubusercontent.com/jlaxson
arrayfire:masterhttps://patch-diff.githubusercontent.com/arrayfire/arrayfire/tree/master
jlaxson:fix-cpu-fast-dimshttps://patch-diff.githubusercontent.com/jlaxson/arrayfire/tree/fix-cpu-fast-dims
Conversation 0 https://patch-diff.githubusercontent.com/arrayfire/arrayfire/pull/3357
Commits 2 https://patch-diff.githubusercontent.com/arrayfire/arrayfire/pull/3357/commits
Checks 0 https://patch-diff.githubusercontent.com/arrayfire/arrayfire/pull/3357/checks
Files changed https://patch-diff.githubusercontent.com/arrayfire/arrayfire/pull/3357/files
Please reload this pagehttps://patch-diff.githubusercontent.com/arrayfire/arrayfire/pull/3357
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/arrayfire/arrayfire/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/jlaxson
jlaxsonhttps://patch-diff.githubusercontent.com/jlaxson
Jan 24, 2023https://patch-diff.githubusercontent.com/arrayfire/arrayfire/pull/3357#issue-1555822018
Please reload this pagehttps://patch-diff.githubusercontent.com/arrayfire/arrayfire/pull/3357
Please reload this pagehttps://patch-diff.githubusercontent.com/arrayfire/arrayfire/pull/3357
jlaxsonhttps://patch-diff.githubusercontent.com/jlaxson
January 24, 2023 15:31https://patch-diff.githubusercontent.com/arrayfire/arrayfire/pull/3357#commits-pushed-fed10a0
https://patch-diff.githubusercontent.com/jlaxson
Fix bounds check for FAST Nonmaxhttps://patch-diff.githubusercontent.com/arrayfire/arrayfire/pull/3357/commits/fed10a0b257c175056d473bfd18b3c98a9eadf0b
fed10a0https://patch-diff.githubusercontent.com/arrayfire/arrayfire/pull/3357/commits/fed10a0b257c175056d473bfd18b3c98a9eadf0b
https://patch-diff.githubusercontent.com/syurkevi
fix x/y dim1/dim0 inconsistencies in feature detectorshttps://patch-diff.githubusercontent.com/arrayfire/arrayfire/pull/3357/commits/67e2d6cfcc633a24c3b41aefffa9a1ead4b5f0ef
67e2d6chttps://patch-diff.githubusercontent.com/arrayfire/arrayfire/pull/3357/commits/67e2d6cfcc633a24c3b41aefffa9a1ead4b5f0ef
https://patch-diff.githubusercontent.com/syurkevi
syurkevihttps://patch-diff.githubusercontent.com/syurkevi
force-pushedhttps://patch-diff.githubusercontent.com/arrayfire/arrayfire/compare/2f9be7cfaf970d37e6fd2b8117503974372b9e19..67e2d6cfcc633a24c3b41aefffa9a1ead4b5f0ef
2f9be7chttps://patch-diff.githubusercontent.com/arrayfire/arrayfire/commit/2f9be7cfaf970d37e6fd2b8117503974372b9e19
67e2d6chttps://patch-diff.githubusercontent.com/arrayfire/arrayfire/commit/67e2d6cfcc633a24c3b41aefffa9a1ead4b5f0ef
Compare https://patch-diff.githubusercontent.com/arrayfire/arrayfire/compare/2f9be7cfaf970d37e6fd2b8117503974372b9e19..67e2d6cfcc633a24c3b41aefffa9a1ead4b5f0ef
January 25, 2023 06:15https://patch-diff.githubusercontent.com/arrayfire/arrayfire/pull/3357#event-8351486064
https://patch-diff.githubusercontent.com/syurkevi
syurkevihttps://patch-diff.githubusercontent.com/syurkevi
Jan 25, 2023 https://patch-diff.githubusercontent.com/arrayfire/arrayfire/pull/3357#ref-issue-335505739
ORB: CPU backend does not detect all features that CUDA and OpenCL does #2212 https://patch-diff.githubusercontent.com/arrayfire/arrayfire/issues/2212
https://patch-diff.githubusercontent.com/syurkevi
syurkevihttps://patch-diff.githubusercontent.com/syurkevi
3.9.0https://patch-diff.githubusercontent.com/arrayfire/arrayfire/milestone/32
Mar 7, 2023https://patch-diff.githubusercontent.com/arrayfire/arrayfire/pull/3357#event-8690073417
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Farrayfire%2Farrayfire%2Fpull%2F3357
3.9.0 https://patch-diff.githubusercontent.com/arrayfire/arrayfire/milestone/32
Please reload this pagehttps://patch-diff.githubusercontent.com/arrayfire/arrayfire/pull/3357
https://patch-diff.githubusercontent.com/jlaxson
https://patch-diff.githubusercontent.com/syurkevi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.