René's URL Explorer Experiment


Title: Typings show tag as optional but check has a guard against null tags · Issue #71 · applitools/Eyes.Selenium.JavaScript · GitHub

Open Graph Title: Typings show tag as optional but check has a guard against null tags · Issue #71 · applitools/Eyes.Selenium.JavaScript

X Title: Typings show tag as optional but check has a guard against null tags · Issue #71 · applitools/Eyes.Selenium.JavaScript

Description: When running eyes via typescript you're able to call the method eyes.checkWindow() and this is valid because tag and matchTimeout are both optional checkWindow(tag?: string, matchTimeout?: number): Promise; However when you run you throw...

Open Graph Description: When running eyes via typescript you're able to call the method eyes.checkWindow() and this is valid because tag and matchTimeout are both optional checkWindow(tag?: string, matchTimeout?: number):...

X Description: When running eyes via typescript you're able to call the method eyes.checkWindow() and this is valid because tag and matchTimeout are both optional checkWindow(tag?: string, matchTimeout?: numb...

Opengraph URL: https://github.com/applitools/Eyes.Selenium.JavaScript/issues/71

X: @github

direct link

Domain: patch-diff.githubusercontent.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Typings show tag as optional but check has a guard against null tags","articleBody":"When running eyes via typescript you're able to call the method\r\n\r\neyes.checkWindow() and this is valid because tag and matchTimeout are both optional\r\ncheckWindow(tag?: string, matchTimeout?: number): Promise\u003cvoid\u003e;\r\n\r\nHowever when you run you throw a very curious error that \"Name\" isn't set.\r\n\r\nThis appears to be due to the guard in Eyes.js         \r\nArgumentGuard.notNullOrEmpty(name, \"Name\");\r\n\r\nWhich means that this isn't actually an optional parameter in practice.\r\n\r\nOptions are to remove ? from tag \r\nhttps://github.com/jhendershott/Eyes.Selenium.JavaScript/pull/1\r\n\r\nor remove the guard.\r\n\r\nalso. it seems like having tag and name separate is very confusing especially if the guard is against 'NAME' and that should likely be updated through out the library\r\n\r\n\r\n","author":{"url":"https://github.com/jhendershott","@type":"Person","name":"jhendershott"},"datePublished":"2019-08-14T22:01:00.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/71/Eyes.Selenium.JavaScript/issues/71"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:350d0266-9f55-a9b6-25c4-caea4f209df8
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8FE8:1D94B1:347D82:48A383:697211EF
html-safe-nonceed40dfa17e1a96e2f6ed2c5f6cfd2fd516d23580b2c87a53fb5fe8b691a47e09
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RkU4OjFEOTRCMTozNDdEODI6NDhBMzgzOjY5NzIxMUVGIiwidmlzaXRvcl9pZCI6IjgzODM2NTcwODEyOTc4MzQ0NzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace4cc7a0bb6f5b736f49150fdf63923adbdcd82e0c2c7c6299b1070599e42ddd9
hovercard-subject-tagissue:480908333
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/applitools/Eyes.Selenium.JavaScript/71/issue_layout
twitter:imagehttps://opengraph.githubassets.com/b2737526daeb3bcfd314a57e9f443509bbcdffd88ceb72bc56c463808a45aeb5/applitools/Eyes.Selenium.JavaScript/issues/71
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b2737526daeb3bcfd314a57e9f443509bbcdffd88ceb72bc56c463808a45aeb5/applitools/Eyes.Selenium.JavaScript/issues/71
og:image:altWhen running eyes via typescript you're able to call the method eyes.checkWindow() and this is valid because tag and matchTimeout are both optional checkWindow(tag?: string, matchTimeout?: number):...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejhendershott
hostnamegithub.com
expected-hostnamegithub.com
None453de246939b1e04d711e109432e2df10933270413df93b7a8f8f1df8dda7f18
turbo-cache-controlno-preview
go-importgithub.com/applitools/Eyes.Selenium.JavaScript git https://github.com/applitools/Eyes.Selenium.JavaScript.git
octolytics-dimension-user_id8025560
octolytics-dimension-user_loginapplitools
octolytics-dimension-repository_id21348064
octolytics-dimension-repository_nwoapplitools/Eyes.Selenium.JavaScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21348064
octolytics-dimension-repository_network_root_nwoapplitools/Eyes.Selenium.JavaScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release12756e5bdb9000be815bbf20a1acc7935638e596
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/applitools/Eyes.Selenium.JavaScript/issues/71#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapplitools%2FEyes.Selenium.JavaScript%2Fissues%2F71
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapplitools%2FEyes.Selenium.JavaScript%2Fissues%2F71
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=applitools%2FEyes.Selenium.JavaScript
Reloadhttps://patch-diff.githubusercontent.com/applitools/Eyes.Selenium.JavaScript/issues/71
Reloadhttps://patch-diff.githubusercontent.com/applitools/Eyes.Selenium.JavaScript/issues/71
Reloadhttps://patch-diff.githubusercontent.com/applitools/Eyes.Selenium.JavaScript/issues/71
applitools https://patch-diff.githubusercontent.com/applitools
Eyes.Selenium.JavaScripthttps://patch-diff.githubusercontent.com/applitools/Eyes.Selenium.JavaScript
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fapplitools%2FEyes.Selenium.JavaScript
Fork 17 https://patch-diff.githubusercontent.com/login?return_to=%2Fapplitools%2FEyes.Selenium.JavaScript
Star 19 https://patch-diff.githubusercontent.com/login?return_to=%2Fapplitools%2FEyes.Selenium.JavaScript
Code https://patch-diff.githubusercontent.com/applitools/Eyes.Selenium.JavaScript
Issues 2 https://patch-diff.githubusercontent.com/applitools/Eyes.Selenium.JavaScript/issues
Pull requests 0 https://patch-diff.githubusercontent.com/applitools/Eyes.Selenium.JavaScript/pulls
Actions https://patch-diff.githubusercontent.com/applitools/Eyes.Selenium.JavaScript/actions
Projects 0 https://patch-diff.githubusercontent.com/applitools/Eyes.Selenium.JavaScript/projects
Wiki https://patch-diff.githubusercontent.com/applitools/Eyes.Selenium.JavaScript/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/applitools/Eyes.Selenium.JavaScript/security
Please reload this pagehttps://patch-diff.githubusercontent.com/applitools/Eyes.Selenium.JavaScript/issues/71
Insights https://patch-diff.githubusercontent.com/applitools/Eyes.Selenium.JavaScript/pulse
Code https://patch-diff.githubusercontent.com/applitools/Eyes.Selenium.JavaScript
Issues https://patch-diff.githubusercontent.com/applitools/Eyes.Selenium.JavaScript/issues
Pull requests https://patch-diff.githubusercontent.com/applitools/Eyes.Selenium.JavaScript/pulls
Actions https://patch-diff.githubusercontent.com/applitools/Eyes.Selenium.JavaScript/actions
Projects https://patch-diff.githubusercontent.com/applitools/Eyes.Selenium.JavaScript/projects
Wiki https://patch-diff.githubusercontent.com/applitools/Eyes.Selenium.JavaScript/wiki
Security https://patch-diff.githubusercontent.com/applitools/Eyes.Selenium.JavaScript/security
Insights https://patch-diff.githubusercontent.com/applitools/Eyes.Selenium.JavaScript/pulse
Typings show tag as optional but check has a guard against null tagshttps://patch-diff.githubusercontent.com/applitools/Eyes.Selenium.JavaScript/issues/71#top
https://github.com/jhendershott
https://github.com/jhendershott
jhendershotthttps://github.com/jhendershott
on Aug 14, 2019https://github.com/applitools/Eyes.Selenium.JavaScript/issues/71#issue-480908333
jhendershott#1https://github.com/jhendershott/Eyes.Selenium.JavaScript/pull/1
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.