Title: Typings show tag as optional but check has a guard against null tags · Issue #71 · applitools/Eyes.Selenium.JavaScript · GitHub
Open Graph Title: Typings show tag as optional but check has a guard against null tags · Issue #71 · applitools/Eyes.Selenium.JavaScript
X Title: Typings show tag as optional but check has a guard against null tags · Issue #71 · applitools/Eyes.Selenium.JavaScript
Description: When running eyes via typescript you're able to call the method eyes.checkWindow() and this is valid because tag and matchTimeout are both optional checkWindow(tag?: string, matchTimeout?: number): Promise; However when you run you throw...
Open Graph Description: When running eyes via typescript you're able to call the method eyes.checkWindow() and this is valid because tag and matchTimeout are both optional checkWindow(tag?: string, matchTimeout?: number):...
X Description: When running eyes via typescript you're able to call the method eyes.checkWindow() and this is valid because tag and matchTimeout are both optional checkWindow(tag?: string, matchTimeout?: numb...
Opengraph URL: https://github.com/applitools/Eyes.Selenium.JavaScript/issues/71
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Typings show tag as optional but check has a guard against null tags","articleBody":"When running eyes via typescript you're able to call the method\r\n\r\neyes.checkWindow() and this is valid because tag and matchTimeout are both optional\r\ncheckWindow(tag?: string, matchTimeout?: number): Promise\u003cvoid\u003e;\r\n\r\nHowever when you run you throw a very curious error that \"Name\" isn't set.\r\n\r\nThis appears to be due to the guard in Eyes.js \r\nArgumentGuard.notNullOrEmpty(name, \"Name\");\r\n\r\nWhich means that this isn't actually an optional parameter in practice.\r\n\r\nOptions are to remove ? from tag \r\nhttps://github.com/jhendershott/Eyes.Selenium.JavaScript/pull/1\r\n\r\nor remove the guard.\r\n\r\nalso. it seems like having tag and name separate is very confusing especially if the guard is against 'NAME' and that should likely be updated through out the library\r\n\r\n\r\n","author":{"url":"https://github.com/jhendershott","@type":"Person","name":"jhendershott"},"datePublished":"2019-08-14T22:01:00.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/71/Eyes.Selenium.JavaScript/issues/71"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:350d0266-9f55-a9b6-25c4-caea4f209df8 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8FE8:1D94B1:347D82:48A383:697211EF |
| html-safe-nonce | ed40dfa17e1a96e2f6ed2c5f6cfd2fd516d23580b2c87a53fb5fe8b691a47e09 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RkU4OjFEOTRCMTozNDdEODI6NDhBMzgzOjY5NzIxMUVGIiwidmlzaXRvcl9pZCI6IjgzODM2NTcwODEyOTc4MzQ0NzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | e4cc7a0bb6f5b736f49150fdf63923adbdcd82e0c2c7c6299b1070599e42ddd9 |
| hovercard-subject-tag | issue:480908333 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/applitools/Eyes.Selenium.JavaScript/71/issue_layout |
| twitter:image | https://opengraph.githubassets.com/b2737526daeb3bcfd314a57e9f443509bbcdffd88ceb72bc56c463808a45aeb5/applitools/Eyes.Selenium.JavaScript/issues/71 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b2737526daeb3bcfd314a57e9f443509bbcdffd88ceb72bc56c463808a45aeb5/applitools/Eyes.Selenium.JavaScript/issues/71 |
| og:image:alt | When running eyes via typescript you're able to call the method eyes.checkWindow() and this is valid because tag and matchTimeout are both optional checkWindow(tag?: string, matchTimeout?: number):... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jhendershott |
| hostname | github.com |
| expected-hostname | github.com |
| None | 453de246939b1e04d711e109432e2df10933270413df93b7a8f8f1df8dda7f18 |
| turbo-cache-control | no-preview |
| go-import | github.com/applitools/Eyes.Selenium.JavaScript git https://github.com/applitools/Eyes.Selenium.JavaScript.git |
| octolytics-dimension-user_id | 8025560 |
| octolytics-dimension-user_login | applitools |
| octolytics-dimension-repository_id | 21348064 |
| octolytics-dimension-repository_nwo | applitools/Eyes.Selenium.JavaScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 21348064 |
| octolytics-dimension-repository_network_root_nwo | applitools/Eyes.Selenium.JavaScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 12756e5bdb9000be815bbf20a1acc7935638e596 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width