René's URL Explorer Experiment


Title: Use system CMake when available by mgorny · Pull Request #59 · apache/datasketches-python · GitHub

Open Graph Title: Use system CMake when available by mgorny · Pull Request #59 · apache/datasketches-python

X Title: Use system CMake when available by mgorny · Pull Request #59 · apache/datasketches-python

Description: Replace the unconditional build requirement of cmake with one that is added only if system CMake is not available, in order to facilitate building against system CMake when available. This avoids unnecessary dependency on some systems, and improves portability when the particular target requires downstream patching of CMake. While at it, also update the existing CMake check to use shutil.which() which is more efficient than spawning a subprocess, and update the error message to reference matching CMake version.

Open Graph Description: Replace the unconditional build requirement of cmake with one that is added only if system CMake is not available, in order to facilitate building against system CMake when available. This avoids ...

X Description: Replace the unconditional build requirement of cmake with one that is added only if system CMake is not available, in order to facilitate building against system CMake when available. This avoids ...

Opengraph URL: https://github.com/apache/datasketches-python/pull/59

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0184171b-e80e-4b33-ddc1-3c2f4bb33ebc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id99F4:61C75:564CA3:73A047:698F962C
html-safe-nonceed2db623c0c514204103a2f45cf5b5d135bc468d308d93e10633668b1d0e8785
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OUY0OjYxQzc1OjU2NENBMzo3M0EwNDc6Njk4Rjk2MkMiLCJ2aXNpdG9yX2lkIjoiMjgzMTk3NjY1MDc3MzU5OTc4OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac26360e657a42860ebfca1dfc051c7dab74c498c297a12b0ec1f50fe79d1e8119
hovercard-subject-tagpull_request:2326430360
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/apache/datasketches-python/pull/59/files
twitter:imagehttps://avatars.githubusercontent.com/u/110765?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/110765?s=400&v=4
og:image:altReplace the unconditional build requirement of cmake with one that is added only if system CMake is not available, in order to facilitate building against system CMake when available. This avoids ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f47eb8d0aaafbfcb6a8220a40bd81431acf688857c575e6489670c394cfa36f
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/apache/datasketches-python git https://github.com/apache/datasketches-python.git
octolytics-dimension-user_id47359
octolytics-dimension-user_loginapache
octolytics-dimension-repository_id685709717
octolytics-dimension-repository_nwoapache/datasketches-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id685709717
octolytics-dimension-repository_network_root_nwoapache/datasketches-python
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release09a8136f6e8f8fd3078d54ce5f8b7adb493d44a7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/files#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fdatasketches-python%2Fpull%2F59%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fdatasketches-python%2Fpull%2F59%2Ffiles
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=apache%2Fdatasketches-python
Reloadhttps://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/files
Reloadhttps://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/files
Reloadhttps://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/files
apache https://patch-diff.githubusercontent.com/apache
datasketches-pythonhttps://patch-diff.githubusercontent.com/apache/datasketches-python
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fapache%2Fdatasketches-python
Fork 8 https://patch-diff.githubusercontent.com/login?return_to=%2Fapache%2Fdatasketches-python
Star 40 https://patch-diff.githubusercontent.com/login?return_to=%2Fapache%2Fdatasketches-python
Code https://patch-diff.githubusercontent.com/apache/datasketches-python
Issues 3 https://patch-diff.githubusercontent.com/apache/datasketches-python/issues
Pull requests 0 https://patch-diff.githubusercontent.com/apache/datasketches-python/pulls
Actions https://patch-diff.githubusercontent.com/apache/datasketches-python/actions
Security 0 https://patch-diff.githubusercontent.com/apache/datasketches-python/security
Insights https://patch-diff.githubusercontent.com/apache/datasketches-python/pulse
Code https://patch-diff.githubusercontent.com/apache/datasketches-python
Issues https://patch-diff.githubusercontent.com/apache/datasketches-python/issues
Pull requests https://patch-diff.githubusercontent.com/apache/datasketches-python/pulls
Actions https://patch-diff.githubusercontent.com/apache/datasketches-python/actions
Security https://patch-diff.githubusercontent.com/apache/datasketches-python/security
Insights https://patch-diff.githubusercontent.com/apache/datasketches-python/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fapache%2Fdatasketches-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fapache%2Fdatasketches-python%2Fissues%2Fnew%2Fchoose
jmalkinhttps://patch-diff.githubusercontent.com/jmalkin
apache:mainhttps://patch-diff.githubusercontent.com/apache/datasketches-python/tree/main
mgorny:sys-cmakehttps://patch-diff.githubusercontent.com/mgorny/datasketches-python/tree/sys-cmake
Conversation 2 https://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59
Commits 1 https://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/commits
Checks 3 https://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/checks
Files changed https://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/files
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/files
Use system CMake when available https://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/files#top
Show all changes 1 commit https://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/files
24ae166 Use system CMake when available mgorny Feb 10, 2025 https://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/commits/24ae166aa736def3e97be04fa2d2e58333167c9a
Clear filters https://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/files
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/files
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/files
pyproject.toml https://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711
setup.py https://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7
pyproject.tomlhttps://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711
View file https://patch-diff.githubusercontent.com/mgorny/datasketches-python/blob/24ae166aa736def3e97be04fa2d2e58333167c9a/pyproject.toml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711
https://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711
setup.pyhttps://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7
View file https://patch-diff.githubusercontent.com/mgorny/datasketches-python/blob/24ae166aa736def3e97be04fa2d2e58333167c9a/setup.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7
https://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7
https://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7
https://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7
https://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.