René's URL Explorer Experiment


Title: Use system CMake when available by mgorny · Pull Request #59 · apache/datasketches-python · GitHub

Open Graph Title: Use system CMake when available by mgorny · Pull Request #59 · apache/datasketches-python

X Title: Use system CMake when available by mgorny · Pull Request #59 · apache/datasketches-python

Description: Replace the unconditional build requirement of cmake with one that is added only if system CMake is not available, in order to facilitate building against system CMake when available. This avoids unnecessary dependency on some systems, and improves portability when the particular target requires downstream patching of CMake. While at it, also update the existing CMake check to use shutil.which() which is more efficient than spawning a subprocess, and update the error message to reference matching CMake version.

Open Graph Description: Replace the unconditional build requirement of cmake with one that is added only if system CMake is not available, in order to facilitate building against system CMake when available. This avoids ...

X Description: Replace the unconditional build requirement of cmake with one that is added only if system CMake is not available, in order to facilitate building against system CMake when available. This avoids ...

Opengraph URL: https://github.com/apache/datasketches-python/pull/59

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/:user_id/:repository/pull/:id/checks(.:format)
route-controllerpull_requests
route-actionchecks
fetch-noncev2:439a1ab0-0a80-c24d-7187-81d0a220d190
current-catalog-service-hash87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a
request-id862A:18B347:3955E:4FB20:698F356E
html-safe-noncefea0238e7f67241df72034e9b1182f94cac8997f1dcb87a2d53c28d538b7f431
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjJBOjE4QjM0NzozOTU1RTo0RkIyMDo2OThGMzU2RSIsInZpc2l0b3JfaWQiOiI3NjM2NzY4MjI1NjQ0OTgzNjYyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac99f4e82afbad2bb29780d9db957f14cb3e56e891fb0716a1f2b7914efed7bf10
hovercard-subject-tagpull_request:2326430360
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/checks
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/apache/datasketches-python/pull/59/checks
twitter:imagehttps://avatars.githubusercontent.com/u/110765?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/110765?s=400&v=4
og:image:altReplace the unconditional build requirement of cmake with one that is added only if system CMake is not available, in order to facilitate building against system CMake when available. This avoids ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None6102991c714c1a6a27d05fb4f96ea6ca87a6750b4f093b95cc57ed1b84b145a1
turbo-cache-controlno-cache
go-importgithub.com/apache/datasketches-python git https://github.com/apache/datasketches-python.git
octolytics-dimension-user_id47359
octolytics-dimension-user_loginapache
octolytics-dimension-repository_id685709717
octolytics-dimension-repository_nwoapache/datasketches-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id685709717
octolytics-dimension-repository_network_root_nwoapache/datasketches-python
turbo-body-classeslogged-out env-production page-responsive full-width full-width-p-0
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee2fe82f90e107669021e243add8f74ea2a9be1b3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/checks#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fdatasketches-python%2Fpull%2F59%2Fchecks
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fdatasketches-python%2Fpull%2F59%2Fchecks
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fchecks&source=header-repo&source_repo=apache%2Fdatasketches-python
Reloadhttps://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/checks
Reloadhttps://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/checks
Reloadhttps://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/checks
apache https://patch-diff.githubusercontent.com/apache
datasketches-pythonhttps://patch-diff.githubusercontent.com/apache/datasketches-python
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fapache%2Fdatasketches-python
Fork 8 https://patch-diff.githubusercontent.com/login?return_to=%2Fapache%2Fdatasketches-python
Star 40 https://patch-diff.githubusercontent.com/login?return_to=%2Fapache%2Fdatasketches-python
Code https://patch-diff.githubusercontent.com/apache/datasketches-python
Issues 3 https://patch-diff.githubusercontent.com/apache/datasketches-python/issues
Pull requests 0 https://patch-diff.githubusercontent.com/apache/datasketches-python/pulls
Actions https://patch-diff.githubusercontent.com/apache/datasketches-python/actions
Security 0 https://patch-diff.githubusercontent.com/apache/datasketches-python/security
Insights https://patch-diff.githubusercontent.com/apache/datasketches-python/pulse
Code https://patch-diff.githubusercontent.com/apache/datasketches-python
Issues https://patch-diff.githubusercontent.com/apache/datasketches-python/issues
Pull requests https://patch-diff.githubusercontent.com/apache/datasketches-python/pulls
Actions https://patch-diff.githubusercontent.com/apache/datasketches-python/actions
Security https://patch-diff.githubusercontent.com/apache/datasketches-python/security
Insights https://patch-diff.githubusercontent.com/apache/datasketches-python/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fapache%2Fdatasketches-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fapache%2Fdatasketches-python%2Fissues%2Fnew%2Fchoose
jmalkinhttps://patch-diff.githubusercontent.com/jmalkin
apache:mainhttps://patch-diff.githubusercontent.com/apache/datasketches-python/tree/main
mgorny:sys-cmakehttps://patch-diff.githubusercontent.com/mgorny/datasketches-python/tree/sys-cmake
Conversation 2 https://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59
Commits 1 https://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/commits
Checks 3 https://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/checks
Files changed https://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/files
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/checks
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/checks
Sign in for the full log viewhttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fdatasketches-python%2Fpull%2F59%2Fchecks
Use system CMake when available https://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/checks#top
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/datasketches-python/pull/59/checks
Continuous Integration on: pull_request https://patch-diff.githubusercontent.com/apache/datasketches-python/actions/runs/13244590605
MacOS Latest, Clang https://patch-diff.githubusercontent.com/apache/datasketches-python/actions/runs/13244590605/job/36975869397?pr=59
Ubuntu Latest, GCC https://patch-diff.githubusercontent.com/apache/datasketches-python/actions/runs/13244590605/job/36975869763?pr=59
Windows Latest, MSVC https://patch-diff.githubusercontent.com/apache/datasketches-python/actions/runs/13244590605/job/36975870164?pr=59
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.