René's URL Explorer Experiment


Title: Set nfsVersion in ssvm agent.properties only if it is not null by abh1sar · Pull Request #12445 · apache/cloudstack · GitHub

Open Graph Title: Set nfsVersion in ssvm agent.properties only if it is not null by abh1sar · Pull Request #12445 · apache/cloudstack

X Title: Set nfsVersion in ssvm agent.properties only if it is not null by abh1sar · Pull Request #12445 · apache/cloudstack

Description: Description This PR fixes #12415 The agent.properties contains "nfsVersion = null" if the global settings secstorage.nfs.version is not set. NfsSecondaryStorageResource picks up the nfsVersion as "null" String in CopyCommand and some other commands, and tries to mount the secondary storage with vers=null option leading to mount failures in logs. Types of changes Breaking change (fix or feature that would cause existing functionality to change) New feature (non-breaking change which adds functionality) Bug fix (non-breaking change which fixes an issue) Enhancement (improves an existing feature and functionality) Cleanup (Code refactoring and cleanup, that may add test cases) Build/CI Test (unit or integration test code) Feature/Enhancement Scale or Bug Severity Feature/Enhancement Scale Major Minor Bug Severity BLOCKER Critical Major Minor Trivial Screenshots (if appropriate): How Has This Been Tested? How did you try to break this feature and the system with this change?

Open Graph Description: Description This PR fixes #12415 The agent.properties contains "nfsVersion = null" if the global settings secstorage.nfs.version is not set. NfsSecondaryStorageResource picks up the nfsVe...

X Description: Description This PR fixes #12415 The agent.properties contains "nfsVersion = null" if the global settings secstorage.nfs.version is not set. NfsSecondaryStorageResource picks up t...

Opengraph URL: https://github.com/apache/cloudstack/pull/12445

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ce8decc0-af72-f873-43a9-a73b0fbf8487
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA0D6:201EEF:8E7E465:BE8D0A5:696E21BB
html-safe-noncec33cb28901c175c16a4f117d00fefcf5f3d65c50bf160fba2abb48a83f71898e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMEQ2OjIwMUVFRjo4RTdFNDY1OkJFOEQwQTU6Njk2RTIxQkIiLCJ2aXNpdG9yX2lkIjoiMTIwODY5NTA4MjgzNzY5Mjc2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacce6869e6f90f53d30c6ebba0b7a3574cbf500fe77e89d7a7923a8c9ffaeb3445
hovercard-subject-tagpull_request:3179886969
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/apache/cloudstack/pull/12445/files
twitter:imagehttps://avatars.githubusercontent.com/u/63767682?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/63767682?s=400&v=4
og:image:altDescription This PR fixes #12415 The agent.properties contains "nfsVersion = null" if the global settings secstorage.nfs.version is not set. NfsSecondaryStorageResource picks up the nfsVe...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None2fbe8cba5e260284c10af515699ff9bb2d6ace05ab6c2e2e585b71d93b2812c3
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/apache/cloudstack git https://github.com/apache/cloudstack.git
octolytics-dimension-user_id47359
octolytics-dimension-user_loginapache
octolytics-dimension-repository_id9759448
octolytics-dimension-repository_nwoapache/cloudstack
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id9759448
octolytics-dimension-repository_network_root_nwoapache/cloudstack
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7fb3bc5c995a876085291706b75cf9b08900c338
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/files#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Fpull%2F12445%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Fpull%2F12445%2Ffiles
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=apache%2Fcloudstack
Reloadhttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/files
Reloadhttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/files
Reloadhttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/files
apache https://patch-diff.githubusercontent.com/apache
cloudstackhttps://patch-diff.githubusercontent.com/apache/cloudstack
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fapache%2Fcloudstack
Fork 1.3k https://patch-diff.githubusercontent.com/login?return_to=%2Fapache%2Fcloudstack
Star 2.8k https://patch-diff.githubusercontent.com/login?return_to=%2Fapache%2Fcloudstack
Code https://patch-diff.githubusercontent.com/apache/cloudstack
Issues 473 https://patch-diff.githubusercontent.com/apache/cloudstack/issues
Pull requests 237 https://patch-diff.githubusercontent.com/apache/cloudstack/pulls
Discussions https://patch-diff.githubusercontent.com/apache/cloudstack/discussions
Actions https://patch-diff.githubusercontent.com/apache/cloudstack/actions
Projects 3 https://patch-diff.githubusercontent.com/apache/cloudstack/projects
Wiki https://patch-diff.githubusercontent.com/apache/cloudstack/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/apache/cloudstack/security
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/files
Insights https://patch-diff.githubusercontent.com/apache/cloudstack/pulse
Code https://patch-diff.githubusercontent.com/apache/cloudstack
Issues https://patch-diff.githubusercontent.com/apache/cloudstack/issues
Pull requests https://patch-diff.githubusercontent.com/apache/cloudstack/pulls
Discussions https://patch-diff.githubusercontent.com/apache/cloudstack/discussions
Actions https://patch-diff.githubusercontent.com/apache/cloudstack/actions
Projects https://patch-diff.githubusercontent.com/apache/cloudstack/projects
Wiki https://patch-diff.githubusercontent.com/apache/cloudstack/wiki
Security https://patch-diff.githubusercontent.com/apache/cloudstack/security
Insights https://patch-diff.githubusercontent.com/apache/cloudstack/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fapache%2Fcloudstack%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fapache%2Fcloudstack%2Fissues%2Fnew%2Fchoose
abh1sarhttps://patch-diff.githubusercontent.com/abh1sar
apache:4.20https://patch-diff.githubusercontent.com/apache/cloudstack/tree/4.20
shapeblue:ssvm-mounthttps://patch-diff.githubusercontent.com/shapeblue/cloudstack/tree/ssvm-mount
Conversation 29 https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
Commits 6 https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/commits
Checks 26 https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/checks
Files changed 1 https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/files
Set nfsVersion in ssvm agent.properties only if it is not null https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/files#top
Show all changes 6 commits https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/files
722c2e3 set nfsVersion in ssvm agent.properties only if it is not null abh1sar Jan 16, 2026 https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/commits/722c2e39a7b2238aa48cd5cd8570d8428063231f
bee935c Merge branch '4.20' into ssvm-mount abh1sar Jan 16, 2026 https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/commits/bee935c87497b1b10fa574e157b0d759066614c0
9946565 Use isNotBlank instead of null check abh1sar Jan 16, 2026 https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/commits/99465659fc1d9856aa37ffb0e441335eeeade85d
c44bdce Merge remote-tracking branch 'origin/ssvm-mount' into ssvm-mount abh1sar Jan 16, 2026 https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/commits/c44bdcea6920b348b663145daae9a82454a0e57c
050e0ed simplified the nfsVersion assignment abh1sar Jan 16, 2026 https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/commits/050e0ed2f597283c7d7f498da1caa30957a590cd
98506f4 Merge branch '4.20' into ssvm-mount abh1sar Jan 19, 2026 https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/commits/98506f4064d6b4bb8eb884ebb92d246895da6dc4
Clear filters https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/files
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/files
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/files
...ler/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.javahttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/files#diff-89565ee501e0c9f0b93790fd2ba596474d0b0c11cbff71a21183f7934fbb79cf
View file https://patch-diff.githubusercontent.com/apache/cloudstack/blob/98506f4064d6b4bb8eb884ebb92d246895da6dc4/services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/files#diff-89565ee501e0c9f0b93790fd2ba596474d0b0c11cbff71a21183f7934fbb79cf
https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/files#diff-89565ee501e0c9f0b93790fd2ba596474d0b0c11cbff71a21183f7934fbb79cf
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.