René's URL Explorer Experiment


Title: Set nfsVersion in ssvm agent.properties only if it is not null by abh1sar · Pull Request #12445 · apache/cloudstack · GitHub

Open Graph Title: Set nfsVersion in ssvm agent.properties only if it is not null by abh1sar · Pull Request #12445 · apache/cloudstack

X Title: Set nfsVersion in ssvm agent.properties only if it is not null by abh1sar · Pull Request #12445 · apache/cloudstack

Description: Description This PR fixes #12415 The agent.properties contains "nfsVersion = null" if the global settings secstorage.nfs.version is not set. NfsSecondaryStorageResource picks up the nfsVersion as "...

Open Graph Description: Description This PR fixes #12415 The agent.properties contains "nfsVersion = null" if the global settings secstorage.nfs.version is not set. NfsSecondaryStorageResource picks up the nfsVe...

X Description: Description This PR fixes #12415 The agent.properties contains "nfsVersion = null" if the global settings secstorage.nfs.version is not set. NfsSecondaryStorageResource picks up t...

Opengraph URL: https://github.com/apache/cloudstack/pull/12445

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e5e743c0-7f63-798c-50ff-f140d6a7dd8f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id97D4:2411E:7B7E12B:A1A417A:696DC18F
html-safe-nonce07097581e480d103d1c134f30907cd27b23e1ad0738e4f158e97e22bc1b7f52a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5N0Q0OjI0MTFFOjdCN0UxMkI6QTFBNDE3QTo2OTZEQzE4RiIsInZpc2l0b3JfaWQiOiI0NDQ0Mzg2MDY2MDgwNTc5OTgzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb24f622378f86d2396af4c9f94d14b2fc36a606cee9ad049fb572dd0273b6521
hovercard-subject-tagpull_request:3179886969
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/apache/cloudstack/12445/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7851258dbefe654deafa4c5a57169b4aaea81cd63b2cd723f73526570b6cdcff/apache/cloudstack/pull/12445
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7851258dbefe654deafa4c5a57169b4aaea81cd63b2cd723f73526570b6cdcff/apache/cloudstack/pull/12445
og:image:altDescription This PR fixes #12415 The agent.properties contains "nfsVersion = null" if the global settings secstorage.nfs.version is not set. NfsSecondaryStorageResource picks up the nfsVe...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameabh1sar
hostnamegithub.com
expected-hostnamegithub.com
None4922b452d03cd8dbce479d866a11bc25b59ef6ee2da23aa9b0ddefa6bd4d0064
turbo-cache-controlno-preview
go-importgithub.com/apache/cloudstack git https://github.com/apache/cloudstack.git
octolytics-dimension-user_id47359
octolytics-dimension-user_loginapache
octolytics-dimension-repository_id9759448
octolytics-dimension-repository_nwoapache/cloudstack
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id9759448
octolytics-dimension-repository_network_root_nwoapache/cloudstack
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7e5ae23c70136152637ceee8d6faceb35596ec46
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Fpull%2F12445
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Fpull%2F12445
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=apache%2Fcloudstack
Reloadhttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
Reloadhttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
Reloadhttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
apache https://patch-diff.githubusercontent.com/apache
cloudstackhttps://patch-diff.githubusercontent.com/apache/cloudstack
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fapache%2Fcloudstack
Fork 1.3k https://patch-diff.githubusercontent.com/login?return_to=%2Fapache%2Fcloudstack
Star 2.8k https://patch-diff.githubusercontent.com/login?return_to=%2Fapache%2Fcloudstack
Code https://patch-diff.githubusercontent.com/apache/cloudstack
Issues 471 https://patch-diff.githubusercontent.com/apache/cloudstack/issues
Pull requests 236 https://patch-diff.githubusercontent.com/apache/cloudstack/pulls
Discussions https://patch-diff.githubusercontent.com/apache/cloudstack/discussions
Actions https://patch-diff.githubusercontent.com/apache/cloudstack/actions
Projects 3 https://patch-diff.githubusercontent.com/apache/cloudstack/projects
Wiki https://patch-diff.githubusercontent.com/apache/cloudstack/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/apache/cloudstack/security
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
Insights https://patch-diff.githubusercontent.com/apache/cloudstack/pulse
Code https://patch-diff.githubusercontent.com/apache/cloudstack
Issues https://patch-diff.githubusercontent.com/apache/cloudstack/issues
Pull requests https://patch-diff.githubusercontent.com/apache/cloudstack/pulls
Discussions https://patch-diff.githubusercontent.com/apache/cloudstack/discussions
Actions https://patch-diff.githubusercontent.com/apache/cloudstack/actions
Projects https://patch-diff.githubusercontent.com/apache/cloudstack/projects
Wiki https://patch-diff.githubusercontent.com/apache/cloudstack/wiki
Security https://patch-diff.githubusercontent.com/apache/cloudstack/security
Insights https://patch-diff.githubusercontent.com/apache/cloudstack/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fapache%2Fcloudstack%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fapache%2Fcloudstack%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#issue-comment-box
abh1sarhttps://patch-diff.githubusercontent.com/abh1sar
apache:4.20https://patch-diff.githubusercontent.com/apache/cloudstack/tree/4.20
shapeblue:ssvm-mounthttps://patch-diff.githubusercontent.com/shapeblue/cloudstack/tree/ssvm-mount
Set nfsVersion in ssvm agent.properties only if it is not null https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#top
abh1sarhttps://patch-diff.githubusercontent.com/abh1sar
apache:4.20https://patch-diff.githubusercontent.com/apache/cloudstack/tree/4.20
shapeblue:ssvm-mounthttps://patch-diff.githubusercontent.com/shapeblue/cloudstack/tree/ssvm-mount
Conversation 26 https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
Commits 6 https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/commits
Checks 26 https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/checks
Files changed https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/files
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/apache/cloudstack/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/abh1sar
abh1sarhttps://patch-diff.githubusercontent.com/abh1sar
Jan 16, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#issue-3820452997
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
#12415https://github.com/apache/cloudstack/issues/12415
https://private-user-images.githubusercontent.com/63767682/536660285-758c3b01-b8b2-4c3a-ba18-07a63e0b948f.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Njg4MDA5NTUsIm5iZiI6MTc2ODgwMDY1NSwicGF0aCI6Ii82Mzc2NzY4Mi81MzY2NjAyODUtNzU4YzNiMDEtYjhiMi00YzNhLWJhMTgtMDdhNjNlMGI5NDhmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAxMTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMTE5VDA1MzA1NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZmYWZhMDdmZTM1OGMyMGZiYmI0Y2I5NWZkYzNhOTA3ZmQ4MzI5MDFhNGYzNDM5YTkwZDk0OWZkN2I2ZTk3YjcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.acb8tLO4CMI72W8FFkVTnDqGqPfq46tEO1nCKCUBVPw
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
https://patch-diff.githubusercontent.com/abh1sar
set nfsVersion in ssvm agent.properties only if it is not nullhttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/commits/722c2e39a7b2238aa48cd5cd8570d8428063231f
722c2e3https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/commits/722c2e39a7b2238aa48cd5cd8570d8428063231f
https://patch-diff.githubusercontent.com/apps/boring-cyborg
boring-cyborghttps://patch-diff.githubusercontent.com/apps/boring-cyborg
component:secondary-storage https://patch-diff.githubusercontent.com/apache/cloudstack/issues?q=state%3Aopen%20label%3Acomponent%3Asecondary-storage
component:ssvm https://patch-diff.githubusercontent.com/apache/cloudstack/issues?q=state%3Aopen%20label%3Acomponent%3Assvm
Jan 16, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#event-22086764019
https://patch-diff.githubusercontent.com/abh1sar
abh1sarhttps://patch-diff.githubusercontent.com/abh1sar
4.20.3https://patch-diff.githubusercontent.com/apache/cloudstack/milestone/43
Jan 16, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#event-22086769121
https://patch-diff.githubusercontent.com/apps/codecov
codecovhttps://patch-diff.githubusercontent.com/apps/codecov
Jan 16, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#issuecomment-3758274239
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
Codecovhttps://app.codecov.io/gh/apache/cloudstack/pull/12445?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache
76e6de7https://app.codecov.io/gh/apache/cloudstack/commit/76e6de7f90e5b741f3deb845ea722858101a7117?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache
98506f4https://app.codecov.io/gh/apache/cloudstack/commit/98506f4064d6b4bb8eb884ebb92d246895da6dc4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache
Files with missing lineshttps://app.codecov.io/gh/apache/cloudstack/pull/12445?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache
.../secondarystorage/SecondaryStorageManagerImpl.javahttps://app.codecov.io/gh/apache/cloudstack/pull/12445?src=pr&el=tree&filepath=services%2Fsecondary-storage%2Fcontroller%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcloudstack%2Fsecondarystorage%2FSecondaryStorageManagerImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmljZXMvc2Vjb25kYXJ5LXN0b3JhZ2UvY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9zZWNvbmRhcnlzdG9yYWdlL1NlY29uZGFyeVN0b3JhZ2VNYW5hZ2VySW1wbC5qYXZh
3 Missing ⚠️ https://app.codecov.io/gh/apache/cloudstack/pull/12445?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache
Flaghttps://app.codecov.io/gh/apache/cloudstack/pull/12445/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache
uitestshttps://app.codecov.io/gh/apache/cloudstack/pull/12445/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache
unittestshttps://app.codecov.io/gh/apache/cloudstack/pull/12445/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache
Click herehttps://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment
☔ View full report in Codecov by Sentryhttps://app.codecov.io/gh/apache/cloudstack/pull/12445?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache
Share it herehttps://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
https://patch-diff.githubusercontent.com/abh1sar
Merge branch '4.20' into ssvm-mounthttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/commits/bee935c87497b1b10fa574e157b0d759066614c0
bee935chttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/commits/bee935c87497b1b10fa574e157b0d759066614c0
https://patch-diff.githubusercontent.com/abh1sar
abh1sarhttps://patch-diff.githubusercontent.com/abh1sar
Jan 16, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#issuecomment-3758304357
@blueorangutanhttps://github.com/blueorangutan
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
https://patch-diff.githubusercontent.com/blueorangutan
blueorangutanhttps://patch-diff.githubusercontent.com/blueorangutan
Jan 16, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#issuecomment-3758305427
@abh1sarhttps://github.com/abh1sar
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
https://patch-diff.githubusercontent.com/blueorangutan
blueorangutanhttps://patch-diff.githubusercontent.com/blueorangutan
Jan 16, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#issuecomment-3758440201
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
https://patch-diff.githubusercontent.com/abh1sar
abh1sarhttps://patch-diff.githubusercontent.com/abh1sar
vishesh92https://patch-diff.githubusercontent.com/vishesh92
weizhouapachehttps://patch-diff.githubusercontent.com/weizhouapache
January 16, 2026 08:10https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#event-22089389717
https://patch-diff.githubusercontent.com/vishesh92
vishesh92https://patch-diff.githubusercontent.com/vishesh92
Copilothttps://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer
January 16, 2026 08:16https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#event-22089515364
started reviewinghttps://github.com/copilot/tasks/pull/PR_kwDOAJTq2M69iTl5?session_id=9894eea5-9b30-4171-8908-ec5d9e4d7508
vishesh92https://patch-diff.githubusercontent.com/vishesh92
January 16, 2026 08:17https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#event-22089526094
View session https://github.com/copilot/tasks/pull/PR_kwDOAJTq2M69iTl5?session_id=9894eea5-9b30-4171-8908-ec5d9e4d7508
https://patch-diff.githubusercontent.com/DaanHoogland
DaanHooglandhttps://patch-diff.githubusercontent.com/DaanHoogland
Jan 16, 2026 https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#pullrequestreview-3669503978
View reviewed changes https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/files/bee935c87497b1b10fa574e157b0d759066614c0
DaanHooglandhttps://patch-diff.githubusercontent.com/DaanHoogland
https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#pullrequestreview-3669503978
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@abh1sarhttps://github.com/abh1sar
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
https://patch-diff.githubusercontent.com/vishesh92
vishesh92https://patch-diff.githubusercontent.com/vishesh92
Jan 16, 2026 https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#pullrequestreview-3669504893
View reviewed changes https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/files/bee935c87497b1b10fa574e157b0d759066614c0
...roller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.javahttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/files/bee935c87497b1b10fa574e157b0d759066614c0#diff-89565ee501e0c9f0b93790fd2ba596474d0b0c11cbff71a21183f7934fbb79cf
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
https://patch-diff.githubusercontent.com/abh1sar
abh1sarhttps://patch-diff.githubusercontent.com/abh1sar
Jan 16, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#issuecomment-3758731460
@abh1sarhttps://github.com/abh1sar
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
abh1sarhttps://patch-diff.githubusercontent.com/abh1sar
January 16, 2026 13:55https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#commits-pushed-9946565
https://patch-diff.githubusercontent.com/abh1sar
Use isNotBlank instead of null checkhttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/commits/99465659fc1d9856aa37ffb0e441335eeeade85d
9946565https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/commits/99465659fc1d9856aa37ffb0e441335eeeade85d
https://patch-diff.githubusercontent.com/abh1sar
Merge remote-tracking branch 'origin/ssvm-mount' into ssvm-mounthttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/commits/c44bdcea6920b348b663145daae9a82454a0e57c
c44bdcehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/commits/c44bdcea6920b348b663145daae9a82454a0e57c
https://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer
Copilothttps://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer
Jan 16, 2026 https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#pullrequestreview-3669525597
View reviewed changes https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/files/c44bdcea6920b348b663145daae9a82454a0e57c
Copilothttps://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer
https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#pullrequestreview-3669525597
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Add Copilot custom instructionshttps://patch-diff.githubusercontent.com/apache/cloudstack/new/main/.github/instructions?filename=*.instructions.md
Learn how to get startedhttps://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
...roller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.javahttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/files/c44bdcea6920b348b663145daae9a82454a0e57c#diff-89565ee501e0c9f0b93790fd2ba596474d0b0c11cbff71a21183f7934fbb79cf
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
https://patch-diff.githubusercontent.com/abh1sar
https://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer
simplified the nfsVersion assignmenthttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/commits/050e0ed2f597283c7d7f498da1caa30957a590cd
050e0edhttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/commits/050e0ed2f597283c7d7f498da1caa30957a590cd
https://patch-diff.githubusercontent.com/DaanHoogland
DaanHooglandhttps://patch-diff.githubusercontent.com/DaanHoogland
Jan 16, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#issuecomment-3759069805
@abh1sarhttps://github.com/abh1sar
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
https://patch-diff.githubusercontent.com/DaanHoogland
DaanHooglandhttps://patch-diff.githubusercontent.com/DaanHoogland
Jan 16, 2026 https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#pullrequestreview-3669873420
View reviewed changes https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/files/98506f4064d6b4bb8eb884ebb92d246895da6dc4
DaanHooglandhttps://patch-diff.githubusercontent.com/DaanHoogland
https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#pullrequestreview-3669873420
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
https://patch-diff.githubusercontent.com/abh1sar
abh1sarhttps://patch-diff.githubusercontent.com/abh1sar
Jan 16, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#issuecomment-3759080932
@abh1sarhttps://github.com/abh1sar
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
https://patch-diff.githubusercontent.com/DaanHoogland
DaanHooglandhttps://patch-diff.githubusercontent.com/DaanHoogland
Jan 16, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#issuecomment-3759101599
@blueorangutanhttps://github.com/blueorangutan
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
https://patch-diff.githubusercontent.com/blueorangutan
blueorangutanhttps://patch-diff.githubusercontent.com/blueorangutan
Jan 16, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#issuecomment-3759106043
@DaanHooglandhttps://github.com/DaanHoogland
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
https://patch-diff.githubusercontent.com/DaanHoogland
DaanHooglandhttps://patch-diff.githubusercontent.com/DaanHoogland
status:needs-testing https://patch-diff.githubusercontent.com/apache/cloudstack/issues?q=state%3Aopen%20label%3Astatus%3Aneeds-testing
Jan 16, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#event-22092125676
https://patch-diff.githubusercontent.com/blueorangutan
blueorangutanhttps://patch-diff.githubusercontent.com/blueorangutan
Jan 16, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#issuecomment-3759480909
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
https://patch-diff.githubusercontent.com/abh1sar
abh1sarhttps://patch-diff.githubusercontent.com/abh1sar
RosiKyuhttps://patch-diff.githubusercontent.com/RosiKyu
Jan 16, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#event-22093427992
https://patch-diff.githubusercontent.com/RosiKyu
RosiKyuhttps://patch-diff.githubusercontent.com/RosiKyu
Jan 18, 2026 https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#pullrequestreview-3675307652
View reviewed changes https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/files/98506f4064d6b4bb8eb884ebb92d246895da6dc4
RosiKyuhttps://patch-diff.githubusercontent.com/RosiKyu
https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#pullrequestreview-3675307652
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#12415https://github.com/apache/cloudstack/issues/12415
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
https://patch-diff.githubusercontent.com/RosiKyu
RosiKyuhttps://patch-diff.githubusercontent.com/RosiKyu
status:needs-testing https://patch-diff.githubusercontent.com/apache/cloudstack/issues?q=state%3Aopen%20label%3Astatus%3Aneeds-testing
Jan 18, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#event-22120449992
https://patch-diff.githubusercontent.com/RosiKyu
RosiKyuhttps://patch-diff.githubusercontent.com/RosiKyu
status:ready-for-merge https://patch-diff.githubusercontent.com/apache/cloudstack/issues?q=state%3Aopen%20label%3Astatus%3Aready-for-merge
Jan 18, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#event-22120450202
https://patch-diff.githubusercontent.com/abh1sar
abh1sarhttps://patch-diff.githubusercontent.com/abh1sar
Jan 18, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#issuecomment-3765045463
@blueorangutanhttps://github.com/blueorangutan
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
https://patch-diff.githubusercontent.com/blueorangutan
blueorangutanhttps://patch-diff.githubusercontent.com/blueorangutan
Jan 18, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#issuecomment-3765046322
@abh1sarhttps://github.com/abh1sar
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
https://patch-diff.githubusercontent.com/blueorangutan
blueorangutanhttps://patch-diff.githubusercontent.com/blueorangutan
Jan 18, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#issuecomment-3765048783
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
https://patch-diff.githubusercontent.com/abh1sar
abh1sarhttps://patch-diff.githubusercontent.com/abh1sar
Jan 19, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#issuecomment-3766121285
@blueorangutanhttps://github.com/blueorangutan
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
https://patch-diff.githubusercontent.com/blueorangutan
blueorangutanhttps://patch-diff.githubusercontent.com/blueorangutan
Jan 19, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#issuecomment-3766124777
@abh1sarhttps://github.com/abh1sar
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
https://patch-diff.githubusercontent.com/blueorangutan
blueorangutanhttps://patch-diff.githubusercontent.com/blueorangutan
Jan 19, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#issuecomment-3766129783
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
https://patch-diff.githubusercontent.com/abh1sar
Merge branch '4.20' into ssvm-mounthttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/commits/98506f4064d6b4bb8eb884ebb92d246895da6dc4
98506f4https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/commits/98506f4064d6b4bb8eb884ebb92d246895da6dc4
https://patch-diff.githubusercontent.com/abh1sar
abh1sarhttps://patch-diff.githubusercontent.com/abh1sar
Jan 19, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#issuecomment-3766134963
@blueorangutanhttps://github.com/blueorangutan
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
https://patch-diff.githubusercontent.com/blueorangutan
blueorangutanhttps://patch-diff.githubusercontent.com/blueorangutan
Jan 19, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#issuecomment-3766137605
@abh1sarhttps://github.com/abh1sar
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
https://patch-diff.githubusercontent.com/blueorangutan
blueorangutanhttps://patch-diff.githubusercontent.com/blueorangutan
Jan 19, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445#issuecomment-3766241027
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Fpull%2F12445
https://patch-diff.githubusercontent.com/vishesh92
vishesh92 https://patch-diff.githubusercontent.com/vishesh92
https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/files/bee935c87497b1b10fa574e157b0d759066614c0
Copilot code review https://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer
Copilot https://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer
https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/files/c44bdcea6920b348b663145daae9a82454a0e57c
https://patch-diff.githubusercontent.com/DaanHoogland
DaanHoogland https://patch-diff.githubusercontent.com/DaanHoogland
https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/files/98506f4064d6b4bb8eb884ebb92d246895da6dc4
https://patch-diff.githubusercontent.com/weizhouapache
weizhouapache https://patch-diff.githubusercontent.com/weizhouapache
https://patch-diff.githubusercontent.com/RosiKyu
RosiKyu https://patch-diff.githubusercontent.com/RosiKyu
https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445/files/98506f4064d6b4bb8eb884ebb92d246895da6dc4
https://patch-diff.githubusercontent.com/RosiKyu
RosiKyu https://patch-diff.githubusercontent.com/RosiKyu
component:secondary-storage https://patch-diff.githubusercontent.com/apache/cloudstack/issues?q=state%3Aopen%20label%3Acomponent%3Asecondary-storage
component:ssvm https://patch-diff.githubusercontent.com/apache/cloudstack/issues?q=state%3Aopen%20label%3Acomponent%3Assvm
status:ready-for-merge https://patch-diff.githubusercontent.com/apache/cloudstack/issues?q=state%3Aopen%20label%3Astatus%3Aready-for-merge
4.20.3 https://patch-diff.githubusercontent.com/apache/cloudstack/milestone/43
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12445
https://patch-diff.githubusercontent.com/abh1sar
https://patch-diff.githubusercontent.com/blueorangutan
https://patch-diff.githubusercontent.com/DaanHoogland
https://patch-diff.githubusercontent.com/vishesh92
https://patch-diff.githubusercontent.com/RosiKyu
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.