René's URL Explorer Experiment


Title: Enhance DHCP functionality by adding lease timeout support by NVShawn · Pull Request #12410 · apache/cloudstack · GitHub

Open Graph Title: Enhance DHCP functionality by adding lease timeout support by NVShawn · Pull Request #12410 · apache/cloudstack

X Title: Enhance DHCP functionality by adding lease timeout support by NVShawn · Pull Request #12410 · apache/cloudstack

Description: Description This PR enhances the feature added in #3662 to allow for non-infinite dhcp lease times. So we do not break current installs, we keep the 'infinite' lease time as default but allow for a...

Open Graph Description: Description This PR enhances the feature added in #3662 to allow for non-infinite dhcp lease times. So we do not break current installs, we keep the 'infinite' lease time as default but all...

X Description: Description This PR enhances the feature added in #3662 to allow for non-infinite dhcp lease times. So we do not break current installs, we keep the 'infinite' lease time as default...

Mail addresses
dev@cloudstack.apache.org

Opengraph URL: https://github.com/apache/cloudstack/pull/12410

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9987b89d-3f0e-385a-0e7b-1165bc246b69
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB6EE:298462:1483:1846:696E5E9C
html-safe-nonce1a6e70242b7abe22efe6589d1efd30b44dfe7869a21444236a7234aa9ca9ccf2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNkVFOjI5ODQ2MjoxNDgzOjE4NDY6Njk2RTVFOUMiLCJ2aXNpdG9yX2lkIjoiMTQyNzY5MTQxNjM2NzAyOTkxNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaceccb8b4726da511dcd7a30fb205beb93802fa61e58ffce91374b0d7d35bc7816
hovercard-subject-tagpull_request:3166732717
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/apache/cloudstack/12410/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/95ddcc1c390511e52583b5a32c8a0559578255b946b246ee365658f31f3f98d5/apache/cloudstack/pull/12410
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/95ddcc1c390511e52583b5a32c8a0559578255b946b246ee365658f31f3f98d5/apache/cloudstack/pull/12410
og:image:altDescription This PR enhances the feature added in #3662 to allow for non-infinite dhcp lease times. So we do not break current installs, we keep the 'infinite' lease time as default but all...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameNVShawn
hostnamegithub.com
expected-hostnamegithub.com
Nonef68b42d371252b0f236260d6234f4304a806fe5ac43d59faa21fb59d80df103b
turbo-cache-controlno-preview
go-importgithub.com/apache/cloudstack git https://github.com/apache/cloudstack.git
octolytics-dimension-user_id47359
octolytics-dimension-user_loginapache
octolytics-dimension-repository_id9759448
octolytics-dimension-repository_nwoapache/cloudstack
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id9759448
octolytics-dimension-repository_network_root_nwoapache/cloudstack
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6b74bc8dbcd10b5d69fd9ee9d2cfdc8b35e18a4c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Fpull%2F12410
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Fpull%2F12410
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=apache%2Fcloudstack
Reloadhttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410
Reloadhttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410
Reloadhttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410
apache https://patch-diff.githubusercontent.com/apache
cloudstackhttps://patch-diff.githubusercontent.com/apache/cloudstack
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fapache%2Fcloudstack
Fork 1.3k https://patch-diff.githubusercontent.com/login?return_to=%2Fapache%2Fcloudstack
Star 2.8k https://patch-diff.githubusercontent.com/login?return_to=%2Fapache%2Fcloudstack
Code https://patch-diff.githubusercontent.com/apache/cloudstack
Issues 473 https://patch-diff.githubusercontent.com/apache/cloudstack/issues
Pull requests 237 https://patch-diff.githubusercontent.com/apache/cloudstack/pulls
Discussions https://patch-diff.githubusercontent.com/apache/cloudstack/discussions
Actions https://patch-diff.githubusercontent.com/apache/cloudstack/actions
Projects 3 https://patch-diff.githubusercontent.com/apache/cloudstack/projects
Wiki https://patch-diff.githubusercontent.com/apache/cloudstack/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/apache/cloudstack/security
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410
Insights https://patch-diff.githubusercontent.com/apache/cloudstack/pulse
Code https://patch-diff.githubusercontent.com/apache/cloudstack
Issues https://patch-diff.githubusercontent.com/apache/cloudstack/issues
Pull requests https://patch-diff.githubusercontent.com/apache/cloudstack/pulls
Discussions https://patch-diff.githubusercontent.com/apache/cloudstack/discussions
Actions https://patch-diff.githubusercontent.com/apache/cloudstack/actions
Projects https://patch-diff.githubusercontent.com/apache/cloudstack/projects
Wiki https://patch-diff.githubusercontent.com/apache/cloudstack/wiki
Security https://patch-diff.githubusercontent.com/apache/cloudstack/security
Insights https://patch-diff.githubusercontent.com/apache/cloudstack/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fapache%2Fcloudstack%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fapache%2Fcloudstack%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410#issue-comment-box
NVShawnhttps://patch-diff.githubusercontent.com/NVShawn
apache:mainhttps://patch-diff.githubusercontent.com/apache/cloudstack/tree/main
NVShawn:mainhttps://patch-diff.githubusercontent.com/NVShawn/cloudstack/tree/main
Enhance DHCP functionality by adding lease timeout support https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410#top
NVShawnhttps://patch-diff.githubusercontent.com/NVShawn
apache:mainhttps://patch-diff.githubusercontent.com/apache/cloudstack/tree/main
NVShawn:mainhttps://patch-diff.githubusercontent.com/NVShawn/cloudstack/tree/main
Conversation 10 https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410
Commits 2 https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410/commits
Checks 28 https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410/checks
Files changed https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410/files
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/apache/cloudstack/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/NVShawn
NVShawnhttps://patch-diff.githubusercontent.com/NVShawn
Jan 12, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410#issue-3805310739
#3662https://github.com/apache/cloudstack/pull/3662
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410
https://patch-diff.githubusercontent.com/NVShawn
Enhance DHCP functionality by adding lease time support across variou…https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410/commits/bb72490b72b1c122973aaa3d399bb7a5da2a57d1
bb72490https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410/commits/bb72490b72b1c122973aaa3d399bb7a5da2a57d1
https://patch-diff.githubusercontent.com/apps/boring-cyborg
boring-cyborghttps://patch-diff.githubusercontent.com/apps/boring-cyborg
component:api https://patch-diff.githubusercontent.com/apache/cloudstack/issues?q=state%3Aopen%20label%3Acomponent%3Aapi
component:networking https://patch-diff.githubusercontent.com/apache/cloudstack/issues?q=state%3Aopen%20label%3Acomponent%3Anetworking
component:virtual-router https://patch-diff.githubusercontent.com/apache/cloudstack/issues?q=state%3Aopen%20label%3Acomponent%3Avirtual-router
Python https://patch-diff.githubusercontent.com/apache/cloudstack/issues?q=state%3Aopen%20label%3APython
Jan 12, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410#event-21995625093
https://patch-diff.githubusercontent.com/apps/boring-cyborg
boring-cyborghttps://patch-diff.githubusercontent.com/apps/boring-cyborg
Jan 12, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410#issuecomment-3739707346
https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.mdhttps://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md
https://github.com/apache/cloudstack-documentationhttps://github.com/apache/cloudstack-documentation
ASF Code of Conducthttps://github.com/apache/.github/blob/main/.github/CODE_OF_CONDUCT.md
CloudStack Coding Conventionshttps://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions
https://cloudstack.apache.org/mailing-lists.htmlhttps://cloudstack.apache.org/mailing-lists.html
https://apachecloudstack.slack.com/https://apachecloudstack.slack.com/
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410
https://patch-diff.githubusercontent.com/DaanHoogland
DaanHooglandhttps://patch-diff.githubusercontent.com/DaanHoogland
weizhouapachehttps://patch-diff.githubusercontent.com/weizhouapache
January 13, 2026 08:25https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410#event-22009996356
https://patch-diff.githubusercontent.com/DaanHoogland
DaanHooglandhttps://patch-diff.githubusercontent.com/DaanHoogland
4.23.0https://patch-diff.githubusercontent.com/apache/cloudstack/milestone/42
Jan 13, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410#event-22009999752
https://patch-diff.githubusercontent.com/DaanHoogland
DaanHooglandhttps://patch-diff.githubusercontent.com/DaanHoogland
Jan 13, 2026 https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410#pullrequestreview-3654522141
View reviewed changes https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410/files/bb72490b72b1c122973aaa3d399bb7a5da2a57d1
DaanHooglandhttps://patch-diff.githubusercontent.com/DaanHoogland
https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410#pullrequestreview-3654522141
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410
server/src/main/java/com/cloud/configuration/Config.javahttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410/files/bb72490b72b1c122973aaa3d399bb7a5da2a57d1#diff-0dbb07fafeb6f537bd703ca50b7980c05c765ce57c06d2f19336ce504f35c2c2
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410
https://patch-diff.githubusercontent.com/apps/codecov
codecovhttps://patch-diff.githubusercontent.com/apps/codecov
Jan 13, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410#issuecomment-3742864318
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410
Codecovhttps://app.codecov.io/gh/apache/cloudstack/pull/12410?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache
b8813c7https://app.codecov.io/gh/apache/cloudstack/commit/b8813c7b243787b8b33080d7fea3327d709bcccf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache
0ac84b0https://app.codecov.io/gh/apache/cloudstack/commit/0ac84b08dd651f7b5ed91bfad8d1052bbdb0d969?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache
b8813c7https://github.com/apache/cloudstack/commit/b8813c7b243787b8b33080d7fea3327d709bcccf
0ac84b0https://github.com/apache/cloudstack/commit/0ac84b08dd651f7b5ed91bfad8d1052bbdb0d969
b8813c7https://github.com/apache/cloudstack/commit/b8813c7b243787b8b33080d7fea3327d709bcccf
0ac84b0https://github.com/apache/cloudstack/commit/0ac84b08dd651f7b5ed91bfad8d1052bbdb0d969
Flaghttps://app.codecov.io/gh/apache/cloudstack/pull/12410/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache
uitestshttps://app.codecov.io/gh/apache/cloudstack/pull/12410/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache
unittestshttps://app.codecov.io/gh/apache/cloudstack/pull/12410/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache
Click herehttps://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment
☔ View full report in Codecov by Sentryhttps://app.codecov.io/gh/apache/cloudstack/pull/12410?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache
Share it herehttps://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410
https://patch-diff.githubusercontent.com/NVShawn
Move dhcp lease timeout to ConfigKey, set it to 'zone' scope, and add…https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410/commits/0ac84b08dd651f7b5ed91bfad8d1052bbdb0d969
0ac84b0https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410/commits/0ac84b08dd651f7b5ed91bfad8d1052bbdb0d969
https://patch-diff.githubusercontent.com/DaanHoogland
DaanHooglandhttps://patch-diff.githubusercontent.com/DaanHoogland
Jan 13, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410#issuecomment-3746094409
@NVShawnhttps://github.com/NVShawn
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Fpull%2F12410
https://patch-diff.githubusercontent.com/DaanHoogland
DaanHoogland https://patch-diff.githubusercontent.com/DaanHoogland
https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410/files/bb72490b72b1c122973aaa3d399bb7a5da2a57d1
https://patch-diff.githubusercontent.com/weizhouapache
weizhouapache https://patch-diff.githubusercontent.com/weizhouapache
component:api https://patch-diff.githubusercontent.com/apache/cloudstack/issues?q=state%3Aopen%20label%3Acomponent%3Aapi
component:networking https://patch-diff.githubusercontent.com/apache/cloudstack/issues?q=state%3Aopen%20label%3Acomponent%3Anetworking
component:virtual-router https://patch-diff.githubusercontent.com/apache/cloudstack/issues?q=state%3Aopen%20label%3Acomponent%3Avirtual-router
Python https://patch-diff.githubusercontent.com/apache/cloudstack/issues?q=state%3Aopen%20label%3APython
4.23.0 https://patch-diff.githubusercontent.com/apache/cloudstack/milestone/42
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12410
https://patch-diff.githubusercontent.com/NVShawn
https://patch-diff.githubusercontent.com/DaanHoogland
https://patch-diff.githubusercontent.com/weizhouapache
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.