René's URL Explorer Experiment


Title: check if a source NAT IP address is needed before assigning one by DaanHoogland · Pull Request #12408 · apache/cloudstack · GitHub

Open Graph Title: check if a source NAT IP address is needed before assigning one by DaanHoogland · Pull Request #12408 · apache/cloudstack

X Title: check if a source NAT IP address is needed before assigning one by DaanHoogland · Pull Request #12408 · apache/cloudstack

Description: Description This PR... Fixes: #10122 Types of changes Breaking change (fix or feature that would cause existing functionality to change) New feature (non-breaking change which adds func...

Open Graph Description: Description This PR... Fixes: #10122 Types of changes Breaking change (fix or feature that would cause existing functionality to change) New feature (non-breaking change which adds func...

X Description: Description This PR... Fixes: #10122 Types of changes Breaking change (fix or feature that would cause existing functionality to change) New feature (non-breaking change which adds func...

Opengraph URL: https://github.com/apache/cloudstack/pull/12408

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3a8da8bf-e78f-8083-169c-3496f4de4082
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE8CE:2445E2:4A5D387:6365969:696DFB78
html-safe-noncecdd6eb6323c55f9b496f71a040e2651b47a5a446667b8f7216a1b832c8c028ea
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOENFOjI0NDVFMjo0QTVEMzg3OjYzNjU5Njk6Njk2REZCNzgiLCJ2aXNpdG9yX2lkIjoiNDkyNjEyNDMyMTE0Nzg0NTQ5NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7aba9df79023e6efc2a18ce73ea2c097d64c74e96230ca8b16e27a48aa113ec8
hovercard-subject-tagpull_request:3166322372
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/apache/cloudstack/12408/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/77ca45f9410f7d294d7d9e12b54b1004f8b9e6cc0f58079a1ecb31c912eaf213/apache/cloudstack/pull/12408
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/77ca45f9410f7d294d7d9e12b54b1004f8b9e6cc0f58079a1ecb31c912eaf213/apache/cloudstack/pull/12408
og:image:altDescription This PR... Fixes: #10122 Types of changes Breaking change (fix or feature that would cause existing functionality to change) New feature (non-breaking change which adds func...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameDaanHoogland
hostnamegithub.com
expected-hostnamegithub.com
None4922b452d03cd8dbce479d866a11bc25b59ef6ee2da23aa9b0ddefa6bd4d0064
turbo-cache-controlno-preview
go-importgithub.com/apache/cloudstack git https://github.com/apache/cloudstack.git
octolytics-dimension-user_id47359
octolytics-dimension-user_loginapache
octolytics-dimension-repository_id9759448
octolytics-dimension-repository_nwoapache/cloudstack
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id9759448
octolytics-dimension-repository_network_root_nwoapache/cloudstack
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7e5ae23c70136152637ceee8d6faceb35596ec46
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Fpull%2F12408
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Fpull%2F12408
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=apache%2Fcloudstack
Reloadhttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
Reloadhttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
Reloadhttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
apache https://patch-diff.githubusercontent.com/apache
cloudstackhttps://patch-diff.githubusercontent.com/apache/cloudstack
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fapache%2Fcloudstack
Fork 1.3k https://patch-diff.githubusercontent.com/login?return_to=%2Fapache%2Fcloudstack
Star 2.8k https://patch-diff.githubusercontent.com/login?return_to=%2Fapache%2Fcloudstack
Code https://patch-diff.githubusercontent.com/apache/cloudstack
Issues 474 https://patch-diff.githubusercontent.com/apache/cloudstack/issues
Pull requests 233 https://patch-diff.githubusercontent.com/apache/cloudstack/pulls
Discussions https://patch-diff.githubusercontent.com/apache/cloudstack/discussions
Actions https://patch-diff.githubusercontent.com/apache/cloudstack/actions
Projects 3 https://patch-diff.githubusercontent.com/apache/cloudstack/projects
Wiki https://patch-diff.githubusercontent.com/apache/cloudstack/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/apache/cloudstack/security
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
Insights https://patch-diff.githubusercontent.com/apache/cloudstack/pulse
Code https://patch-diff.githubusercontent.com/apache/cloudstack
Issues https://patch-diff.githubusercontent.com/apache/cloudstack/issues
Pull requests https://patch-diff.githubusercontent.com/apache/cloudstack/pulls
Discussions https://patch-diff.githubusercontent.com/apache/cloudstack/discussions
Actions https://patch-diff.githubusercontent.com/apache/cloudstack/actions
Projects https://patch-diff.githubusercontent.com/apache/cloudstack/projects
Wiki https://patch-diff.githubusercontent.com/apache/cloudstack/wiki
Security https://patch-diff.githubusercontent.com/apache/cloudstack/security
Insights https://patch-diff.githubusercontent.com/apache/cloudstack/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fapache%2Fcloudstack%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fapache%2Fcloudstack%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408#issue-comment-box
DaanHooglandhttps://patch-diff.githubusercontent.com/DaanHoogland
apache:4.20https://patch-diff.githubusercontent.com/apache/cloudstack/tree/4.20
shapeblue:ghi10122-routedModeWithSourceNAThttps://patch-diff.githubusercontent.com/shapeblue/cloudstack/tree/ghi10122-routedModeWithSourceNAT
check if a source NAT IP address is needed before assigning one https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408#top
DaanHooglandhttps://patch-diff.githubusercontent.com/DaanHoogland
apache:4.20https://patch-diff.githubusercontent.com/apache/cloudstack/tree/4.20
shapeblue:ghi10122-routedModeWithSourceNAThttps://patch-diff.githubusercontent.com/shapeblue/cloudstack/tree/ghi10122-routedModeWithSourceNAT
Conversation 28 https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
Commits 1 https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408/commits
Checks 26 https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408/checks
Files changed 1 https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408/files
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/apache/cloudstack/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/DaanHoogland
DaanHooglandhttps://patch-diff.githubusercontent.com/DaanHoogland
Jan 12, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408#issue-3804836448
#10122https://github.com/apache/cloudstack/issues/10122
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
https://patch-diff.githubusercontent.com/apps/boring-cyborg
boring-cyborghttps://patch-diff.githubusercontent.com/apps/boring-cyborg
component:networking https://patch-diff.githubusercontent.com/apache/cloudstack/issues?q=state%3Aopen%20label%3Acomponent%3Anetworking
Jan 12, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408#event-21992700034
https://patch-diff.githubusercontent.com/apps/codecov
codecovhttps://patch-diff.githubusercontent.com/apps/codecov
Jan 12, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408#issuecomment-3739189804
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
Codecovhttps://app.codecov.io/gh/apache/cloudstack/pull/12408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache
ef1aaa0https://app.codecov.io/gh/apache/cloudstack/commit/ef1aaa0551d3d372e3ac7295b7f87dc203212a80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache
519b8cfhttps://app.codecov.io/gh/apache/cloudstack/commit/519b8cf0a8341afb2798fb34c659c2a6f6fcfd14?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache
Files with missing lineshttps://app.codecov.io/gh/apache/cloudstack/pull/12408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache
...n/java/com/cloud/network/IpAddressManagerImpl.javahttps://app.codecov.io/gh/apache/cloudstack/pull/12408?src=pr&el=tree&filepath=server%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fnetwork%2FIpAddressManagerImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL25ldHdvcmsvSXBBZGRyZXNzTWFuYWdlckltcGwuamF2YQ==
17 Missing and 1 partial ⚠️ https://app.codecov.io/gh/apache/cloudstack/pull/12408?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache
Flaghttps://app.codecov.io/gh/apache/cloudstack/pull/12408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache
uitestshttps://app.codecov.io/gh/apache/cloudstack/pull/12408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache
unittestshttps://app.codecov.io/gh/apache/cloudstack/pull/12408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache
Click herehttps://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment
☔ View full report in Codecov by Sentryhttps://app.codecov.io/gh/apache/cloudstack/pull/12408?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache
Share it herehttps://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
https://patch-diff.githubusercontent.com/DaanHoogland
DaanHooglandhttps://patch-diff.githubusercontent.com/DaanHoogland
Jan 13, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408#issuecomment-3742585635
@blueorangutanhttps://github.com/blueorangutan
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
https://patch-diff.githubusercontent.com/blueorangutan
blueorangutanhttps://patch-diff.githubusercontent.com/blueorangutan
Jan 13, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408#issuecomment-3742597543
@DaanHooglandhttps://github.com/DaanHoogland
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
https://patch-diff.githubusercontent.com/blueorangutan
blueorangutanhttps://patch-diff.githubusercontent.com/blueorangutan
Jan 13, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408#issuecomment-3743110557
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
https://patch-diff.githubusercontent.com/DaanHoogland
DaanHooglandhttps://patch-diff.githubusercontent.com/DaanHoogland
Copilothttps://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer
January 13, 2026 13:02https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408#event-22016156221
started reviewinghttps://github.com/copilot/tasks/pull/PR_kwDOAJTq2M68uj7E?session_id=37b5df77-db2a-4249-805b-d7ae841c8180
DaanHooglandhttps://patch-diff.githubusercontent.com/DaanHoogland
January 13, 2026 13:02https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408#event-22016167737
View session https://github.com/copilot/tasks/pull/PR_kwDOAJTq2M68uj7E?session_id=37b5df77-db2a-4249-805b-d7ae841c8180
https://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer
Copilothttps://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer
Jan 13, 2026 https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408#pullrequestreview-3655726071
View reviewed changes https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408/files
Copilothttps://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer
https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408#pullrequestreview-3655726071
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#10122https://github.com/apache/cloudstack/issues/10122
Add Copilot custom instructionshttps://patch-diff.githubusercontent.com/apache/cloudstack/new/main/.github/instructions?filename=*.instructions.md
Learn how to get startedhttps://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
server/src/main/java/com/cloud/network/IpAddressManagerImpl.javahttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408/files#diff-dc46c96a04bd9c6670c43ef7bc4c513a6d73c75228965b4b4e139bf2bee3fe32
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
server/src/main/java/com/cloud/network/IpAddressManagerImpl.javahttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408/files#diff-dc46c96a04bd9c6670c43ef7bc4c513a6d73c75228965b4b4e139bf2bee3fe32
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
server/src/main/java/com/cloud/network/IpAddressManagerImpl.javahttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408/files#diff-dc46c96a04bd9c6670c43ef7bc4c513a6d73c75228965b4b4e139bf2bee3fe32
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
server/src/main/java/com/cloud/network/IpAddressManagerImpl.javahttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408/files#diff-dc46c96a04bd9c6670c43ef7bc4c513a6d73c75228965b4b4e139bf2bee3fe32
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
https://patch-diff.githubusercontent.com/DaanHoogland
DaanHooglandhttps://patch-diff.githubusercontent.com/DaanHoogland
Copilothttps://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer
January 13, 2026 13:21https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408#event-22016606305
started reviewinghttps://github.com/copilot/tasks/pull/PR_kwDOAJTq2M68uj7E?session_id=5bcb2b2f-dcb4-45ff-9e4e-3c08a726cd1f
DaanHooglandhttps://patch-diff.githubusercontent.com/DaanHoogland
January 13, 2026 13:22https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408#event-22016617316
View session https://github.com/copilot/tasks/pull/PR_kwDOAJTq2M68uj7E?session_id=5bcb2b2f-dcb4-45ff-9e4e-3c08a726cd1f
https://patch-diff.githubusercontent.com/weizhouapache
weizhouapachehttps://patch-diff.githubusercontent.com/weizhouapache
Jan 13, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408#issuecomment-3744333078
@DaanHooglandhttps://github.com/DaanHoogland
#10122https://github.com/apache/cloudstack/issues/10122
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
https://patch-diff.githubusercontent.com/DaanHoogland
DaanHooglandhttps://patch-diff.githubusercontent.com/DaanHoogland
Jan 13, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408#issuecomment-3744348798
@DaanHooglandhttps://github.com/DaanHoogland
#10122https://github.com/apache/cloudstack/issues/10122
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
https://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer
Copilothttps://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer
Jan 13, 2026 https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408#pullrequestreview-3655815479
View reviewed changes https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408/files
Copilothttps://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer
https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408#pullrequestreview-3655815479
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Add Copilot custom instructionshttps://patch-diff.githubusercontent.com/apache/cloudstack/new/main/.github/instructions?filename=*.instructions.md
Learn how to get startedhttps://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
server/src/main/java/com/cloud/network/IpAddressManagerImpl.javahttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408/files#diff-dc46c96a04bd9c6670c43ef7bc4c513a6d73c75228965b4b4e139bf2bee3fe32
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
server/src/main/java/com/cloud/network/IpAddressManagerImpl.javahttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408/files#diff-dc46c96a04bd9c6670c43ef7bc4c513a6d73c75228965b4b4e139bf2bee3fe32
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
server/src/main/java/com/cloud/network/IpAddressManagerImpl.javahttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408/files#diff-dc46c96a04bd9c6670c43ef7bc4c513a6d73c75228965b4b4e139bf2bee3fe32
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
server/src/main/java/com/cloud/network/IpAddressManagerImpl.javahttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408/files#diff-dc46c96a04bd9c6670c43ef7bc4c513a6d73c75228965b4b4e139bf2bee3fe32
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
server/src/main/java/com/cloud/network/IpAddressManagerImpl.javahttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408/files#diff-dc46c96a04bd9c6670c43ef7bc4c513a6d73c75228965b4b4e139bf2bee3fe32
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
server/src/main/java/com/cloud/network/IpAddressManagerImpl.javahttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408/files#diff-dc46c96a04bd9c6670c43ef7bc4c513a6d73c75228965b4b4e139bf2bee3fe32
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
server/src/main/java/com/cloud/network/IpAddressManagerImpl.javahttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408/files#diff-dc46c96a04bd9c6670c43ef7bc4c513a6d73c75228965b4b4e139bf2bee3fe32
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
server/src/main/java/com/cloud/network/IpAddressManagerImpl.javahttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408/files#diff-dc46c96a04bd9c6670c43ef7bc4c513a6d73c75228965b4b4e139bf2bee3fe32
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
server/src/main/java/com/cloud/network/IpAddressManagerImpl.javahttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408/files#diff-dc46c96a04bd9c6670c43ef7bc4c513a6d73c75228965b4b4e139bf2bee3fe32
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
server/src/main/java/com/cloud/network/IpAddressManagerImpl.javahttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408/files#diff-dc46c96a04bd9c6670c43ef7bc4c513a6d73c75228965b4b4e139bf2bee3fe32
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
https://patch-diff.githubusercontent.com/DaanHoogland
DaanHooglandhttps://patch-diff.githubusercontent.com/DaanHoogland
force-pushedhttps://patch-diff.githubusercontent.com/apache/cloudstack/compare/e8cebc652d01ac3b2c1aed6f6e08ded18ce91442..7274c9e033fc61878ca28f34cf05e9dedeced95c
e8cebc6https://patch-diff.githubusercontent.com/apache/cloudstack/commit/e8cebc652d01ac3b2c1aed6f6e08ded18ce91442
7274c9ehttps://patch-diff.githubusercontent.com/apache/cloudstack/commit/7274c9e033fc61878ca28f34cf05e9dedeced95c
Compare https://patch-diff.githubusercontent.com/apache/cloudstack/compare/e8cebc652d01ac3b2c1aed6f6e08ded18ce91442..7274c9e033fc61878ca28f34cf05e9dedeced95c
January 14, 2026 14:44https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408#event-22045355047
https://patch-diff.githubusercontent.com/DaanHoogland
DaanHooglandhttps://patch-diff.githubusercontent.com/DaanHoogland
Copilothttps://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer
January 14, 2026 14:44https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408#event-22045359409
started reviewinghttps://github.com/copilot/tasks/pull/PR_kwDOAJTq2M68uj7E?session_id=7d824c02-9072-4b27-8a82-80062edef513
DaanHooglandhttps://patch-diff.githubusercontent.com/DaanHoogland
January 14, 2026 14:45https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408#event-22045374438
View session https://github.com/copilot/tasks/pull/PR_kwDOAJTq2M68uj7E?session_id=7d824c02-9072-4b27-8a82-80062edef513
https://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer
Copilothttps://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer
Jan 14, 2026 https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408#pullrequestreview-3661162015
View reviewed changes https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408/files
Copilothttps://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer
https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408#pullrequestreview-3661162015
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Add Copilot custom instructionshttps://patch-diff.githubusercontent.com/apache/cloudstack/new/main/.github/instructions?filename=*.instructions.md
Learn how to get startedhttps://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
server/src/main/java/com/cloud/network/IpAddressManagerImpl.javahttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408/files#diff-dc46c96a04bd9c6670c43ef7bc4c513a6d73c75228965b4b4e139bf2bee3fe32
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
server/src/main/java/com/cloud/network/IpAddressManagerImpl.javahttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408/files#diff-dc46c96a04bd9c6670c43ef7bc4c513a6d73c75228965b4b4e139bf2bee3fe32
Copilothttps://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer
Jan 14, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408#discussion_r2690785466
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
Copilothttps://docs.github.com/copilot/responsible-use-of-github-copilot-features/responsible-use-of-github-copilot-code-review
check if a source NAT IP address is needed before assigning onehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408/commits/519b8cf0a8341afb2798fb34c659c2a6f6fcfd14
519b8cfhttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408/commits/519b8cf0a8341afb2798fb34c659c2a6f6fcfd14
https://patch-diff.githubusercontent.com/DaanHoogland
DaanHooglandhttps://patch-diff.githubusercontent.com/DaanHoogland
force-pushedhttps://patch-diff.githubusercontent.com/apache/cloudstack/compare/7274c9e033fc61878ca28f34cf05e9dedeced95c..519b8cf0a8341afb2798fb34c659c2a6f6fcfd14
7274c9ehttps://patch-diff.githubusercontent.com/apache/cloudstack/commit/7274c9e033fc61878ca28f34cf05e9dedeced95c
519b8cfhttps://patch-diff.githubusercontent.com/apache/cloudstack/commit/519b8cf0a8341afb2798fb34c659c2a6f6fcfd14
Compare https://patch-diff.githubusercontent.com/apache/cloudstack/compare/7274c9e033fc61878ca28f34cf05e9dedeced95c..519b8cf0a8341afb2798fb34c659c2a6f6fcfd14
January 14, 2026 15:19https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408#event-22046250914
https://patch-diff.githubusercontent.com/weizhouapache
weizhouapachehttps://patch-diff.githubusercontent.com/weizhouapache
Jan 14, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408#issuecomment-3750073780
@DaanHooglandhttps://github.com/DaanHoogland
#10122https://github.com/apache/cloudstack/issues/10122
@DaanHooglandhttps://github.com/DaanHoogland
@msinhorehttps://github.com/msinhore
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
https://patch-diff.githubusercontent.com/DaanHoogland
DaanHooglandhttps://patch-diff.githubusercontent.com/DaanHoogland
Jan 14, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408#issuecomment-3750230951
@DaanHooglandhttps://github.com/DaanHoogland
#10122https://github.com/apache/cloudstack/issues/10122
@DaanHooglandhttps://github.com/DaanHoogland
@msinhorehttps://github.com/msinhore
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
https://patch-diff.githubusercontent.com/weizhouapache
weizhouapachehttps://patch-diff.githubusercontent.com/weizhouapache
Jan 14, 2026https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408#issuecomment-3750367086
@DaanHooglandhttps://github.com/DaanHoogland
#10122https://github.com/apache/cloudstack/issues/10122
@DaanHooglandhttps://github.com/DaanHoogland
@msinhorehttps://github.com/msinhore
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Fpull%2F12408
Copilot code review https://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer
Copilot https://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer
https://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408/files/7274c9e033fc61878ca28f34cf05e9dedeced95c
component:networking https://patch-diff.githubusercontent.com/apache/cloudstack/issues?q=state%3Aopen%20label%3Acomponent%3Anetworking
Please reload this pagehttps://patch-diff.githubusercontent.com/apache/cloudstack/pull/12408
https://patch-diff.githubusercontent.com/DaanHoogland
https://patch-diff.githubusercontent.com/blueorangutan
https://patch-diff.githubusercontent.com/weizhouapache
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.