Title: fix($$RAFProvider): prevent a JavaScript error in Firefox by dmuellner · Pull Request #16192 · angular/angular.js · GitHub
Open Graph Title: fix($$RAFProvider): prevent a JavaScript error in Firefox by dmuellner · Pull Request #16192 · angular/angular.js
X Title: fix($$RAFProvider): prevent a JavaScript error in Firefox by dmuellner · Pull Request #16192 · angular/angular.js
Description: What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Bug fix: prevent a JavaScript error in Firefox. What is the current behavior? (You can also link to an open issue here) Firefox raises a Javascript Error "TypeError: 'requestAnimationFrame' called on an object that does not implement interface Window." with animated elements. This is because Window.requestAnimationFrame() is called without binding to a Window instance in the function which is returned from $$RAFProvider(). What is the new behavior (if this is a feature change)? No error message. Does this PR introduce a breaking change? Not that I know of. Please check if the PR fulfills these requirements The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) Other information: I was not able to run local tests.
Open Graph Description: What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Bug fix: prevent a JavaScript error in Firefox. What is the current behavior? (You can also link to an open issue he...
X Description: What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Bug fix: prevent a JavaScript error in Firefox. What is the current behavior? (You can also link to an open issue he...
Opengraph URL: https://github.com/angular/angular.js/pull/16192
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:8e255d55-d0eb-cf31-4581-8f7bc83dea80 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AEFC:154085:92DCBBD:C2F0462:696E0967 |
| html-safe-nonce | 23b292f0fbe41762b25e5b6a748fa5e9286e84ec301c3230a56868240e708dad |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRUZDOjE1NDA4NTo5MkRDQkJEOkMyRjA0NjI6Njk2RTA5NjciLCJ2aXNpdG9yX2lkIjoiODc5NTM4MjEzMzg3NDg4NzAxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | b4211a583c7432c301aec650f732893a1057bfef53044615b761c5899cb587ea |
| hovercard-subject-tag | pull_request:137152630 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular.js/pull/16192/files |
| twitter:image | https://avatars.githubusercontent.com/u/1724712?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1724712?s=400&v=4 |
| og:image:alt | What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Bug fix: prevent a JavaScript error in Firefox. What is the current behavior? (You can also link to an open issue he... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0b1760aa20e1a810eba6245d04e3885be7363dfe08d08b61f605c852359472e0 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular.js git https://github.com/angular/angular.js.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 460078 |
| octolytics-dimension-repository_nwo | angular/angular.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 460078 |
| octolytics-dimension-repository_network_root_nwo | angular/angular.js |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 84090305cd10c2b140bf307f69f57f0892b4f215 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width