Title: fix(removePatch): fire $destroy event when full jQuery is used by PeteAppleton · Pull Request #1512 · angular/angular.js · GitHub
Open Graph Title: fix(removePatch): fire $destroy event when full jQuery is used by PeteAppleton · Pull Request #1512 · angular/angular.js
X Title: fix(removePatch): fire $destroy event when full jQuery is used by PeteAppleton · Pull Request #1512 · angular/angular.js
Description: We found an issue where jQuery 1.8.2 is used where form controls created by ngRepeat are never removed from the parent form because the $destroy custom event is not fired. As a result, if a control was invalid (due to the model binding) and then destroyed the form's validity state became out-of-sync with the model and impossible to restore. This patch corrects the issue. The previous code relied upon internal jQuery structures which are not present in v.1.8.2 (current). This code uses the public API to fire the $destroy custom event, and so should work with any post-1.4 jQuery version.
Open Graph Description: We found an issue where jQuery 1.8.2 is used where form controls created by ngRepeat are never removed from the parent form because the $destroy custom event is not fired. As a result, if a contro...
X Description: We found an issue where jQuery 1.8.2 is used where form controls created by ngRepeat are never removed from the parent form because the $destroy custom event is not fired. As a result, if a contro...
Opengraph URL: https://github.com/angular/angular.js/pull/1512
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:740c402c-9a1a-e654-eb9e-c78bcdece7b5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AF9E:235B21:1195A09:1692388:6992459D |
| html-safe-nonce | 1351149df80510cb914e52db13fe8658d022cd4d3877d300db0dc511701df4b7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjlFOjIzNUIyMToxMTk1QTA5OjE2OTIzODg6Njk5MjQ1OUQiLCJ2aXNpdG9yX2lkIjoiODgxMzg0MjU1NjE1MDQ5ODcxNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 9e412d91fc4a35e2ac220ee5b9736bcc7c9d9d8f6e75c51220c3d7073df4e27b |
| hovercard-subject-tag | pull_request:2834459 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular.js/pull/1512/files |
| twitter:image | https://avatars.githubusercontent.com/u/2473999?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/2473999?s=400&v=4 |
| og:image:alt | We found an issue where jQuery 1.8.2 is used where form controls created by ngRepeat are never removed from the parent form because the $destroy custom event is not fired. As a result, if a contro... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular.js git https://github.com/angular/angular.js.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 460078 |
| octolytics-dimension-repository_nwo | angular/angular.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 460078 |
| octolytics-dimension-repository_network_root_nwo | angular/angular.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width