| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7f806b10-2c71-effe-69b5-974822c2465a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BD38:3617D0:953C37:C876EA:6973C853 |
| html-safe-nonce | 5d8cfc94956c59f99ff021ff1633326e8ece4e5ce404ee100afb9784360e28c6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDM4OjM2MTdEMDo5NTNDMzc6Qzg3NkVBOjY5NzNDODUzIiwidmlzaXRvcl9pZCI6IjgyNDQxNTAyOTg2NDE0MTgzMjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1161faa4b5741fb548628e3c659664502f57e7929c46d421af94c28cc8909822 |
| hovercard-subject-tag | pull_request:96729898 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/13272/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/fbddc8a106b6576697d2c64e3021347c7d43b3a43359f82b3a1d6f1d1ee9c14a/angular/angular/pull/13272 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/fbddc8a106b6576697d2c64e3021347c7d43b3a43359f82b3a1d6f1d1ee9c14a/angular/angular/pull/13272 |
| og:image:alt | Please check if the PR fulfills these requirements
The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have bee... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | maxime-allex |
| hostname | github.com |
| expected-hostname | github.com |
| None | acb8c988baca9616cb18bcb596629b823688faa1ef21a000061fe3616b4e3605 |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | af4eb23c75c70abd61c0b216b767faf4c9a30817 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/angular/angular/pull/13272#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F13272 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F13272 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://patch-diff.githubusercontent.com/angular/angular/pull/13272 |
| Reload | https://patch-diff.githubusercontent.com/angular/angular/pull/13272 |
| Reload | https://patch-diff.githubusercontent.com/angular/angular/pull/13272 |
|
angular
| https://patch-diff.githubusercontent.com/angular |
| angular | https://patch-diff.githubusercontent.com/angular/angular |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2Fangular%2Fangular |
|
Fork
27k
| https://patch-diff.githubusercontent.com/login?return_to=%2Fangular%2Fangular |
|
Star
99.7k
| https://patch-diff.githubusercontent.com/login?return_to=%2Fangular%2Fangular |
|
Code
| https://patch-diff.githubusercontent.com/angular/angular |
|
Issues
1k
| https://patch-diff.githubusercontent.com/angular/angular/issues |
|
Pull requests
125
| https://patch-diff.githubusercontent.com/angular/angular/pulls |
|
Discussions
| https://patch-diff.githubusercontent.com/angular/angular/discussions |
|
Actions
| https://patch-diff.githubusercontent.com/angular/angular/actions |
|
Projects
2
| https://patch-diff.githubusercontent.com/angular/angular/projects |
|
Security
4
| https://patch-diff.githubusercontent.com/angular/angular/security |
|
Insights
| https://patch-diff.githubusercontent.com/angular/angular/pulse |
|
Code
| https://patch-diff.githubusercontent.com/angular/angular |
|
Issues
| https://patch-diff.githubusercontent.com/angular/angular/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/angular/angular/pulls |
|
Discussions
| https://patch-diff.githubusercontent.com/angular/angular/discussions |
|
Actions
| https://patch-diff.githubusercontent.com/angular/angular/actions |
|
Projects
| https://patch-diff.githubusercontent.com/angular/angular/projects |
|
Security
| https://patch-diff.githubusercontent.com/angular/angular/security |
|
Insights
| https://patch-diff.githubusercontent.com/angular/angular/pulse |
| Sign up for GitHub
| https://patch-diff.githubusercontent.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://patch-diff.githubusercontent.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://patch-diff.githubusercontent.com/angular/angular/pull/13272#issue-comment-box |
| maxime-allex | https://patch-diff.githubusercontent.com/maxime-allex |
| angular:master | https://patch-diff.githubusercontent.com/angular/angular/tree/master |
| Linkurious:i18n-explicit-id | https://patch-diff.githubusercontent.com/Linkurious/angular/tree/i18n-explicit-id |
|
feat(compiler) : i18n explicit ID
| https://patch-diff.githubusercontent.com/angular/angular/pull/13272#top |
| maxime-allex | https://patch-diff.githubusercontent.com/maxime-allex |
| angular:master | https://patch-diff.githubusercontent.com/angular/angular/tree/master |
| Linkurious:i18n-explicit-id | https://patch-diff.githubusercontent.com/Linkurious/angular/tree/i18n-explicit-id |
|
Conversation
17
| https://patch-diff.githubusercontent.com/angular/angular/pull/13272 |
|
Commits
3
| https://patch-diff.githubusercontent.com/angular/angular/pull/13272/commits |
|
Checks
0
| https://patch-diff.githubusercontent.com/angular/angular/pull/13272/checks |
|
Files changed
| https://patch-diff.githubusercontent.com/angular/angular/pull/13272/files |
| Please reload this page | https://patch-diff.githubusercontent.com/angular/angular/pull/13272 |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/angular/angular/pull/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/maxime-allex |
| maxime-allex | https://patch-diff.githubusercontent.com/maxime-allex |
| Dec 6, 2016 | https://patch-diff.githubusercontent.com/angular/angular/pull/13272#issue-193780874 |
| https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit | https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit |
| [i18n] enable control over translation message ID | https://github.com/angular/angular/issues/12941 |
| Please reload this page | https://patch-diff.githubusercontent.com/angular/angular/pull/13272 |
| https://patch-diff.githubusercontent.com/googlebot |
| googlebot | https://patch-diff.githubusercontent.com/googlebot |
|
cla: yes
| https://patch-diff.githubusercontent.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Dec 6, 2016 | https://patch-diff.githubusercontent.com/angular/angular/pull/13272#event-883680940 |
| https://patch-diff.githubusercontent.com/maxime-allex |
| maxime-allex | https://patch-diff.githubusercontent.com/maxime-allex |
| Dec 6, 2016 | https://patch-diff.githubusercontent.com/angular/angular/pull/13272#issuecomment-265158014 |
| @vicb | https://github.com/vicb |
| Please reload this page | https://patch-diff.githubusercontent.com/angular/angular/pull/13272 |
| https://patch-diff.githubusercontent.com/maxime-allex |
| maxime-allex | https://patch-diff.githubusercontent.com/maxime-allex |
|
Dec 6, 2016
| https://patch-diff.githubusercontent.com/angular/angular/pull/13272#ref-issue-190062557 |
|
[i18n] enable control over translation message ID
#12941
| https://patch-diff.githubusercontent.com/angular/angular/issues/12941 |
| https://patch-diff.githubusercontent.com/maxime-allex |
| maxime-allex | https://patch-diff.githubusercontent.com/maxime-allex |
| force-pushed | https://patch-diff.githubusercontent.com/angular/angular/compare/03506255263fad96769086f2b6dcb797d212aaf8..bde38c5479abea757b95620ccf3704debb29a9b7 |
| 0350625 | https://patch-diff.githubusercontent.com/angular/angular/commit/03506255263fad96769086f2b6dcb797d212aaf8 |
| bde38c5 | https://patch-diff.githubusercontent.com/angular/angular/commit/bde38c5479abea757b95620ccf3704debb29a9b7 |
|
Compare
| https://patch-diff.githubusercontent.com/angular/angular/compare/03506255263fad96769086f2b6dcb797d212aaf8..bde38c5479abea757b95620ccf3704debb29a9b7 |
| December 6, 2016 14:56 | https://patch-diff.githubusercontent.com/angular/angular/pull/13272#event-883752989 |
| https://patch-diff.githubusercontent.com/vicb |
| vicb | https://patch-diff.githubusercontent.com/vicb |
|
Dec 6, 2016
| https://patch-diff.githubusercontent.com/angular/angular/pull/13272#pullrequestreview-11636995 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/angular/angular/pull/13272/files |
| modules/@angular/compiler/src/i18n/extractor_merger.ts | https://patch-diff.githubusercontent.com/angular/angular/pull/13272/files#diff-605ceac0c61be242c5f100695c6f34c33940007bc6ca9f3c4ca6de437fa1b489 |
| vicb | https://patch-diff.githubusercontent.com/vicb |
| Dec 6, 2016 | https://patch-diff.githubusercontent.com/angular/angular/pull/13272#discussion_r91127701 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/angular/angular/pull/13272 |
| maxime-allex | https://patch-diff.githubusercontent.com/maxime-allex |
| Dec 7, 2016 | https://patch-diff.githubusercontent.com/angular/angular/pull/13272#discussion_r91240609 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @vicb | https://github.com/vicb |
| Please reload this page | https://patch-diff.githubusercontent.com/angular/angular/pull/13272 |
| https://patch-diff.githubusercontent.com/vicb |
| vicb | https://patch-diff.githubusercontent.com/vicb |
|
Dec 6, 2016
| https://patch-diff.githubusercontent.com/angular/angular/pull/13272#pullrequestreview-11637080 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/angular/angular/pull/13272/files |
| modules/@angular/compiler/src/i18n/extractor_merger.ts | https://patch-diff.githubusercontent.com/angular/angular/pull/13272/files#diff-605ceac0c61be242c5f100695c6f34c33940007bc6ca9f3c4ca6de437fa1b489 |
| vicb | https://patch-diff.githubusercontent.com/vicb |
| Dec 6, 2016 | https://patch-diff.githubusercontent.com/angular/angular/pull/13272#discussion_r91127776 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/angular/angular/pull/13272 |
| https://patch-diff.githubusercontent.com/vicb |
| vicb | https://patch-diff.githubusercontent.com/vicb |
|
Dec 6, 2016
| https://patch-diff.githubusercontent.com/angular/angular/pull/13272#pullrequestreview-11637207 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/angular/angular/pull/13272/files |
| modules/@angular/compiler/src/i18n/extractor_merger.ts | https://patch-diff.githubusercontent.com/angular/angular/pull/13272/files#diff-605ceac0c61be242c5f100695c6f34c33940007bc6ca9f3c4ca6de437fa1b489 |
| vicb | https://patch-diff.githubusercontent.com/vicb |
| Dec 6, 2016 | https://patch-diff.githubusercontent.com/angular/angular/pull/13272#discussion_r91127895 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/angular/angular/pull/13272 |
| https://patch-diff.githubusercontent.com/vicb |
| vicb | https://patch-diff.githubusercontent.com/vicb |
|
Dec 6, 2016
| https://patch-diff.githubusercontent.com/angular/angular/pull/13272#pullrequestreview-11637551 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/angular/angular/pull/13272/files |
| modules/@angular/compiler/src/i18n/extractor_merger.ts | https://patch-diff.githubusercontent.com/angular/angular/pull/13272/files#diff-605ceac0c61be242c5f100695c6f34c33940007bc6ca9f3c4ca6de437fa1b489 |
| vicb | https://patch-diff.githubusercontent.com/vicb |
| Dec 6, 2016 | https://patch-diff.githubusercontent.com/angular/angular/pull/13272#discussion_r91128212 |
| Please reload this page | https://patch-diff.githubusercontent.com/angular/angular/pull/13272 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/angular/angular/pull/13272 |
| https://patch-diff.githubusercontent.com/vicb |
| vicb | https://patch-diff.githubusercontent.com/vicb |
|
Dec 6, 2016
| https://patch-diff.githubusercontent.com/angular/angular/pull/13272#pullrequestreview-11637687 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/angular/angular/pull/13272/files |
| modules/@angular/compiler/test/i18n/digest_spec.ts | https://patch-diff.githubusercontent.com/angular/angular/pull/13272/files#diff-b28105e4fd4e370923202087646d41c92c23928680cc6d28bcdba01b0ac882a6 |
| vicb | https://patch-diff.githubusercontent.com/vicb |
| Dec 6, 2016 | https://patch-diff.githubusercontent.com/angular/angular/pull/13272#discussion_r91128346 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/angular/angular/pull/13272 |
| https://patch-diff.githubusercontent.com/vicb |
| vicb | https://patch-diff.githubusercontent.com/vicb |
| Dec 6, 2016 | https://patch-diff.githubusercontent.com/angular/angular/pull/13272#issuecomment-265215197 |
| Please reload this page | https://patch-diff.githubusercontent.com/angular/angular/pull/13272 |
| https://patch-diff.githubusercontent.com/vicb |
| vicb | https://patch-diff.githubusercontent.com/vicb |
|
area: i18n
| https://patch-diff.githubusercontent.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22 |
|
action: review
| https://patch-diff.githubusercontent.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
feature
| https://patch-diff.githubusercontent.com/angular/angular/issues?q=state%3Aopen%20label%3Afeature |
|
action: cleanup
| https://patch-diff.githubusercontent.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
| Dec 6, 2016 | https://patch-diff.githubusercontent.com/angular/angular/pull/13272#event-884004986 |
| https://patch-diff.githubusercontent.com/vicb |
| vicb | https://patch-diff.githubusercontent.com/vicb |
| Dec 6, 2016 | https://patch-diff.githubusercontent.com/angular/angular/pull/13272#issuecomment-265237525 |
| Please reload this page | https://patch-diff.githubusercontent.com/angular/angular/pull/13272 |
| https://patch-diff.githubusercontent.com/maxime-allex |
| maxime-allex | https://patch-diff.githubusercontent.com/maxime-allex |
| force-pushed | https://patch-diff.githubusercontent.com/angular/angular/compare/bde38c5479abea757b95620ccf3704debb29a9b7..8f8af593a0495bfb7722fed1cf3f500f19e80c51 |
| bde38c5 | https://patch-diff.githubusercontent.com/angular/angular/commit/bde38c5479abea757b95620ccf3704debb29a9b7 |
| 8f8af59 | https://patch-diff.githubusercontent.com/angular/angular/commit/8f8af593a0495bfb7722fed1cf3f500f19e80c51 |
|
Compare
| https://patch-diff.githubusercontent.com/angular/angular/compare/bde38c5479abea757b95620ccf3704debb29a9b7..8f8af593a0495bfb7722fed1cf3f500f19e80c51 |
| December 7, 2016 08:51 | https://patch-diff.githubusercontent.com/angular/angular/pull/13272#event-884897631 |
| https://patch-diff.githubusercontent.com/maxime-allex |
| maxime-allex | https://patch-diff.githubusercontent.com/maxime-allex |
| Dec 7, 2016 | https://patch-diff.githubusercontent.com/angular/angular/pull/13272#issuecomment-265417599 |
| @vicb | https://github.com/vicb |
| docs(compiler): add doc + examples for i18n explicit ID option | https://github.com/angular/angular.io/pull/2941 |
| Please reload this page | https://patch-diff.githubusercontent.com/angular/angular/pull/13272 |
| https://patch-diff.githubusercontent.com/maxime-allex |
| maxime-allex | https://patch-diff.githubusercontent.com/maxime-allex |
| force-pushed | https://patch-diff.githubusercontent.com/angular/angular/compare/8f8af593a0495bfb7722fed1cf3f500f19e80c51..129d9c796043f79385f73b078c45fb79182b7547 |
| 8f8af59 | https://patch-diff.githubusercontent.com/angular/angular/commit/8f8af593a0495bfb7722fed1cf3f500f19e80c51 |
| 129d9c7 | https://patch-diff.githubusercontent.com/angular/angular/commit/129d9c796043f79385f73b078c45fb79182b7547 |
|
Compare
| https://patch-diff.githubusercontent.com/angular/angular/compare/8f8af593a0495bfb7722fed1cf3f500f19e80c51..129d9c796043f79385f73b078c45fb79182b7547 |
| December 7, 2016 10:58 | https://patch-diff.githubusercontent.com/angular/angular/pull/13272#event-885057184 |
| https://patch-diff.githubusercontent.com/vicb |
| vicb | https://patch-diff.githubusercontent.com/vicb |
|
Dec 7, 2016
| https://patch-diff.githubusercontent.com/angular/angular/pull/13272#pullrequestreview-11866305 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/angular/angular/pull/13272/files |
| modules/@angular/compiler/src/i18n/extractor_merger.ts | https://patch-diff.githubusercontent.com/angular/angular/pull/13272/files#diff-605ceac0c61be242c5f100695c6f34c33940007bc6ca9f3c4ca6de437fa1b489 |
| vicb | https://patch-diff.githubusercontent.com/vicb |
| Dec 7, 2016 | https://patch-diff.githubusercontent.com/angular/angular/pull/13272#discussion_r91357049 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/angular/angular/pull/13272 |
| https://patch-diff.githubusercontent.com/vicb |
| vicb | https://patch-diff.githubusercontent.com/vicb |
|
Dec 7, 2016
| https://patch-diff.githubusercontent.com/angular/angular/pull/13272#pullrequestreview-11867378 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/angular/angular/pull/13272/files |
| modules/@angular/compiler/src/i18n/extractor_merger.ts | https://patch-diff.githubusercontent.com/angular/angular/pull/13272/files#diff-605ceac0c61be242c5f100695c6f34c33940007bc6ca9f3c4ca6de437fa1b489 |
| vicb | https://patch-diff.githubusercontent.com/vicb |
| Dec 7, 2016 | https://patch-diff.githubusercontent.com/angular/angular/pull/13272#discussion_r91358138 |
| Please reload this page | https://patch-diff.githubusercontent.com/angular/angular/pull/13272 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/angular/angular/pull/13272 |
| https://patch-diff.githubusercontent.com/vicb |
| vicb | https://patch-diff.githubusercontent.com/vicb |
|
Dec 7, 2016
| https://patch-diff.githubusercontent.com/angular/angular/pull/13272#pullrequestreview-11867638 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/angular/angular/pull/13272/files |
| modules/@angular/compiler/test/i18n/extractor_merger_spec.ts | https://patch-diff.githubusercontent.com/angular/angular/pull/13272/files#diff-928a7179eba00e9fdaea76cfffa3308cdcde9e836f6677a5fa162a808db40cb7 |
| vicb | https://patch-diff.githubusercontent.com/vicb |
| Dec 7, 2016 | https://patch-diff.githubusercontent.com/angular/angular/pull/13272#discussion_r91358397 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/angular/angular/pull/13272 |
| https://patch-diff.githubusercontent.com/vicb |
| vicb | https://patch-diff.githubusercontent.com/vicb |
| Dec 7, 2016 | https://patch-diff.githubusercontent.com/angular/angular/pull/13272#issuecomment-265534409 |
| Please reload this page | https://patch-diff.githubusercontent.com/angular/angular/pull/13272 |
| maxime-allex | https://patch-diff.githubusercontent.com/maxime-allex |
| December 8, 2016 09:54 | https://patch-diff.githubusercontent.com/angular/angular/pull/13272#commits-pushed-9d5fbf7 |
|
| https://patch-diff.githubusercontent.com/maxime-allex |
| feat(compiler): add id property to i18nMessage | https://patch-diff.githubusercontent.com/angular/angular/pull/13272/commits/9d5fbf74f42d134b1d717dac259f76b03d9e37f6 |
| 9d5fbf7 | https://patch-diff.githubusercontent.com/angular/angular/pull/13272/commits/9d5fbf74f42d134b1d717dac259f76b03d9e37f6 |
|
| https://patch-diff.githubusercontent.com/maxime-allex |
| feat(compiler): digest methods return i18nMessage id if sets | https://patch-diff.githubusercontent.com/angular/angular/pull/13272/commits/03c874fadd5ebd31c62ffbaa543c1af0129633aa |
| 03c874f | https://patch-diff.githubusercontent.com/angular/angular/pull/13272/commits/03c874fadd5ebd31c62ffbaa543c1af0129633aa |
|
| https://patch-diff.githubusercontent.com/maxime-allex |
| test(compiler): test i18n explicit id | https://patch-diff.githubusercontent.com/angular/angular/pull/13272/commits/b868ce28304ac25cf16e43de08cb7032d85abc15 |
| b868ce2 | https://patch-diff.githubusercontent.com/angular/angular/pull/13272/commits/b868ce28304ac25cf16e43de08cb7032d85abc15 |
| https://patch-diff.githubusercontent.com/maxime-allex |
| maxime-allex | https://patch-diff.githubusercontent.com/maxime-allex |
| force-pushed | https://patch-diff.githubusercontent.com/angular/angular/compare/129d9c796043f79385f73b078c45fb79182b7547..b868ce28304ac25cf16e43de08cb7032d85abc15 |
| 129d9c7 | https://patch-diff.githubusercontent.com/angular/angular/commit/129d9c796043f79385f73b078c45fb79182b7547 |
| b868ce2 | https://patch-diff.githubusercontent.com/angular/angular/commit/b868ce28304ac25cf16e43de08cb7032d85abc15 |
|
Compare
| https://patch-diff.githubusercontent.com/angular/angular/compare/129d9c796043f79385f73b078c45fb79182b7547..b868ce28304ac25cf16e43de08cb7032d85abc15 |
| December 8, 2016 08:54 | https://patch-diff.githubusercontent.com/angular/angular/pull/13272#event-886535951 |
| https://patch-diff.githubusercontent.com/vicb |
| vicb | https://patch-diff.githubusercontent.com/vicb |
|
action: merge
| https://patch-diff.githubusercontent.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: cleanup
| https://patch-diff.githubusercontent.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
| Dec 9, 2016 | https://patch-diff.githubusercontent.com/angular/angular/pull/13272#event-887914507 |
| https://patch-diff.githubusercontent.com/vicb |
| vicb | https://patch-diff.githubusercontent.com/vicb |
| Dec 9, 2016 | https://patch-diff.githubusercontent.com/angular/angular/pull/13272#issuecomment-265939385 |
| Please reload this page | https://patch-diff.githubusercontent.com/angular/angular/pull/13272 |
| https://patch-diff.githubusercontent.com/vicb |
| vicb | https://patch-diff.githubusercontent.com/vicb |
|
action: review
| https://patch-diff.githubusercontent.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Dec 9, 2016 | https://patch-diff.githubusercontent.com/angular/angular/pull/13272#event-888705226 |
| https://patch-diff.githubusercontent.com/vicb |
| vicb | https://patch-diff.githubusercontent.com/vicb |
| 56c361f | https://patch-diff.githubusercontent.com/angular/angular/commit/56c361ff6adee8c9d03e495f04eaab8a9d4cc1f4 |
| Dec 9, 2016 | https://patch-diff.githubusercontent.com/angular/angular/pull/13272#event-888751333 |
| https://patch-diff.githubusercontent.com/kibbled |
| kibbled | https://patch-diff.githubusercontent.com/kibbled |
| Dec 21, 2016 | https://patch-diff.githubusercontent.com/angular/angular/pull/13272#issuecomment-268635235 |
| Please reload this page | https://patch-diff.githubusercontent.com/angular/angular/pull/13272 |
| https://patch-diff.githubusercontent.com/vicb |
| vicb | https://patch-diff.githubusercontent.com/vicb |
|
Jan 4, 2017
| https://patch-diff.githubusercontent.com/angular/angular/pull/13272#ref-issue-198777767 |
|
Allow specifying an i18n ID rather than generating it from the content
#13781
| https://patch-diff.githubusercontent.com/angular/angular/issues/13781 |
| https://patch-diff.githubusercontent.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://patch-diff.githubusercontent.com/apps/angular-automatic-lock-bot |
| Sep 10, 2019 | https://patch-diff.githubusercontent.com/angular/angular/pull/13272#issuecomment-529909175 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://patch-diff.githubusercontent.com/angular/angular/pull/13272 |
| https://patch-diff.githubusercontent.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://patch-diff.githubusercontent.com/apps/angular-automatic-lock-bot |
| Sep 10, 2019 | https://patch-diff.githubusercontent.com/angular/angular/pull/13272#event-2622038017 |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F13272 |
|
| https://patch-diff.githubusercontent.com/vicb |
|
vicb
| https://patch-diff.githubusercontent.com/vicb |
|
| https://patch-diff.githubusercontent.com/angular/angular/pull/13272/files/129d9c796043f79385f73b078c45fb79182b7547 |
|
action: merge
| https://patch-diff.githubusercontent.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
area: i18n
| https://patch-diff.githubusercontent.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22 |
|
cla: yes
| https://patch-diff.githubusercontent.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
feature
| https://patch-diff.githubusercontent.com/angular/angular/issues?q=state%3Aopen%20label%3Afeature |
| Please reload this page | https://patch-diff.githubusercontent.com/angular/angular/pull/13272 |
|
| https://patch-diff.githubusercontent.com/maxime-allex |
|
| https://patch-diff.githubusercontent.com/vicb |
|
| https://patch-diff.githubusercontent.com/kibbled |
|
| https://patch-diff.githubusercontent.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |