René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"extract-i18n generating wrong source inside the xfl file when parsing empty elements","articleBody":"### Command\r\n\r\nextract-i18n\r\n\r\n### Is this a regression?\r\n\r\n- [X] Yes, this behavior used to work in the previous version\r\n\r\n### The previous version in which this bug was not present was\r\n\r\n_No response_\r\n\r\n### Description\r\n\r\nWe recently upgraded to v16.2.14 from v14 (couldn't update further as we need to fix some dependencies which don't support \u003e v17) and now I discovered by chance that extract-i18n is producing an xlf which would break html once using a language different from the default one.\r\nDebugging a bit, I found out that the parse of empty html elements (like `\u003csvg\u003e\u003c/svg\u003e` or `\u003cspan\u003e\u003c/span\u003e`) is producing wrong closing tags picking up part of the text after the real closing tag. An example below:\r\nthis html\r\n```html\r\n\u003cdiv\u003e\r\n  \u003cbutton\r\n    i18n=\"add line button@myAddLineStringId\"\r\n  \u003e\r\n    Add line\r\n    \u003csvg cdsIcon=\"add\" size=\"20\" class=\"cds--btn__icon\"\u003e\u003c/svg\u003e\r\n  \u003c/button\u003e\r\n\u003c/div\u003e\r\n```\r\nis producing this entry in the xlf\r\n```xlf\r\n\u003csource\u003e Add line \u003cx id=\"START_TAG__SVG_SVG\" ctype=\"x-_svg_svg\" equiv-text=\"\u0026lt;svg cdsIcon=\u0026quot;add\u0026quot; size=\u0026quot;20\u0026quot; class=\u0026quot;cds--btn__icon\u0026quot;\u0026gt;\"/\u003e\u003cx id=\"CLOSE_TAG__SVG_SVG\" ctype=\"x-_svg_svg\" equiv-text=\"\u0026lt;/button\u0026gt;\r\n\u0026lt;/di\"/\u003e\u003c/source\u003e\r\n```\r\nas you can see, when the translated xlf will take over the default language version, it will produce an svg closing tag `\u003c/button\u003e\u003c/di` which would then break the above html\r\nA simple fix is to add a space inside the empty element, or move the closing tag in a new line, but this might collide with linter setup, so not a great temporary solution.\r\n\r\n### Minimal Reproduction\r\n\r\nhave in a template the following:\r\n```html\r\n\u003cdiv i18n=\"description@@stringId\"\u003e\r\n  A string\r\n  \u003cspan\u003e\u003c/span\u003e\r\n\u003c/div\u003e\r\n```\r\n\r\nand then run the normal extract-i18n\r\n\r\n### Exception or Error\r\n\r\n_No response_\r\n\r\n### Your Environment\r\n\r\n```text\r\n_                      _                 ____ _     ___\r\n    / \\   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|\r\n   / △ \\ | '_ \\ / _` | | | | |/ _` | '__|   | |   | |    | |\r\n  / ___ \\| | | | (_| | |_| | | (_| | |      | |___| |___ | |\r\n /_/   \\_\\_| |_|\\__, |\\__,_|_|\\__,_|_|       \\____|_____|___|\r\n                |___/\r\n    \r\n\r\nAngular CLI: 16.2.14\r\nNode: 18.20.1\r\nPackage Manager: yarn 1.22.19\r\nOS: darwin arm64\r\n\r\nAngular: 16.2.12\r\n... animations, common, compiler, compiler-cli, core, elements\r\n... forms, language-service, localize, platform-browser\r\n... platform-browser-dynamic, router, service-worker\r\n\r\nPackage                         Version\r\n---------------------------------------------------------\r\n@angular-devkit/architect       0.1602.14\r\n@angular-devkit/build-angular   16.2.14\r\n@angular-devkit/core            16.2.14\r\n@angular-devkit/schematics      16.2.14\r\n@angular/cdk                    16.2.14\r\n@angular/cli                    16.2.14\r\n@angular/material               16.2.14\r\n@schematics/angular             16.2.14\r\nrxjs                            7.8.1\r\ntypescript                      4.9.5\r\nzone.js                         0.13.3\r\n```\r\n\r\n\r\n### Anything else relevant?\r\n\r\n_No response_","author":{"url":"https://github.com/Licen-it","@type":"Person","name":"Licen-it"},"datePublished":"2024-07-03T12:38:08.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":9},"url":"https://github.com/56824/angular/issues/56824"}