Title: Switch controller buttons back to `button` elements · Issue #672 · ableplayer/ableplayer · GitHub
Open Graph Title: Switch controller buttons back to `button` elements · Issue #672 · ableplayer/ableplayer
X Title: Switch controller buttons back to `button` elements · Issue #672 · ableplayer/ableplayer
Description: All of Able Player's buttons were changed to div elements with role="button" in 51fdbd8, to resolve issues with high contrast mode. I know that there are other solutions to this problem, and I feel like it would be better to use native b...
Open Graph Description: All of Able Player's buttons were changed to div elements with role="button" in 51fdbd8, to resolve issues with high contrast mode. I know that there are other solutions to this problem, and I feel...
X Description: All of Able Player's buttons were changed to div elements with role="button" in 51fdbd8, to resolve issues with high contrast mode. I know that there are other solutions to this probl...
Opengraph URL: https://github.com/ableplayer/ableplayer/issues/672
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Switch controller buttons back to `button` elements","articleBody":"All of Able Player's buttons were changed to `div` elements with `role=\"button\"` in https://github.com/ableplayer/ableplayer/commit/51fdbd8496b37e5ca44e59ebc7caa9a2eb712de5, to resolve issues with high contrast mode. \n\nI know that there are other solutions to this problem, and I feel like it would be better to use native `button` elements and solve the issue in CSS. \n\nThis could result in CSS compatibility problems with styling, but overall I still think it would be better. \n\nTo start, I might need to make it an option (possibly enabled by default), but allow people to opt out while they get their styles adapted (or while I fix bugs, if possible.)\n\nBut by version 5.0, I'd like to be solely using real button elements.","author":{"url":"https://github.com/joedolson","@type":"Person","name":"joedolson"},"datePublished":"2025-08-22T02:11:42.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/672/ableplayer/issues/672"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:156af72a-7224-b39b-eda6-d36e326102ff |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A158:25602F:EAABE29:13204875:6976F9FC |
| html-safe-nonce | d89ac438ccc04ca4ce42c2f5033e11b70779f1df0d415ae1d9b40a9d7b7de883 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTU4OjI1NjAyRjpFQUFCRTI5OjEzMjA0ODc1OjY5NzZGOUZDIiwidmlzaXRvcl9pZCI6IjI0NjQwODI1NjQwODQwNzA5MDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | c3e0b60d5db178ad508bfa3d116bce1266160bd930b6f1c56125191ddb0c01e1 |
| hovercard-subject-tag | issue:3343850713 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/ableplayer/ableplayer/672/issue_layout |
| twitter:image | https://opengraph.githubassets.com/3a0558916445c1b6db5eceff9b1213d35c8d9dfacd07350a7d6b02f8f605e6fc/ableplayer/ableplayer/issues/672 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3a0558916445c1b6db5eceff9b1213d35c8d9dfacd07350a7d6b02f8f605e6fc/ableplayer/ableplayer/issues/672 |
| og:image:alt | All of Able Player's buttons were changed to div elements with role="button" in 51fdbd8, to resolve issues with high contrast mode. I know that there are other solutions to this problem, and I feel... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | joedolson |
| hostname | github.com |
| expected-hostname | github.com |
| None | 01d198479908d09a841b2febe8eb105a81af2af7d81830960fe0971e1f4adc09 |
| turbo-cache-control | no-preview |
| go-import | github.com/ableplayer/ableplayer git https://github.com/ableplayer/ableplayer.git |
| octolytics-dimension-user_id | 8876080 |
| octolytics-dimension-user_login | ableplayer |
| octolytics-dimension-repository_id | 18680618 |
| octolytics-dimension-repository_nwo | ableplayer/ableplayer |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 18680618 |
| octolytics-dimension-repository_network_root_nwo | ableplayer/ableplayer |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f752335dbbea672610081196a1998e39aec5e14b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width