René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[feature/refactor] general bugs","articleBody":"I'm going to use this issue to track all the bugs I find while working on the LSP\r\n\r\n## Error Reporting\r\n- [ ] `missing call argument` reported incorrectly\r\nThis should be reported as `too many call arguments` or better `1 parameter expecetd but 2 were given`\r\n```zenscript\r\nblock.setFriction(1, \"\");\r\n```\r\nThis happens [here](https://github.com/ZenCodeLang/ZenCode/blob/3b7a3024fd0b759ecd1b2c0c6340ef3097c90845/CodeModel/src/main/java/org/openzen/zenscript/codemodel/compilation/MatchedCallArguments.java#L128)\r\n- [ ] call argument error position is incorrect\r\nThe position should be reported in between the `()`\r\n![image](https://github.com/user-attachments/assets/002b6f31-1b8e-4e3a-b59b-ec124a715f03)\r\n- [ ] Unknown variable has a weird reporting message, [this](https://github.com/ZenCodeLang/ZenCode/blob/f325e2f54221dd0df3cd5f29d1624a3a2c2293b9/CodeModel/src/main/java/org/openzen/zenscript/codemodel/compilation/CompileErrors.java#L192) can probably be more vague, like `cannot find X`\r\n- [ ] (opinion) `ambigious call` is too verbose\r\n\r\n```zenscript\r\nvar b = a.map\u003cstring\u003e(x =\u003e \"a\" + x);\r\n```\r\n is reporting as\r\n\r\n```\r\nAmbiguous call; multiple headers match:\r\n\u003cU@Arrays.zs:50:12\u003e(projection: function(value: string): string): string[]\r\n\u003cU@arrays_map_2.zc:7:12\u003e(projection: function(value: string): string): string[]\r\n```\r\n\r\nCould be reported as:\r\n```\r\nAmbiguous call; multiple headers match:\r\n\u003cU@Arrays.zs:50:12\u003e(function(string): string): string[]\r\n\u003cU@arrays_map_2.zc:7:12\u003e(function(string): string): string[]\r\n```\r\nThere could be more cleanup, but I think removing the parameter names are a good start\r\nJava reports this error as:\r\n```\r\nAmbiguous method call: both 'CompilerErrors.doThing(Function\u003cString, String\u003e)' and 'CompilerErrors.doThing(int[])' match.\r\n```\r\n\r\n\r\n- [ ] No operator in type position is incorrect when in call arguments\r\nThe position should be reported on the operator, instead of on the function call\r\n![image](https://github.com/user-attachments/assets/5ddc7257-9c92-4982-8425-518d86221341)\r\n\r\n- [ ] Iterator errors are reported in the wrong place\r\n![image](https://github.com/user-attachments/assets/8945123b-bbea-4fac-b571-18173ca80228)\r\n\r\n## General\r\n- [ ] If a class has a constructor, the ContructorMember's body never gets set and is always null\r\nhttps://github.com/ZenCodeLang/ZenCode/blob/f325e2f54221dd0df3cd5f29d1624a3a2c2293b9/CodeModel/src/main/java/org/openzen/zenscript/codemodel/definition/ClassDefinition.java#L46","author":{"url":"https://github.com/jaredlll08","@type":"Person","name":"jaredlll08"},"datePublished":"2024-08-11T08:36:24.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/165/ZenCode/issues/165"}