René's URL Explorer Experiment

Title: Fix string.find and string.match from unexpected explosions by jordan4ibanez · Pull Request #86 · TypeScriptToLua/lua-types · GitHub

Open Graph Title: Fix string.find and string.match from unexpected explosions by jordan4ibanez · Pull Request #86 · TypeScriptToLua/lua-types

X Title: Fix string.find and string.match from unexpected explosions by jordan4ibanez · Pull Request #86 · TypeScriptToLua/lua-types

Description: I was reading the documentation for string.find and I noticed that in it's own documentation it reads: /** * Looks for the first match of pattern (see §6.4.1) in the string s. If it * finds a match, then find returns the indices of s where this occurrence * starts and ends; otherwise, it returns nil. * / I see the definition defined as: function find( s: string, pattern: string, init?: number, plain?: boolean ): LuaMultiReturn<[number, number, ...string[]] | []> ; Perhaps the easiest solution for this would be to simply add optional return parameters as follows: function find( s: string, pattern: string, init?: number, plain?: boolean ): LuaMultiReturn<[number?, number?, ...string[]] | []> ; So this way, at least you know it might explode instead of blindly walking into an explosion. Also: I noticed that string.match could also blow up so I threw that in there.

Open Graph Description: I was reading the documentation for string.find and I noticed that in it's own documentation it reads: /** * Looks for the first match of pattern (see §6.4.1) in the string s. If it * finds...

X Description: I was reading the documentation for string.find and I noticed that in it&#39;s own documentation it reads: /** * Looks for the first match of pattern (see §6.4.1) in the string s. If it * f...

Opengraph URL: https://github.com/TypeScriptToLua/lua-types/pull/86

X: @github

direct link

Domain: patch-diff.githubusercontent.com

Links:

Viewport: width=device-width