René's URL Explorer Experiment

Title: `repl` param of `string.gsub` seems to be incorrect · Issue #52 · TypeScriptToLua/lua-types · GitHub

Open Graph Title: `repl` param of `string.gsub` seems to be incorrect · Issue #52 · TypeScriptToLua/lua-types

X Title: `repl` param of `string.gsub` seems to be incorrect · Issue #52 · TypeScriptToLua/lua-types

Description: The types say: repl: string | Record | ((...matches: string[]) => string),, whereas the above docstring says: "otherwise, if it is false or nil, then there is no replacement" - therefore, this should be an optional string...

Open Graph Description: The types say: repl: string | Record | ((...matches: string[]) => string),, whereas the above docstring says: "otherwise, if it is false or nil, then there is no replacement" - ther...

X Description: The types say: repl: string | Record<string, string> | ((...matches: string[]) => string),, whereas the above docstring says: "otherwise, if it is false or nil, then there is no repla...

Opengraph URL: https://github.com/TypeScriptToLua/lua-types/issues/52

X: @github

direct link

Domain: patch-diff.githubusercontent.com

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`repl` param of `string.gsub` seems to be incorrect","articleBody":"The types say: `repl: string | Record\u003cstring, string\u003e | ((...matches: string[]) =\u003e string),`, whereas the above docstring says: \"otherwise, if it is false or nil, then there is no replacement\" - therefore, this should be an optional string, as it may be `nil`.\r\n\r\nFurthermore, I believe a `()` capture group will return an `index`, so the matches aren't even necessarily a `string[]`, but may be either `number` or `string`. `gmatch` etc might have similar issues.\r\n\r\nYou should maybe declare a `match` type which may be either a `number` or a `string`.","author":{"url":"https://github.com/appgurueu","@type":"Person","name":"appgurueu"},"datePublished":"2022-02-12T21:01:44.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/52/lua-types/issues/52"}

Links:

Viewport: width=device-width