Title: fix: only parse arguments from first line of tag comment by aabajyan · Pull Request #1650 · TypeScriptToLua/TypeScriptToLua · GitHub
Open Graph Title: fix: only parse arguments from first line of tag comment by aabajyan · Pull Request #1650 · TypeScriptToLua/TypeScriptToLua
X Title: fix: only parse arguments from first line of tag comment by aabajyan · Pull Request #1650 · TypeScriptToLua/TypeScriptToLua
Description: I had this issue, where I was trying to use customName annotation to rename methods and I noticed that it was also including a new line and the first word of the next line. For example: /** @noSelf */ declare namespace TestNamespace { /** * @customName pass * The first word should not be included. **/ function fail(): void; } TestNamespace.fail(); Would result in: TestNamespace["pass\nThe"]() The solution was pretty simple, I only had to get the first line before splitting it by space. I ran the tests and everything passes. Let me know if there's other changes I need to make.
Open Graph Description: I had this issue, where I was trying to use customName annotation to rename methods and I noticed that it was also including a new line and the first word of the next line. For example: /** @noSelf...
X Description: I had this issue, where I was trying to use customName annotation to rename methods and I noticed that it was also including a new line and the first word of the next line. For example: /** @noSelf...
Opengraph URL: https://github.com/TypeScriptToLua/TypeScriptToLua/pull/1650
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:58395d29-5202-f29d-0353-24f890131740 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8836:3476BC:2994C3C:3A68807:697103F9 |
| html-safe-nonce | 26f6e8f7f6f1faed6e9b413b8658e085b0cba0a32680e528fea627b1ef1c7d27 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODM2OjM0NzZCQzoyOTk0QzNDOjNBNjg4MDc6Njk3MTAzRjkiLCJ2aXNpdG9yX2lkIjoiMTI1MDM5NzQ4MTM3NTY5NTg2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | d9e008c4a785ff85a8f321a3aff2349f1f43b70fe74e2621c2138d22580c78f2 |
| hovercard-subject-tag | pull_request:2668792229 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/TypeScriptToLua/TypeScriptToLua/pull/1650/files |
| twitter:image | https://avatars.githubusercontent.com/u/62068860?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/62068860?s=400&v=4 |
| og:image:alt | I had this issue, where I was trying to use customName annotation to rename methods and I noticed that it was also including a new line and the first word of the next line. For example: /** @noSelf... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2d17fd2bbd784dc91f3a78a2f1d2c41d9f4f8ce86136d09833e3cf21b2bde1b7 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/TypeScriptToLua/TypeScriptToLua git https://github.com/TypeScriptToLua/TypeScriptToLua.git |
| octolytics-dimension-user_id | 44121206 |
| octolytics-dimension-user_login | TypeScriptToLua |
| octolytics-dimension-repository_id | 115876595 |
| octolytics-dimension-repository_nwo | TypeScriptToLua/TypeScriptToLua |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 115876595 |
| octolytics-dimension-repository_network_root_nwo | TypeScriptToLua/TypeScriptToLua |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e053d923fb27a9d948f8cefae8ba3bf43f7b938f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width