Title: fix: only parse arguments from first line of tag comment by aabajyan · Pull Request #1650 · TypeScriptToLua/TypeScriptToLua · GitHub
Open Graph Title: fix: only parse arguments from first line of tag comment by aabajyan · Pull Request #1650 · TypeScriptToLua/TypeScriptToLua
X Title: fix: only parse arguments from first line of tag comment by aabajyan · Pull Request #1650 · TypeScriptToLua/TypeScriptToLua
Description: I had this issue, where I was trying to use customName annotation to rename methods and I noticed that it was also including a new line and the first word of the next line. For example: /** @noSelf */ declare namespace TestNamespace { /** * @customName pass * The first word should not be included. **/ function fail(): void; } TestNamespace.fail(); Would result in: TestNamespace["pass\nThe"]() The solution was pretty simple, I only had to get the first line before splitting it by space. I ran the tests and everything passes. Let me know if there's other changes I need to make.
Open Graph Description: I had this issue, where I was trying to use customName annotation to rename methods and I noticed that it was also including a new line and the first word of the next line. For example: /** @noSelf...
X Description: I had this issue, where I was trying to use customName annotation to rename methods and I noticed that it was also including a new line and the first word of the next line. For example: /** @noSelf...
Opengraph URL: https://github.com/TypeScriptToLua/TypeScriptToLua/pull/1650
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:d5f131e3-140a-e1bb-e9c0-0e851d5ee033 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | CF26:29B36B:3320687:47D20FF:69711D21 |
| html-safe-nonce | e2a1970cea9ed05b82952dafd3bd2aa94078170c0a356670a14206250a5f0f49 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjI2OjI5QjM2QjozMzIwNjg3OjQ3RDIwRkY6Njk3MTFEMjEiLCJ2aXNpdG9yX2lkIjoiNDgyMDc1NTA4OTYxMTM2NTY2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 90efef345bdf6c573c64140fabb6533e6d1f72932defb9061ad44d95be8373b2 |
| hovercard-subject-tag | pull_request:2668792229 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/TypeScriptToLua/TypeScriptToLua/pull/1650/checks |
| twitter:image | https://avatars.githubusercontent.com/u/62068860?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/62068860?s=400&v=4 |
| og:image:alt | I had this issue, where I was trying to use customName annotation to rename methods and I noticed that it was also including a new line and the first word of the next line. For example: /** @noSelf... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 73ca43ac10b0f114fadc2d2cf702bc0c6453174aa5f9dad3a1d131b428870c6d |
| turbo-cache-control | no-cache |
| go-import | github.com/TypeScriptToLua/TypeScriptToLua git https://github.com/TypeScriptToLua/TypeScriptToLua.git |
| octolytics-dimension-user_id | 44121206 |
| octolytics-dimension-user_login | TypeScriptToLua |
| octolytics-dimension-repository_id | 115876595 |
| octolytics-dimension-repository_nwo | TypeScriptToLua/TypeScriptToLua |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 115876595 |
| octolytics-dimension-repository_network_root_nwo | TypeScriptToLua/TypeScriptToLua |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c16e50bde10edd19f5772e9b3804df6d7bf9bfe |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width