Title: fix: add check to see in ownerSymbol parent is the global symbol by starsprung · Pull Request #1472 · TypeScriptToLua/TypeScriptToLua · GitHub
Open Graph Title: fix: add check to see in ownerSymbol parent is the global symbol by starsprung · Pull Request #1472 · TypeScriptToLua/TypeScriptToLua
X Title: fix: add check to see in ownerSymbol parent is the global symbol by starsprung · Pull Request #1472 · TypeScriptToLua/TypeScriptToLua
Description: Add check to see in ownerSymbol.parent is the global symbol when determining when to transform global builtin calls. I'm not sure if this is the appropriate fix, but this change allows calls to console.log to compile correctly when using the types from @types/node and not using the dom lib. They already work correctly with the type declarations in lib.dom.d.ts, due to a difference in structure: Node's typings wrap console inside global { }, which means it has a parent, whereas console from lib.dom.d.ts doesn't. E.g. Input console.log('test'); tstl output without fix --[[ Generated with https://github.com/TypeScriptToLua/TypeScriptToLua ]] console:log("hello world") tstl output with fix --[[ Generated with https://github.com/TypeScriptToLua/TypeScriptToLua ]] print("hello world")
Open Graph Description: Add check to see in ownerSymbol.parent is the global symbol when determining when to transform global builtin calls. I'm not sure if this is the appropriate fix, but this change allows calls to...
X Description: Add check to see in ownerSymbol.parent is the global symbol when determining when to transform global builtin calls. I'm not sure if this is the appropriate fix, but this change allows call...
Opengraph URL: https://github.com/TypeScriptToLua/TypeScriptToLua/pull/1472
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:fa63ac35-2356-b656-8a95-5859ea01287d |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | 8EFC:358171:12E6804:1A7AE0C:6972044D |
| html-safe-nonce | 6dbd46b2feffef56536cd3b1f0697563e63aabcda8106d8374e58346c31e0d29 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RUZDOjM1ODE3MToxMkU2ODA0OjFBN0FFMEM6Njk3MjA0NEQiLCJ2aXNpdG9yX2lkIjoiNjg3NDE3NDUwMjk4NDc1NTk3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a2201c432fdd1c30bf941ebc2f769eba839f3092d517c456a94d04698d0deda3 |
| hovercard-subject-tag | pull_request:1463752579 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/TypeScriptToLua/TypeScriptToLua/pull/1472/checks |
| twitter:image | https://avatars.githubusercontent.com/u/48957?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/48957?s=400&v=4 |
| og:image:alt | Add check to see in ownerSymbol.parent is the global symbol when determining when to transform global builtin calls. I'm not sure if this is the appropriate fix, but this change allows calls to... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5d01a3551afdd1a0e12e78acaf3ba43a9a1f7dcb518695d6ed59db76a9290f13 |
| turbo-cache-control | no-preview |
| go-import | github.com/TypeScriptToLua/TypeScriptToLua git https://github.com/TypeScriptToLua/TypeScriptToLua.git |
| octolytics-dimension-user_id | 44121206 |
| octolytics-dimension-user_login | TypeScriptToLua |
| octolytics-dimension-repository_id | 115876595 |
| octolytics-dimension-repository_nwo | TypeScriptToLua/TypeScriptToLua |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 115876595 |
| octolytics-dimension-repository_network_root_nwo | TypeScriptToLua/TypeScriptToLua |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 062b05dcdf64ee7a3dad7acabb746494ae0982cc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width