| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b1b28f49-421f-6b7b-32ab-04dfe33a1c28 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EB22:DD6B:378A0A0:4AE85D9:69707675 |
| html-safe-nonce | 1fae5564b367d7475d99802448e6c38637471c411d19f23e7f083291993b924e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjIyOkRENkI6Mzc4QTBBMDo0QUU4NUQ5OjY5NzA3Njc1IiwidmlzaXRvcl9pZCI6IjM2MzUzNzgzODExNjQ0MTA0ODUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d16a3a87b297c9aa960a979399496091e5e730f0c571de90043e22aed49a25e3 |
| hovercard-subject-tag | pull_request:650682115 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/SolidCode/SolidPython/pull/174/files |
| twitter:image | https://avatars.githubusercontent.com/u/1105041?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1105041?s=400&v=4 |
| og:image:alt | -> #173
To be able to fix it (call _subbed_keyword from within objects.py) I had to extract _[un]subbed_keyword into a separate module -> helpers.py.
This branch is based ontop #170 & #17... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9920a62ba22d06470388e2904804fb7e5ec51c9e35f81784e9191394c74b2bd2 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/SolidCode/SolidPython git https://github.com/SolidCode/SolidPython.git |
| octolytics-dimension-user_id | 622839 |
| octolytics-dimension-user_login | SolidCode |
| octolytics-dimension-repository_id | 1377446 |
| octolytics-dimension-repository_nwo | SolidCode/SolidPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1377446 |
| octolytics-dimension-repository_network_root_nwo | SolidCode/SolidPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7d6181066430cc06553c8396ca201e194ae33cb9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FSolidCode%2FSolidPython%2Fpull%2F174%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FSolidCode%2FSolidPython%2Fpull%2F174%2Ffiles |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=SolidCode%2FSolidPython |
| Reload | https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files |
| Reload | https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files |
| Reload | https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files |
|
SolidCode
| https://patch-diff.githubusercontent.com/SolidCode |
| SolidPython | https://patch-diff.githubusercontent.com/SolidCode/SolidPython |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2FSolidCode%2FSolidPython |
|
Fork
189
| https://patch-diff.githubusercontent.com/login?return_to=%2FSolidCode%2FSolidPython |
|
Star
1.2k
| https://patch-diff.githubusercontent.com/login?return_to=%2FSolidCode%2FSolidPython |
|
Code
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython |
|
Issues
27
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/issues |
|
Pull requests
6
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/actions |
|
Projects
0
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/projects |
|
Wiki
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/wiki |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/security |
| Please reload this page | https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files |
|
Insights
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pulse |
|
Code
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython |
|
Issues
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/actions |
|
Projects
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/projects |
|
Wiki
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/wiki |
|
Security
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/security |
|
Insights
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pulse |
| Sign up for GitHub
| https://patch-diff.githubusercontent.com/signup?return_to=%2FSolidCode%2FSolidPython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://patch-diff.githubusercontent.com/login?return_to=%2FSolidCode%2FSolidPython%2Fissues%2Fnew%2Fchoose |
| jeff-dh | https://patch-diff.githubusercontent.com/jeff-dh |
| SolidCode:master | https://patch-diff.githubusercontent.com/SolidCode/SolidPython/tree/master |
| jeff-dh:fix_173 | https://patch-diff.githubusercontent.com/jeff-dh/SolidPython/tree/fix_173 |
|
Conversation
0
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174 |
|
Commits
13
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/commits |
|
Checks
0
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/checks |
|
Files changed
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files |
| Please reload this page | https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files |
|
Fixes 173: import of illegal python identifiers from filenames
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files#top |
|
Show all changes
13 commits
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files |
|
cc28da6
added py_scadparser
jeff-dh May 16, 2021
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/commits/cc28da61d8e13b1730b2487fdf6700fc7368942d |
|
e64dff0
removed unused function extract_callable_signatures
jeff-dh May 16, 2021
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/commits/e64dff08b726ce7cab7c1c5414d66a5f1888321b |
|
49988f2
use py_scadparser
jeff-dh May 16, 2021
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/commits/49988f22b9e0a7dc2977fc1e8784bb6aa63e368f |
|
243bfd7
fixed wrong openscad function syntax in examples/scad_to_include.scad
jeff-dh May 16, 2021
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/commits/243bfd78230ca41552e4ee81ca3ad4263e1df41d |
|
c749460
added another test module to examples/scad_to_include.scad
jeff-dh May 16, 2021
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/commits/c749460076c06154924a90e06a7ed949c69717f0 |
|
fe6b85d
fix OpenSCAD identifiers starting with a digit
jeff-dh May 16, 2021
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/commits/fe6b85d23164319d6b83ba69e881bec28f392327 |
|
b883cfa
added support for (non)optional arguments
jeff-dh May 16, 2021
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/commits/b883cfa54398ad02cda3fd175cd6ad5a6e2ee766 |
|
9860be4
fixed test_parse_scad_callables
jeff-dh May 19, 2021
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/commits/9860be43e94000b79096ff8e7143711fba329dc5 |
|
1ece137
(hopefully) made run_all_tests.sh more portable
jeff-dh May 19, 2021
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/commits/1ece137e5802b4486405e6d3975067e53758fff9 |
|
010c815
fixed unclosed file handle in py_scadparser
jeff-dh May 19, 2021
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/commits/010c815fcc95364199dfdf33b7cb9182d49e3a82 |
|
9a68259
Merge branch 'openscad_identifiers_starting_with_digits' into fix_173
jeff-dh May 22, 2021
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/commits/9a682592ab5c598993c924900c634e188249493c |
|
b1ac306
moved [un]subbed_keyword into helpers.py
jeff-dh May 22, 2021
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/commits/b1ac30601725907f9ce608dd640787d8dcc730ea |
|
c30cef4
fixed import of illegal python identifiers (#173)
jeff-dh May 22, 2021
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/commits/c30cef468dcfe3adae9b64009f6c4ee86da2424b |
|
Clear filters
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files |
| Please reload this page | https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files |
| Please reload this page | https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files |
|
basic_scad_include.py
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files#diff-0c4b1e9913c76a5cd2022e97fe66a0db8450072a79c6d431a6b8fa405d094bde |
|
scad_to_include.scad
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files#diff-13690b3028a4a32e91c1e503ae8e273573de1c0c3dc3189051ae44d707405d17 |
|
helpers.py
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files#diff-5f99c72a00fa92f61bfa174eb766156be9e8f1549f38daf56d0d9fe3711e545b |
|
objects.py
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files#diff-89ca1f3cc8652b6dc766b5b9063ba691a733d58a1a9a1b39737961b410d5fbed |
|
LICENSE
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files#diff-9239589a18f3c1ce89807c26b1ebbad537f6f850a2e41b8f41bd50c4dd7b77ee |
|
README.md
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files#diff-4096935536d4b649a171178e32df51a45a65d6dca3acae28bcff37b0b70eee0f |
|
scad_parser.py
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files#diff-1b8b20dbbb5abfa2d3369f0a758f68df2207d39ca7bfe5523809a8fdecb444f5 |
|
scad_tokens.py
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files#diff-cc0b658e6c071cb625fd40271d7ae6656d0eb61e80bf04e6df428c5820c6c550 |
|
solidpython.py
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files#diff-04aa431f6fc70be220e9ebaa3752be7b39c14c552e2405b15e665417a39704ee |
|
run_all_tests.sh
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files#diff-34b8e03c52fa5e4e9c0c6e5627774a94523f8ab9da2d02b2427af8556f8516f5 |
|
test_solidpython.py
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files#diff-25c3c2b4f1a411b37591e01400887a16876bbb17fff7c36dd72b7f9125a7622b |
| solid/examples/basic_scad_include.py | https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files#diff-0c4b1e9913c76a5cd2022e97fe66a0db8450072a79c6d431a6b8fa405d094bde |
|
View file
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/blob/c30cef468dcfe3adae9b64009f6c4ee86da2424b/solid/examples/basic_scad_include.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files#diff-0c4b1e9913c76a5cd2022e97fe66a0db8450072a79c6d431a6b8fa405d094bde |
|
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files#diff-0c4b1e9913c76a5cd2022e97fe66a0db8450072a79c6d431a6b8fa405d094bde |
| solid/examples/scad_to_include.scad | https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files#diff-13690b3028a4a32e91c1e503ae8e273573de1c0c3dc3189051ae44d707405d17 |
|
View file
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/blob/c30cef468dcfe3adae9b64009f6c4ee86da2424b/solid/examples/scad_to_include.scad |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files#diff-13690b3028a4a32e91c1e503ae8e273573de1c0c3dc3189051ae44d707405d17 |
| solid/helpers.py | https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files#diff-5f99c72a00fa92f61bfa174eb766156be9e8f1549f38daf56d0d9fe3711e545b |
|
View file
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/blob/c30cef468dcfe3adae9b64009f6c4ee86da2424b/solid/helpers.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/{{ revealButtonHref }} |
| solid/objects.py | https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files#diff-89ca1f3cc8652b6dc766b5b9063ba691a733d58a1a9a1b39737961b410d5fbed |
|
View file
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/blob/c30cef468dcfe3adae9b64009f6c4ee86da2424b/solid/objects.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files#diff-89ca1f3cc8652b6dc766b5b9063ba691a733d58a1a9a1b39737961b410d5fbed |
|
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files#diff-89ca1f3cc8652b6dc766b5b9063ba691a733d58a1a9a1b39737961b410d5fbed |
|
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files#diff-89ca1f3cc8652b6dc766b5b9063ba691a733d58a1a9a1b39737961b410d5fbed |
|
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files#diff-89ca1f3cc8652b6dc766b5b9063ba691a733d58a1a9a1b39737961b410d5fbed |
|
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files#diff-89ca1f3cc8652b6dc766b5b9063ba691a733d58a1a9a1b39737961b410d5fbed |
|
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files#diff-89ca1f3cc8652b6dc766b5b9063ba691a733d58a1a9a1b39737961b410d5fbed |
| solid/py_scadparser/LICENSE | https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files#diff-9239589a18f3c1ce89807c26b1ebbad537f6f850a2e41b8f41bd50c4dd7b77ee |
|
View file
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/blob/c30cef468dcfe3adae9b64009f6c4ee86da2424b/solid/py_scadparser/LICENSE |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/{{ revealButtonHref }} |
| solid/py_scadparser/README.md | https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files#diff-4096935536d4b649a171178e32df51a45a65d6dca3acae28bcff37b0b70eee0f |
|
View file
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/blob/c30cef468dcfe3adae9b64009f6c4ee86da2424b/solid/py_scadparser/README.md |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/{{ revealButtonHref }} |
| Please reload this page | https://patch-diff.githubusercontent.com/SolidCode/SolidPython/pull/174/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |