Title: cmp_bbp required strike and dip tolerance is less than rounding · Issue #46 · SCECcode/bbp · GitHub
Open Graph Title: cmp_bbp required strike and dip tolerance is less than rounding · Issue #46 · SCECcode/bbp
X Title: cmp_bbp required strike and dip tolerance is less than rounding · Issue #46 · SCECcode/bbp
Description: One of our researchers ran the unit test and got the error ====================================================================== FAIL: test_genslip_fftw (test_genslip.TestGenslip) Test GP rupture generator for the correct FFTW behavior ...
Open Graph Description: One of our researchers ran the unit test and got the error ====================================================================== FAIL: test_genslip_fftw (test_genslip.TestGenslip) Test GP rupture ...
X Description: One of our researchers ran the unit test and got the error ====================================================================== FAIL: test_genslip_fftw (test_genslip.TestGenslip) Test GP rupture ...
Opengraph URL: https://github.com/SCECcode/bbp/issues/46
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"cmp_bbp required strike and dip tolerance is less than rounding","articleBody":"One of our researchers ran the unit test and got the error\r\n```\r\n======================================================================\r\nFAIL: test_genslip_fftw (test_genslip.TestGenslip)\r\nTest GP rupture generator for the correct FFTW behavior\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n File \"/project/6001152/bbp/bbp-22.4.0/bbp/tests/test_genslip.py\", line 132, in test_genslip_fftw\r\n self.assertFalse(not cmp_bbp.cmp_srf(a_ref_file, a_newfile,\r\nAssertionError: True is not false : Output file /home/tyson/projects/def-tyson/bbp/bbp_data/tmpdata/5201715/5201715_nr_eq.srf does not match reference file /home/tyson/projects/def-tyson/bbp/bbp-22.4.0/bbp/tests/ref_data/gp/m6.73-0.10x0.10_s2379646.srf\r\n```\r\n\r\nRunning the comparison manually gives (is there any way to get the output from the `cmp_bbp` routine from the unit test script?)\r\n```\r\nPlane 0, point 186: point parameters in field 4 disagree.\r\n```\r\nThe relevant lines from the files are\r\n```\r\n -118.434769 34.303387 5.16943e+00 116 44 1.00000e+08 8.352078e+00 1.00000e-01 3.35000e+05 2.70000e+00\r\n 79 77.4399 23 0.0000 0 0.0000 0\r\n```\r\n```\r\n -118.434769 34.303387 5.16943e+00 115 44 1.00000e+08 8.352078e+00 1.00000e-01 3.35000e+05 2.70000e+00\r\n 79 77.4399 23 0.0000 0 0.0000 0\r\n```\r\nso it seems the issue is that the strike angle disagree by 1 degree.\r\n\r\nExamining the [`cmp_bbp`](../blob/main/bbp/tests/cmp_bbp.py#L231) routine reveals they are expected to agree to [`PP_TOLERANCE = 0.011`](../blob/main/bbp/tests/cmp_bbp.py#L171), which is pretty meaningless given they are only output to the degree. Seems there should either at least two decimals output or an `ANGLE_TOLERANCE = 1` added and used to compare strike and dip.","author":{"url":"https://github.com/twhitehead","@type":"Person","name":"twhitehead"},"datePublished":"2023-02-01T13:26:56.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/46/bbp/issues/46"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:07ee7baa-02ba-cb67-d406-839f5dde2edc |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8CD4:35C45A:69A3446:8FC984D:698D083C |
| html-safe-nonce | ce5a6a8a9798b2936aa693362fac5a9422cef61476487124f8f53cdf8fbb2b18 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Q0Q0OjM1QzQ1QTo2OUEzNDQ2OjhGQzk4NEQ6Njk4RDA4M0MiLCJ2aXNpdG9yX2lkIjoiODM5MTA2MDgyNzUyODgyNDg5MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 1d10af0ad31bad8307689248c17e50a99cdd7d0eb910c04c43d670f381cb5d6b |
| hovercard-subject-tag | issue:1566116668 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/SCECcode/bbp/46/issue_layout |
| twitter:image | https://opengraph.githubassets.com/9a012e20141bcafcd0f8aaa762b72c049f53cafd91cabea1177d12691660246f/SCECcode/bbp/issues/46 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9a012e20141bcafcd0f8aaa762b72c049f53cafd91cabea1177d12691660246f/SCECcode/bbp/issues/46 |
| og:image:alt | One of our researchers ran the unit test and got the error ====================================================================== FAIL: test_genslip_fftw (test_genslip.TestGenslip) Test GP rupture ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | twhitehead |
| hostname | github.com |
| expected-hostname | github.com |
| None | f2da95634bce8a94cfa4123788169bfabdf845fd1d790fbaaaaab09dcfebdf28 |
| turbo-cache-control | no-preview |
| go-import | github.com/SCECcode/bbp git https://github.com/SCECcode/bbp.git |
| octolytics-dimension-user_id | 8519819 |
| octolytics-dimension-user_login | SCECcode |
| octolytics-dimension-repository_id | 61656861 |
| octolytics-dimension-repository_nwo | SCECcode/bbp |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 61656861 |
| octolytics-dimension-repository_network_root_nwo | SCECcode/bbp |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c21843b18feba17d11efb1895a7db61e8672f2cf |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width