René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"FAS module no longer works as a standalone module (without comparing to observations)","articleBody":"@fabiolsilva, I had been using the FAS module to compute FAS for simulations where I was not comparing with any observations. This commit to the FAS module now breaks it if observations aren't supplied:\r\n\r\n646b247492212ade3f6a59210fcfd90cd050c29f\r\n\r\nI get this stack trace at first:\r\n\r\n```\r\nTraceback (most recent call last):\r\n  File \"/project/scec_608/kmilner/bbp/dev/bbp/comps/run_bbp.py\", line 304, in \u003cmodule\u003e\r\n    obj = item.instantiate(sim_id)\r\n  File \"/project/scec_608/kmilner/bbp/dev/bbp/comps/module.py\", line 134, in instantiate\r\n    return globals()[self.module_name](*self.module_args, **self.kw_args)\r\nTypeError: __init__() missing 1 required positional argument: 'i_comparison_label'\r\n```\r\n\r\nI then tried changing the __init__ method to default i_comparison_label to None, but get a new one:\r\n\r\n```\r\nTraceback (most recent call last):\r\n  File \"/project/scec_608/kmilner/bbp/dev/bbp/comps/run_bbp.py\", line 305, in \u003cmodule\u003e\r\n    obj.run()\r\n  File \"/project/scec_608/kmilner/bbp/dev/bbp/comps/fas.py\", line 836, in run\r\n    obs_dt = read_bbp_dt(input_obs_acc_file)\r\n  File \"/project/scec_608/kmilner/bbp/dev/bbp/comps/fas.py\", line 339, in read_bbp_dt\r\n    input_file = open(bbp_file)\r\nFileNotFoundError: [Errno 2] No such file or directory: '/tmp/SLURM_3430421/tmpdata/11127002307386261/obs_seis_USC/USC.bbp'\r\n```\r\n\r\nI need this working soon, so I'll start throwing a bunch of if statements in there to isolate the observation code, but thought I would give you the chance to do it if you would prefer and can get to it in the next day or so. Thanks!\r\n\r\nKevin","author":{"url":"https://github.com/kevinmilner","@type":"Person","name":"kevinmilner"},"datePublished":"2022-01-25T00:26:24.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/40/bbp/issues/40"}