René's URL Explorer Experiment

Title: Handle non-string keys in class namespaces without panicking by Copilot · Pull Request #6503 · RustPython/RustPython · GitHub

Open Graph Title: Handle non-string keys in class namespaces without panicking by Copilot · Pull Request #6503 · RustPython/RustPython

X Title: Handle non-string keys in class namespaces without panicking by Copilot · Pull Request #6503 · RustPython/RustPython

Description: Setting non-string keys in a class namespace (e.g., via locals()[42] = "abc") caused RustPython to panic; mappingproxy also ignored such entries. Class namespace handling Split string attributes from non-string entries when building types; keep non-string entries in a side dict to avoid panics. Expose combined view via __dict__/mappingproxy so non-string keys are still reachable. Mappingproxy behavior Allow lookup, containment, and copy over the preserved non-string namespace entries. Error messaging dict.to_attributes now raises a clear TypeError for non-string attribute keys. Regression coverage Added snippet ensuring locals()[42] in a class ends up accessible via __dict__. Example: class B(object): locals()[42] = "abc" assert B.__dict__[42] == "abc" Original prompt This section details on the original issue you should resolve Setting locals() value leads to panicked. In the following example, we set the locals()[42] as a string "abc" in a class A. Then it causes rustpython panicked. test.py: class A(object): locals()[42] = 'abc' Behavior on rustpython(rustpython 0.1.2): thread 'main' panicked at 'dict has non-string keys: [PyObject PyInt { value: 42 }]', vm/src/builtins/dict.rs:537:48 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace Expected behavior(behavior on CPython 3.9.1): work well on the Python interpreter Step to reproduce: type "cargo run --release test.py" on the console of Ubuntu 18.04 and MacOS Big Sur 11.7.1 rust version: rustc 1.65.0 The proper test is: `` class A(object): locals()['42'] = 'abc' ## Comments on the Issue (you are @copilot in this section) @DimitrisJim I honestly was not aware you could update the class `__dict__` this way. Another shorter repro is `type("A", (), {1:1})` with any other non string key for the dict. We currently store the class namespace using a map with string keys. Weirdly enough no test cases for CPython test this as far as I could find. I doubt it could be considered an implementation detail, though. Fixes #4314 💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Open Graph Description: Setting non-string keys in a class namespace (e.g., via locals()[42] = "abc") caused RustPython to panic; mappingproxy also ignored such entries. Class namespace handling Split string ...

X Description: Setting non-string keys in a class namespace (e.g., via locals()[42] = "abc") caused RustPython to panic; mappingproxy also ignored such entries. Class namespace handling Split...

Opengraph URL: https://github.com/RustPython/RustPython/pull/6503

X: @github

direct link

Domain: patch-diff.githubusercontent.com

Links:

Viewport: width=device-width