Title: Invoke attribute command performance improvements by wrongsell · Pull Request #149 · RocketModFix/RocketModFix · GitHub
Open Graph Title: Invoke attribute command performance improvements by wrongsell · Pull Request #149 · RocketModFix/RocketModFix
X Title: Invoke attribute command performance improvements by wrongsell · Pull Request #149 · RocketModFix/RocketModFix
Description: Previously, the command signature was determined and the method was called at execution time, using reflection for the call (MethodInfo.Invoke). Now, when registering a command, we check the signature to avoid unnecessary methods and detect errors during the command registration process. We also create a delegate instead of invoking it via reflection, significantly speeding up command invocation. Previously, there was support for different command signatures registered via an attribute, but I've decided to remove this from the current implementation, as I don't consider such variability a good practice and recommend using a generally accepted standard.
Open Graph Description: Previously, the command signature was determined and the method was called at execution time, using reflection for the call (MethodInfo.Invoke). Now, when registering a command, we check the signat...
X Description: Previously, the command signature was determined and the method was called at execution time, using reflection for the call (MethodInfo.Invoke). Now, when registering a command, we check the signat...
Opengraph URL: https://github.com/RocketModFix/RocketModFix/pull/149
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:b6bac47e-7219-e398-7772-26cff87385a5 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | AA94:2C2AD:56B407:7045FE:698E751A |
| html-safe-nonce | 3bcdc3dec2dc1d9de760a1c16d764b4814cf4c01a4d4d33c8854b6f3f00fb39b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTk0OjJDMkFEOjU2QjQwNzo3MDQ1RkU6Njk4RTc1MUEiLCJ2aXNpdG9yX2lkIjoiNjQ4ODc5Njk4NDM3OTM0MDA1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | fdb6a3e8e6c240046cf2b9d612298fefad468b910f58cf794edf38d69517ef66 |
| hovercard-subject-tag | pull_request:2992450029 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RocketModFix/RocketModFix/pull/149/checks |
| twitter:image | https://avatars.githubusercontent.com/u/84908244?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/84908244?s=400&v=4 |
| og:image:alt | Previously, the command signature was determined and the method was called at execution time, using reflection for the call (MethodInfo.Invoke). Now, when registering a command, we check the signat... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | f86603f0b4e9df9a462725324a8c84c98fc50866bdb6ae8ff026fabe56a60c57 |
| turbo-cache-control | no-cache |
| go-import | github.com/RocketModFix/RocketModFix git https://github.com/RocketModFix/RocketModFix.git |
| octolytics-dimension-user_id | 148712015 |
| octolytics-dimension-user_login | RocketModFix |
| octolytics-dimension-repository_id | 708477287 |
| octolytics-dimension-repository_nwo | RocketModFix/RocketModFix |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | true |
| octolytics-dimension-repository_parent_id | 259763703 |
| octolytics-dimension-repository_parent_nwo | SmartlyDressedGames/Legally-Distinct-Missile |
| octolytics-dimension-repository_network_root_id | 259763703 |
| octolytics-dimension-repository_network_root_nwo | SmartlyDressedGames/Legally-Distinct-Missile |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7eb8835f5978c5aa7a64336b39e0774a93a9a196 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width