Title: Adds Undo/Redo to ReClass.NET by FransBouma · Pull Request #263 · ReClassNET/ReClass.NET · GitHub
Open Graph Title: Adds Undo/Redo to ReClass.NET by FransBouma · Pull Request #263 · ReClassNET/ReClass.NET
X Title: Adds Undo/Redo to ReClass.NET by FransBouma · Pull Request #263 · ReClassNET/ReClass.NET
Description: I've implemented this in a separate branch (with the changes from my previous PR #262 already merged). What's changed? Undo/Redo support for class creation/deletion/modification Undo/Redo support for changing nodes / node types / address etc. Added an undo/redo button pair to the toolbar using the existing icons already in the resources Defined some toolbar buttons for some node types to be able to overflow the toolbar if the window is narrow I didn't implement undo/redo for enums as the enum functionality is a bit broken I think (there's an add event but not a remove event for instance. I had it working more or less but didn't want to add it just yet) so I left it as-is. I added this using Algorithmia's command system. This is a library I wrote a long time ago and maintain since, and it's very stable. It comes with 2 nuget packages (algorithmia and bcl extensions). The system basically tracks commands executed through the command queue manager and records every command in the 'active' queue on top of the stack. So when a command A changes something that executes a command B, B will end up in A's command queue and B's command queue is then put on top of the stack. This way you can track multiple commands within the scope of a single command and undo/redo them in 1 go. A command is an object with a lambda that makes a change and it has optional lambda's to obtain the pre-change state and the post-change state. Algorithmia has several datastructures that mimic BCL classes (like list) and wrappers (to wrap members to make them undo/redo aware) and they take care of change checking and event raising as well. I have tested it with several class hierarchies and I think it works ok, but I know from experience that Undo/Redo code can get hairy at times especially in edge cases, e.g. multiple undo/redo sequences work ok but perhaps I missed an edge case and an event handler creates duplicate elements when redoing the whole tree of commands. Let me know if you need additional info, or if I have to make additional changes :) NOTE the commits in this PR are apparently also the ones in #262 :( Which sucks, and might be complicate file reviewing. If you want to wait reviewing this because of that, that's fine. I'm sorry this happened, I honestly don't know how to avoid that.
Open Graph Description: I've implemented this in a separate branch (with the changes from my previous PR #262 already merged). What's changed? Undo/Redo support for class creation/deletion/modification Undo/Redo ...
X Description: I've implemented this in a separate branch (with the changes from my previous PR #262 already merged). What's changed? Undo/Redo support for class creation/deletion/modification Un...
Opengraph URL: https://github.com/ReClassNET/ReClass.NET/pull/263
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:8f1a5c95-951b-38dd-77c1-9659fdc72603 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | B982:367630:1CA1E2:278A4A:696F32A6 |
| html-safe-nonce | 3038f39768ed0ab6aa85912b19a469c9399fe2a93cff83daa6e8668815d1fc6f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTgyOjM2NzYzMDoxQ0ExRTI6Mjc4QTRBOjY5NkYzMkE2IiwidmlzaXRvcl9pZCI6IjQ3NTU2NDA4NjQyNTgwNzczNTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 68411c00a4ff973356e1e40ed6fa1331d7b931adc89b77dcc22bffaef164fced |
| hovercard-subject-tag | pull_request:1419779041 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/ReClassNET/ReClass.NET/pull/263/checks |
| twitter:image | https://avatars.githubusercontent.com/u/3628530?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/3628530?s=400&v=4 |
| og:image:alt | I've implemented this in a separate branch (with the changes from my previous PR #262 already merged). What's changed? Undo/Redo support for class creation/deletion/modification Undo/Redo ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b278ad162d35332b6de714dfb005de04386c4d92df6475522bef910f491a35ee |
| turbo-cache-control | no-preview |
| go-import | github.com/ReClassNET/ReClass.NET git https://github.com/ReClassNET/ReClass.NET.git |
| octolytics-dimension-user_id | 36203059 |
| octolytics-dimension-user_login | ReClassNET |
| octolytics-dimension-repository_id | 70486261 |
| octolytics-dimension-repository_nwo | ReClassNET/ReClass.NET |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 70486261 |
| octolytics-dimension-repository_network_root_nwo | ReClassNET/ReClass.NET |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 39aed5006635ab6f45e6b77d23e73b08a00272a3 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width