Title: Add setting for optional zip compression (different approach) by DisabledMallis · Pull Request #244 · ReClassNET/ReClass.NET · GitHub
Open Graph Title: Add setting for optional zip compression (different approach) by DisabledMallis · Pull Request #244 · ReClassNET/ReClass.NET
X Title: Add setting for optional zip compression (different approach) by DisabledMallis · Pull Request #244 · ReClassNET/ReClass.NET
Description: I know someone already opened a PR for this feature, however I decided to try implementing it a little differently on my fork. Instead of modifying the ReClassNetFile class(es), I decided to create a new one called ReClassDataFile. Enabling/Disabling the "Compress as ZIP" under a new "Project Settings" tab will enable/disable the use of ReClassDataFile over ReClassNetFile. The benefit of using a new class to implement the feature is that it continues to follow the current code format/style, whereas just modifying the ReClassNetFile class directly could encourage code to become a little 'messy'. There are some more things I should probably fix/change to make this a better suited PR for merging, such as: Just putting "Compress as ZIP" under "General" instead of "Project Settings". I think it would be better to have a general project-specific settings tab, but that may not be the case. Opening a rcnet or xml file should adjust the setting accordingly.
Open Graph Description: I know someone already opened a PR for this feature, however I decided to try implementing it a little differently on my fork. Instead of modifying the ReClassNetFile class(es), I decided to create...
X Description: I know someone already opened a PR for this feature, however I decided to try implementing it a little differently on my fork. Instead of modifying the ReClassNetFile class(es), I decided to create...
Opengraph URL: https://github.com/ReClassNET/ReClass.NET/pull/244
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:878dfb52-95e9-f0be-3f56-5ba4e4eb56b1 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | AE4C:3FC603:40BAE:56347:696F0FD5 |
| html-safe-nonce | 6f3efe5aa847a6023c06fab89bd99005031c0af4104daddf0fa50a963d3e8bdd |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTRDOjNGQzYwMzo0MEJBRTo1NjM0Nzo2OTZGMEZENSIsInZpc2l0b3JfaWQiOiI0NzgxMTIyNTE4Njc4MTc5Nzk3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 44fe3d19a1d5b47eb852d8557a12d0db85e173c60179d23940f4f03803c176c8 |
| hovercard-subject-tag | pull_request:1114543406 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/ReClassNET/ReClass.NET/pull/244/checks |
| twitter:image | https://avatars.githubusercontent.com/u/30188317?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/30188317?s=400&v=4 |
| og:image:alt | I know someone already opened a PR for this feature, however I decided to try implementing it a little differently on my fork. Instead of modifying the ReClassNetFile class(es), I decided to create... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b278ad162d35332b6de714dfb005de04386c4d92df6475522bef910f491a35ee |
| turbo-cache-control | no-preview |
| go-import | github.com/ReClassNET/ReClass.NET git https://github.com/ReClassNET/ReClass.NET.git |
| octolytics-dimension-user_id | 36203059 |
| octolytics-dimension-user_login | ReClassNET |
| octolytics-dimension-repository_id | 70486261 |
| octolytics-dimension-repository_nwo | ReClassNET/ReClass.NET |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 70486261 |
| octolytics-dimension-repository_network_root_nwo | ReClassNET/ReClass.NET |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 39aed5006635ab6f45e6b77d23e73b08a00272a3 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width