Title: Fix compilation under clang-19 aarch64 by andrjohns · Pull Request #235 · RcppCore/RcppParallel · GitHub
Open Graph Title: Fix compilation under clang-19 aarch64 by andrjohns · Pull Request #235 · RcppCore/RcppParallel
X Title: Fix compilation under clang-19 aarch64 by andrjohns · Pull Request #235 · RcppCore/RcppParallel
Description: The development version is failing to compile under the rtools45 pre-release for Windows Arm because one of the methods in the tbb-compat stub is missing an attribute from one the declarations: Installing package into 'C:/Users/andrew/AppData/Local/R/aarch64-library/4.6' (as 'lib' is unspecified) * installing *source* package 'RcppParallel' ... ** this is package 'RcppParallel' version '5.1.10.9000' ** using staged installation ** preparing to configure package 'RcppParallel' ... *** configured file: 'R/tbb-autodetected.R.in' => 'R/tbb-autodetected.R' *** configured file: 'src/Makevars.in' => 'src/Makevars' ** finished configure for package 'RcppParallel' ** libs using C++ compiler: 'clang version 19.1.7' installing via 'install.libs.R' to C:/Users/andrew/AppData/Local/R/aarch64-library/4.6/00LOCK-RcppParallel/00new/RcppParallel ** creating tbb stub library using C++ compiler: 'clang version 19.1.7' clang++ -std=gnu++17 -I"C:/PROGRA~1/R-AARC~1/R-devel/include" -DNDEBUG -I../inst/include -I"C:/rtools45-aarch64/aarch64-w64-mingw32.static.posix/include" -I"/aarch64-w64-mingw32.static.posix/include" -DRCPP_PARALLEL_USE_TBB=1 -O2 -Wall -c tbb-compat/tbb-compat.cpp -o tbb-compat/tbb-compat.o tbb-compat/tbb-compat.cpp:137:54: error: redeclaration of 'tbb::internal::task_scheduler_observer_v3::observe' cannot add 'dllexport' attribute 137 | void __TBB_EXPORTED_FUNC task_scheduler_observer_v3::observe( bool enable ) { | ^ tbb-compat/tbb-compat.cpp:43:31: note: previous declaration is here 43 | void __TBB_EXPORTED_METHOD observe( bool state=true ); | ^ 1 error generated. make: *** [C:/PROGRA~1/R-AARC~1/R-devel/etc/Makeconf:296: tbb-compat/tbb-compat.o] Error 1 Error in .install.libs(tbbLib) : error building tbb stub library * removing 'C:/Users/andrew/AppData/Local/R/aarch64-library/4.6/RcppParallel' * restoring previous 'C:/Users/andrew/AppData/Local/R/aarch64-library/4.6/RcppParallel' Warning message: In install.packages(getwd(), type = "source", repos = NULL) : This errors since clang has different handling of attributes in this case, and attribute needs to be present in both declarations
Open Graph Description: The development version is failing to compile under the rtools45 pre-release for Windows Arm because one of the methods in the tbb-compat stub is missing an attribute from one the declarations: Ins...
X Description: The development version is failing to compile under the rtools45 pre-release for Windows Arm because one of the methods in the tbb-compat stub is missing an attribute from one the declarations: Ins...
Opengraph URL: https://github.com/RcppCore/RcppParallel/pull/235
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:318cfbcf-c591-169a-b330-a0ab787b570f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B9DC:2735DF:42D12EC:5CFF16F:697143E4 |
| html-safe-nonce | 0276d4642696f310abfa198689f5abba27ff134265a712629caa938cfa4cb0f8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOURDOjI3MzVERjo0MkQxMkVDOjVDRkYxNkY6Njk3MTQzRTQiLCJ2aXNpdG9yX2lkIjoiMTYxOTc2NTY2MDk2OTE1NzYwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 429d0afd3bfada9fb25068612d72e173e25c62e1fd51a26d82df7c096b52f2d5 |
| hovercard-subject-tag | pull_request:2402454109 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RcppCore/RcppParallel/pull/235/files |
| twitter:image | https://avatars.githubusercontent.com/u/27717896?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/27717896?s=400&v=4 |
| og:image:alt | The development version is failing to compile under the rtools45 pre-release for Windows Arm because one of the methods in the tbb-compat stub is missing an attribute from one the declarations: Ins... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9bd14a55b65b030988a89787ed340c0f040258c3240af6941d85f740f21629a0 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RcppCore/RcppParallel git https://github.com/RcppCore/RcppParallel.git |
| octolytics-dimension-user_id | 5811336 |
| octolytics-dimension-user_login | RcppCore |
| octolytics-dimension-repository_id | 21576989 |
| octolytics-dimension-repository_nwo | RcppCore/RcppParallel |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 21576989 |
| octolytics-dimension-repository_network_root_nwo | RcppCore/RcppParallel |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 24a7109a3a584a05e29240fcc1ba60220deccdb8 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width