René's URL Explorer Experiment


Title: dispose layers containers when removing them by dfguerrerom · Pull Request #14 · QuantStack/leaflet-splitmap · GitHub

Open Graph Title: dispose layers containers when removing them by dfguerrerom · Pull Request #14 · QuantStack/leaflet-splitmap

X Title: dispose layers containers when removing them by dfguerrerom · Pull Request #14 · QuantStack/leaflet-splitmap

Description: This PR aims to close jupyter-widgets/ipyleaflet#1233 by disposing the layer containers instead of removing its styles. Screencast.from.04-10-2024.14.18.49.webm

Open Graph Description: This PR aims to close jupyter-widgets/ipyleaflet#1233 by disposing the layer containers instead of removing its styles. Screencast.from.04-10-2024.14.18.49.webm

X Description: This PR aims to close jupyter-widgets/ipyleaflet#1233 by disposing the layer containers instead of removing its styles. Screencast.from.04-10-2024.14.18.49.webm

Opengraph URL: https://github.com/QuantStack/leaflet-splitmap/pull/14

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:49e2f15a-12d4-9d62-edb1-308e39b16552
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD6EC:DE06B:35E511:4A9A7D:69774C17
html-safe-nonce268454ba7b9cdc203baae22587dedc127f97d0ed66cc70990a2323573227db27
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENkVDOkRFMDZCOjM1RTUxMTo0QTlBN0Q6Njk3NzRDMTciLCJ2aXNpdG9yX2lkIjoiODk4MTk0NDU2NDA4NzA2MDcxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0dcd2833fa2486ab4cc1ff3cbb5aca4d764b9a6c02c0a14c1e7b44b1e2bd1b27
hovercard-subject-tagpull_request:2107471680
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/QuantStack/leaflet-splitmap/14/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8511ebd204c6035eb1d12f760c9706413157c2c4e19cf3844684101668294c73/QuantStack/leaflet-splitmap/pull/14
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8511ebd204c6035eb1d12f760c9706413157c2c4e19cf3844684101668294c73/QuantStack/leaflet-splitmap/pull/14
og:image:altThis PR aims to close jupyter-widgets/ipyleaflet#1233 by disposing the layer containers instead of removing its styles. Screencast.from.04-10-2024.14.18.49.webm
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedfguerrerom
hostnamegithub.com
expected-hostnamegithub.com
None01d198479908d09a841b2febe8eb105a81af2af7d81830960fe0971e1f4adc09
turbo-cache-controlno-preview
go-importgithub.com/QuantStack/leaflet-splitmap git https://github.com/QuantStack/leaflet-splitmap.git
octolytics-dimension-user_id19627246
octolytics-dimension-user_loginQuantStack
octolytics-dimension-repository_id125548272
octolytics-dimension-repository_nwoQuantStack/leaflet-splitmap
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id125548272
octolytics-dimension-repository_network_root_nwoQuantStack/leaflet-splitmap
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released37e99eca9fba24ee37da98481d573461cc1ab7d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/pull/14#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FQuantStack%2Fleaflet-splitmap%2Fpull%2F14
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FQuantStack%2Fleaflet-splitmap%2Fpull%2F14
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=QuantStack%2Fleaflet-splitmap
Reloadhttps://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/pull/14
Reloadhttps://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/pull/14
Reloadhttps://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/pull/14
QuantStack https://patch-diff.githubusercontent.com/QuantStack
leaflet-splitmaphttps://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2FQuantStack%2Fleaflet-splitmap
Fork 18 https://patch-diff.githubusercontent.com/login?return_to=%2FQuantStack%2Fleaflet-splitmap
Star 18 https://patch-diff.githubusercontent.com/login?return_to=%2FQuantStack%2Fleaflet-splitmap
Code https://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap
Issues 5 https://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/issues
Pull requests 3 https://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/pulls
Actions https://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/actions
Projects 0 https://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/projects
Security 0 https://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/security
Insights https://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/pulse
Code https://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap
Issues https://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/issues
Pull requests https://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/pulls
Actions https://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/actions
Projects https://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/projects
Security https://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/security
Insights https://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2FQuantStack%2Fleaflet-splitmap%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2FQuantStack%2Fleaflet-splitmap%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/pull/14#issue-comment-box
dfguerreromhttps://patch-diff.githubusercontent.com/dfguerrerom
QuantStack:masterhttps://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/tree/master
dfguerrerom:dispose_layershttps://patch-diff.githubusercontent.com/dfguerrerom/leaflet-splitmap/tree/dispose_layers
dispose layers containers when removing them https://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/pull/14#top
dfguerreromhttps://patch-diff.githubusercontent.com/dfguerrerom
QuantStack:masterhttps://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/tree/master
dfguerrerom:dispose_layershttps://patch-diff.githubusercontent.com/dfguerrerom/leaflet-splitmap/tree/dispose_layers
Conversation 0 https://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/pull/14
Commits 2 https://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/pull/14/commits
Checks 0 https://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/pull/14/checks
Files changed https://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/pull/14/files
Please reload this pagehttps://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/pull/14
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/dfguerrerom
dfguerreromhttps://patch-diff.githubusercontent.com/dfguerrerom
Oct 4, 2024https://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/pull/14#issue-2566243129
jupyter-widgets/ipyleaflet#1233https://github.com/jupyter-widgets/ipyleaflet/issues/1233
Please reload this pagehttps://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/pull/14
dfguerreromhttps://patch-diff.githubusercontent.com/dfguerrerom
October 4, 2024 14:17https://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/pull/14#commits-pushed-0f8a7db
https://patch-diff.githubusercontent.com/dfguerrerom
dispose layers containers when removing themhttps://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/pull/14/commits/0f8a7db8ee2c4eece099b12eda657de415ecfa6e
0f8a7dbhttps://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/pull/14/commits/0f8a7db8ee2c4eece099b12eda657de415ecfa6e
https://patch-diff.githubusercontent.com/dfguerrerom
remove debug linehttps://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/pull/14/commits/388a31bfe34aed8884f1234e8af4f2c545af27e5
388a31bhttps://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/pull/14/commits/388a31bfe34aed8884f1234e8af4f2c545af27e5
https://patch-diff.githubusercontent.com/dfguerrerom
dfguerreromhttps://patch-diff.githubusercontent.com/dfguerrerom
Jan 10, 2025 https://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/pull/14#ref-pullrequest-2661339334
fix: layer.getContainer could return null #15 https://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/pull/15
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FQuantStack%2Fleaflet-splitmap%2Fpull%2F14
Removing SplitMapControl doesn't update the map layers https://github.com/jupyter-widgets/ipyleaflet/issues/1233
Please reload this pagehttps://patch-diff.githubusercontent.com/QuantStack/leaflet-splitmap/pull/14
https://patch-diff.githubusercontent.com/dfguerrerom
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.