| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:fb98f046-8b2b-b128-ce4e-62817a5c35c1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8C9C:3EAA26:445102:5D2692:698E308E |
| html-safe-nonce | 711136492e6aa2eeb0986ff69e02ddc8bf1d8ce3b1d36bec089f173e21f67156 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzlDOjNFQUEyNjo0NDUxMDI6NUQyNjkyOjY5OEUzMDhFIiwidmlzaXRvcl9pZCI6IjYyMDQxMTI3NDY3MzQwMTk5OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2fe5a165b7faf14b1e4028aeb2c0a7f1eba7103526945d4592ffabefc70e8baa |
| hovercard-subject-tag | pull_request:452305000 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/ProgrammableGroup/chat-iOS/29/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/8b3318a7b43d305dbacee8389e9b941b685db5675b27f30975bd3a05f490c17e/ProgrammableGroup/chat-iOS/pull/29 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8b3318a7b43d305dbacee8389e9b941b685db5675b27f30975bd3a05f490c17e/ProgrammableGroup/chat-iOS/pull/29 |
| og:image:alt | 概要
チャット選択画面を追加した
レビュー観点
コードの書き方
collectionviewとtableviewが同様のデータを持っているが表示データ自体を変数で分けて良いのか
レビューレベル
Lv0: まったく見ないでAcceptする
Lv1: ぱっとみて違和感がないかチェックしてAcceptする
Lv2: 仕様レベルまで理解して、仕様通りに動くかある程度検証してAcceptする
... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ojun9 |
| hostname | github.com |
| expected-hostname | github.com |
| None | a5632af64f7fed7bff1d6a428d1aca1b94fa7a48f760de2d39d9b1effdbf0082 |
| turbo-cache-control | no-cache |
| go-import | github.com/ProgrammableGroup/chat-iOS git https://github.com/ProgrammableGroup/chat-iOS.git |
| octolytics-dimension-user_id | 67103205 |
| octolytics-dimension-user_login | ProgrammableGroup |
| octolytics-dimension-repository_id | 273842495 |
| octolytics-dimension-repository_nwo | ProgrammableGroup/chat-iOS |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 273842495 |
| octolytics-dimension-repository_network_root_nwo | ProgrammableGroup/chat-iOS |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | df1885ca022c7c5634d3a31e5a91e6a35990d0b7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FProgrammableGroup%2Fchat-iOS%2Fpull%2F29 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FProgrammableGroup%2Fchat-iOS%2Fpull%2F29 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=ProgrammableGroup%2Fchat-iOS |
| Reload | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29 |
| Reload | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29 |
| Reload | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29 |
|
ProgrammableGroup
| https://patch-diff.githubusercontent.com/ProgrammableGroup |
| chat-iOS | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2FProgrammableGroup%2Fchat-iOS |
|
Fork
1
| https://patch-diff.githubusercontent.com/login?return_to=%2FProgrammableGroup%2Fchat-iOS |
|
Star
1
| https://patch-diff.githubusercontent.com/login?return_to=%2FProgrammableGroup%2Fchat-iOS |
|
Code
| https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS |
|
Issues
7
| https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/issues |
|
Pull requests
5
| https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/actions |
|
Projects
0
| https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/projects |
|
Security
0
| https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/security |
|
Insights
| https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pulse |
|
Code
| https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS |
|
Issues
| https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/actions |
|
Projects
| https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/projects |
|
Security
| https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/security |
|
Insights
| https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pulse |
| ojun9 | https://patch-diff.githubusercontent.com/ojun9 |
| master | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/tree/master |
| feature/createChatRoomVC | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/tree/feature/createChatRoomVC |
| Conversation | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29 |
| Commits34 (34) | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits |
| Checks | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/checks |
| Files changed | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/files |
| Feature/create chat room vc | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29#top |
| ojun9 | https://patch-diff.githubusercontent.com/ojun9 |
| master | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/tree/master |
| feature/createChatRoomVC | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/tree/feature/createChatRoomVC |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| ojun9 | https://patch-diff.githubusercontent.com/ojun9 |
| Jul 19, 2020 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29#issue-660557236 |
| https://user-images.githubusercontent.com/42542860/87866345-8f643d80-c9bb-11ea-9396-c0d4a946c36b.gif |
| Please reload this page | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29 |
| ojun9 | https://patch-diff.githubusercontent.com/ojun9 |
| July 18, 2020 11:38 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29#commits-pushed-d200ce7 |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| CreateChatRoomの各種ファイルを追加 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/d200ce7305a2a304d260b95f37581f4dbfda5598 |
| d200ce7 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/d200ce7305a2a304d260b95f37581f4dbfda5598 |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| Storyboardに部品の配置をした | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/f1519003cbdf812675871bc74ab7863edbb6f1a8 |
| f151900 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/f1519003cbdf812675871bc74ab7863edbb6f1a8 |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| カスタムセルを作って部品を接続した | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/f17d77a09773c0a8b23a055cf7b13c0024e8e211 |
| f17d77a | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/f17d77a09773c0a8b23a055cf7b13c0024e8e211 |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| 各cellのsetupを書いた | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/eaca76e994f199a07c69b1ef19e7cc5490cc23ca |
| eaca76e | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/eaca76e994f199a07c69b1ef19e7cc5490cc23ca |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| CreateChatRoomViewControllerのセットアップを行った | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/ae1492c749a10585c01edc2926ade85d93245f84 |
| ae1492c | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/ae1492c749a10585c01edc2926ade85d93245f84 |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| Searchのスペルが間違ってたのを修正 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/fc1e95367caf4f27497118bef43431299a123062 |
| fc1e953 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/fc1e95367caf4f27497118bef43431299a123062 |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| ファイル名の最初が大文字になってたかったのを修正 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/9cdb665fddc88fdbaaa71291bb13426b388589a5 |
| 9cdb665 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/9cdb665fddc88fdbaaa71291bb13426b388589a5 |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| デバックようにcellを表示した | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/30e3bbf054b0b5347f1a388c7c2384782d26fb90 |
| 30e3bbf | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/30e3bbf054b0b5347f1a388c7c2384782d26fb90 |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| デバック用にimageを表示した | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/a9015c4f9b16245c1d7373f294a31a809c2e1e15 |
| a9015c4 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/a9015c4f9b16245c1d7373f294a31a809c2e1e15 |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| serchUserTableviewを選択したときにデータをtableviewとcollectionviewに反映させる処理を書いた | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/6cd9b4aadde60082b6dbd1e57b67134bb4587b30 |
| 6cd9b4a | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/6cd9b4aadde60082b6dbd1e57b67134bb4587b30 |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| radioImageViewに結果を反映させるようにした | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/53e978396564f20e6a1d1a92c8efe335a834839e |
| 53e9783 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/53e978396564f20e6a1d1a92c8efe335a834839e |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| selectedUserCollectionViewのcellの表示を調整 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/64d01bd44e28548925a027f0240203bd70244c75 |
| 64d01bd | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/64d01bd44e28548925a027f0240203bd70244c75 |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| selectedUserCollectionViewでバツボタン押せれた時に削除できるようにした | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/8cf5f94a89bbef428a0856eb02b81e50c6a69ff8 |
| 8cf5f94 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/8cf5f94a89bbef428a0856eb02b81e50c6a69ff8 |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| キーボードが登場したときにcollectionviewを上に上げる処理を書いた | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/74c38ab7f88e9546c6dfac814f5cc2a3079405f3 |
| 74c38ab | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/74c38ab7f88e9546c6dfac814f5cc2a3079405f3 |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| キーボードを閉じる処理をcollectionviewの時はしないようにした | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/71833962f44702234c850834782b4516391381af |
| 7183396 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/71833962f44702234c850834782b4516391381af |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| NavigationItemと各アイテムがタップされたときの処理を書いた | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/68eec80ad4116c6f8e856a516f4da8487423c780 |
| 68eec80 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/68eec80ad4116c6f8e856a516f4da8487423c780 |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| searchBarSearchButtonClickedのときの処理を書いた | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/8fc7cf1b5c0c3439d9f63f9b60ddaefda8b19d20 |
| 8fc7cf1 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/8fc7cf1b5c0c3439d9f63f9b60ddaefda8b19d20 |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| バツボタン押してユーザ削除したときにtableviewに反映されない問題を修正 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/1a5c7741983d3c91a5d989b2cdf14699da45b04f |
| 1a5c774 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/1a5c7741983d3c91a5d989b2cdf14699da45b04f |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| firestoreからwhereFieldでユーザを検索する機能を追加した | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/97e244071c8d4193747ec4c57eb1a9a1c7d4d356 |
| 97e2440 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/97e244071c8d4193747ec4c57eb1a9a1c7d4d356 |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| activityIndicatorを追加して検索中にくるくるする処理を書いた | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/b3b787908e701fc1913a85683682f886cca9312d |
| b3b7879 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/b3b787908e701fc1913a85683682f886cca9312d |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| CollectionViewを表示/非表示するときにアニメーションを追加 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/a6f3baa33f9ab113a858c8c83bef5c976a6724a8 |
| a6f3baa | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/a6f3baa33f9ab113a858c8c83bef5c976a6724a8 |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| presenterとviewにweakをつけた | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/433dc02d11a21e8848e34ab10a7c19d4b88f3672 |
| 433dc02 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/433dc02d11a21e8848e34ab10a7c19d4b88f3672 |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| コメントの追加と,Rootを開発用に変更してたのを元に戻した | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/daf5d664bfee6c7eec8f39c0b9eb9d2da0e05c6b |
| daf5d66 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/daf5d664bfee6c7eec8f39c0b9eb9d2da0e05c6b |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| TODOのコメントを追加 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/9113277b861200eb1d3a76f605e823e5a1cc04ad |
| 9113277 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/9113277b861200eb1d3a76f605e823e5a1cc04ad |
| https://patch-diff.githubusercontent.com/ojun9 |
| ojun9 | https://patch-diff.githubusercontent.com/ojun9 |
| geekshu625 | https://patch-diff.githubusercontent.com/geekshu625 |
| ren-suke | https://patch-diff.githubusercontent.com/ren-suke |
| shinya-todaka | https://patch-diff.githubusercontent.com/shinya-todaka |
| July 19, 2020 03:34 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29#event-3561980196 |
| https://patch-diff.githubusercontent.com/shinya-todaka |
| shinya-todaka | https://patch-diff.githubusercontent.com/shinya-todaka |
|
Jul 20, 2020
| https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29#pullrequestreview-451415377 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/files/9113277b861200eb1d3a76f605e823e5a1cc04ad |
| shinya-todaka | https://patch-diff.githubusercontent.com/shinya-todaka |
| https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29#pullrequestreview-451415377 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/marty-suzuki/iOSDesignPatternSamples/tree/mvp/iOSDesignPatternSamples/Sources/UI/Favorite | https://github.com/marty-suzuki/iOSDesignPatternSamples/tree/mvp/iOSDesignPatternSamples/Sources/UI/Favorite |
| https://qiita.com/taketomato/items/d5630fe5df45f4093720#3-classes | https://qiita.com/taketomato/items/d5630fe5df45f4093720#3-classes |
| Please reload this page | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29 |
| chat-iOS/Views/CreateChatRoom/CreateChatRoomViewController.swift | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/files/9113277b861200eb1d3a76f605e823e5a1cc04ad#diff-7111f6e84a616daf405a881e4185d45ea20174d90ce58c855bb21ab0154492e6 |
| Please reload this page | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29 |
| chat-iOS/Views/CreateChatRoom/CreateChatRoomViewController.swift | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/files/9113277b861200eb1d3a76f605e823e5a1cc04ad#diff-7111f6e84a616daf405a881e4185d45ea20174d90ce58c855bb21ab0154492e6 |
| Please reload this page | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29 |
| chat-iOS/Views/CreateChatRoom/CreateChatRoomViewController.swift | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/files/9113277b861200eb1d3a76f605e823e5a1cc04ad#diff-7111f6e84a616daf405a881e4185d45ea20174d90ce58c855bb21ab0154492e6 |
| Please reload this page | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29 |
| chat-iOS/Views/CreateChatRoom/CreateChatRoomViewController.swift | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/files/9113277b861200eb1d3a76f605e823e5a1cc04ad#diff-7111f6e84a616daf405a881e4185d45ea20174d90ce58c855bb21ab0154492e6 |
| Please reload this page | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29 |
| chat-iOS/Views/CreateChatRoom/CreateChatRoomViewController.swift | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/files/9113277b861200eb1d3a76f605e823e5a1cc04ad#diff-7111f6e84a616daf405a881e4185d45ea20174d90ce58c855bb21ab0154492e6 |
| Please reload this page | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29 |
| chat-iOS/Views/CreateChatRoom/CreateChatRoomViewController.swift | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/files/9113277b861200eb1d3a76f605e823e5a1cc04ad#diff-7111f6e84a616daf405a881e4185d45ea20174d90ce58c855bb21ab0154492e6 |
| shinya-todaka | https://patch-diff.githubusercontent.com/shinya-todaka |
| Jul 20, 2020 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29#discussion_r457205352 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://fluffy.es/handling-button-tap-inside-uitableviewcell-without-using-tag/ | https://fluffy.es/handling-button-tap-inside-uitableviewcell-without-using-tag/ |
| Please reload this page | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29 |
| ojun9 | https://patch-diff.githubusercontent.com/ojun9 |
| Jul 22, 2020 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29#discussion_r458527294 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29 |
| shinya-todaka | https://patch-diff.githubusercontent.com/shinya-todaka |
| Jul 22, 2020 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29#discussion_r458539160 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29 |
| ojun9 | https://patch-diff.githubusercontent.com/ojun9 |
| Jul 23, 2020 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29#discussion_r459193609 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29 |
| chat-iOS/Views/CreateChatRoom/CreateChatRoomViewBuilder.swift | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/files/9113277b861200eb1d3a76f605e823e5a1cc04ad#diff-7617ebf022bcd7938ff9e4b0b9e5299fac7cbec3217165a99879e104d3772cae |
| Please reload this page | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29 |
| ojun9 | https://patch-diff.githubusercontent.com/ojun9 |
| July 22, 2020 12:46 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29#commits-pushed-64f6246 |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| didTapCreateRoomButtonのタイポを修正 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/64f62463b9852a8f3d11f77f36b0391c3ee04b8e |
| 64f6246 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/64f62463b9852a8f3d11f77f36b0391c3ee04b8e |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| cellのviewの更新をcell内のconfigureでした | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/b356c217ed01584fb16e1377c8c17b409c0ed8f0 |
| b356c21 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/b356c217ed01584fb16e1377c8c17b409c0ed8f0 |
| ojun9 | https://patch-diff.githubusercontent.com/ojun9 |
| July 22, 2020 12:58 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29#commits-pushed-6a23ac3 |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| 変数の1文字目が大文字になってるのを修正 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/6a23ac396856c0ec8e79b3bc108de36f65c2d025 |
| 6a23ac3 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/6a23ac396856c0ec8e79b3bc108de36f65c2d025 |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| viewControllerからsearchedUsersArray とselectedUsersArray を取り除いた | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/ed5a521e2529ffc8c5373989f56bd856ba0be2c4 |
| ed5a521 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/ed5a521e2529ffc8c5373989f56bd856ba0be2c4 |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| DispatchQueue.main.asyncが必要ないところを削除した | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/a52e4995da06f79e393837917b1807da44e14c17 |
| a52e499 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/a52e4995da06f79e393837917b1807da44e14c17 |
| https://patch-diff.githubusercontent.com/ojun9 |
| ojun9 | https://patch-diff.githubusercontent.com/ojun9 |
| Jul 22, 2020 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29#issuecomment-662233779 |
| Please reload this page | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29 |
| ojun9 | https://patch-diff.githubusercontent.com/ojun9 |
| July 22, 2020 19:54 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29#commits-pushed-d9a5050 |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| Roomを保存する処理を書いた | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/d9a505046e6d449848b7076665d0ac07c1bdc1a6 |
| d9a5050 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/d9a505046e6d449848b7076665d0ac07c1bdc1a6 |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| クロージャでcellを削除する処理を書いた | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/8f53c5731e937c31c1a61856fa22c0ce15b705c9 |
| 8f53c57 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/8f53c5731e937c31c1a61856fa22c0ce15b705c9 |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| コードを一部整形 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/8972caa289a6c5a32cf1b4a17faec7ac97eeed7d |
| 8972caa | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/8972caa289a6c5a32cf1b4a17faec7ac97eeed7d |
| https://patch-diff.githubusercontent.com/ojun9 |
| ojun9 | https://patch-diff.githubusercontent.com/ojun9 |
| Jul 23, 2020 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29#issuecomment-662800067 |
| Please reload this page | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29 |
| https://patch-diff.githubusercontent.com/shinya-todaka |
| shinya-todaka | https://patch-diff.githubusercontent.com/shinya-todaka |
| Jul 23, 2020 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29#issuecomment-662872752 |
| Please reload this page | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29 |
| Please reload this page | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29 |
| ojun9 | https://patch-diff.githubusercontent.com/ojun9 |
| July 24, 2020 13:39 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29#commits-pushed-6023a3d |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| cellの処理と配列の取得を変更 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/6023a3d7f330cc1621df9b65ea85383739894a9d |
| 6023a3d | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/6023a3d7f330cc1621df9b65ea85383739894a9d |
|
| https://patch-diff.githubusercontent.com/ojun9 |
| radioImageViewが見にくかったのを修正 | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/9c71c2ba3c90531d161297ca76dcfa8bcf56e37c |
| 9c71c2b | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/commits/9c71c2ba3c90531d161297ca76dcfa8bcf56e37c |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/{{ revealButtonHref }} |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in to comment | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FProgrammableGroup%2Fchat-iOS%2Fpull%2F29 |
|
| https://patch-diff.githubusercontent.com/shinya-todaka |
|
shinya-todaka
| https://patch-diff.githubusercontent.com/shinya-todaka |
|
| https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29/files/a52e4995da06f79e393837917b1807da44e14c17 |
|
| https://patch-diff.githubusercontent.com/geekshu625 |
|
geekshu625
| https://patch-diff.githubusercontent.com/geekshu625 |
|
| https://patch-diff.githubusercontent.com/ren-suke |
|
ren-suke
| https://patch-diff.githubusercontent.com/ren-suke |
| Please reload this page | https://patch-diff.githubusercontent.com/ProgrammableGroup/chat-iOS/pull/29 |
|
| https://patch-diff.githubusercontent.com/ojun9 |
|
| https://patch-diff.githubusercontent.com/shinya-todaka |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |