| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c0d5053e-b868-cd9f-a80e-c5792442cce6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A866:239A7F:531BE12:70BBCF8:6973228B |
| html-safe-nonce | 24d948c07af968a2f12bff60b01bfbfdc17a7e037fd485111740eaa3474422da |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODY2OjIzOUE3Rjo1MzFCRTEyOjcwQkJDRjg6Njk3MzIyOEIiLCJ2aXNpdG9yX2lkIjoiNTQ2OTc0MTUzNTg0ODUwNTk5NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6323660c71e2994904d7087fac3af0bf3b00412f25ee67c15ad4d9541ed183a8 |
| hovercard-subject-tag | pull_request:1788573183 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/PowerShell/PowerShellEditorServices/2152/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7569302b77d7c95b4b8145063cbc7d3e29c77b6360012e762c9f6541630d2c87/PowerShell/PowerShellEditorServices/pull/2152 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7569302b77d7c95b4b8145063cbc7d3e29c77b6360012e762c9f6541630d2c87/PowerShell/PowerShellEditorServices/pull/2152 |
| og:image:alt | Issue: Smart Variable Rename
PR Summary
This pull request implements the LSP textDocument/rename and textDocument/prepareRename handlers for PowerShell.
#2152 exposes the related service settings i... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Razmo99 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 44ab3188c1dcfe3be0f9c3feca2e04e14fb79f120939ce2395e4f15ab96ec1d4 |
| turbo-cache-control | no-preview |
| go-import | github.com/PowerShell/PowerShellEditorServices git https://github.com/PowerShell/PowerShellEditorServices.git |
| octolytics-dimension-user_id | 11524380 |
| octolytics-dimension-user_login | PowerShell |
| octolytics-dimension-repository_id | 36031537 |
| octolytics-dimension-repository_nwo | PowerShell/PowerShellEditorServices |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 36031537 |
| octolytics-dimension-repository_network_root_nwo | PowerShell/PowerShellEditorServices |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | a5e2b48bd1260476599758f5d253b5d24092ab84 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShellEditorServices%2Fpull%2F2152 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShellEditorServices%2Fpull%2F2152 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=PowerShell%2FPowerShellEditorServices |
| Reload | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152 |
| Reload | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152 |
| Reload | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152 |
|
PowerShell
| https://patch-diff.githubusercontent.com/PowerShell |
| PowerShellEditorServices | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2FPowerShell%2FPowerShellEditorServices |
|
Fork
243
| https://patch-diff.githubusercontent.com/login?return_to=%2FPowerShell%2FPowerShellEditorServices |
|
Star
731
| https://patch-diff.githubusercontent.com/login?return_to=%2FPowerShell%2FPowerShellEditorServices |
|
Code
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices |
|
Issues
183
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/issues |
|
Pull requests
10
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/actions |
|
Security
0
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/security |
|
Insights
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pulse |
|
Code
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices |
|
Issues
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/actions |
|
Security
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/security |
|
Insights
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pulse |
| Sign up for GitHub
| https://patch-diff.githubusercontent.com/signup?return_to=%2FPowerShell%2FPowerShellEditorServices%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://patch-diff.githubusercontent.com/login?return_to=%2FPowerShell%2FPowerShellEditorServices%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#issue-comment-box |
| Razmo99 | https://patch-diff.githubusercontent.com/Razmo99 |
| PowerShell:main | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/tree/main |
| Razmo99:rename-function-customvisitor | https://patch-diff.githubusercontent.com/Razmo99/PowerShellEditorServices/tree/rename-function-customvisitor |
|
RenameProvider for variable/function renaming
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#top |
| Razmo99 | https://patch-diff.githubusercontent.com/Razmo99 |
| PowerShell:main | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/tree/main |
| Razmo99:rename-function-customvisitor | https://patch-diff.githubusercontent.com/Razmo99/PowerShellEditorServices/tree/rename-function-customvisitor |
|
Conversation
48
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152 |
|
Commits
215
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits |
|
Checks
1
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/checks |
|
Files changed
98
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/files |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/Razmo99 |
| Razmo99 | https://patch-diff.githubusercontent.com/Razmo99 |
| Mar 25, 2024 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#issue-2204805663 |
| Please reload this page | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152 |
| Smart Variable Rename | https://github.com/PowerShell/vscode-powershell/issues/261 |
| textDocument/rename | https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_rename |
| textDocument/prepareRename | https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_prepareRename |
| #2152 | https://github.com/PowerShell/PowerShellEditorServices/pull/2152 |
| pass thru the info to LSP | https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#workspace_configuration |
| Please reload this page | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152 |
| https://patch-diff.githubusercontent.com/Razmo99 |
| Razmo99 | https://patch-diff.githubusercontent.com/Razmo99 |
|
Mar 25, 2024
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#ref-pullrequest-2204784072 |
|
Implement Client Rename Provider Settings
PowerShell/vscode-powershell#4950
| https://patch-diff.githubusercontent.com/PowerShell/vscode-powershell/pull/4950 |
| https://patch-diff.githubusercontent.com/Razmo99 |
| Razmo99 | https://patch-diff.githubusercontent.com/Razmo99 |
| Mar 25, 2024 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#event-12229141095 |
| https://patch-diff.githubusercontent.com/Razmo99 |
| Razmo99 | https://patch-diff.githubusercontent.com/Razmo99 |
| March 25, 2024 04:06 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#event-12229141625 |
| https://patch-diff.githubusercontent.com/Razmo99 |
| Razmo99 | https://patch-diff.githubusercontent.com/Razmo99 |
| March 25, 2024 04:06 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#event-12229141651 |
| https://patch-diff.githubusercontent.com/andyleejordan |
| andyleejordan | https://patch-diff.githubusercontent.com/andyleejordan |
| force-pushed | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/compare/e3907558cba14aaccddc38cfec12ca811931f463..db3d83329045875120f17986a385caa439c33615 |
| e390755 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/commit/e3907558cba14aaccddc38cfec12ca811931f463 |
| db3d833 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/commit/db3d83329045875120f17986a385caa439c33615 |
|
Compare
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/compare/e3907558cba14aaccddc38cfec12ca811931f463..db3d83329045875120f17986a385caa439c33615 |
| March 27, 2024 19:05 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#event-12271746634 |
| https://patch-diff.githubusercontent.com/andyleejordan |
| andyleejordan | https://patch-diff.githubusercontent.com/andyleejordan |
| force-pushed | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/compare/caa9e27790f45a7f10649614508887793373c792..677f42ca38996f5f212a5f0e79b61995afc1e388 |
| caa9e27 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/commit/caa9e27790f45a7f10649614508887793373c792 |
| 677f42c | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/commit/677f42ca38996f5f212a5f0e79b61995afc1e388 |
|
Compare
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/compare/caa9e27790f45a7f10649614508887793373c792..677f42ca38996f5f212a5f0e79b61995afc1e388 |
| May 3, 2024 23:07 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#event-12702006838 |
| https://patch-diff.githubusercontent.com/silverqx |
| silverqx | https://patch-diff.githubusercontent.com/silverqx |
|
May 31, 2024
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#ref-issue-2326455736 |
|
Basic refactoring features
PowerShell/vscode-powershell#4999
| https://patch-diff.githubusercontent.com/PowerShell/vscode-powershell/issues/4999 |
| https://patch-diff.githubusercontent.com/JustinGrote |
| JustinGrote | https://patch-diff.githubusercontent.com/JustinGrote |
| SeeminglyScience | https://patch-diff.githubusercontent.com/SeeminglyScience |
| andyleejordan | https://patch-diff.githubusercontent.com/andyleejordan |
| May 31, 2024 00:47 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#event-12993234496 |
| https://patch-diff.githubusercontent.com/JustinGrote |
| JustinGrote | https://patch-diff.githubusercontent.com/JustinGrote |
|
Area-Language Server
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/issues?q=state%3Aopen%20label%3A%22Area-Language%20Server%22 |
|
Area-Symbols and References
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/issues?q=state%3Aopen%20label%3A%22Area-Symbols%20and%20References%22 |
| May 31, 2024 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#event-12993236406 |
| https://patch-diff.githubusercontent.com/JustinGrote |
| JustinGrote | https://patch-diff.githubusercontent.com/JustinGrote |
| May 31, 2024 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#issuecomment-2141109486 |
| Please reload this page | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152 |
| https://patch-diff.githubusercontent.com/Razmo99 |
| Razmo99 | https://patch-diff.githubusercontent.com/Razmo99 |
| Jun 2, 2024 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#issuecomment-2143649209 |
| @JustinGrote | https://github.com/JustinGrote |
| Please reload this page | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152 |
| https://patch-diff.githubusercontent.com/JustinGrote |
| JustinGrote | https://patch-diff.githubusercontent.com/JustinGrote |
| Jun 3, 2024 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#issuecomment-2145945127 |
| Please reload this page | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152 |
| Please reload this page | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152 |
| https://patch-diff.githubusercontent.com/JustinGrote |
| JustinGrote | https://patch-diff.githubusercontent.com/JustinGrote |
| Jun 3, 2024 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#event-13027504554 |
| https://patch-diff.githubusercontent.com/JustinGrote |
| JustinGrote | https://patch-diff.githubusercontent.com/JustinGrote |
| Jun 3, 2024 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#issuecomment-2146205459 |
| Please reload this page | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152 |
| https://patch-diff.githubusercontent.com/JustinGrote |
| JustinGrote | https://patch-diff.githubusercontent.com/JustinGrote |
| Jun 4, 2024 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#issuecomment-2148018849 |
| Please reload this page | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152 |
| Please reload this page | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152 |
| https://patch-diff.githubusercontent.com/JustinGrote |
| JustinGrote | https://patch-diff.githubusercontent.com/JustinGrote |
| Jun 4, 2024 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#issuecomment-2148089510 |
| PowerShell/vscode-powershell#261 (comment) | https://github.com/PowerShell/vscode-powershell/issues/261#issuecomment-465249755 |
| Please reload this page | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152 |
| https://patch-diff.githubusercontent.com/Razmo99 |
| Razmo99 | https://patch-diff.githubusercontent.com/Razmo99 |
| Jun 5, 2024 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#issuecomment-2148859646 |
| Please reload this page | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152 |
| https://patch-diff.githubusercontent.com/JustinGrote |
| JustinGrote | https://patch-diff.githubusercontent.com/JustinGrote |
|
Jun 5, 2024
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#pullrequestreview-2099635352 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/files |
| test/PowerShellEditorServices.Test/Refactoring/RefactorVariableTests.cs | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/files#diff-14a1cc30d7fb94a52b8c167011e1f3e915d2e4a9796782a94f4c31bf92dcaff9 |
| Please reload this page | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152 |
| https://patch-diff.githubusercontent.com/JustinGrote |
| JustinGrote | https://patch-diff.githubusercontent.com/JustinGrote |
|
Jun 5, 2024
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#pullrequestreview-2099682261 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/files |
| test/PowerShellEditorServices.Test.Shared/Refactoring/Functions/ForeachFunction.ps1 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/files#diff-39302a197caa976adccf443f0664b5c70a914e3362ab254c0034405d41e5cfb4 |
| Please reload this page | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152 |
| https://patch-diff.githubusercontent.com/JustinGrote |
| JustinGrote | https://patch-diff.githubusercontent.com/JustinGrote |
|
Jun 5, 2024
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#pullrequestreview-2099692382 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/files |
| test/PowerShellEditorServices.Test.Shared/Refactoring/Functions/ForeachFunction.ps1 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/files#diff-39302a197caa976adccf443f0664b5c70a914e3362ab254c0034405d41e5cfb4 |
| Please reload this page | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152 |
| https://patch-diff.githubusercontent.com/JustinGrote |
| JustinGrote | https://patch-diff.githubusercontent.com/JustinGrote |
|
Jun 5, 2024
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#pullrequestreview-2099698501 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/files |
| test/PowerShellEditorServices.Test.Shared/Refactoring/Functions/ForeachFunction.ps1 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/files#diff-39302a197caa976adccf443f0664b5c70a914e3362ab254c0034405d41e5cfb4 |
| Please reload this page | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152 |
| https://patch-diff.githubusercontent.com/JustinGrote |
| JustinGrote | https://patch-diff.githubusercontent.com/JustinGrote |
|
Jun 5, 2024
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#pullrequestreview-2099705560 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/files |
| src/PowerShellEditorServices/Services/PowerShell/Refactoring/IterativeVariableVisitor.cs | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/files#diff-ecb54d00e035267f5472432fcbce6b61911e26635050db8d30cc49ecb3645628 |
| Please reload this page | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152 |
| https://patch-diff.githubusercontent.com/JustinGrote |
| JustinGrote | https://patch-diff.githubusercontent.com/JustinGrote |
|
Jun 5, 2024
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#pullrequestreview-2100050995 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/files |
| test/PowerShellEditorServices.Test/Refactoring/RefactorFunctionTests.cs | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/files#diff-13dd254a02bc231765d8e0e4c44d934ac9ffba23c11719bf271f3e01530a4dba |
| Please reload this page | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152 |
| https://patch-diff.githubusercontent.com/JustinGrote |
| JustinGrote | https://patch-diff.githubusercontent.com/JustinGrote |
| code owner | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/blob/a99180d4ce0594d59ff6577e340c97f7666e42c3/.github/CODEOWNERS#L4 |
| September 12, 2024 03:57 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#event-14226185322 |
| https://patch-diff.githubusercontent.com/JustinGrote |
| JustinGrote | https://patch-diff.githubusercontent.com/JustinGrote |
| Sep 12, 2024 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#issuecomment-2345224422 |
| Please reload this page | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152 |
| @Razmo99 | https://github.com/Razmo99 |
| ff9c25b | https://github.com/PowerShell/PowerShellEditorServices/commit/ff9c25ba9180f9e71829bbccfcbcd0961ed99bce |
| Please reload this page | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152 |
| https://patch-diff.githubusercontent.com/JustinGrote |
| JustinGrote | https://patch-diff.githubusercontent.com/JustinGrote |
| force-pushed | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/compare/ff9c25ba9180f9e71829bbccfcbcd0961ed99bce..386b707aa01ac0493ef10179700b5172d49e3c7f |
| ff9c25b | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/commit/ff9c25ba9180f9e71829bbccfcbcd0961ed99bce |
| 386b707 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/commit/386b707aa01ac0493ef10179700b5172d49e3c7f |
|
Compare
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/compare/ff9c25ba9180f9e71829bbccfcbcd0961ed99bce..386b707aa01ac0493ef10179700b5172d49e3c7f |
| September 12, 2024 04:21 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#event-14226323846 |
| JustinGrote | https://patch-diff.githubusercontent.com/JustinGrote |
| March 18, 2025 12:13 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#commits-pushed-13e99eb |
|
| https://patch-diff.githubusercontent.com/JustinGrote |
| Small test fixes and naming updates | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/13e99eb9804c4886dd60221e4ecf06035c609333 |
| 13e99eb | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/13e99eb9804c4886dd60221e4ecf06035c609333 |
|
| https://patch-diff.githubusercontent.com/JustinGrote |
| Move AstExtensions to Utility | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/93c449e1be14b21df958957325f9ae81706cab1c |
| 93c449e | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/93c449e1be14b21df958957325f9ae81706cab1c |
|
| https://patch-diff.githubusercontent.com/JustinGrote |
| Remove utilities as they have been moved into RenameService or AstExt… | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/edcadeb9fe41c0265b0932199a3996ca65bc1e45 |
| edcadeb | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/edcadeb9fe41c0265b0932199a3996ca65bc1e45 |
|
| https://patch-diff.githubusercontent.com/JustinGrote |
| Rewrote Variable Handler, all tests passing except a stringconstant s… | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/8af302ee45b6737fbba8707bc25113840e03dea3 |
| 8af302e | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/8af302ee45b6737fbba8707bc25113840e03dea3 |
|
| https://patch-diff.githubusercontent.com/JustinGrote |
| Fix up Splat function finding, all tests pass | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/27f1a3bafaaeee9e05e869edd8933968a344afb2 |
| 27f1a3b | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/27f1a3bafaaeee9e05e869edd8933968a344afb2 |
|
| https://patch-diff.githubusercontent.com/JustinGrote |
| Clean out some dead code | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/87fee89560ae92bea6ba55dd0573ce2a9dac383c |
| 87fee89 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/87fee89560ae92bea6ba55dd0573ce2a9dac383c |
|
| https://patch-diff.githubusercontent.com/JustinGrote |
| Add name validation and related tests, also rearrange/rename some tes… | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/c8d26c6cc27b8de9890cb31634cc54a92245f888 |
| c8d26c6 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/c8d26c6cc27b8de9890cb31634cc54a92245f888 |
|
| https://patch-diff.githubusercontent.com/JustinGrote |
| Update readme with current unsupported scenarios | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/6832e0ccd0a592ea84f9b97670905b8999d87cfe |
| 6832e0c | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/6832e0ccd0a592ea84f9b97670905b8999d87cfe |
|
| https://patch-diff.githubusercontent.com/JustinGrote |
| Rework function name check to be ast based | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/46ccae37c2d99ee243d82ebf0ebdc415e9269cbc |
| 46ccae3 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/46ccae37c2d99ee243d82ebf0ebdc415e9269cbc |
|
| https://patch-diff.githubusercontent.com/JustinGrote |
| Add Limitation about scriptblocks | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/7607f468551b04cb7af4583fb3bafc1f8094e498 |
| 7607f46 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/7607f468551b04cb7af4583fb3bafc1f8094e498 |
|
| https://patch-diff.githubusercontent.com/JustinGrote |
| Cleanup and refactor a lot of logic out to the extension functions, r… | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/5c34173851128a3eac1c7ddf4c94596c03a364cc |
| 5c34173 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/5c34173851128a3eac1c7ddf4c94596c03a364cc |
|
| https://patch-diff.githubusercontent.com/JustinGrote |
| Simplify GetTopVariableAssignment using new extension methods | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/9f611baa8376e5ce992eccd48174ccdc27dcae9f |
| 9f611ba | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/9f611baa8376e5ce992eccd48174ccdc27dcae9f |
|
| https://patch-diff.githubusercontent.com/JustinGrote |
| Add Test case and more info | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/bdb40b74a61acb18da29b9ebc18ae8a317ac559e |
| bdb40b7 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/bdb40b74a61acb18da29b9ebc18ae8a317ac559e |
|
| https://patch-diff.githubusercontent.com/JustinGrote |
| Add Rename Parameter Alias Support | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/102c69dc2cb5de3a39010c01cf5995634c847a47 |
| 102c69d | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/102c69dc2cb5de3a39010c01cf5995634c847a47 |
|
| https://patch-diff.githubusercontent.com/JustinGrote |
| Add note about Get/Set variable limitation | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/d3bb1b9d66fadd59364b273fddf7b802e50dd671 |
| d3bb1b9 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/d3bb1b9d66fadd59364b273fddf7b802e50dd671 |
|
| https://patch-diff.githubusercontent.com/JustinGrote |
| Fix readme markdown formatting | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/706c9b11dc178a6d380c39d7170f57ab34ead870 |
| 706c9b1 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/706c9b11dc178a6d380c39d7170f57ab34ead870 |
|
| https://patch-diff.githubusercontent.com/JustinGrote |
| Rolyn Lint Fixes | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/25f74a5452fb69a33b7efe707d5ec1b0a3753aae |
| 25f74a5 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/25f74a5452fb69a33b7efe707d5ec1b0a3753aae |
|
| https://patch-diff.githubusercontent.com/JustinGrote |
| Fix closing param | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/4da6079dd1e6dd77e91bde67e8fa0f64eeca3d9b |
| 4da6079 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/4da6079dd1e6dd77e91bde67e8fa0f64eeca3d9b |
|
| https://patch-diff.githubusercontent.com/JustinGrote |
| Remove unused function | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/0abbb250cda6a254bced6acb4723becc2edd8d42 |
| 0abbb25 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/0abbb250cda6a254bced6acb4723becc2edd8d42 |
|
| https://patch-diff.githubusercontent.com/JustinGrote |
| Fix Typo | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/9f1aaa239284900c8ce528573b947941eb46d68a |
| 9f1aaa2 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/9f1aaa239284900c8ce528573b947941eb46d68a |
|
| https://patch-diff.githubusercontent.com/JustinGrote |
| Fix bad indentation | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/e643423562cdf76a75edb94a1ffdc6c10fd59a03 |
| e643423 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/e643423562cdf76a75edb94a1ffdc6c10fd59a03 |
|
| https://patch-diff.githubusercontent.com/JustinGrote |
| Implement Roslynator Recommendation | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/882131040a3e6eb676b743d5b933e4c865e6b2c0 |
| 8821310 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/882131040a3e6eb676b743d5b933e4c865e6b2c0 |
|
| https://patch-diff.githubusercontent.com/JustinGrote |
| Add back GetFullScript | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/38fe32977f03577a546b70fce5aaa6bcd215cc78 |
| 38fe329 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/38fe32977f03577a546b70fce5aaa6bcd215cc78 |
|
| https://patch-diff.githubusercontent.com/JustinGrote |
| Remove unused script extensions | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/87753ed72eef15897a2b435d85595977099fdb58 |
| 87753ed | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/87753ed72eef15897a2b435d85595977099fdb58 |
|
| https://patch-diff.githubusercontent.com/JustinGrote |
| Fix minor script extension update | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/981f6e9ecbe8f62cfcc47484948bf1901a06bf20 |
| 981f6e9 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/981f6e9ecbe8f62cfcc47484948bf1901a06bf20 |
| https://patch-diff.githubusercontent.com/JustinGrote |
| JustinGrote | https://patch-diff.githubusercontent.com/JustinGrote |
| force-pushed | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/compare/1897e7bcea04635241c825ba49a156951659e2aa..981f6e9ecbe8f62cfcc47484948bf1901a06bf20 |
| 1897e7b | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/commit/1897e7bcea04635241c825ba49a156951659e2aa |
| 981f6e9 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/commit/981f6e9ecbe8f62cfcc47484948bf1901a06bf20 |
|
Compare
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/compare/1897e7bcea04635241c825ba49a156951659e2aa..981f6e9ecbe8f62cfcc47484948bf1901a06bf20 |
| March 18, 2025 19:26 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#event-16844950332 |
| https://patch-diff.githubusercontent.com/JustinGrote |
| JustinGrote | https://patch-diff.githubusercontent.com/JustinGrote |
| Mar 18, 2025 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#issuecomment-2734489356 |
| Please reload this page | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152 |
| JustinGrote | https://patch-diff.githubusercontent.com/JustinGrote |
| March 20, 2025 11:00 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152#commits-pushed-35eea13 |
|
| https://patch-diff.githubusercontent.com/JustinGrote |
| Remove placeholders/comments and clean up in-progress items | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/35eea13ef4dad5d9db375f22bf3c88a309d02760 |
| 35eea13 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/35eea13ef4dad5d9db375f22bf3c88a309d02760 |
|
| https://patch-diff.githubusercontent.com/JustinGrote |
| Remove and cleanup TODO comments | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/d43045923264954a98686c8b3b03dee72285297a |
| d430459 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/d43045923264954a98686c8b3b03dee72285297a |
|
| https://patch-diff.githubusercontent.com/JustinGrote |
| Fix placeholder not being a valid variable name | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/153dd514a100c8d71d10a2958780ab78b0e76b52 |
| 153dd51 | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/commits/153dd514a100c8d71d10a2958780ab78b0e76b52 |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in to comment | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FPowerShell%2FPowerShellEditorServices%2Fpull%2F2152 |
|
| https://patch-diff.githubusercontent.com/JustinGrote |
|
JustinGrote
| https://patch-diff.githubusercontent.com/JustinGrote |
|
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/files/1ba71187673201fcacf11585e7366de7c6134dd6 |
|
| https://patch-diff.githubusercontent.com/andyleejordan |
|
andyleejordan
| https://patch-diff.githubusercontent.com/andyleejordan |
|
| https://patch-diff.githubusercontent.com/SeeminglyScience |
|
SeeminglyScience
| https://patch-diff.githubusercontent.com/SeeminglyScience |
|
| https://patch-diff.githubusercontent.com/HeyItsGilbert |
|
HeyItsGilbert
| https://patch-diff.githubusercontent.com/HeyItsGilbert |
|
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152/files/63bfac1010afa5d7f295f16d4067e997ea3b8543 |
|
| https://patch-diff.githubusercontent.com/JustinGrote |
|
JustinGrote
| https://patch-diff.githubusercontent.com/JustinGrote |
|
Area-Language Server
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/issues?q=state%3Aopen%20label%3A%22Area-Language%20Server%22 |
|
Area-Symbols and References
| https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/issues?q=state%3Aopen%20label%3A%22Area-Symbols%20and%20References%22 |
| Please reload this page | https://patch-diff.githubusercontent.com/PowerShell/PowerShellEditorServices/pull/2152 |
|
| https://patch-diff.githubusercontent.com/Razmo99 |
|
| https://patch-diff.githubusercontent.com/JustinGrote |
|
| https://patch-diff.githubusercontent.com/andyleejordan |
|
| https://patch-diff.githubusercontent.com/HeyItsGilbert |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |