René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"deployVirtualMachine build unexpected query string for parameter iptonetworklist","articleBody":"Hello there, I got the very same problem reported on issue #1 but here I'll try to explain how to reproduce the case.\r\n\r\nOn `deployVirtualMachine` command the API accepts an array for parameter `iptonetworklist`, which is formatted this way if you create a VM directly from CloudStack UI: `\u0026iptonetworklist[0].networkid=b6170452-820c-4a5b-bb76-6a22a0266c0d\u0026iptonetworklist[0].ip=10.1.1.100\u0026iptonetworklist[0].mac=DC-FE-49-00-66-0D`. The key [0] on this array can be incremented when you associate more than one network to the new VM.\r\n\r\nThe point is that the method `protected function buildQueryString(array $params)` on `PCextreme\\Cloudstack\\Client` is not able to build the query string array like expected by CloudStack API on this command, giving `Notice: Undefined index: key` if we try to send the array data with something like this:\r\n\r\n```php\r\n  \"iptonetworklist\" =\u003e array:1 [\r\n    0 =\u003e array:3 [\r\n      \"mac\" =\u003e \"54-77-2F-BA-67-74\"\r\n      \"networkid\" =\u003e \"b6170452-820c-4a5b-bb76-6a22a0266c0d\"\r\n      \"ip\" =\u003e \"10.1.1.50\"\r\n    ]\r\n  ]\r\n```\r\n\r\nOtherwise, if we try to send the array as expected by the method, like the example bellow:\r\n\r\n```php\r\n  \"iptonetworklist\" =\u003e array:3 [\r\n    0 =\u003e array:2 [\r\n      \"key\" =\u003e \"mac\"\r\n      \"value\" =\u003e \"54-77-2F-BA-67-74\"\r\n    ]\r\n    1 =\u003e array:2 [\r\n      \"key\" =\u003e \"networkid\"\r\n      \"value\" =\u003e \"b6170452-820c-4a5b-bb76-6a22a0266c0d\"\r\n    ]\r\n    2 =\u003e array:2 [\r\n      \"key\" =\u003e \"ip\"\r\n      \"value\" =\u003e \"10.1.1.50\"\r\n    ]\r\n  ]\r\n```\r\n\r\nWe get the query string as this: `\u0026iptonetworklist[0].key=mac\u0026iptonetworklist[0].value=54-77-2F-BA-67-74\u0026iptonetworklist[1].key=networkid\u0026iptonetworklist[1].value=b6170452-820c-4a5b-bb76-6a22a0266c0d\u0026iptonetworklist[2].key=ip\u0026iptonetworklist[2].value=10.1.1.50`\r\n\r\nThis way the method will not give the notice, but CloudStack API will treat each key on the array as a different entry in the map, returning this error:\r\n\r\n```php\r\nClientException {#3412\r\n  #response: array:1 [\r\n    \"deployvirtualmachineresponse\" =\u003e array:4 [\r\n      \"uuidList\" =\u003e []\r\n      \"errorcode\" =\u003e 431\r\n      \"cserrorcode\" =\u003e 4350\r\n      \"errortext\" =\u003e \"Unable to translate and find entity with networkId: null\"\r\n    ]\r\n  ]\r\n  #message: \"Unable to translate and find entity with networkId: null\"\r\n  #code: 431\r\n  #file: \"/var/www/html/vendor/pcextreme/cloudstack/src/Client.php\"\r\n  #line: 405\r\n```\r\n\r\nI'm not sure if this is the only endpoint treating array on request this way, but the way `buildQueryString()` method parses input and build query string is not working for the command `deployVirtualMachine`.\r\n\r\nIf you could confirm if there are other commands receiving and parsing arrays for requests I could eventually send a PR to fix this, but I'm afraid we fix for this command and break for others.\r\n\r\nPlease let me know if I can help sending other evidences of the case.\r\n\r\nFor the reference, I'm using **CloudStack 4.15.0.0** here.","author":{"url":"https://github.com/danielcosta","@type":"Person","name":"danielcosta"},"datePublished":"2021-06-10T17:20:30.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/32/cloudstack-php/issues/32"}