Title: Mismap and possible mismatch with Material in mid-Indev · Issue #201 · OrnitheMC/feather · GitHub
Open Graph Title: Mismap and possible mismatch with Material in mid-Indev · Issue #201 · OrnitheMC/feather
X Title: Mismap and possible mismatch with Material in mid-Indev · Issue #201 · OrnitheMC/feather
Description: Type Field, maybe Class Describe where the element is net.minecraft.block.material.Material(.f1017744) Description of the element In indev-20100201-0025: the mentioned field is used for any block that is not lava/water. And the class in ...
Open Graph Description: Type Field, maybe Class Describe where the element is net.minecraft.block.material.Material(.f1017744) Description of the element In indev-20100201-0025: the mentioned field is used for any block t...
X Description: Type Field, maybe Class Describe where the element is net.minecraft.block.material.Material(.f1017744) Description of the element In indev-20100201-0025: the mentioned field is used for any block t...
Opengraph URL: https://github.com/OrnitheMC/feather/issues/201
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Mismap and possible mismatch with Material in mid-Indev","articleBody":"**Type** \nField, maybe Class\n\n**Describe where the element is** \nnet.minecraft.block.material.Material(.f1017744)\n\n**Description of the element** \nIn indev-20100201-0025: the mentioned field is used for any block that is not lava/water. And the class in general is focused on liquids entirely.\n\nIn indev-20100201-2227: the mentioned field is used for wooden materials specifically. The class in general is now focused on Materials in general, and lava/water are defined using an extending class, with a method to check for liquid/not.\n\n**Expected name** \nField: NON_LIQUID\nmaybe Class: LiquidState\n\n**Additional Context**\nThe class in general seems to have been re-purposed from liquids, to generic materials, with liquids being a subset. I think there are arguments that this is anywhere between a mis-mapped field, and a mismatched class, depending on how you look at it. The field has undeniably changed purpose, a name change is necessary at least, and there's no reason it to should match to anything in particular, since there's nothing that lines up, which leads me to believe it's a mismatch too. The class is arguably doing the same thing (determining subsets of blocks and their properties), but simply changed scope massively, this is quite possibly a good match, and maybe even a good mapping too.\n\nLeast extensive suggested change: rename Material.WOOD to Material.NON_LIQUID in indev-20100201-0025 and below.\n\nMost extensive suggested change: rematch the class net.minecraft.block.material.Material for indev-20100201-0025 and below, remap to LiquidState, and remap fields as LAVA, WATER, and NON_LIQUID","author":{"url":"https://github.com/FubyCutie","@type":"Person","name":"FubyCutie"},"datePublished":"2025-09-09T18:59:23.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/201/feather/issues/201"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:a3c2abff-70c2-ec1e-8a81-ef57c4674971 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E09E:13D878:43E7B1:564F85:69913EB2 |
| html-safe-nonce | f0bc284b5f44bb0822fac3f0e9bb2cbf45172db557b0df9de7dd1ba09d710b39 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDlFOjEzRDg3ODo0M0U3QjE6NTY0Rjg1OjY5OTEzRUIyIiwidmlzaXRvcl9pZCI6IjY3MzcxNTk0NzI2MzUwMDI1NDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f2e57a4f6c59fdc46410882661c66a1122ed8b643e7984735f58093fdfd55ec9 |
| hovercard-subject-tag | issue:3399590551 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/OrnitheMC/feather/201/issue_layout |
| twitter:image | https://opengraph.githubassets.com/a7277190526faa6da98227922df5fd18defeb7458e9e0a12e228c06889c773cc/OrnitheMC/feather/issues/201 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a7277190526faa6da98227922df5fd18defeb7458e9e0a12e228c06889c773cc/OrnitheMC/feather/issues/201 |
| og:image:alt | Type Field, maybe Class Describe where the element is net.minecraft.block.material.Material(.f1017744) Description of the element In indev-20100201-0025: the mentioned field is used for any block t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | FubyCutie |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-preview |
| go-import | github.com/OrnitheMC/feather git https://github.com/OrnitheMC/feather.git |
| octolytics-dimension-user_id | 96929194 |
| octolytics-dimension-user_login | OrnitheMC |
| octolytics-dimension-repository_id | 433184266 |
| octolytics-dimension-repository_nwo | OrnitheMC/feather |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 433184266 |
| octolytics-dimension-repository_network_root_nwo | OrnitheMC/feather |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width