René's URL Explorer Experiment


Title: Remove the `insertAutoGeneratedEnumMappings` gradle task · Issue #142 · OrnitheMC/feather · GitHub

Open Graph Title: Remove the `insertAutoGeneratedEnumMappings` gradle task · Issue #142 · OrnitheMC/feather

X Title: Remove the `insertAutoGeneratedEnumMappings` gradle task · Issue #142 · OrnitheMC/feather

Description: The idea is to remove the insertAutoGeneratedEnumMappings task. This task currently runs stitchs CommandProposeV2FieldNames to generate names from the non-stripped enum variants (at least that's what I think it does). Removing this would...

Open Graph Description: The idea is to remove the insertAutoGeneratedEnumMappings task. This task currently runs stitchs CommandProposeV2FieldNames to generate names from the non-stripped enum variants (at least that's wh...

X Description: The idea is to remove the insertAutoGeneratedEnumMappings task. This task currently runs stitchs CommandProposeV2FieldNames to generate names from the non-stripped enum variants (at least that'...

Opengraph URL: https://github.com/OrnitheMC/feather/issues/142

X: @github

direct link

Domain: patch-diff.githubusercontent.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Remove the `insertAutoGeneratedEnumMappings` gradle task","articleBody":"The idea is to remove the `insertAutoGeneratedEnumMappings` task. This task currently runs stitchs `CommandProposeV2FieldNames` to generate names from the non-stripped enum variants (at least that's what I think it does). Removing this would require us to map these enum variants ourself. This is not hard, we already do this (I think).\r\nIn for example 1.12.2 the task only replaced 16, but detected 2184 \"interesting names\".\r\nIn 12w30e-client it replaced 0  names, and detected 130 \"interesting names\".\r\n\r\nTherefore I think we should just remove that task and simpify the building process.\r\n\r\nIn the image you can see what would be replaced: the two red arrows to and the one from the `insertAutoGeneratedEnumMappings` task would be replaced with the green one that directly connects `buildFeatherTiny` with `v2UnmergedFeatherJar`.\r\n![image](https://github.com/OrnitheMC/feather-mappings/assets/67289119/4f093671-c0a6-4cd2-b9be-1ebba47da553)\r\nNote: I plan to open a PR in the future containing that graph.\r\n\r\nIn terms of code changes:\r\nThe task to be removed is:\r\nhttps://github.com/OrnitheMC/feather-mappings/blob/e28cce1fb4853702bb8e9b68cdc5829a17a1a68e/build.gradle#L1079-L1098\r\nThis would require changes in the `v2UnmergedFeatherJar` task:\r\nhttps://github.com/OrnitheMC/feather-mappings/blob/e28cce1fb4853702bb8e9b68cdc5829a17a1a68e/build.gradle#L1130-L1140\r\nMainly the `dependsOn` would need to change to `buildFeatherTiny`, and `def mappings` also needs to use `buildFeatherTiny`.\r\n\r\nThis issue is created to discuss how much this would break, since I do not currently know how dependant the mappings are on this feature.\r\n\r\nfor the future PR: (just using this as notes for later on)\r\n- Remove the `insertAutoGeneratedEnumMappings` gradle task and instead map these directly; see #142\r\n I do not yet know the impacts of this, see the issue for this.\r\n... maybe there's more that could be cleaned up:\r\n- Why do we use tiny v1 in so many places? We should just switch all to tiny v2 and generate tiny v1 from them.","author":{"url":"https://github.com/zeichenreihe","@type":"Person","name":"zeichenreihe"},"datePublished":"2023-10-21T21:29:31.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/142/feather/issues/142"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:289ba1af-b3c4-b50e-faf8-e6dfd565f144
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idAF3E:21B1E4:252304:2F7946:6990F593
html-safe-noncefb22f1b2d70365294a4bc33d06df3485a55fb4d0866bd3e8d1e05d52659e9c11
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjNFOjIxQjFFNDoyNTIzMDQ6MkY3OTQ2OjY5OTBGNTkzIiwidmlzaXRvcl9pZCI6Ijg4MTQzMjM4OTc0MzAyNDI3MDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac78392d447af89b5d82b45895f9d5d0c834bbd2634bee6e927fa3412af370b926
hovercard-subject-tagissue:1955671281
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/OrnitheMC/feather/142/issue_layout
twitter:imagehttps://opengraph.githubassets.com/3256d315300c71fc8a70aa43b58209ab475f14032ae5e17f16a9e95aeff49713/OrnitheMC/feather/issues/142
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3256d315300c71fc8a70aa43b58209ab475f14032ae5e17f16a9e95aeff49713/OrnitheMC/feather/issues/142
og:image:altThe idea is to remove the insertAutoGeneratedEnumMappings task. This task currently runs stitchs CommandProposeV2FieldNames to generate names from the non-stripped enum variants (at least that's wh...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamezeichenreihe
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-preview
go-importgithub.com/OrnitheMC/feather git https://github.com/OrnitheMC/feather.git
octolytics-dimension-user_id96929194
octolytics-dimension-user_loginOrnitheMC
octolytics-dimension-repository_id433184266
octolytics-dimension-repository_nwoOrnitheMC/feather
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id433184266
octolytics-dimension-repository_network_root_nwoOrnitheMC/feather
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/OrnitheMC/feather/issues/142#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FOrnitheMC%2Ffeather%2Fissues%2F142
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FOrnitheMC%2Ffeather%2Fissues%2F142
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=OrnitheMC%2Ffeather
Reloadhttps://patch-diff.githubusercontent.com/OrnitheMC/feather/issues/142
Reloadhttps://patch-diff.githubusercontent.com/OrnitheMC/feather/issues/142
Reloadhttps://patch-diff.githubusercontent.com/OrnitheMC/feather/issues/142
OrnitheMC https://patch-diff.githubusercontent.com/OrnitheMC
featherhttps://patch-diff.githubusercontent.com/OrnitheMC/feather
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2FOrnitheMC%2Ffeather
Fork 32 https://patch-diff.githubusercontent.com/login?return_to=%2FOrnitheMC%2Ffeather
Star 61 https://patch-diff.githubusercontent.com/login?return_to=%2FOrnitheMC%2Ffeather
Code https://patch-diff.githubusercontent.com/OrnitheMC/feather
Issues 7 https://patch-diff.githubusercontent.com/OrnitheMC/feather/issues
Pull requests 0 https://patch-diff.githubusercontent.com/OrnitheMC/feather/pulls
Actions https://patch-diff.githubusercontent.com/OrnitheMC/feather/actions
Security 0 https://patch-diff.githubusercontent.com/OrnitheMC/feather/security
Insights https://patch-diff.githubusercontent.com/OrnitheMC/feather/pulse
Code https://patch-diff.githubusercontent.com/OrnitheMC/feather
Issues https://patch-diff.githubusercontent.com/OrnitheMC/feather/issues
Pull requests https://patch-diff.githubusercontent.com/OrnitheMC/feather/pulls
Actions https://patch-diff.githubusercontent.com/OrnitheMC/feather/actions
Security https://patch-diff.githubusercontent.com/OrnitheMC/feather/security
Insights https://patch-diff.githubusercontent.com/OrnitheMC/feather/pulse
New issuehttps://patch-diff.githubusercontent.com/login?return_to=https://github.com/OrnitheMC/feather/issues/142
New issuehttps://patch-diff.githubusercontent.com/login?return_to=https://github.com/OrnitheMC/feather/issues/142
Remove the insertAutoGeneratedEnumMappings gradle taskhttps://patch-diff.githubusercontent.com/OrnitheMC/feather/issues/142#top
build systemIssue related to the build systemhttps://github.com/OrnitheMC/feather/issues?q=state%3Aopen%20label%3A%22build%20system%22
enhancementNew feature or requesthttps://github.com/OrnitheMC/feather/issues?q=state%3Aopen%20label%3A%22enhancement%22
https://github.com/zeichenreihe
https://github.com/zeichenreihe
zeichenreihehttps://github.com/zeichenreihe
on Oct 21, 2023https://github.com/OrnitheMC/feather/issues/142#issue-1955671281
https://private-user-images.githubusercontent.com/67289119/277134259-4f093671-c0a6-4cd2-b9be-1ebba47da553.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzExMDgwMzEsIm5iZiI6MTc3MTEwNzczMSwicGF0aCI6Ii82NzI4OTExOS8yNzcxMzQyNTktNGYwOTM2NzEtYzBhNi00Y2QyLWI5YmUtMWViYmE0N2RhNTUzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMjE0VDIyMjIxMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWJmZjBjMDllYzczYmViZGNkYjM1MjI0NWI1OTU1OTBmYjhiNTM5YTk1NjM5OTY0ZWE2MzI3ZDkwNmFkOGM0YmMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.vh1ENUlNWfZSRxFi_uawqWtQdd9uXLEr88sRBRprIXw
https://github.com/OrnitheMC/feather-mappings/blob/e28cce1fb4853702bb8e9b68cdc5829a17a1a68e/build.gradle#L1079-L1098https://github.com/OrnitheMC/feather-mappings/blob/e28cce1fb4853702bb8e9b68cdc5829a17a1a68e/build.gradle#L1079-L1098
https://github.com/OrnitheMC/feather-mappings/blob/e28cce1fb4853702bb8e9b68cdc5829a17a1a68e/build.gradle#L1130-L1140https://github.com/OrnitheMC/feather-mappings/blob/e28cce1fb4853702bb8e9b68cdc5829a17a1a68e/build.gradle#L1130-L1140
Remove the insertAutoGeneratedEnumMappings gradle task #142https://github.com/OrnitheMC/feather/issues/142
build systemIssue related to the build systemhttps://github.com/OrnitheMC/feather/issues?q=state%3Aopen%20label%3A%22build%20system%22
enhancementNew feature or requesthttps://github.com/OrnitheMC/feather/issues?q=state%3Aopen%20label%3A%22enhancement%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.