Title: Remove the `insertAutoGeneratedEnumMappings` gradle task · Issue #142 · OrnitheMC/feather · GitHub
Open Graph Title: Remove the `insertAutoGeneratedEnumMappings` gradle task · Issue #142 · OrnitheMC/feather
X Title: Remove the `insertAutoGeneratedEnumMappings` gradle task · Issue #142 · OrnitheMC/feather
Description: The idea is to remove the insertAutoGeneratedEnumMappings task. This task currently runs stitchs CommandProposeV2FieldNames to generate names from the non-stripped enum variants (at least that's what I think it does). Removing this would...
Open Graph Description: The idea is to remove the insertAutoGeneratedEnumMappings task. This task currently runs stitchs CommandProposeV2FieldNames to generate names from the non-stripped enum variants (at least that's wh...
X Description: The idea is to remove the insertAutoGeneratedEnumMappings task. This task currently runs stitchs CommandProposeV2FieldNames to generate names from the non-stripped enum variants (at least that'...
Opengraph URL: https://github.com/OrnitheMC/feather/issues/142
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Remove the `insertAutoGeneratedEnumMappings` gradle task","articleBody":"The idea is to remove the `insertAutoGeneratedEnumMappings` task. This task currently runs stitchs `CommandProposeV2FieldNames` to generate names from the non-stripped enum variants (at least that's what I think it does). Removing this would require us to map these enum variants ourself. This is not hard, we already do this (I think).\r\nIn for example 1.12.2 the task only replaced 16, but detected 2184 \"interesting names\".\r\nIn 12w30e-client it replaced 0 names, and detected 130 \"interesting names\".\r\n\r\nTherefore I think we should just remove that task and simpify the building process.\r\n\r\nIn the image you can see what would be replaced: the two red arrows to and the one from the `insertAutoGeneratedEnumMappings` task would be replaced with the green one that directly connects `buildFeatherTiny` with `v2UnmergedFeatherJar`.\r\n\r\nNote: I plan to open a PR in the future containing that graph.\r\n\r\nIn terms of code changes:\r\nThe task to be removed is:\r\nhttps://github.com/OrnitheMC/feather-mappings/blob/e28cce1fb4853702bb8e9b68cdc5829a17a1a68e/build.gradle#L1079-L1098\r\nThis would require changes in the `v2UnmergedFeatherJar` task:\r\nhttps://github.com/OrnitheMC/feather-mappings/blob/e28cce1fb4853702bb8e9b68cdc5829a17a1a68e/build.gradle#L1130-L1140\r\nMainly the `dependsOn` would need to change to `buildFeatherTiny`, and `def mappings` also needs to use `buildFeatherTiny`.\r\n\r\nThis issue is created to discuss how much this would break, since I do not currently know how dependant the mappings are on this feature.\r\n\r\nfor the future PR: (just using this as notes for later on)\r\n- Remove the `insertAutoGeneratedEnumMappings` gradle task and instead map these directly; see #142\r\n I do not yet know the impacts of this, see the issue for this.\r\n... maybe there's more that could be cleaned up:\r\n- Why do we use tiny v1 in so many places? We should just switch all to tiny v2 and generate tiny v1 from them.","author":{"url":"https://github.com/zeichenreihe","@type":"Person","name":"zeichenreihe"},"datePublished":"2023-10-21T21:29:31.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/142/feather/issues/142"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:289ba1af-b3c4-b50e-faf8-e6dfd565f144 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | AF3E:21B1E4:252304:2F7946:6990F593 |
| html-safe-nonce | fb22f1b2d70365294a4bc33d06df3485a55fb4d0866bd3e8d1e05d52659e9c11 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjNFOjIxQjFFNDoyNTIzMDQ6MkY3OTQ2OjY5OTBGNTkzIiwidmlzaXRvcl9pZCI6Ijg4MTQzMjM4OTc0MzAyNDI3MDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 78392d447af89b5d82b45895f9d5d0c834bbd2634bee6e927fa3412af370b926 |
| hovercard-subject-tag | issue:1955671281 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/OrnitheMC/feather/142/issue_layout |
| twitter:image | https://opengraph.githubassets.com/3256d315300c71fc8a70aa43b58209ab475f14032ae5e17f16a9e95aeff49713/OrnitheMC/feather/issues/142 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3256d315300c71fc8a70aa43b58209ab475f14032ae5e17f16a9e95aeff49713/OrnitheMC/feather/issues/142 |
| og:image:alt | The idea is to remove the insertAutoGeneratedEnumMappings task. This task currently runs stitchs CommandProposeV2FieldNames to generate names from the non-stripped enum variants (at least that's wh... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | zeichenreihe |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-preview |
| go-import | github.com/OrnitheMC/feather git https://github.com/OrnitheMC/feather.git |
| octolytics-dimension-user_id | 96929194 |
| octolytics-dimension-user_login | OrnitheMC |
| octolytics-dimension-repository_id | 433184266 |
| octolytics-dimension-repository_nwo | OrnitheMC/feather |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 433184266 |
| octolytics-dimension-repository_network_root_nwo | OrnitheMC/feather |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width