Title: Incorrect Action Executed In OMList.doAction() · Issue #55 · OpenMap-java/openmap · GitHub
Open Graph Title: Incorrect Action Executed In OMList.doAction() · Issue #55 · OpenMap-java/openmap
X Title: Incorrect Action Executed In OMList.doAction() · Issue #55 · OpenMap-java/openmap
Description: In the OMList.doAction() method the OMGraphicConstants.LOWER_TO_BOTTOM_GRAPHIC_MASK action calls the moveIndexedOneToBottom() method instead of moveIndexedToBottom(). Both OMGraphicConstants.LOWER_TO_BOTTOM_GRAPHIC_MASK and OMGraphicCons...
Open Graph Description: In the OMList.doAction() method the OMGraphicConstants.LOWER_TO_BOTTOM_GRAPHIC_MASK action calls the moveIndexedOneToBottom() method instead of moveIndexedToBottom(). Both OMGraphicConstants.LOWER_...
X Description: In the OMList.doAction() method the OMGraphicConstants.LOWER_TO_BOTTOM_GRAPHIC_MASK action calls the moveIndexedOneToBottom() method instead of moveIndexedToBottom(). Both OMGraphicConstants.LOWER_...
Opengraph URL: https://github.com/OpenMap-java/openmap/issues/55
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Incorrect Action Executed In OMList.doAction()","articleBody":"In the OMList.doAction() method the OMGraphicConstants.LOWER_TO_BOTTOM_GRAPHIC_MASK action calls the moveIndexedOneToBottom() method instead of moveIndexedToBottom().\r\n\r\nBoth OMGraphicConstants.LOWER_TO_BOTTOM_GRAPHIC_MASK and OMGraphicConstants.LOWER_GRAPHIC_MASK currently perform the same action to moveIndexedOneToBottom().\r\n\r\nI verified that correctly calling moveIndexedToBottom() when the mask is set to OMGraphicConstants.LOWER_TO_BOTTOM_GRAPHIC_MASK works as expected.\r\n\r\nThe issue exists in the currently available download version, OpenMap 5.1.15.\r\n\r\nThe correction is the following inside the OMList.doAction() method:\r\n\r\n```\r\nif (action.isMask(LOWER_TO_BOTTOM_GRAPHIC_MASK)) {\r\n Debug.message(\"omgl\", \"OMGraphicList.doAction: lowering graphic to bottom\");\r\n moveIndexedToBottom(i); // -\u003e Corrected by Jose M. Torres\r\n}\r\n```\r\n","author":{"url":"https://github.com/jose-m-torres","@type":"Person","name":"jose-m-torres"},"datePublished":"2021-09-17T16:42:16.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/55/openmap/issues/55"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:e5b5a369-fa21-438d-1c7a-04093ad1c565 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8086:3DF1BE:43A224:5F19FE:6980DB7C |
| html-safe-nonce | e440cf7dc8056d10871fb2ff0f3b3c90c12c53c201770fbe57535a5f48d1761b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDg2OjNERjFCRTo0M0EyMjQ6NUYxOUZFOjY5ODBEQjdDIiwidmlzaXRvcl9pZCI6Ijc3MjI5MjE3NTIwMjM1ODc3MDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | e93b91edb31c12abd499ea2192b89bc2edff5dbdfcbbeeda9d3211979bac6c86 |
| hovercard-subject-tag | issue:999541071 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/OpenMap-java/openmap/55/issue_layout |
| twitter:image | https://opengraph.githubassets.com/6929e558380f047dfddeddaf3793057a74c5a7119d85baee18a1085e1bb30ca4/OpenMap-java/openmap/issues/55 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6929e558380f047dfddeddaf3793057a74c5a7119d85baee18a1085e1bb30ca4/OpenMap-java/openmap/issues/55 |
| og:image:alt | In the OMList.doAction() method the OMGraphicConstants.LOWER_TO_BOTTOM_GRAPHIC_MASK action calls the moveIndexedOneToBottom() method instead of moveIndexedToBottom(). Both OMGraphicConstants.LOWER_... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jose-m-torres |
| hostname | github.com |
| expected-hostname | github.com |
| None | 17bc0924c8593587ed4a8ae12c6076d0895c5516aaa44daccbb68ede54878b1f |
| turbo-cache-control | no-preview |
| go-import | github.com/OpenMap-java/openmap git https://github.com/OpenMap-java/openmap.git |
| octolytics-dimension-user_id | 13439710 |
| octolytics-dimension-user_login | OpenMap-java |
| octolytics-dimension-repository_id | 40129738 |
| octolytics-dimension-repository_nwo | OpenMap-java/openmap |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 40129738 |
| octolytics-dimension-repository_network_root_nwo | OpenMap-java/openmap |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 602fb6e6fec65cf4baabc1305db1830bc609c154 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width