René's URL Explorer Experiment


Title: fix: Cannot reattach ActivatedRouteSnapshot created from a different … by edusperoni · Pull Request #2279 · NativeScript/nativescript-angular · GitHub

Open Graph Title: fix: Cannot reattach ActivatedRouteSnapshot created from a different … by edusperoni · Pull Request #2279 · NativeScript/nativescript-angular

X Title: fix: Cannot reattach ActivatedRouteSnapshot created from a different … by edusperoni · Pull Request #2279 · NativeScript/nativescript-angular

Description: …route PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/nativescript-angular/blob/master/DevelopmentWorkflow.md#running-the-tests Tests for the changes are included. What is the current behavior? Navigating between sibling routes may sometimes mess with the cache due to it using the key of a parent route, instead of the complete route. What is the new behavior? This now uses the correct key from the farthest children of the route PARTIALLY Fixes #1993. (this issue has 2 problems on it: 1 is the one fixed in this PR, the other is that route guard/resolvers don't work on back navigation and may break navigation for a PRO)

Open Graph Description: …route PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this P...

X Description: …route PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this P...

Opengraph URL: https://github.com/NativeScript/nativescript-angular/pull/2279

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/:user_id/:repository/pull/:id/checks(.:format)
route-controllerpull_requests
route-actionchecks
fetch-noncev2:c9ae41ab-8341-df0e-3e56-9ee8d004ae74
current-catalog-service-hash87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a
request-id9916:3DCC68:1D7B3D8:25F0B2F:6974A073
html-safe-nonce80a5ecb393c3df6942ccff219d0a0381f21aae5e9ac710c1f8302fdd622dad4f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTE2OjNEQ0M2ODoxRDdCM0Q4OjI1RjBCMkY6Njk3NEEwNzMiLCJ2aXNpdG9yX2lkIjoiODUzMTEyOTk1NDU0Njc4NjQxOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac939a6c41902623c62348fc868cefc314aa4dc63288773dc851590fb9812831f6
hovercard-subject-tagpull_request:506103161
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/checks
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/nativescript-angular/pull/2279/checks
twitter:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
og:image:alt…route PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this P...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4a4bf5f4e28041a9d2e5c107d7d20b78b4294ba261cab243b28167c16a623a1f
turbo-cache-controlno-preview
go-importgithub.com/NativeScript/nativescript-angular git https://github.com/NativeScript/nativescript-angular.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id35951404
octolytics-dimension-repository_nwoNativeScript/nativescript-angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id35951404
octolytics-dimension-repository_network_root_nwoNativeScript/nativescript-angular
turbo-body-classeslogged-out env-production page-responsive full-width full-width-p-0
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release488b30e96dfd057fbbe44c6665ccbc030b729dde
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/NativeScript/nativescript-angular/pull/2279/checks#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-angular%2Fpull%2F2279%2Fchecks
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-angular%2Fpull%2F2279%2Fchecks
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fchecks&source=header-repo&source_repo=NativeScript%2Fnativescript-angular
Reloadhttps://patch-diff.githubusercontent.com/NativeScript/nativescript-angular/pull/2279/checks
Reloadhttps://patch-diff.githubusercontent.com/NativeScript/nativescript-angular/pull/2279/checks
Reloadhttps://patch-diff.githubusercontent.com/NativeScript/nativescript-angular/pull/2279/checks
NativeScript https://patch-diff.githubusercontent.com/NativeScript
nativescript-angularhttps://patch-diff.githubusercontent.com/NativeScript/nativescript-angular
Please reload this pagehttps://patch-diff.githubusercontent.com/NativeScript/nativescript-angular/pull/2279/checks
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2FNativeScript%2Fnativescript-angular
Fork 240 https://patch-diff.githubusercontent.com/login?return_to=%2FNativeScript%2Fnativescript-angular
Star 1.2k https://patch-diff.githubusercontent.com/login?return_to=%2FNativeScript%2Fnativescript-angular
Code https://patch-diff.githubusercontent.com/NativeScript/nativescript-angular
Issues 294 https://patch-diff.githubusercontent.com/NativeScript/nativescript-angular/issues
Pull requests 2 https://patch-diff.githubusercontent.com/NativeScript/nativescript-angular/pulls
Actions https://patch-diff.githubusercontent.com/NativeScript/nativescript-angular/actions
Security 0 https://patch-diff.githubusercontent.com/NativeScript/nativescript-angular/security
Insights https://patch-diff.githubusercontent.com/NativeScript/nativescript-angular/pulse
Code https://patch-diff.githubusercontent.com/NativeScript/nativescript-angular
Issues https://patch-diff.githubusercontent.com/NativeScript/nativescript-angular/issues
Pull requests https://patch-diff.githubusercontent.com/NativeScript/nativescript-angular/pulls
Actions https://patch-diff.githubusercontent.com/NativeScript/nativescript-angular/actions
Security https://patch-diff.githubusercontent.com/NativeScript/nativescript-angular/security
Insights https://patch-diff.githubusercontent.com/NativeScript/nativescript-angular/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2FNativeScript%2Fnativescript-angular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2FNativeScript%2Fnativescript-angular%2Fissues%2Fnew%2Fchoose
edusperonihttps://patch-diff.githubusercontent.com/edusperoni
NativeScript:masterhttps://patch-diff.githubusercontent.com/NativeScript/nativescript-angular/tree/master
edusperoni:activated-route-fixhttps://patch-diff.githubusercontent.com/edusperoni/nativescript-angular/tree/activated-route-fix
Conversation 2 https://patch-diff.githubusercontent.com/NativeScript/nativescript-angular/pull/2279
Commits 1 https://patch-diff.githubusercontent.com/NativeScript/nativescript-angular/pull/2279/commits
Checks 0 https://patch-diff.githubusercontent.com/NativeScript/nativescript-angular/pull/2279/checks
Files changed 1 https://patch-diff.githubusercontent.com/NativeScript/nativescript-angular/pull/2279/files
Please reload this pagehttps://patch-diff.githubusercontent.com/NativeScript/nativescript-angular/pull/2279/checks
fix: Cannot reattach ActivatedRouteSnapshot created from a different … https://patch-diff.githubusercontent.com/NativeScript/nativescript-angular/pull/2279/checks#top
Please reload this pagehttps://patch-diff.githubusercontent.com/NativeScript/nativescript-angular/pull/2279/checks
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.