Title: fix: Cannot reattach ActivatedRouteSnapshot created from a different … by edusperoni · Pull Request #2279 · NativeScript/nativescript-angular · GitHub
Open Graph Title: fix: Cannot reattach ActivatedRouteSnapshot created from a different … by edusperoni · Pull Request #2279 · NativeScript/nativescript-angular
X Title: fix: Cannot reattach ActivatedRouteSnapshot created from a different … by edusperoni · Pull Request #2279 · NativeScript/nativescript-angular
Description: …route PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/nativescript-angular/blob/master/DevelopmentWorkflow.md#running-the-tests Tests for the changes are included. What is the current behavior? Navigating between sibling routes may sometimes mess with the cache due to it using the key of a parent route, instead of the complete route. What is the new behavior? This now uses the correct key from the farthest children of the route PARTIALLY Fixes #1993. (this issue has 2 problems on it: 1 is the one fixed in this PR, the other is that route guard/resolvers don't work on back navigation and may break navigation for a PRO)
Open Graph Description: …route PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this P...
X Description: …route PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this P...
Opengraph URL: https://github.com/NativeScript/nativescript-angular/pull/2279
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:c9ae41ab-8341-df0e-3e56-9ee8d004ae74 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | 9916:3DCC68:1D7B3D8:25F0B2F:6974A073 |
| html-safe-nonce | 80a5ecb393c3df6942ccff219d0a0381f21aae5e9ac710c1f8302fdd622dad4f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTE2OjNEQ0M2ODoxRDdCM0Q4OjI1RjBCMkY6Njk3NEEwNzMiLCJ2aXNpdG9yX2lkIjoiODUzMTEyOTk1NDU0Njc4NjQxOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 939a6c41902623c62348fc868cefc314aa4dc63288773dc851590fb9812831f6 |
| hovercard-subject-tag | pull_request:506103161 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/NativeScript/nativescript-angular/pull/2279/checks |
| twitter:image | https://avatars.githubusercontent.com/u/4061767?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/4061767?s=400&v=4 |
| og:image:alt | …route PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this P... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4a4bf5f4e28041a9d2e5c107d7d20b78b4294ba261cab243b28167c16a623a1f |
| turbo-cache-control | no-preview |
| go-import | github.com/NativeScript/nativescript-angular git https://github.com/NativeScript/nativescript-angular.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 35951404 |
| octolytics-dimension-repository_nwo | NativeScript/nativescript-angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 35951404 |
| octolytics-dimension-repository_network_root_nwo | NativeScript/nativescript-angular |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 488b30e96dfd057fbbe44c6665ccbc030b729dde |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width