Title: Fix actionbar insets by vardhan30016 · Pull Request #10960 · NativeScript/NativeScript · GitHub
Open Graph Title: Fix actionbar insets by vardhan30016 · Pull Request #10960 · NativeScript/NativeScript
X Title: Fix actionbar insets by vardhan30016 · Pull Request #10960 · NativeScript/NativeScript
Description: PR Checklist The PR title follows the commit guidelines. There is an issue for the bug this PR is fixing (#10856). I have signed the CLA. All existing tests are passing. Tests for the changes can be added if required. What is the current behavior? On newer Android versions (API 29+), especially Android 14–16 (edge-to-edge navigation), the ActionBar is rendered under the status bar. This causes the ActionBar title, menu items, and navigation button to overlap with the system status bar. This is due to Toolbar not applying WindowInsets top padding on newer Android layouts. Related issue: #10856 What is the new behavior? During createNativeView() on Android: The Toolbar now enables setFitsSystemWindows(true) for correct inset handling. A OnApplyWindowInsetsListener is attached to read the top system inset. The inset value is applied as top padding to the ActionBar. Logic is wrapped in try/catch for safety and backward compatibility. This ensures the ActionBar is correctly positioned below the status bar on all Android versions. Fixes #10856. BREAKING CHANGES None. This patch does not modify public APIs or change behavior for older Android versions. It only resolves layout misalignment under edge-to-edge mode on Android 10+.
Open Graph Description: PR Checklist The PR title follows the commit guidelines. There is an issue for the bug this PR is fixing (#10856). I have signed the CLA. All existing tests are passing. Tests for the changes...
X Description: PR Checklist The PR title follows the commit guidelines. There is an issue for the bug this PR is fixing (#10856). I have signed the CLA. All existing tests are passing. Tests for the changes...
Opengraph URL: https://github.com/NativeScript/NativeScript/pull/10960
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:6a2d6685-2e6d-3e9d-6ed3-40b5e8afb092 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8DD8:34DEC:19C06A6:24018DC:6970DD8B |
| html-safe-nonce | c44cb5b49a582088bb4b22cdf5003ad8c0d32d4b619c11a41e4267acd1b32a9e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4REQ4OjM0REVDOjE5QzA2QTY6MjQwMThEQzo2OTcwREQ4QiIsInZpc2l0b3JfaWQiOiI2OTY3NTM4NTg0OTI3NjU3MzU1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 7e82ae2b148e00b272076a9796a8d969c6e4e5237d11a01ee025bfaed546fcae |
| hovercard-subject-tag | pull_request:3038487904 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/10960/files |
| twitter:image | https://avatars.githubusercontent.com/u/221947958?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/221947958?s=400&v=4 |
| og:image:alt | PR Checklist The PR title follows the commit guidelines. There is an issue for the bug this PR is fixing (#10856). I have signed the CLA. All existing tests are passing. Tests for the changes... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9203e7efc62065329c3b7015a1e6d16fc14bce440abec7b0d3cbe9e4fb1e2e4 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 31492490 |
| octolytics-dimension-repository_nwo | NativeScript/NativeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 31492490 |
| octolytics-dimension-repository_network_root_nwo | NativeScript/NativeScript |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | eb3c92b74ae48a78cffd8700b8eb5f60bad61528 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width