Title: fix(android): handle width and height as strings in ImageAsset options by thearnabsaha · Pull Request #10728 · NativeScript/NativeScript · GitHub
Open Graph Title: fix(android): handle width and height as strings in ImageAsset options by thearnabsaha · Pull Request #10728 · NativeScript/NativeScript
X Title: fix(android): handle width and height as strings in ImageAsset options by thearnabsaha · Pull Request #10728 · NativeScript/NativeScript
Description: PR Checklist There is an issue for the bug/feature this PR is for: #10668 I have signed the CLA. All existing tests are passing. What is the current behavior? When ImageAsset.options.width and options.height are provided as strings (e.g., "300"), the Android implementation crashes. The method loadImageAsync expects numeric values for dimensions, but receives a stringified version, causing an exception and breaking image loading. What is the new behavior? Explicitly parses options.width and options.height using parseInt(). Prevents crashes when developers provide string values. Defaults to Screen.mainScreen.widthPixels and heightPixels when parsing fails. Adds resilience to the image loading logic and improves developer experience. Fixes #10668 Additional Notes This update resolves a breaking bug that affected multiple NativeScript users. Validated across devices with both numeric and string values. PR tested manually; guidance requested to add or locate proper unit tests for ImageAsset.
Open Graph Description: PR Checklist There is an issue for the bug/feature this PR is for: #10668 I have signed the CLA. All existing tests are passing. What is the current behavior? When ImageAsset.options.width an...
X Description: PR Checklist There is an issue for the bug/feature this PR is for: #10668 I have signed the CLA. All existing tests are passing. What is the current behavior? When ImageAsset.options.width an...
Opengraph URL: https://github.com/NativeScript/NativeScript/pull/10728
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f6e5c5ae-5c8a-0fa0-0cc2-aade2528c7a7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9F58:CF8F9:D989EA:12DCB6B:696F3996 |
| html-safe-nonce | ddd1e2f78364da09389267beeb1f748997defd64b16a1e0fd1d41d87c771e828 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjU4OkNGOEY5OkQ5ODlFQToxMkRDQjZCOjY5NkYzOTk2IiwidmlzaXRvcl9pZCI6IjgxODk4NjMzOTM3ODMzOTY3NTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 424c96a35dff411855e0db2d2f234cdeefdee3cf4e48bcd07cbe869f1f6650f2 |
| hovercard-subject-tag | pull_request:2450664084 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/10728/files |
| twitter:image | https://avatars.githubusercontent.com/u/68840187?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/68840187?s=400&v=4 |
| og:image:alt | PR Checklist There is an issue for the bug/feature this PR is for: #10668 I have signed the CLA. All existing tests are passing. What is the current behavior? When ImageAsset.options.width an... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b278ad162d35332b6de714dfb005de04386c4d92df6475522bef910f491a35ee |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 31492490 |
| octolytics-dimension-repository_nwo | NativeScript/NativeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 31492490 |
| octolytics-dimension-repository_network_root_nwo | NativeScript/NativeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 39aed5006635ab6f45e6b77d23e73b08a00272a3 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width