René's URL Explorer Experiment


Title: fix(android): Setting String Value to Width And Height by db-r-hashimoto · Pull Request #10668 · NativeScript/NativeScript · GitHub

Open Graph Title: fix(android): Setting String Value to Width And Height by db-r-hashimoto · Pull Request #10668 · NativeScript/NativeScript

X Title: fix(android): Setting String Value to Width And Height by db-r-hashimoto · Pull Request #10668 · NativeScript/NativeScript

Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application. Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md. What is the current behavior? Currently, when a string value is assigned to the width or height property of ImageAssetOptions, an error occurs on Android. This issue prevents users from specifying these properties as strings, which can be problematic in scenarios where string-based dimensions are used. What is the new behavior? With this update, assigning a string value to the width or height property of ImageAssetOptions no longer results in an error on Android. The system now properly handles string-based dimensions, providing a more flexible and consistent experience for users. Fixes/Implements/Closes #6289 .

Open Graph Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...

X Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...

Opengraph URL: https://github.com/NativeScript/NativeScript/pull/10668

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5d510cf9-a3c3-684f-009c-b30374f03549
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id92BC:EF6F3:94028C9:C141FA0:696CF5A3
html-safe-nonce83294ce65d9f8c4a84b43c68c26fefbdb5f123ee34102c3bec2ccc114ca2cd68
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkJDOkVGNkYzOjk0MDI4Qzk6QzE0MUZBMDo2OTZDRjVBMyIsInZpc2l0b3JfaWQiOiI2NDU1MjE1NTQ1NjIyNzg3NDkyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace92ceadb132ef35861dc1f73a0df24371a457b66ddf194b063931f38d2ecf61d
hovercard-subject-tagpull_request:2283195691
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/10668/files
twitter:imagehttps://avatars.githubusercontent.com/u/110803648?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/110803648?s=400&v=4
og:image:altPR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None31994babd8463b50f2371f63aab0826561f4efe3981ac0ebc4c33e6c41032dbd
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id31492490
octolytics-dimension-repository_nwoNativeScript/NativeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31492490
octolytics-dimension-repository_network_root_nwoNativeScript/NativeScript
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef5a202c3c4aefc9cf00c8c78951a1e72eaebebeb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/files#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F10668%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F10668%2Ffiles
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2FNativeScript
Reloadhttps://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/files
Reloadhttps://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/files
Reloadhttps://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/files
NativeScript https://patch-diff.githubusercontent.com/NativeScript
NativeScripthttps://patch-diff.githubusercontent.com/NativeScript/NativeScript
Please reload this pagehttps://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/files
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2FNativeScript%2FNativeScript
Fork 1.7k https://patch-diff.githubusercontent.com/login?return_to=%2FNativeScript%2FNativeScript
Star 25.4k https://patch-diff.githubusercontent.com/login?return_to=%2FNativeScript%2FNativeScript
Code https://patch-diff.githubusercontent.com/NativeScript/NativeScript
Issues 868 https://patch-diff.githubusercontent.com/NativeScript/NativeScript/issues
Pull requests 59 https://patch-diff.githubusercontent.com/NativeScript/NativeScript/pulls
Discussions https://patch-diff.githubusercontent.com/NativeScript/NativeScript/discussions
Actions https://patch-diff.githubusercontent.com/NativeScript/NativeScript/actions
Projects 0 https://patch-diff.githubusercontent.com/NativeScript/NativeScript/projects
Wiki https://patch-diff.githubusercontent.com/NativeScript/NativeScript/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/NativeScript/NativeScript/security
Please reload this pagehttps://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/files
Insights https://patch-diff.githubusercontent.com/NativeScript/NativeScript/pulse
Code https://patch-diff.githubusercontent.com/NativeScript/NativeScript
Issues https://patch-diff.githubusercontent.com/NativeScript/NativeScript/issues
Pull requests https://patch-diff.githubusercontent.com/NativeScript/NativeScript/pulls
Discussions https://patch-diff.githubusercontent.com/NativeScript/NativeScript/discussions
Actions https://patch-diff.githubusercontent.com/NativeScript/NativeScript/actions
Projects https://patch-diff.githubusercontent.com/NativeScript/NativeScript/projects
Wiki https://patch-diff.githubusercontent.com/NativeScript/NativeScript/wiki
Security https://patch-diff.githubusercontent.com/NativeScript/NativeScript/security
Insights https://patch-diff.githubusercontent.com/NativeScript/NativeScript/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
db-r-hashimotohttps://patch-diff.githubusercontent.com/db-r-hashimoto
NativeScript:mainhttps://patch-diff.githubusercontent.com/NativeScript/NativeScript/tree/main
db-r-hashimoto:setting-string-value-width-heighthttps://patch-diff.githubusercontent.com/db-r-hashimoto/NativeScript/tree/setting-string-value-width-height
Conversation 2 https://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668
Commits 2 https://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/commits
Checks 0 https://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/checks
Files changed 4 https://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/files
fix(android): Setting String Value to Width And Height https://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/files#top
Show all changes 2 commits https://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/files
89ed02a fix(android): Setting String Value to Width And Height db-r-hashimoto Jan 17, 2025 https://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/commits/89ed02a43c85223add1403119a23b4ddeb514cd0
12ba676 fix to single quote db-r-hashimoto Jan 17, 2025 https://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/commits/12ba676fd920e36b3d898b323c93df9e10d69756
Clear filters https://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/files
Please reload this pagehttps://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/files
Please reload this pagehttps://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/files
image-asset-common.ts https://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/files#diff-c5c2ab10ee82ba1a5ccfe8f7a4ce6f9ef5b0fd32f9787b3bf3fc0c73b42ccec6
index.android.ts https://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/files#diff-91babf51b7ba0214e2c86320cd3179c8b57560966c76827ca9ddccdd695798aa
index.d.ts https://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/files#diff-bc213610a1de85faa9960f163c3203dd57d6465ff71af4f882cc34c3d43abed7
index.ios.ts https://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/files#diff-a47b0a5afed89cf011171d10a900b25c2fea82ebb520176ce6af42e77f7f4817
packages/core/image-asset/image-asset-common.tshttps://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/files#diff-c5c2ab10ee82ba1a5ccfe8f7a4ce6f9ef5b0fd32f9787b3bf3fc0c73b42ccec6
View file https://patch-diff.githubusercontent.com/NativeScript/NativeScript/blob/12ba676fd920e36b3d898b323c93df9e10d69756/packages/core/image-asset/image-asset-common.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/files#diff-c5c2ab10ee82ba1a5ccfe8f7a4ce6f9ef5b0fd32f9787b3bf3fc0c73b42ccec6
packages/core/image-asset/index.android.tshttps://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/files#diff-91babf51b7ba0214e2c86320cd3179c8b57560966c76827ca9ddccdd695798aa
View file https://patch-diff.githubusercontent.com/NativeScript/NativeScript/blob/12ba676fd920e36b3d898b323c93df9e10d69756/packages/core/image-asset/index.android.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/files#diff-91babf51b7ba0214e2c86320cd3179c8b57560966c76827ca9ddccdd695798aa
https://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/files#diff-91babf51b7ba0214e2c86320cd3179c8b57560966c76827ca9ddccdd695798aa
packages/core/image-asset/index.d.tshttps://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/files#diff-bc213610a1de85faa9960f163c3203dd57d6465ff71af4f882cc34c3d43abed7
View file https://patch-diff.githubusercontent.com/NativeScript/NativeScript/blob/12ba676fd920e36b3d898b323c93df9e10d69756/packages/core/image-asset/index.d.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/files#diff-bc213610a1de85faa9960f163c3203dd57d6465ff71af4f882cc34c3d43abed7
packages/core/image-asset/index.ios.tshttps://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/files#diff-a47b0a5afed89cf011171d10a900b25c2fea82ebb520176ce6af42e77f7f4817
View file https://patch-diff.githubusercontent.com/NativeScript/NativeScript/blob/12ba676fd920e36b3d898b323c93df9e10d69756/packages/core/image-asset/index.ios.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/files#diff-a47b0a5afed89cf011171d10a900b25c2fea82ebb520176ce6af42e77f7f4817
https://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/files#diff-a47b0a5afed89cf011171d10a900b25c2fea82ebb520176ce6af42e77f7f4817
https://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/files#diff-a47b0a5afed89cf011171d10a900b25c2fea82ebb520176ce6af42e77f7f4817
https://patch-diff.githubusercontent.com/NativeScript/NativeScript/pull/10668/files#diff-a47b0a5afed89cf011171d10a900b25c2fea82ebb520176ce6af42e77f7f4817
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.