| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2ce32825-8404-f649-2e82-85a5befec917 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DF38:CA7BC:A0641F0:D12C5BF:6975F551 |
| html-safe-nonce | b722a1d78522c5acb9c0bdffc94b70ba733e5a8728125184b0c220c835421c46 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjM4OkNBN0JDOkEwNjQxRjA6RDEyQzVCRjo2OTc1RjU1MSIsInZpc2l0b3JfaWQiOiI5MDE4Mjk4MDAxNzU5MDA4MDgxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | f44fd334c20a83a46b10ef7c4ca98d89e7343f329c0e901224030a6dfab642cb |
| hovercard-subject-tag | pull_request:770353137 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/NHSDigital/software-engineering-quality-framework/211/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5329c4e0936260e4041dcecfaf3fd0640b94e0c5f3214869bad2ce0bd13fa8f7/NHSDigital/software-engineering-quality-framework/pull/211 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5329c4e0936260e4041dcecfaf3fd0640b94e0c5f3214869bad2ce0bd13fa8f7/NHSDigital/software-engineering-quality-framework/pull/211 |
| og:image:alt | Feedback from bs-select team.
I've made the best-practices clearer.
I've pointed out the MAIN benefit of using sonar default rules is that they are auto-updated and ongoingly curated by the... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | dlavender4 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2bce766e7450b03e00b2fc5badd417927ce33a860e78cda3e4ecb9bbd1374cc6 |
| turbo-cache-control | no-preview |
| go-import | github.com/NHSDigital/software-engineering-quality-framework git https://github.com/NHSDigital/software-engineering-quality-framework.git |
| octolytics-dimension-user_id | 6683590 |
| octolytics-dimension-user_login | NHSDigital |
| octolytics-dimension-repository_id | 286510661 |
| octolytics-dimension-repository_nwo | NHSDigital/software-engineering-quality-framework |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 286510661 |
| octolytics-dimension-repository_network_root_nwo | NHSDigital/software-engineering-quality-framework |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | fcca2b8ef702b5f7f91427a6e920fa44446fe312 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FNHSDigital%2Fsoftware-engineering-quality-framework%2Fpull%2F211 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FNHSDigital%2Fsoftware-engineering-quality-framework%2Fpull%2F211 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=NHSDigital%2Fsoftware-engineering-quality-framework |
| Reload | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211 |
| Reload | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211 |
| Reload | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211 |
|
NHSDigital
| https://patch-diff.githubusercontent.com/NHSDigital |
| software-engineering-quality-framework | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2FNHSDigital%2Fsoftware-engineering-quality-framework |
|
Fork
41
| https://patch-diff.githubusercontent.com/login?return_to=%2FNHSDigital%2Fsoftware-engineering-quality-framework |
|
Star
179
| https://patch-diff.githubusercontent.com/login?return_to=%2FNHSDigital%2Fsoftware-engineering-quality-framework |
|
Code
| https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework |
|
Issues
54
| https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/issues |
|
Pull requests
15
| https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/actions |
|
Projects
0
| https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/projects |
|
Security
0
| https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/security |
|
Insights
| https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pulse |
|
Code
| https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework |
|
Issues
| https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/actions |
|
Projects
| https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/projects |
|
Security
| https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/security |
|
Insights
| https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pulse |
| Sign up for GitHub
| https://patch-diff.githubusercontent.com/signup?return_to=%2FNHSDigital%2Fsoftware-engineering-quality-framework%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://patch-diff.githubusercontent.com/login?return_to=%2FNHSDigital%2Fsoftware-engineering-quality-framework%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211#issue-comment-box |
| dlavender4 | https://patch-diff.githubusercontent.com/dlavender4 |
| main | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/tree/main |
| sonarqube_changes | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/tree/sonarqube_changes |
|
sonarqube benefits of default rules, and making best practices clearer
| https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211#top |
| dlavender4 | https://patch-diff.githubusercontent.com/dlavender4 |
| main | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/tree/main |
| sonarqube_changes | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/tree/sonarqube_changes |
|
Conversation
3
| https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211 |
|
Commits
6
| https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211/commits |
|
Checks
0
| https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211/checks |
|
Files changed
| https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211/files |
| Please reload this page | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211 |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/dlavender4 |
| dlavender4 | https://patch-diff.githubusercontent.com/dlavender4 |
| Nov 1, 2021 | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211#issue-1040974065 |
| Please reload this page | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211 |
|
| https://patch-diff.githubusercontent.com/dlavender4 |
| sonarqube benefits of default rules, and making best practices clearer | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211/commits/947c780c167bac84ee9e08747de040dfff2cd6ea |
| 947c780 | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211/commits/947c780c167bac84ee9e08747de040dfff2cd6ea |
| https://patch-diff.githubusercontent.com/dlavender4 |
| dlavender4 | https://patch-diff.githubusercontent.com/dlavender4 |
| andyblundell | https://patch-diff.githubusercontent.com/andyblundell |
| iw-ezequiel | https://patch-diff.githubusercontent.com/iw-ezequiel |
| snehal-vahule | https://patch-diff.githubusercontent.com/snehal-vahule |
| November 1, 2021 09:41 | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211#event-5547766471 |
| https://patch-diff.githubusercontent.com/iw-ezequiel |
| iw-ezequiel | https://patch-diff.githubusercontent.com/iw-ezequiel |
|
Nov 1, 2021
| https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211#pullrequestreview-794123795 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211/files/947c780c167bac84ee9e08747de040dfff2cd6ea |
| tools/sonarqube.md | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211/files/947c780c167bac84ee9e08747de040dfff2cd6ea#diff-2a419640a8ee0247a0b41aa8e6448517b39fb3faad4b70f3a2ba49bd29c6678f |
| iw-ezequiel | https://patch-diff.githubusercontent.com/iw-ezequiel |
| Nov 1, 2021 | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211#discussion_r740152678 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211 |
| tools/sonarqube.md | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211/files/947c780c167bac84ee9e08747de040dfff2cd6ea#diff-2a419640a8ee0247a0b41aa8e6448517b39fb3faad4b70f3a2ba49bd29c6678f |
| iw-ezequiel | https://patch-diff.githubusercontent.com/iw-ezequiel |
| Nov 1, 2021 | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211#discussion_r740155249 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211 |
| iw-ezequiel | https://patch-diff.githubusercontent.com/iw-ezequiel |
| November 1, 2021 11:54 | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211#commits-pushed-809da88 |
|
| https://patch-diff.githubusercontent.com/iw-ezequiel |
| Merge branch 'master' into sonarqube_changes | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211/commits/809da8868387c734e933aa97c5cea5df23229c38 |
| 809da88 | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211/commits/809da8868387c734e933aa97c5cea5df23229c38 |
|
| https://patch-diff.githubusercontent.com/andyblundell |
| Merge branch 'master' into sonarqube_changes | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211/commits/435b58690f8fd28e89346dca4cf608a23f8ca713 |
| 435b586 | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211/commits/435b58690f8fd28e89346dca4cf608a23f8ca713 |
|
| https://patch-diff.githubusercontent.com/andyblundell |
| Merge branch 'master' into sonarqube_changes | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211/commits/0d477db832e8be6311b8b28167c21b3a55ca9711 |
| 0d477db | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211/commits/0d477db832e8be6311b8b28167c21b3a55ca9711 |
|
| https://patch-diff.githubusercontent.com/andyblundell |
| Merge branch 'main' into sonarqube_changes | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211/commits/d82b528c0e5455b748778d62d4cd33b4d80bb3d8 |
| d82b528 | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211/commits/d82b528c0e5455b748778d62d4cd33b4d80bb3d8 |
| https://patch-diff.githubusercontent.com/andyblundell |
| andyblundell | https://patch-diff.githubusercontent.com/andyblundell |
| code owner | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/blob/287c320ca448ba31078a2510f5e20046c94345ff/.github/CODEOWNERS#L2 |
| November 9, 2021 14:20 | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211#event-5590089937 |
|
| https://patch-diff.githubusercontent.com/dlavender4 |
| Merge branch 'main' into sonarqube_changes | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211/commits/9abe36cdc6d6f54bd4ceb528d5060107f88cd319 |
| 9abe36c | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211/commits/9abe36cdc6d6f54bd4ceb528d5060107f88cd319 |
| https://patch-diff.githubusercontent.com/apps/sonarqubecloud |
| sonarqubecloud | https://patch-diff.githubusercontent.com/apps/sonarqubecloud |
| Jul 8, 2022 | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211#issuecomment-1179069521 |
| https://sonarcloud.io/dashboard?id=NHSDigital_software-engineering-quality-framework&pullRequest=211 |
| https://sonarcloud.io/project/issues?id=NHSDigital_software-engineering-quality-framework&pullRequest=211&resolved=false&types=BUG |
| https://sonarcloud.io/project/issues?id=NHSDigital_software-engineering-quality-framework&pullRequest=211&resolved=false&types=BUG |
| 0 Bugs | https://sonarcloud.io/project/issues?id=NHSDigital_software-engineering-quality-framework&pullRequest=211&resolved=false&types=BUG |
| https://sonarcloud.io/project/issues?id=NHSDigital_software-engineering-quality-framework&pullRequest=211&resolved=false&types=VULNERABILITY |
| https://sonarcloud.io/project/issues?id=NHSDigital_software-engineering-quality-framework&pullRequest=211&resolved=false&types=VULNERABILITY |
| 0 Vulnerabilities | https://sonarcloud.io/project/issues?id=NHSDigital_software-engineering-quality-framework&pullRequest=211&resolved=false&types=VULNERABILITY |
| https://sonarcloud.io/project/security_hotspots?id=NHSDigital_software-engineering-quality-framework&pullRequest=211&resolved=false&types=SECURITY_HOTSPOT |
| https://sonarcloud.io/project/security_hotspots?id=NHSDigital_software-engineering-quality-framework&pullRequest=211&resolved=false&types=SECURITY_HOTSPOT |
| 0 Security Hotspots | https://sonarcloud.io/project/security_hotspots?id=NHSDigital_software-engineering-quality-framework&pullRequest=211&resolved=false&types=SECURITY_HOTSPOT |
| https://sonarcloud.io/project/issues?id=NHSDigital_software-engineering-quality-framework&pullRequest=211&resolved=false&types=CODE_SMELL |
| https://sonarcloud.io/project/issues?id=NHSDigital_software-engineering-quality-framework&pullRequest=211&resolved=false&types=CODE_SMELL |
| 0 Code Smells | https://sonarcloud.io/project/issues?id=NHSDigital_software-engineering-quality-framework&pullRequest=211&resolved=false&types=CODE_SMELL |
| https://sonarcloud.io/component_measures?id=NHSDigital_software-engineering-quality-framework&pullRequest=211 |
| https://sonarcloud.io/component_measures?id=NHSDigital_software-engineering-quality-framework&pullRequest=211&metric=duplicated_lines_density&view=list |
| Please reload this page | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211 |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in to comment | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FNHSDigital%2Fsoftware-engineering-quality-framework%2Fpull%2F211 |
|
| https://patch-diff.githubusercontent.com/snehal-vahule |
|
snehal-vahule
| https://patch-diff.githubusercontent.com/snehal-vahule |
|
| https://patch-diff.githubusercontent.com/andyblundell |
|
andyblundell
| https://patch-diff.githubusercontent.com/andyblundell |
|
| https://patch-diff.githubusercontent.com/iw-ezequiel |
|
iw-ezequiel
| https://patch-diff.githubusercontent.com/iw-ezequiel |
|
| https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211/files/947c780c167bac84ee9e08747de040dfff2cd6ea |
| Please reload this page | https://patch-diff.githubusercontent.com/NHSDigital/software-engineering-quality-framework/pull/211 |
|
| https://patch-diff.githubusercontent.com/dlavender4 |
|
| https://patch-diff.githubusercontent.com/iw-ezequiel |
|
| https://patch-diff.githubusercontent.com/andyblundell |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |