Title: Undefined dataset on language select in Settings-Screen · Issue #176 · Monogatari/Monogatari · GitHub
Open Graph Title: Undefined dataset on language select in Settings-Screen · Issue #176 · Monogatari/Monogatari
X Title: Undefined dataset on language select in Settings-Screen · Issue #176 · Monogatari/Monogatari
Description: When clicking on the arrow-icon [data-select="set-language"] of the language selection dropdown the action will break with: Uncaught TypeError: t.dataset is undefined The erroneous code is this piece right here: // Fix for select labels ...
Open Graph Description: When clicking on the arrow-icon [data-select="set-language"] of the language selection dropdown the action will break with: Uncaught TypeError: t.dataset is undefined The erroneous code is this pie...
X Description: When clicking on the arrow-icon [data-select="set-language"] of the language selection dropdown the action will break with: Uncaught TypeError: t.dataset is undefined The erroneous code i...
Opengraph URL: https://github.com/Monogatari/Monogatari/issues/176
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Undefined dataset on language select in Settings-Screen","articleBody":"When clicking on the arrow-icon `[data-select=\"set-language\"]` of the language selection dropdown the action will break with:\r\n\r\n\u003e Uncaught TypeError: t.dataset is undefined\r\n\r\nThe erroneous code is [this piece](https://github.com/Monogatari/Monogatari/blob/develop/src/components/settings-screen/index.js#L11C50-L11C69) right here:\r\n```js\r\n// Fix for select labels\r\nthis.engine.on ('click', '[data-select]', () =\u003e {\r\n\tconst e = document.createEvent ('MouseEvents');\r\n\te.initMouseEvent ('mousedown');\r\n\tthis.engine.element ().find (`[data-action='${this.dataset.select}']`).first ().dispatchEvent (e);\r\n});\r\n```\r\nI'm guessing that the `this` inside the arrow function does not refer to the actual HTMLElement of the icon.","author":{"url":"https://github.com/JulianSchoenbaechler","@type":"Person","name":"JulianSchoenbaechler"},"datePublished":"2024-01-11T13:15:10.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/176/Monogatari/issues/176"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:c744c393-3827-bbc8-7784-0b5eb6a57c76 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D5F6:6E05D:196D2D8:217658D:6992CA81 |
| html-safe-nonce | 159cab203bdec8942772a9da5d1486886ce8d780b556c17622b496655dd7218c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENUY2OjZFMDVEOjE5NkQyRDg6MjE3NjU4RDo2OTkyQ0E4MSIsInZpc2l0b3JfaWQiOiI0Mjg4MjM3NDU3NjgwNTUwNTI5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 39c679d9de9fa080f0ce180ea5dace5d57cd91aa2c2da32839cc7f28b5d8b07a |
| hovercard-subject-tag | issue:2076624351 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/Monogatari/Monogatari/176/issue_layout |
| twitter:image | https://opengraph.githubassets.com/1a8fd30a9e3d9a18d868150ba2fedf1b1b94e8ea8aa667e6cfe5eb38ecaac8a7/Monogatari/Monogatari/issues/176 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1a8fd30a9e3d9a18d868150ba2fedf1b1b94e8ea8aa667e6cfe5eb38ecaac8a7/Monogatari/Monogatari/issues/176 |
| og:image:alt | When clicking on the arrow-icon [data-select="set-language"] of the language selection dropdown the action will break with: Uncaught TypeError: t.dataset is undefined The erroneous code is this pie... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | JulianSchoenbaechler |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-preview |
| go-import | github.com/Monogatari/Monogatari git https://github.com/Monogatari/Monogatari.git |
| octolytics-dimension-user_id | 29076049 |
| octolytics-dimension-user_login | Monogatari |
| octolytics-dimension-repository_id | 37935886 |
| octolytics-dimension-repository_nwo | Monogatari/Monogatari |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 37935886 |
| octolytics-dimension-repository_network_root_nwo | Monogatari/Monogatari |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 84dcb133269e3cfe6e0296cc85fbacb92cae92bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width