René's URL Explorer Experiment


Title: Migrate to ICU by dickermoshe · Pull Request #249 · KosherJava/zmanim · GitHub

Open Graph Title: Migrate to ICU by dickermoshe · Pull Request #249 · KosherJava/zmanim

X Title: Migrate to ICU by dickermoshe · Pull Request #249 · KosherJava/zmanim

Description: This is only being used for comparative purposed and should no be merged or reviewed

Open Graph Description: This is only being used for comparative purposed and should no be merged or reviewed

X Description: This is only being used for comparative purposed and should no be merged or reviewed

Opengraph URL: https://github.com/KosherJava/zmanim/pull/249

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b08e72e7-e743-884b-45b9-a4126e21a245
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB53E:3DC7CC:6572F9:8773B9:697BEC4E
html-safe-nonce09d1fef51d9e3e206566c73bb2bdd21d34b37812abf456a56f328bddc6049136
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTNFOjNEQzdDQzo2NTcyRjk6ODc3M0I5OjY5N0JFQzRFIiwidmlzaXRvcl9pZCI6IjM2OTcyODA1OTgwNDYxNDE1MTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca6e0574693f4f39db8204cff1a1ded005d2031d725cb23905d6728c7ea4b9784
hovercard-subject-tagpull_request:3100678178
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/KosherJava/zmanim/249/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a7df73196395bfa39d9be25d8c1978e80d7bf5ab708733ea28522936ee507d4a/KosherJava/zmanim/pull/249
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a7df73196395bfa39d9be25d8c1978e80d7bf5ab708733ea28522936ee507d4a/KosherJava/zmanim/pull/249
og:image:altThis is only being used for comparative purposed and should no be merged or reviewed
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedickermoshe
hostnamegithub.com
expected-hostnamegithub.com
Noneda4f0ee56809799586f8ee546b27f94fe9b5893edfbf87732e82be45be013b52
turbo-cache-controlno-preview
go-importgithub.com/KosherJava/zmanim git https://github.com/KosherJava/zmanim.git
octolytics-dimension-user_id6101129
octolytics-dimension-user_loginKosherJava
octolytics-dimension-repository_id41635214
octolytics-dimension-repository_nwoKosherJava/zmanim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id41635214
octolytics-dimension-repository_network_root_nwoKosherJava/zmanim
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1491f56585cd699a89b9580003a35ac0ae1ea3af
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FKosherJava%2Fzmanim%2Fpull%2F249
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FKosherJava%2Fzmanim%2Fpull%2F249
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=KosherJava%2Fzmanim
Reloadhttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249
Reloadhttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249
Reloadhttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249
KosherJava https://patch-diff.githubusercontent.com/KosherJava
zmanimhttps://patch-diff.githubusercontent.com/KosherJava/zmanim
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2FKosherJava%2Fzmanim
Fork 54 https://patch-diff.githubusercontent.com/login?return_to=%2FKosherJava%2Fzmanim
Star 121 https://patch-diff.githubusercontent.com/login?return_to=%2FKosherJava%2Fzmanim
Code https://patch-diff.githubusercontent.com/KosherJava/zmanim
Issues 13 https://patch-diff.githubusercontent.com/KosherJava/zmanim/issues
Pull requests 16 https://patch-diff.githubusercontent.com/KosherJava/zmanim/pulls
Actions https://patch-diff.githubusercontent.com/KosherJava/zmanim/actions
Projects 0 https://patch-diff.githubusercontent.com/KosherJava/zmanim/projects
Security 0 https://patch-diff.githubusercontent.com/KosherJava/zmanim/security
Insights https://patch-diff.githubusercontent.com/KosherJava/zmanim/pulse
Code https://patch-diff.githubusercontent.com/KosherJava/zmanim
Issues https://patch-diff.githubusercontent.com/KosherJava/zmanim/issues
Pull requests https://patch-diff.githubusercontent.com/KosherJava/zmanim/pulls
Actions https://patch-diff.githubusercontent.com/KosherJava/zmanim/actions
Projects https://patch-diff.githubusercontent.com/KosherJava/zmanim/projects
Security https://patch-diff.githubusercontent.com/KosherJava/zmanim/security
Insights https://patch-diff.githubusercontent.com/KosherJava/zmanim/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2FKosherJava%2Fzmanim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2FKosherJava%2Fzmanim%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249#issue-comment-box
dickermoshehttps://patch-diff.githubusercontent.com/dickermoshe
KosherJava:masterhttps://patch-diff.githubusercontent.com/KosherJava/zmanim/tree/master
dickermoshe:icuhttps://patch-diff.githubusercontent.com/dickermoshe/zmanim/tree/icu
Migrate to ICU https://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249#top
dickermoshehttps://patch-diff.githubusercontent.com/dickermoshe
KosherJava:masterhttps://patch-diff.githubusercontent.com/KosherJava/zmanim/tree/master
dickermoshe:icuhttps://patch-diff.githubusercontent.com/dickermoshe/zmanim/tree/icu
Conversation 0 https://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249
Commits 17 https://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits
Checks 0 https://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/checks
Files changed https://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/files
Please reload this pagehttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/dickermoshe
dickermoshehttps://patch-diff.githubusercontent.com/dickermoshe
Dec 15, 2025https://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249#issue-3728372513
Please reload this pagehttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249
dickermoshehttps://patch-diff.githubusercontent.com/dickermoshe
November 10, 2025 22:07https://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249#commits-pushed-4cf3bd7
https://patch-diff.githubusercontent.com/dickermoshe
improve naive timezone conversionhttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/4cf3bd7898347726f46f91b65f09c56a1f3c84c7
4cf3bd7https://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/4cf3bd7898347726f46f91b65f09c56a1f3c84c7
https://patch-diff.githubusercontent.com/dickermoshe
use java.time for improved accuracy for distant dateshttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/657b60c2528e4a48f4256baf9a4b81581b3f70c6
657b60chttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/657b60c2528e4a48f4256baf9a4b81581b3f70c6
https://patch-diff.githubusercontent.com/dickermoshe
additional java.time conversionshttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/05a983c6eba2f830178ffd886c1d5abb75024b97
05a983chttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/05a983c6eba2f830178ffd886c1d5abb75024b97
https://patch-diff.githubusercontent.com/dickermoshe
validate length of hebrew monthshttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/81e56cd62735593aa0148094e87efacfd8293e16
81e56cdhttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/81e56cd62735593aa0148094e87efacfd8293e16
https://patch-diff.githubusercontent.com/dickermoshe
apply offset correctlyhttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/f15204e1206460af9eaea058fef85a22ef174fe5
f15204ehttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/f15204e1206460af9eaea058fef85a22ef174fe5
https://patch-diff.githubusercontent.com/dickermoshe
fix null error in getMoladBasedTimehttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/931f23929b9f7839501cea545f131bb1df8b01b2
931f239https://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/931f23929b9f7839501cea545f131bb1df8b01b2
https://patch-diff.githubusercontent.com/dickermoshe
use UTC in yerushalmi calchttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/9b74e47b61176b4adf8733c7bc7c6be0c9f68859
9b74e47https://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/9b74e47b61176b4adf8733c7bc7c6be0c9f68859
https://patch-diff.githubusercontent.com/dickermoshe
fix missing importhttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/e4dc75550eb9bc524910c69e36d40e1bb8b2f8e9
e4dc755https://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/e4dc75550eb9bc524910c69e36d40e1bb8b2f8e9
https://patch-diff.githubusercontent.com/dickermoshe
some more yerushalmi changeshttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/0179cab599da53179bc8cbd13f0cbe36ead45f62
0179cabhttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/0179cab599da53179bc8cbd13f0cbe36ead45f62
https://patch-diff.githubusercontent.com/dickermoshe
Fix formatting and spacing in JewishCalendar.javahttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/07a6f0f9031b430a5fad79e0a63268be8d598863
07a6f0fhttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/07a6f0f9031b430a5fad79e0a63268be8d598863
https://patch-diff.githubusercontent.com/dickermoshe
fix yomi for transition datehttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/c944303966f10e7520fef986fa6f35d877b42de1
c944303https://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/c944303966f10e7520fef986fa6f35d877b42de1
https://patch-diff.githubusercontent.com/dickermoshe
check for valid dates with forwarding dateshttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/0f8f92bb18253cc428eb5520ac8d5cf8c847f144
0f8f92bhttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/0f8f92bb18253cc428eb5520ac8d5cf8c847f144
https://patch-diff.githubusercontent.com/dickermoshe
fix issue with daf yomi calculation on start datehttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/85130ca4b27ce8baaadcabe8cfcec217c2652fc4
85130cahttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/85130ca4b27ce8baaadcabe8cfcec217c2652fc4
https://patch-diff.githubusercontent.com/dickermoshe
Add ICUhttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/499f36d99460d2eda5b98f540fe27b6187b123ac
499f36dhttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/499f36d99460d2eda5b98f540fe27b6187b123ac
https://patch-diff.githubusercontent.com/dickermoshe
fix back a amonthhttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/81680949ffc001bb401917e0716a06d11099df9a
8168094https://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/81680949ffc001bb401917e0716a06d11099df9a
https://patch-diff.githubusercontent.com/dickermoshe
add morehttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/c9dc1be6df8f1a5663f6d97e2bd8edbfc970d846
c9dc1behttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/c9dc1be6df8f1a5663f6d97e2bd8edbfc970d846
https://patch-diff.githubusercontent.com/dickermoshe
do not apply day offset to lmt calchttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/3e14159862a795fbc3ef6cbeae426d42d4b26716
3e14159https://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249/commits/3e14159862a795fbc3ef6cbeae426d42d4b26716
https://patch-diff.githubusercontent.com/dickermoshe
dickermoshehttps://patch-diff.githubusercontent.com/dickermoshe
force-pushedhttps://patch-diff.githubusercontent.com/KosherJava/zmanim/compare/a5f1fea6c7bd03a7c477903ca970cdaba91aa227..3e14159862a795fbc3ef6cbeae426d42d4b26716
a5f1feahttps://patch-diff.githubusercontent.com/KosherJava/zmanim/commit/a5f1fea6c7bd03a7c477903ca970cdaba91aa227
3e14159https://patch-diff.githubusercontent.com/KosherJava/zmanim/commit/3e14159862a795fbc3ef6cbeae426d42d4b26716
Compare https://patch-diff.githubusercontent.com/KosherJava/zmanim/compare/a5f1fea6c7bd03a7c477903ca970cdaba91aa227..3e14159862a795fbc3ef6cbeae426d42d4b26716
January 18, 2026 16:47https://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249#event-22123080744
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FKosherJava%2Fzmanim%2Fpull%2F249
Please reload this pagehttps://patch-diff.githubusercontent.com/KosherJava/zmanim/pull/249
https://patch-diff.githubusercontent.com/dickermoshe
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.