Title: Flaw in logic? · Issue #211 · KosherJava/zmanim · GitHub
Open Graph Title: Flaw in logic? · Issue #211 · KosherJava/zmanim
X Title: Flaw in logic? · Issue #211 · KosherJava/zmanim
Description: Shouldn't this be >= instead of >? If 30 minutes is equal to the second zman, return 30 minutes (or the other zman, depending on how you look at it). Is this not semantically equivalent to Math.max()? zmanim/src/main/java/com/kosherjava/...
Open Graph Description: Shouldn't this be >= instead of >? If 30 minutes is equal to the second zman, return 30 minutes (or the other zman, depending on how you look at it). Is this not semantically equivalent to Math.max...
X Description: Shouldn't this be >= instead of >? If 30 minutes is equal to the second zman, return 30 minutes (or the other zman, depending on how you look at it). Is this not semantically equivalent t...
Opengraph URL: https://github.com/KosherJava/zmanim/issues/211
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Flaw in logic?","articleBody":"Shouldn't this be `\u003e=` instead of `\u003e`? If 30 minutes is equal to the second zman, return 30 minutes (or the other zman, depending on how you look at it). Is this not semantically equivalent to `Math.max()`? https://github.com/KosherJava/zmanim/blob/d24323b295779dd4922dccf418afc54e420e592a/src/main/java/com/kosherjava/zmanim/ComplexZmanimCalendar.java#L1860\r\n\r\nSame for this:\r\nhttps://github.com/KosherJava/zmanim/blob/d24323b295779dd4922dccf418afc54e420e592a/src/main/java/com/kosherjava/zmanim/ComplexZmanimCalendar.java#L4025","author":{"url":"https://github.com/Sternbach-Software","@type":"Person","name":"Sternbach-Software"},"datePublished":"2023-07-10T21:48:47.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/211/zmanim/issues/211"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:664ba4fa-d165-9bcb-9069-3d6a5ed96d45 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 943C:254F49:2A5602:39731B:697C69CF |
| html-safe-nonce | 8dfa14899d06e7503f316c91166e7a6028790a58466f44cdad8567d3247f19d3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDNDOjI1NEY0OToyQTU2MDI6Mzk3MzFCOjY5N0M2OUNGIiwidmlzaXRvcl9pZCI6Ijg2NzA5NDc2MzcwMDE0ODA2NTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | c28326454943d13158e2ae382170094fef7aa03bc85626a2a046d38cc468dfb2 |
| hovercard-subject-tag | issue:1797634063 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/KosherJava/zmanim/211/issue_layout |
| twitter:image | https://opengraph.githubassets.com/35d7d516cd8f093eb734d3854c2d946fa49e4fe7526a6d6c6609f437a6ba822d/KosherJava/zmanim/issues/211 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/35d7d516cd8f093eb734d3854c2d946fa49e4fe7526a6d6c6609f437a6ba822d/KosherJava/zmanim/issues/211 |
| og:image:alt | Shouldn't this be >= instead of >? If 30 minutes is equal to the second zman, return 30 minutes (or the other zman, depending on how you look at it). Is this not semantically equivalent to Math.max... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Sternbach-Software |
| hostname | github.com |
| expected-hostname | github.com |
| None | da4f0ee56809799586f8ee546b27f94fe9b5893edfbf87732e82be45be013b52 |
| turbo-cache-control | no-preview |
| go-import | github.com/KosherJava/zmanim git https://github.com/KosherJava/zmanim.git |
| octolytics-dimension-user_id | 6101129 |
| octolytics-dimension-user_login | KosherJava |
| octolytics-dimension-repository_id | 41635214 |
| octolytics-dimension-repository_nwo | KosherJava/zmanim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 41635214 |
| octolytics-dimension-repository_network_root_nwo | KosherJava/zmanim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 787d8d274e314f52ce6d846c7581f9476d8dc736 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width