Title: create docker image via CI by danthe1st · Pull Request #463 · Java-Discord/JavaBot · GitHub
Open Graph Title: create docker image via CI by danthe1st · Pull Request #463 · Java-Discord/JavaBot
X Title: create docker image via CI by danthe1st · Pull Request #463 · Java-Discord/JavaBot
Description: This PR creates a docker image using a Java 21 JRE automatically on commits to main. Specifically, it contains the following changes: Gradle and Lombok were updated to work with Java 21 (for a future update) The default CI script was changed to run on every branch A new CI script was added. This script builds a docker image that allows running the bot. The docker image can be executed like that (where USERNAME/REPONAME is the repository of the docker image, e.g. dan1st/javabot-test) docker run --rm -v "$PWD/config:/work/config" -v "$PWD/logs:/work/logs" -v "$PWD/db:/work/db" -v "$PWD/purgeArchives:/work/purgeArchives" -p 9000:9000 -p 9001:9001 USERNAME/REPONAME This command forwards both the HTTP and AJP port. Publishing the image to Docker Hub requires the following secrets to be present: DOCKERHUB_USERNAME: The username (or organization name) for Docker Hub, e.g. dan1st DOCKERHUB_REPONAME: The repository name for Docker Hub, e.g. javabot DOCKERHUB_TOKEN The Docker Hub token for uploading If DOCKERHUB_USERNAME is missing, the image will not be uploaded but the build should still work. For testing, a repository is available here. An example run can be found here Alternatives It would be possible to use one script for both verifying the build and uploading the Docker image and only build the image on the main branch. This way, there wouldn't be 2 similar scripts running on every push to main. This was implemented. It would be possible to require Java 21 for building. This can be done in a future PR. A different base image/JRE vendor could be used instead Eclipse Adoptium/Temurin. It would be possible to use GraalVM's native-image for a Docker image not requiring a JRE. This was not done due to it being pretty fragile in my experience/quite some work to maintain (I don't want to write more bugreports to Spring/etc. due to issues with that). It would be possible to use jlink to create the JRE. It may be a good idea to change server.address=127.0.0.1 to server.address=0.0.0.0 in the application.properties. See the merge notes. Merge notes - check before merging/deploying/using The branch main should be protected! Only PRs should be allowed. Make sure this is the case. This seems to be the case already. Using this requires changes to the deployment process. For example, it would be possible to execute docker pull USERNAME/REPONAME and the aforementioned docker run command in order to (re)start the bot This could be done every time the bot is stopped with /redeploy. This requires the DB to be located in a directory called db in the directory where the docker run command is executed. This requires moving the DB and changing the systems.json config. a full backup of the bot should be created before deploying! It might also be a good idea to automatically create a backup of the config and DB after every restart (or periodically) if this isn't done already. To make the API accessible, it is necessary to add an application.properties with the content server.address=0.0.0.0 to the config directory. Something similar may be necessary for AJP though it seems to be accessible from outside anyways. If AJP is used without requiring the HTTP endpoint, this is not necessary.
Open Graph Description: This PR creates a docker image using a Java 21 JRE automatically on commits to main. Specifically, it contains the following changes: Gradle and Lombok were updated to work with Java 21 (for a fut...
X Description: This PR creates a docker image using a Java 21 JRE automatically on commits to main. Specifically, it contains the following changes: Gradle and Lombok were updated to work with Java 21 (for a fut...
Opengraph URL: https://github.com/Java-Discord/JavaBot/pull/463
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:1e78705d-0dde-2703-f764-3b0793a3eb76 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CACA:3F5237:20A1C68:2CC84A6:69735B4F |
| html-safe-nonce | 61148e548e3d68d4f156bcc79518ec79b2e98ddaae4b280add1f33ba5e7cf125 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQUNBOjNGNTIzNzoyMEExQzY4OjJDQzg0QTY6Njk3MzVCNEYiLCJ2aXNpdG9yX2lkIjoiNDc5NTc0MzI0NDQ4NDA0MTU1MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 31ab2f83dbcec33dc52aa7c3d1618e9c54218e5a544594d90d77a757309a61fe |
| hovercard-subject-tag | pull_request:1660009577 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/Java-Discord/JavaBot/pull/463/files |
| twitter:image | https://avatars.githubusercontent.com/u/34687786?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/34687786?s=400&v=4 |
| og:image:alt | This PR creates a docker image using a Java 21 JRE automatically on commits to main. Specifically, it contains the following changes: Gradle and Lombok were updated to work with Java 21 (for a fut... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4cf879a11b0a28a85543899a36aaee9ec9ca2fb7bedad86c0da5731193c95f01 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/Java-Discord/JavaBot git https://github.com/Java-Discord/JavaBot.git |
| octolytics-dimension-user_id | 77415047 |
| octolytics-dimension-user_login | Java-Discord |
| octolytics-dimension-repository_id | 371822717 |
| octolytics-dimension-repository_nwo | Java-Discord/JavaBot |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 371822717 |
| octolytics-dimension-repository_network_root_nwo | Java-Discord/JavaBot |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | fe8be790582ef7a55477ce1918ac0ed16b106d31 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width