Title: Technical debt changes in indexing functions by ndgrigorian · Pull Request #2012 · IntelPython/dpctl · GitHub
Open Graph Title: Technical debt changes in indexing functions by ndgrigorian · Pull Request #2012 · IntelPython/dpctl
X Title: Technical debt changes in indexing functions by ndgrigorian · Pull Request #2012 · IntelPython/dpctl
Description: This PR cleans up indexing functions Renames Python bindings from usm_ndarray_take and usm_ndarray_put to py_take and py_put to improve consistency with the rest of dpctl Removes indexing mode macros, opting for a ternary check instead Refactors to break up _populate_kernel_params internal function to improve code readability [WIP] Have you provided a meaningful PR description? Have you added a test, reproducer or referred to an issue with a reproducer? Have you tested your changes locally for CPU and GPU devices? Have you made sure that new changes do not introduce compiler warnings? Have you checked performance impact of proposed changes? Have you added documentation for your changes, if necessary? Have you added your changes to the changelog? If this PR is a work in progress, are you opening the PR as a draft?
Open Graph Description: This PR cleans up indexing functions Renames Python bindings from usm_ndarray_take and usm_ndarray_put to py_take and py_put to improve consistency with the rest of dpctl Removes indexing mode mac...
X Description: This PR cleans up indexing functions Renames Python bindings from usm_ndarray_take and usm_ndarray_put to py_take and py_put to improve consistency with the rest of dpctl Removes indexing mode mac...
Opengraph URL: https://github.com/IntelPython/dpctl/pull/2012
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:06a865f1-545e-58e1-4631-c2835096f1d1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E4A8:F0B17:91C737:CDA8D4:696F3DFF |
| html-safe-nonce | 286013b022cc93731c0683132409e16d2e37c28819ce7e760b72f606428f1677 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNEE4OkYwQjE3OjkxQzczNzpDREE4RDQ6Njk2RjNERkYiLCJ2aXNpdG9yX2lkIjoiODExMDcyNTM0ODU4OTUxODMzNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 95eb5c6718b08c3b77b1076c731a802623d47eb092a131d06ab69882a4a31f64 |
| hovercard-subject-tag | pull_request:2350587740 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/IntelPython/dpctl/pull/2012/files |
| twitter:image | https://avatars.githubusercontent.com/u/46709016?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/46709016?s=400&v=4 |
| og:image:alt | This PR cleans up indexing functions Renames Python bindings from usm_ndarray_take and usm_ndarray_put to py_take and py_put to improve consistency with the rest of dpctl Removes indexing mode mac... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b278ad162d35332b6de714dfb005de04386c4d92df6475522bef910f491a35ee |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/IntelPython/dpctl git https://github.com/IntelPython/dpctl.git |
| octolytics-dimension-user_id | 20491374 |
| octolytics-dimension-user_login | IntelPython |
| octolytics-dimension-repository_id | 279842328 |
| octolytics-dimension-repository_nwo | IntelPython/dpctl |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 279842328 |
| octolytics-dimension-repository_network_root_nwo | IntelPython/dpctl |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 39aed5006635ab6f45e6b77d23e73b08a00272a3 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width