René's URL Explorer Experiment


Title: Feb 10 change to ldap_attribute_store.py broke 'no ldap record found'. · Issue #488 · IdentityPython/SATOSA · GitHub

Open Graph Title: Feb 10 change to ldap_attribute_store.py broke 'no ldap record found'. · Issue #488 · IdentityPython/SATOSA

X Title: Feb 10 change to ldap_attribute_store.py broke 'no ldap record found'. · Issue #488 · IdentityPython/SATOSA

Description: Previously there was a section of code that started on line 586 which handles whether or not an LDAP record was found. It takes the following format. if record: ... else: ... On the commit found here: 4b9c83b That got nested under a for ...

Open Graph Description: Previously there was a section of code that started on line 586 which handles whether or not an LDAP record was found. It takes the following format. if record: ... else: ... On the commit found he...

X Description: Previously there was a section of code that started on line 586 which handles whether or not an LDAP record was found. It takes the following format. if record: ... else: ... On the commit found he...

Opengraph URL: https://github.com/IdentityPython/SATOSA/issues/488

X: @github

direct link

Domain: patch-diff.githubusercontent.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Feb 10 change to ldap_attribute_store.py broke 'no ldap record found'.","articleBody":"Previously there was a section of code that started on line 586 which handles whether or not an LDAP record was found. It takes the following format.\n```\nif record:\n    ...\nelse:\n   ...\n```\n\nOn the commit found here: https://github.com/IdentityPython/SATOSA/commit/4b9c83b966392c3f732a6a85c63994e6f832643e \nThat got nested under a for loop in attempt to process multiple records like such:\n```\nfor record in responses:\n    if record:\n        ...\n    else:\n        ...\n```\n\nThe problem is that if no record exists in responses, the else clause will never be executed, because the for loop will be entirely skipped. (That is of course after you get passed the error of 'responses' not being assigned: \"UnboundLocalError: local variable 'responses' referenced before\").\n\nIt's likely that it was intended to be something like below instead.\n```\n# Address responses being an Unboundlocal when no record is found, then...\n\nif responses:\n    for record in responses:\n        ...\nelse:\n    ...\n```\n\nI've posted the Pull Request to resolve this: [Fix for issue 488](https://github.com/IdentityPython/SATOSA/pull/489)","author":{"url":"https://github.com/aaschenbrener","@type":"Person","name":"aaschenbrener"},"datePublished":"2025-04-24T15:00:57.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/488/SATOSA/issues/488"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:3ddecd61-7702-1767-e269-c970be9c03ef
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id96CA:34DEC:5326A0:74A1D4:6970AA7C
html-safe-nonceb0d96c234e157fc7c1adc9dee97cf06feb6e71f4a7a18aba3a0e2b1d17d00b4e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NkNBOjM0REVDOjUzMjZBMDo3NEExRDQ6Njk3MEFBN0MiLCJ2aXNpdG9yX2lkIjoiMjA3MDAxMzkwMzAxNjg2NDM4MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc12c3333a717cc303fd2397b0ef68a1e4fa55b0d87a6b5295c36086d6ea95688
hovercard-subject-tagissue:3017586949
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/IdentityPython/SATOSA/488/issue_layout
twitter:imagehttps://opengraph.githubassets.com/065a0684de5379b84ee5cf3774f6d143bb860de101dfc61be0a55bc4905cd923/IdentityPython/SATOSA/issues/488
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/065a0684de5379b84ee5cf3774f6d143bb860de101dfc61be0a55bc4905cd923/IdentityPython/SATOSA/issues/488
og:image:altPreviously there was a section of code that started on line 586 which handles whether or not an LDAP record was found. It takes the following format. if record: ... else: ... On the commit found he...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaaschenbrener
hostnamegithub.com
expected-hostnamegithub.com
None5246860f280a060af866c1c633f74a6720ad2dd5d576534e4c5e462496b693ae
turbo-cache-controlno-preview
go-importgithub.com/IdentityPython/SATOSA git https://github.com/IdentityPython/SATOSA.git
octolytics-dimension-user_id29101624
octolytics-dimension-user_loginIdentityPython
octolytics-dimension-repository_id41785805
octolytics-dimension-repository_nwoIdentityPython/SATOSA
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id41785805
octolytics-dimension-repository_network_root_nwoIdentityPython/SATOSA
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7d29ab0ba8deb7bbecf06b664759d4e847623783
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/IdentityPython/SATOSA/issues/488#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FIdentityPython%2FSATOSA%2Fissues%2F488
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FIdentityPython%2FSATOSA%2Fissues%2F488
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=IdentityPython%2FSATOSA
Reloadhttps://patch-diff.githubusercontent.com/IdentityPython/SATOSA/issues/488
Reloadhttps://patch-diff.githubusercontent.com/IdentityPython/SATOSA/issues/488
Reloadhttps://patch-diff.githubusercontent.com/IdentityPython/SATOSA/issues/488
IdentityPython https://patch-diff.githubusercontent.com/IdentityPython
SATOSAhttps://patch-diff.githubusercontent.com/IdentityPython/SATOSA
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2FIdentityPython%2FSATOSA
Fork 136 https://patch-diff.githubusercontent.com/login?return_to=%2FIdentityPython%2FSATOSA
Star 253 https://patch-diff.githubusercontent.com/login?return_to=%2FIdentityPython%2FSATOSA
Code https://patch-diff.githubusercontent.com/IdentityPython/SATOSA
Issues 55 https://patch-diff.githubusercontent.com/IdentityPython/SATOSA/issues
Pull requests 33 https://patch-diff.githubusercontent.com/IdentityPython/SATOSA/pulls
Actions https://patch-diff.githubusercontent.com/IdentityPython/SATOSA/actions
Projects 0 https://patch-diff.githubusercontent.com/IdentityPython/SATOSA/projects
Wiki https://patch-diff.githubusercontent.com/IdentityPython/SATOSA/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/IdentityPython/SATOSA/security
Please reload this pagehttps://patch-diff.githubusercontent.com/IdentityPython/SATOSA/issues/488
Insights https://patch-diff.githubusercontent.com/IdentityPython/SATOSA/pulse
Code https://patch-diff.githubusercontent.com/IdentityPython/SATOSA
Issues https://patch-diff.githubusercontent.com/IdentityPython/SATOSA/issues
Pull requests https://patch-diff.githubusercontent.com/IdentityPython/SATOSA/pulls
Actions https://patch-diff.githubusercontent.com/IdentityPython/SATOSA/actions
Projects https://patch-diff.githubusercontent.com/IdentityPython/SATOSA/projects
Wiki https://patch-diff.githubusercontent.com/IdentityPython/SATOSA/wiki
Security https://patch-diff.githubusercontent.com/IdentityPython/SATOSA/security
Insights https://patch-diff.githubusercontent.com/IdentityPython/SATOSA/pulse
New issuehttps://patch-diff.githubusercontent.com/login?return_to=https://github.com/IdentityPython/SATOSA/issues/488
New issuehttps://patch-diff.githubusercontent.com/login?return_to=https://github.com/IdentityPython/SATOSA/issues/488
Feb 10 change to ldap_attribute_store.py broke 'no ldap record found'.https://patch-diff.githubusercontent.com/IdentityPython/SATOSA/issues/488#top
https://github.com/aaschenbrener
https://github.com/aaschenbrener
aaschenbrenerhttps://github.com/aaschenbrener
on Apr 24, 2025https://github.com/IdentityPython/SATOSA/issues/488#issue-3017586949
4b9c83bhttps://github.com/IdentityPython/SATOSA/commit/4b9c83b966392c3f732a6a85c63994e6f832643e
Fix for issue 488https://github.com/IdentityPython/SATOSA/pull/489
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.