René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Interop.cs minor changes","articleBody":"Hi,\r\n\r\nI just wanted to leave this here in case anyone is interested in adding this. It may not be suitable due to compatibility requirements on the project, but the changes get rid of some warnings for newer C# and .NET.\r\n\r\n```patch\r\ndiff --git a/Interop.cs b/Interop.cs\r\nindex 99544ba..c864c8c 100644\r\n--- a/Interop.cs\r\n+++ b/Interop.cs\r\n@@ -1,16 +1,10 @@\r\n-using System;\r\n-using System.Collections.Generic;\r\n-using System.ComponentModel;\r\n-using System.Diagnostics;\r\n-using System.Linq;\r\n+using System.ComponentModel;\r\n using System.Runtime.InteropServices;\r\n-using System.Security.Principal;\r\n using System.Text;\r\n-using System.Text.RegularExpressions;\r\n \r\n namespace SharpDPAPI\r\n {\r\n     public class Interop\r\n     {\r\n         public enum CryptAlgClass : uint\r\n         {\r\n@@ -164,15 +158,15 @@ namespace SharpDPAPI\r\n             {\r\n                 Marshal.FreeHGlobal(buffer);\r\n                 buffer = IntPtr.Zero;\r\n             }\r\n \r\n             public override string ToString()\r\n             {\r\n-                return Marshal.PtrToStringUni(buffer);\r\n+                return Marshal.PtrToStringUni(buffer) ?? \"\";\r\n             }\r\n         }\r\n \r\n         // From Vincent LE TOUX' \"MakeMeEnterpriseAdmin\"\r\n         //  https://github.com/vletoux/MakeMeEnterpriseAdmin/blob/master/MakeMeEnterpriseAdmin.ps1#L1773-L1794\r\n         [StructLayout(LayoutKind.Sequential)]\r\n         public struct KERB_ECRYPT\r\n@@ -280,15 +274,15 @@ namespace SharpDPAPI\r\n             {\r\n                 Marshal.FreeHGlobal(buffer);\r\n                 buffer = IntPtr.Zero;\r\n             }\r\n \r\n             public override string ToString()\r\n             {\r\n-                return Marshal.PtrToStringUni(buffer);\r\n+                return Marshal.PtrToStringUni(buffer) ?? \"\";\r\n             }\r\n         }\r\n \r\n         [StructLayout(LayoutKind.Sequential, CharSet = CharSet.Unicode)]\r\n         public struct DOMAIN_CONTROLLER_INFO\r\n         {\r\n             [MarshalAs(UnmanagedType.LPTStr)]\r\n@@ -545,29 +539,33 @@ namespace SharpDPAPI\r\n         public  static extern int NetApiBufferFree(IntPtr Buffer);\r\n \r\n \r\n         public static string GetDCName()\r\n         {\r\n             // retrieves the current domain controller name\r\n             // adapted from https://www.pinvoke.net/default.aspx/netapi32.dsgetdcname\r\n-            DOMAIN_CONTROLLER_INFO domainInfo;\r\n+            DOMAIN_CONTROLLER_INFO? domainInfo;\r\n             const int ERROR_SUCCESS = 0;\r\n             IntPtr pDCI = IntPtr.Zero;\r\n \r\n             int val = DsGetDcName(\"\", \"\", 0, \"\",\r\n             DSGETDCNAME_FLAGS.DS_DIRECTORY_SERVICE_REQUIRED |\r\n             DSGETDCNAME_FLAGS.DS_RETURN_DNS_NAME |\r\n             DSGETDCNAME_FLAGS.DS_IP_REQUIRED, out pDCI);\r\n \r\n             if (ERROR_SUCCESS == val)\r\n             {\r\n-                domainInfo = (DOMAIN_CONTROLLER_INFO)Marshal.PtrToStructure(pDCI, typeof(DOMAIN_CONTROLLER_INFO));\r\n-                string dcName = domainInfo.DomainControllerName;\r\n+                domainInfo = (DOMAIN_CONTROLLER_INFO?)Marshal.PtrToStructure(pDCI, typeof(DOMAIN_CONTROLLER_INFO));\r\n+                if (domainInfo is null)\r\n+                {\r\n+                    return \"\";\r\n+                }\r\n+                string? dcName = domainInfo?.DomainControllerName;\r\n                 NetApiBufferFree(pDCI);\r\n-                return dcName.Trim('\\\\');\r\n+                return dcName?.Trim('\\\\') ?? \"\";\r\n             }\r\n             else\r\n             {\r\n                 string errorMessage = new Win32Exception((int)val).Message;\r\n                 Console.WriteLine(\"\\r\\n  [X] Error {0} retrieving domain controller : {1}\", val, errorMessage);\r\n                 NetApiBufferFree(pDCI);\r\n                 return \"\";\r\n```\r\n\r\nSame patch as zipped up .diff file: [patch.zip](https://github.com/user-attachments/files/17559677/patch.zip).\r\n\r\nPS: this should apply cleanly to 4428263fe85bb1fde1640b6208d11dff6db4fb55.","author":{"url":"https://github.com/exoosh","@type":"Person","name":"exoosh"},"datePublished":"2024-10-29T15:52:11.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/41/SharpDPAPI/issues/41"}