| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:29200b93-2866-aeac-f6db-0ba0e703a8fa |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DB5C:F68EE:6D2670:8C5DF1:698E7EEF |
| html-safe-nonce | d0bfd2e1c15e2ebd38345d3e9d5a5b55ec0fd99e5514fc626c67a9b28fba4853 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjVDOkY2OEVFOjZEMjY3MDo4QzVERjE6Njk4RTdFRUYiLCJ2aXNpdG9yX2lkIjoiODg5ODQ4ODgxOTU5MTgzOTQ3MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 557b6daf8681dc00670db114c6b20c6c952dab333b9fef058548e4d8bf52ef17 |
| hovercard-subject-tag | pull_request:1400971992 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/Fastcode/NUClear/68/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/622203d66d09e30ff487b4f8ce86193ffac2a972aac9ad4ceee156ae7a408db3/Fastcode/NUClear/pull/68 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/622203d66d09e30ff487b4f8ce86193ffac2a972aac9ad4ceee156ae7a408db3/Fastcode/NUClear/pull/68 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Bidski |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb2828a801ee6b7be618f3ac76fbf55def35bbc30f053a9c41bf90210b8b72ba |
| turbo-cache-control | no-preview |
| go-import | github.com/Fastcode/NUClear git https://github.com/Fastcode/NUClear.git |
| octolytics-dimension-user_id | 4169323 |
| octolytics-dimension-user_login | Fastcode |
| octolytics-dimension-repository_id | 9468867 |
| octolytics-dimension-repository_nwo | Fastcode/NUClear |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 9468867 |
| octolytics-dimension-repository_network_root_nwo | Fastcode/NUClear |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f7a12861f7011eecb14bcc4388a767d829a52dfc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FFastcode%2FNUClear%2Fpull%2F68 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FFastcode%2FNUClear%2Fpull%2F68 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=Fastcode%2FNUClear |
| Reload | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68 |
| Reload | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68 |
| Reload | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68 |
|
Fastcode
| https://patch-diff.githubusercontent.com/Fastcode |
| NUClear | https://patch-diff.githubusercontent.com/Fastcode/NUClear |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2FFastcode%2FNUClear |
|
Fork
11
| https://patch-diff.githubusercontent.com/login?return_to=%2FFastcode%2FNUClear |
|
Star
14
| https://patch-diff.githubusercontent.com/login?return_to=%2FFastcode%2FNUClear |
|
Code
| https://patch-diff.githubusercontent.com/Fastcode/NUClear |
|
Issues
3
| https://patch-diff.githubusercontent.com/Fastcode/NUClear/issues |
|
Pull requests
12
| https://patch-diff.githubusercontent.com/Fastcode/NUClear/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/Fastcode/NUClear/actions |
|
Projects
0
| https://patch-diff.githubusercontent.com/Fastcode/NUClear/projects |
|
Security
0
| https://patch-diff.githubusercontent.com/Fastcode/NUClear/security |
|
Insights
| https://patch-diff.githubusercontent.com/Fastcode/NUClear/pulse |
|
Code
| https://patch-diff.githubusercontent.com/Fastcode/NUClear |
|
Issues
| https://patch-diff.githubusercontent.com/Fastcode/NUClear/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/Fastcode/NUClear/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/Fastcode/NUClear/actions |
|
Projects
| https://patch-diff.githubusercontent.com/Fastcode/NUClear/projects |
|
Security
| https://patch-diff.githubusercontent.com/Fastcode/NUClear/security |
|
Insights
| https://patch-diff.githubusercontent.com/Fastcode/NUClear/pulse |
| Sign up for GitHub
| https://patch-diff.githubusercontent.com/signup?return_to=%2FFastcode%2FNUClear%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://patch-diff.githubusercontent.com/login?return_to=%2FFastcode%2FNUClear%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68#issue-comment-box |
| Bidski | https://patch-diff.githubusercontent.com/Bidski |
| main | https://patch-diff.githubusercontent.com/Fastcode/NUClear/tree/main |
| biddulph/sanitisers | https://patch-diff.githubusercontent.com/Fastcode/NUClear/tree/biddulph/sanitisers |
|
Add options for compiling in sanitiser, profiling, and valgrind support for better debugging
| https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68#top |
| Bidski | https://patch-diff.githubusercontent.com/Bidski |
| main | https://patch-diff.githubusercontent.com/Fastcode/NUClear/tree/main |
| biddulph/sanitisers | https://patch-diff.githubusercontent.com/Fastcode/NUClear/tree/biddulph/sanitisers |
|
Conversation
1
| https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68 |
|
Commits
92
| https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits |
|
Checks
0
| https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/checks |
|
Files changed
| https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/files |
| Please reload this page | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68 |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Bidski | https://patch-diff.githubusercontent.com/Bidski |
| Jun 21, 2023 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68#issue-1766774421 |
| Please reload this page | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68 |
| Bidski | https://patch-diff.githubusercontent.com/Bidski |
| June 6, 2023 11:51 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68#commits-pushed-a3a10d4 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Replace volatile bools with std::atomics | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/a3a10d4ea0d95f9c433d11aa18f748be2c6098df |
| a3a10d4 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/a3a10d4ea0d95f9c433d11aa18f748be2c6098df |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Add sanitisation compile options | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/e07753dc01a2066b527fda07f3154070b6b8a70d |
| e07753d | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/e07753dc01a2066b527fda07f3154070b6b8a70d |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Add colourised compiler output | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/fb37432932d9817bb541209ffe1349e7e79ee9a6 |
| fb37432 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/fb37432932d9817bb541209ffe1349e7e79ee9a6 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Replace volatile bools with std::atomics | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/24a7848e1389a6a2c2d9626e4ad864e01b526a9f |
| 24a7848 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/24a7848e1389a6a2c2d9626e4ad864e01b526a9f |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Add unit test for sync priority queue | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/619ee7c43536b50baea55462b21dc123dd7a9151 |
| 619ee7c | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/619ee7c43536b50baea55462b21dc123dd7a9151 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Add missing include | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/4aa971d53682bcd0cdc4d1a0064b6c5f76b57f16 |
| 4aa971d | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/4aa971d53682bcd0cdc4d1a0064b6c5f76b57f16 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Add extra source annotations to improve valgrind support | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/76526bdf7fc501ce113049e7177f65cf6417b2b3 |
| 76526bd | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/76526bdf7fc501ce113049e7177f65cf6417b2b3 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Add missing includes | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/b76b397c53a78ee003d95ee8493c1977a39af9c9 |
| b76b397 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/b76b397c53a78ee003d95ee8493c1977a39af9c9 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Replace volatile bools with std::atomics | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/75a98f6a27c6c686e5162d8b97edffb4254a6961 |
| 75a98f6 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/75a98f6a27c6c686e5162d8b97edffb4254a6961 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Lock mutex before calling notify_all() | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/69480c4b1f64da6a514b84530ab6961fdbd85fc0 |
| 69480c4 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/69480c4b1f64da6a514b84530ab6961fdbd85fc0 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Use lock_guard | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/a65fe4c8c28d55ce3f20e2b87c0719bf58bdf9a0 |
| a65fe4c | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/a65fe4c8c28d55ce3f20e2b87c0719bf58bdf9a0 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Store true rather than false | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/b7a590a4f6d73efbba3301e227f612ed81fef4d1 |
| b7a590a | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/b7a590a4f6d73efbba3301e227f612ed81fef4d1 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Merge remote-tracking branch 'origin/main' into biddulph/stuff | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/b3a8525a896f72069be02ff8d8039365481e5879 |
| b3a8525 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/b3a8525a896f72069be02ff8d8039365481e5879 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Add missing includes | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/0d6722a70be8175257fdbc125d38944b0001fcbc |
| 0d6722a | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/0d6722a70be8175257fdbc125d38944b0001fcbc |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Add a Group fusion word | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/2b90f12a021a5365855e39e81ef779a239737e7b |
| 2b90f12 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/2b90f12a021a5365855e39e81ef779a239737e7b |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Add a Pool fusion word | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/8e1560765214600bd2f4d5a4f84df7e0b25501b0 |
| 8e15607 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/8e1560765214600bd2f4d5a4f84df7e0b25501b0 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Update CallbackGenerator to use pool and group | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/f3e69e32dafe2b3cfae06696f9c2d52545b59bd7 |
| f3e69e3 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/f3e69e32dafe2b3cfae06696f9c2d52545b59bd7 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Rewrite TaskScheduler to handle everything | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/0d4fd91ec7c3e7e8ca9577d53927e0185a22d55c |
| 0d4fd91 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/0d4fd91ec7c3e7e8ca9577d53927e0185a22d55c |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Add missing Pool word to Reactor | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/6243f0029952cbcfb6b8fd41cbcd2cd506cdae29 |
| 6243f00 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/6243f0029952cbcfb6b8fd41cbcd2cd506cdae29 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Add an immediate flag to ReactionTask for Direct emits | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/1f7101a9b358aaf28a8f1e5a7d77fd6cd2d130b5 |
| 1f7101a | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/1f7101a9b358aaf28a8f1e5a7d77fd6cd2d130b5 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Rewrite Always to suit new TaskScheduler | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/bfa865f27d12d8a18ffcd667f0acffd5bafff062 |
| bfa865f | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/bfa865f27d12d8a18ffcd667f0acffd5bafff062 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Change Initialise emits to an emit with no delay | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/6f5e82b39e1444d0bded838e4bab39ac08e663d7 |
| 6f5e82b | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/6f5e82b39e1444d0bded838e4bab39ac08e663d7 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Change MainThread to use the main thread pool | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/56ee199023305efe5bf5bcecf781c830611fa6af |
| 56ee199 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/56ee199023305efe5bf5bcecf781c830611fa6af |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Implement Pool DSL | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/6a1a7741612d82c8565b53981ced0a9c529972b4 |
| 6a1a774 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/6a1a7741612d82c8565b53981ced0a9c529972b4 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| #undef valgrind symbols before setting them | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/ee85a92e6a32b45e4c5750e7f379c280dc94d083 |
| ee85a92 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/ee85a92e6a32b45e4c5750e7f379c280dc94d083 |
|
| https://patch-diff.githubusercontent.com/TrentHouliston |
| Remove reschedule | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/7a3c4ef1798dcae38bd5a79d68c6beabbdd3b658 |
| 7a3c4ef | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/7a3c4ef1798dcae38bd5a79d68c6beabbdd3b658 |
|
| https://patch-diff.githubusercontent.com/TrentHouliston |
| formatting | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/daa6ce9ad99d7b943d51e02118a8542806dc8a24 |
| daa6ce9 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/daa6ce9ad99d7b943d51e02118a8542806dc8a24 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Merge remote-tracking branch 'origin/main' into biddulph/stuff | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/35729a2483cf895047dc6442eb19f81dfec3612b |
| 35729a2 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/35729a2483cf895047dc6442eb19f81dfec3612b |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Apply clang-tidy fixes | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/7eb0215b4a70a166a78eacaf1e94fb785e448156 |
| 7eb0215 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/7eb0215b4a70a166a78eacaf1e94fb785e448156 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Make Always work | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/0b9c0d84dac0e5fecc86a772035e1c012ffb7e24 |
| 0b9c0d8 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/0b9c0d84dac0e5fecc86a772035e1c012ffb7e24 |
| Bidski | https://patch-diff.githubusercontent.com/Bidski |
| June 20, 2023 16:48 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68#commits-pushed-f3e4b44 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Simplify diff in ChronoController | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/f3e4b44f6b61c9ecdb15605df3dc4a325d088279 |
| f3e4b44 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/f3e4b44f6b61c9ecdb15605df3dc4a325d088279 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Simplify statics for pools and groups | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/3884744adc917dc99fd3557e81e2aefd5c619d2f |
| 3884744 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/3884744adc917dc99fd3557e81e2aefd5c619d2f |
|
| https://patch-diff.githubusercontent.com/Bidski |
| RAII-ify current_task | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/d1628b986aed6e3b654edd108b9bb4ed56cf295a |
| d1628b9 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/d1628b986aed6e3b654edd108b9bb4ed56cf295a |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Make sure nullptrs are sorted first | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/1d37e2084d49308884500a1a5a8e4aeaad64222f |
| 1d37e20 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/1d37e2084d49308884500a1a5a8e4aeaad64222f |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Unify thread pool structs | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/1003343018e12379a9dc40d64cde576625dc8453 |
| 1003343 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/1003343018e12379a9dc40d64cde576625dc8453 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Make CallbackGenerator constructor explicit | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/6fad9fb65913bc546b13369c0e85c47ac133eb06 |
| 6fad9fb | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/6fad9fb65913bc546b13369c0e85c47ac133eb06 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Revert "Make CallbackGenerator constructor explicit" | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/73653dc66bcfe18fd4982bca397d3f209ab12881 |
| 73653dc | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/73653dc66bcfe18fd4982bca397d3f209ab12881 |
| 6fad9fb | https://github.com/Fastcode/NUClear/commit/6fad9fb65913bc546b13369c0e85c47ac133eb06 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Fix post-shutdown logging | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/7ae4e7558e3aab60abb9f10fce024794458a91e1 |
| 7ae4e75 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/7ae4e7558e3aab60abb9f10fce024794458a91e1 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Emit a lot more messages for SingleSync test | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/071f0749581ba5cc6b2c27be80d50531fce8ea2c |
| 071f074 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/071f0749581ba5cc6b2c27be80d50531fce8ea2c |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Fix up comments | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/312d28d442a92297939aad37c5705f7b1dff7225 |
| 312d28d | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/312d28d442a92297939aad37c5705f7b1dff7225 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Revert RAII-ify | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/fcffd7b320a83b75e4d7e5c15651c184b58c7eaa |
| fcffd7b | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/fcffd7b320a83b75e4d7e5c15651c184b58c7eaa |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Do thread poking once before joining | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/eebe07deb182db5317a6bf54b387c11094574e52 |
| eebe07d | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/eebe07deb182db5317a6bf54b387c11094574e52 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Base Sync on Group | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/6281e95b9e3d124c2ae9ac563d4ee440bb8edda2 |
| 6281e95 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/6281e95b9e3d124c2ae9ac563d4ee440bb8edda2 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Include Group in Reactor | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/839556943036e3d0bd87de8a201b2e8d46917026 |
| 8395569 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/839556943036e3d0bd87de8a201b2e8d46917026 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Remove valgrind and sanitiser stuff | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/fdd146974517f51532f6de7c14cb1f8fb00d778b |
| fdd1469 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/fdd146974517f51532f6de7c14cb1f8fb00d778b |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Add options for valgrind, sanitisers, and profiling | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/bbb3abcea7b0081bb06d46fe3196436ab26af1d4 |
| bbb3abc | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/bbb3abcea7b0081bb06d46fe3196436ab26af1d4 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Fix up cmake formatting | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/cbb3134ce4e19bb4daeee6dc42f892e16b044cd1 |
| cbb3134 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/cbb3134ce4e19bb4daeee6dc42f892e16b044cd1 |
| https://patch-diff.githubusercontent.com/Bidski |
| Bidski | https://patch-diff.githubusercontent.com/Bidski |
| TrentHouliston | https://patch-diff.githubusercontent.com/TrentHouliston |
| June 21, 2023 05:49 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68#event-9588308768 |
| Bidski | https://patch-diff.githubusercontent.com/Bidski |
| June 21, 2023 15:56 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68#commits-pushed-9ea6f63 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| clang-tidy | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/9ea6f63605411803364af2a85ee65b9dd574d987 |
| 9ea6f63 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/9ea6f63605411803364af2a85ee65b9dd574d987 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Merge branch 'biddulph/stuff' into biddulph/sanitisers | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/79f576d232eb5f76a10cdd2100ec75ac32a7240e |
| 79f576d | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/79f576d232eb5f76a10cdd2100ec75ac32a7240e |
| https://patch-diff.githubusercontent.com/Bidski |
| Bidski | https://patch-diff.githubusercontent.com/Bidski |
| June 23, 2023 04:47 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68#event-9613570539 |
| Bidski | https://patch-diff.githubusercontent.com/Bidski |
| June 23, 2023 15:05 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68#commits-pushed-68da88a |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Rebase on main | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/68da88a3388427c726e9ff4a70859a42898573f2 |
| 68da88a | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/68da88a3388427c726e9ff4a70859a42898573f2 |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Finish rebase | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/21cfbed41fa27bf9dffaf7d149f2395cb6b9ddee |
| 21cfbed | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/21cfbed41fa27bf9dffaf7d149f2395cb6b9ddee |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Finish finish rebase | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/61eca93075cebba3bd1467cdb83f0de6434f33fd |
| 61eca93 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/61eca93075cebba3bd1467cdb83f0de6434f33fd |
|
| https://patch-diff.githubusercontent.com/Bidski |
| Merge branch 'main' into biddulph/sanitisers | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/f8e138a17608a78fa7d5949079705ec3779b3f75 |
| f8e138a | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/f8e138a17608a78fa7d5949079705ec3779b3f75 |
| https://patch-diff.githubusercontent.com/apps/sonarqubecloud |
| sonarqubecloud | https://patch-diff.githubusercontent.com/apps/sonarqubecloud |
| Sep 9, 2023 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68#issuecomment-1712500949 |
| https://sonarcloud.io/dashboard?id=Fastcode_NUClear&pullRequest=68 |
| https://sonarcloud.io/project/issues?id=Fastcode_NUClear&pullRequest=68&resolved=false&types=BUG |
| https://sonarcloud.io/project/issues?id=Fastcode_NUClear&pullRequest=68&resolved=false&types=BUG |
| 0 Bugs | https://sonarcloud.io/project/issues?id=Fastcode_NUClear&pullRequest=68&resolved=false&types=BUG |
| https://sonarcloud.io/project/issues?id=Fastcode_NUClear&pullRequest=68&resolved=false&types=VULNERABILITY |
| https://sonarcloud.io/project/issues?id=Fastcode_NUClear&pullRequest=68&resolved=false&types=VULNERABILITY |
| 0 Vulnerabilities | https://sonarcloud.io/project/issues?id=Fastcode_NUClear&pullRequest=68&resolved=false&types=VULNERABILITY |
| https://sonarcloud.io/project/security_hotspots?id=Fastcode_NUClear&pullRequest=68&resolved=false&types=SECURITY_HOTSPOT |
| https://sonarcloud.io/project/security_hotspots?id=Fastcode_NUClear&pullRequest=68&resolved=false&types=SECURITY_HOTSPOT |
| 0 Security Hotspots | https://sonarcloud.io/project/security_hotspots?id=Fastcode_NUClear&pullRequest=68&resolved=false&types=SECURITY_HOTSPOT |
| https://sonarcloud.io/project/issues?id=Fastcode_NUClear&pullRequest=68&resolved=false&types=CODE_SMELL |
| https://sonarcloud.io/project/issues?id=Fastcode_NUClear&pullRequest=68&resolved=false&types=CODE_SMELL |
| 5 Code Smells | https://sonarcloud.io/project/issues?id=Fastcode_NUClear&pullRequest=68&resolved=false&types=CODE_SMELL |
| https://sonarcloud.io/component_measures?id=Fastcode_NUClear&pullRequest=68 |
| https://sonarcloud.io/component_measures?id=Fastcode_NUClear&pullRequest=68&metric=new_duplicated_lines_density&view=list |
| 0.0% Duplication | https://sonarcloud.io/component_measures?id=Fastcode_NUClear&pullRequest=68&metric=new_duplicated_lines_density&view=list |
| Please reload this page | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68 |
|
| https://patch-diff.githubusercontent.com/TrentHouliston |
| Merge branch 'main' into biddulph/sanitisers | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/69d899d0c84c3960ebe373fa4b1f1c989b52f5bd |
| 69d899d | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68/commits/69d899d0c84c3960ebe373fa4b1f1c989b52f5bd |
| TrentHouliston | https://patch-diff.githubusercontent.com/TrentHouliston |
|
Aug 14, 2024
| https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68#ref-commit-5a0488a |
|
| https://patch-diff.githubusercontent.com/TrentHouliston |
| Add options for enabling sanitisers, Partially replaces | https://patch-diff.githubusercontent.com/Fastcode/NUClear/commit/5a0488a6a87b286f1c357655e2280a14176f03c7 |
| #68 | https://github.com/Fastcode/NUClear/pull/68 |
| 5a0488a | https://patch-diff.githubusercontent.com/Fastcode/NUClear/commit/5a0488a6a87b286f1c357655e2280a14176f03c7 |
| https://patch-diff.githubusercontent.com/TrentHouliston |
| TrentHouliston | https://patch-diff.githubusercontent.com/TrentHouliston |
|
Aug 14, 2024
| https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68#ref-pullrequest-2464826654 |
|
Add options for enabling sanitisers
#119
| https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/119 |
| TrentHouliston | https://patch-diff.githubusercontent.com/TrentHouliston |
|
Aug 14, 2024
| https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68#ref-commit-4640ec3 |
|
| https://patch-diff.githubusercontent.com/TrentHouliston |
| Add options for enabling sanitisers ( | https://patch-diff.githubusercontent.com/Fastcode/NUClear/commit/4640ec3169c2f4c5f2827eeefc98cfe75b72eb8d |
| #119 | https://github.com/Fastcode/NUClear/pull/119 |
| ) | https://patch-diff.githubusercontent.com/Fastcode/NUClear/commit/4640ec3169c2f4c5f2827eeefc98cfe75b72eb8d |
| 4640ec3 | https://patch-diff.githubusercontent.com/Fastcode/NUClear/commit/4640ec3169c2f4c5f2827eeefc98cfe75b72eb8d |
| #68 | https://github.com/Fastcode/NUClear/pull/68 |
| #68 | https://github.com/Fastcode/NUClear/pull/68 |
| #68 | https://github.com/Fastcode/NUClear/pull/68 |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in to comment | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FFastcode%2FNUClear%2Fpull%2F68 |
|
| https://patch-diff.githubusercontent.com/TrentHouliston |
|
TrentHouliston
| https://patch-diff.githubusercontent.com/TrentHouliston |
| Please reload this page | https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/68 |
|
| https://patch-diff.githubusercontent.com/Bidski |
|
| https://patch-diff.githubusercontent.com/TrentHouliston |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |