René's URL Explorer Experiment


Title: Improve how thread priority is applied by TrentHouliston · Pull Request #162 · Fastcode/NUClear · GitHub

Open Graph Title: Improve how thread priority is applied by TrentHouliston · Pull Request #162 · Fastcode/NUClear

X Title: Improve how thread priority is applied by TrentHouliston · Pull Request #162 · Fastcode/NUClear

Description: Restore the API keeping the enums, and make ThreadPriority be an RAII object to better handle setting and restoring it. Also change what each of the levels mean now that enums let specific behaviou...

Open Graph Description: Restore the API keeping the enums, and make ThreadPriority be an RAII object to better handle setting and restoring it. Also change what each of the levels mean now that enums let specific behaviou...

X Description: Restore the API keeping the enums, and make ThreadPriority be an RAII object to better handle setting and restoring it. Also change what each of the levels mean now that enums let specific behaviou...

Opengraph URL: https://github.com/Fastcode/NUClear/pull/162

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1c9a0c1a-6368-d61e-0e46-81517cf827d1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8444:21106F:37627F:4AA9CE:698F1F1A
html-safe-nonceaca6afe9f1bb265f32cf729747da4177456484d63f5f5b8b1b4cc83d86680c9f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDQ0OjIxMTA2RjozNzYyN0Y6NEFBOUNFOjY5OEYxRjFBIiwidmlzaXRvcl9pZCI6IjM3NzkxNzEzMDQ5NjExNTQ4NDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca11ccf8fff094b864aac947cecd3be4805bf376b3770685bb09812a5c4101b2d
hovercard-subject-tagpull_request:2249246466
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/Fastcode/NUClear/162/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ac4bac33ce226951d7be8e1f962ab837c0d8a79a87898a3c11c0f7b89bbc0daf/Fastcode/NUClear/pull/162
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ac4bac33ce226951d7be8e1f962ab837c0d8a79a87898a3c11c0f7b89bbc0daf/Fastcode/NUClear/pull/162
og:image:altRestore the API keeping the enums, and make ThreadPriority be an RAII object to better handle setting and restoring it. Also change what each of the levels mean now that enums let specific behaviou...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrentHouliston
hostnamegithub.com
expected-hostnamegithub.com
None6102991c714c1a6a27d05fb4f96ea6ca87a6750b4f093b95cc57ed1b84b145a1
turbo-cache-controlno-preview
go-importgithub.com/Fastcode/NUClear git https://github.com/Fastcode/NUClear.git
octolytics-dimension-user_id4169323
octolytics-dimension-user_loginFastcode
octolytics-dimension-repository_id9468867
octolytics-dimension-repository_nwoFastcode/NUClear
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id9468867
octolytics-dimension-repository_network_root_nwoFastcode/NUClear
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1f991dff419ee6d80807c889c647c151386ba074
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FFastcode%2FNUClear%2Fpull%2F162
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FFastcode%2FNUClear%2Fpull%2F162
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=Fastcode%2FNUClear
Reloadhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162
Reloadhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162
Reloadhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162
Fastcode https://patch-diff.githubusercontent.com/Fastcode
NUClearhttps://patch-diff.githubusercontent.com/Fastcode/NUClear
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2FFastcode%2FNUClear
Fork 11 https://patch-diff.githubusercontent.com/login?return_to=%2FFastcode%2FNUClear
Star 14 https://patch-diff.githubusercontent.com/login?return_to=%2FFastcode%2FNUClear
Code https://patch-diff.githubusercontent.com/Fastcode/NUClear
Issues 3 https://patch-diff.githubusercontent.com/Fastcode/NUClear/issues
Pull requests 12 https://patch-diff.githubusercontent.com/Fastcode/NUClear/pulls
Actions https://patch-diff.githubusercontent.com/Fastcode/NUClear/actions
Projects 0 https://patch-diff.githubusercontent.com/Fastcode/NUClear/projects
Security 0 https://patch-diff.githubusercontent.com/Fastcode/NUClear/security
Insights https://patch-diff.githubusercontent.com/Fastcode/NUClear/pulse
Code https://patch-diff.githubusercontent.com/Fastcode/NUClear
Issues https://patch-diff.githubusercontent.com/Fastcode/NUClear/issues
Pull requests https://patch-diff.githubusercontent.com/Fastcode/NUClear/pulls
Actions https://patch-diff.githubusercontent.com/Fastcode/NUClear/actions
Projects https://patch-diff.githubusercontent.com/Fastcode/NUClear/projects
Security https://patch-diff.githubusercontent.com/Fastcode/NUClear/security
Insights https://patch-diff.githubusercontent.com/Fastcode/NUClear/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2FFastcode%2FNUClear%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2FFastcode%2FNUClear%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162#issue-comment-box
TrentHoulistonhttps://patch-diff.githubusercontent.com/TrentHouliston
mainhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/tree/main
houliston/priority-changeshttps://patch-diff.githubusercontent.com/Fastcode/NUClear/tree/houliston/priority-changes
Improve how thread priority is applied https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162#top
TrentHoulistonhttps://patch-diff.githubusercontent.com/TrentHouliston
mainhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/tree/main
houliston/priority-changeshttps://patch-diff.githubusercontent.com/Fastcode/NUClear/tree/houliston/priority-changes
Conversation 8 https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162
Commits 83 https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits
Checks 11 https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/checks
Files changed https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/files
Please reload this pagehttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/TrentHouliston
TrentHoulistonhttps://patch-diff.githubusercontent.com/TrentHouliston
Dec 23, 2024https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162#issue-2755727073
Please reload this pagehttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162
Please reload this pagehttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162
CMurtagh-LGTMhttps://patch-diff.githubusercontent.com/CMurtagh-LGTM
December 15, 2024 17:28https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162#commits-pushed-971f512
https://patch-diff.githubusercontent.com/CMurtagh-LGTM
[https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/971f512ff9b7a002ef7d03e76b5df7b631e8b6b7
#56https://github.com/Fastcode/NUClear/issues/56
] Fix update current thread priority for linux and make an enumhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/971f512ff9b7a002ef7d03e76b5df7b631e8b6b7
971f512https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/971f512ff9b7a002ef7d03e76b5df7b631e8b6b7
https://patch-diff.githubusercontent.com/CMurtagh-LGTM
add documentation to Priority DSL and utilhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/016dce31c153a7098440931481956b8287c0665f
016dce3https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/016dce31c153a7098440931481956b8287c0665f
https://patch-diff.githubusercontent.com/CMurtagh-LGTM
fix testshttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/2dba179205fc4083ceb5e1079afab7ee3293dbf7
2dba179https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/2dba179205fc4083ceb5e1079afab7ee3293dbf7
https://patch-diff.githubusercontent.com/TrentHouliston
Restore the API keeping the enums, and make ThreadPriority be an RAII…https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/078dfd9853ff1bdfc8080d04249f1a88fd50ca7a
078dfd9https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/078dfd9853ff1bdfc8080d04249f1a88fd50ca7a
https://patch-diff.githubusercontent.com/TrentHouliston
Refactor logging and allow setting a minimum log level that should no…https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/d128891ff577739612af61d95864093f82e3d2f6
d128891https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/d128891ff577739612af61d95864093f82e3d2f6
#161https://github.com/Fastcode/NUClear/pull/161
https://patch-diff.githubusercontent.com/TrentHouliston
TrentHoulistonhttps://patch-diff.githubusercontent.com/TrentHouliston
December 23, 2024 10:38https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162#event-15746640721
TrentHoulistonhttps://patch-diff.githubusercontent.com/TrentHouliston
December 23, 2024 21:40https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162#commits-pushed-bf98d60
https://patch-diff.githubusercontent.com/TrentHouliston
Merge remote-tracking branch 'origin/main' into houliston/priority-ch…https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/bf98d6041e1a83a6ea34d04e027a6f4c39a0014f
bf98d60https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/bf98d6041e1a83a6ea34d04e027a6f4c39a0014f
https://patch-diff.githubusercontent.com/TrentHouliston
Some smart enum fixeshttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/11b2b5dc89b7d71c02e2fef267027bf59066520a
11b2b5dhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/11b2b5dc89b7d71c02e2fef267027bf59066520a
https://patch-diff.githubusercontent.com/TrentHouliston
Didn't need thishttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/2b6c08dbed94c585fdf910a879308e904030ab55
2b6c08dhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/2b6c08dbed94c585fdf910a879308e904030ab55
https://patch-diff.githubusercontent.com/TrentHouliston
Merge branch 'main' into houliston/priority-changeshttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/d3b15fd2331a5b975869aff034bcbd90a4cfb4dd
d3b15fdhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/d3b15fd2331a5b975869aff034bcbd90a4cfb4dd
https://patch-diff.githubusercontent.com/TrentHouliston
Minor fixeshttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/5dcba82ac59c471fb79d4886e6aed2fe20e70b4c
5dcba82https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/5dcba82ac59c471fb79d4886e6aed2fe20e70b4c
https://patch-diff.githubusercontent.com/TrentHouliston
.https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/f3ad6e6a7cb80b63e3bfb269f931cf94c105768e
f3ad6e6https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/f3ad6e6a7cb80b63e3bfb269f931cf94c105768e
https://patch-diff.githubusercontent.com/TrentHouliston
clang-tidyhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/cebe293054b0961f009182c20aba31f13391e1e9
cebe293https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/cebe293054b0961f009182c20aba31f13391e1e9
https://patch-diff.githubusercontent.com/TrentHouliston
clang-tidyhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/82f8464cbf0e89128e47849731354bc38064b1a8
82f8464https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/82f8464cbf0e89128e47849731354bc38064b1a8
https://patch-diff.githubusercontent.com/TrentHouliston
Fix deleted constructorhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/f13936b04e44f4036a4e274d1b952636c3cf4788
f13936bhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/f13936b04e44f4036a4e274d1b952636c3cf4788
https://patch-diff.githubusercontent.com/TrentHouliston
clang-tidyhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/36079f2e5933fe42d6a63363916a83b9a9543136
36079f2https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/36079f2e5933fe42d6a63363916a83b9a9543136
https://patch-diff.githubusercontent.com/TrentHouliston
Redundant statichttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/e8ed9506993bcf254722b689f4422dbde9fc2a6c
e8ed950https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/e8ed9506993bcf254722b689f4422dbde9fc2a6c
https://patch-diff.githubusercontent.com/TrentHouliston
clang-tidy and make setting scheduler priority ignore unknown enum va…https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/353d437c72b328ab0cbed7d855fb12deb8507809
353d437https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/353d437c72b328ab0cbed7d855fb12deb8507809
https://patch-diff.githubusercontent.com/TrentHouliston
Swap to using a different mechanism for osxhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/32c767bb1e27c4002b65dc5c2ae0f0dc4c09c2a2
32c767bhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/32c767bb1e27c4002b65dc5c2ae0f0dc4c09c2a2
https://patch-diff.githubusercontent.com/TrentHouliston
remove headerhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/925dca0f31484a7df64fd335de5a6c9335483c7f
925dca0https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/925dca0f31484a7df64fd335de5a6c9335483c7f
https://patch-diff.githubusercontent.com/TrentHouliston
Better macos setuphttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/15c6c3b9b3d32209f6fdd41ebd541c68abcbde99
15c6c3bhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/15c6c3b9b3d32209f6fdd41ebd541c68abcbde99
https://patch-diff.githubusercontent.com/TrentHouliston
.https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/27b1a9c8ece0dbd7d17c8d91f7c44655a6ee72ae
27b1a9chttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/27b1a9c8ece0dbd7d17c8d91f7c44655a6ee72ae
https://patch-diff.githubusercontent.com/TrentHouliston
Flag PriorityLevel and LogLevel constructors as noexcepthttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/a77fd6569cbc86bf3504378326b28cfa5f9c4af0
a77fd65https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/a77fd6569cbc86bf3504378326b28cfa5f9c4af0
https://patch-diff.githubusercontent.com/TrentHouliston
.https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/7ca97d8ad6062223e336bd6c59823b11ff3ed859
7ca97d8https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/7ca97d8ad6062223e336bd6c59823b11ff3ed859
https://patch-diff.githubusercontent.com/TrentHouliston
Adjust the sync-multi test to just care about relative order of event…https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/4fefe3cc512dc7a5851e08f4decdfd019fd1b768
4fefe3chttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/4fefe3cc512dc7a5851e08f4decdfd019fd1b768
https://patch-diff.githubusercontent.com/TrentHouliston
Try to work out what's wrong with gcovrhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/c665e1f74b30a05703ac53c81a5042e66d4a9e0f
c665e1fhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/c665e1f74b30a05703ac53c81a5042e66d4a9e0f
https://patch-diff.githubusercontent.com/TrentHouliston
.https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/9b85a71f6d434bc437b684a5b31ff39b0f90edc4
9b85a71https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/9b85a71f6d434bc437b684a5b31ff39b0f90edc4
https://patch-diff.githubusercontent.com/TrentHouliston
change coverage flagshttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/1b768ce8ba9f5403a1ca3fb6de80c39f1ae021e2
1b768cehttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/1b768ce8ba9f5403a1ca3fb6de80c39f1ae021e2
https://patch-diff.githubusercontent.com/TrentHouliston
Try ignoring this error since it's all the Catch2 framework stuff tha…https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/81ea199d0abee4248fb1eee3e81db40a995357a4
81ea199https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/81ea199d0abee4248fb1eee3e81db40a995357a4
https://patch-diff.githubusercontent.com/TrentHouliston
Add priority level tests, fix headers and standardise with log level …https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/3e70785fa21c2bb74c8652e012910a858e0f21c1
3e70785https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/3e70785fa21c2bb74c8652e012910a858e0f21c1
TrentHoulistonhttps://patch-diff.githubusercontent.com/TrentHouliston
February 10, 2025 17:08https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162#commits-pushed-0229942
https://patch-diff.githubusercontent.com/TrentHouliston
This did nothing!https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/0229942386589850a27783e08b4c92b807bcded4
0229942https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/0229942386589850a27783e08b4c92b807bcded4
https://patch-diff.githubusercontent.com/TrentHouliston
Try doing nothing on machttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/869edc1d5396ecae1ce86996fbf01b4ec09e6c64
869edc1https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/869edc1d5396ecae1ce86996fbf01b4ec09e6c64
https://patch-diff.githubusercontent.com/TrentHouliston
foiled by Werrorhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/47f11cc769b417c0e3710e9a6c81f5cb6fac2587
47f11cchttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/47f11cc769b417c0e3710e9a6c81f5cb6fac2587
https://patch-diff.githubusercontent.com/TrentHouliston
Match the pool priority even though it doesn't matter (system was alr…https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/e00464a413edc18c81ad4e3e68c7181a370564fc
e00464ahttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/e00464a413edc18c81ad4e3e68c7181a370564fc
https://patch-diff.githubusercontent.com/TrentHouliston
Fix datehttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/9629085c52201ba31c5f38948d81237ea01dfcd2
9629085https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/9629085c52201ba31c5f38948d81237ea01dfcd2
https://patch-diff.githubusercontent.com/TrentHouliston
Measure accuracy for the waiting at the thread priority you run athttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/a2551d5b8fed3522ff7dcd30799f6350a1d7ea0f
a2551d5https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/a2551d5b8fed3522ff7dcd30799f6350a1d7ea0f
https://patch-diff.githubusercontent.com/TrentHouliston
re-enable mac priorityhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/80cf28de60bbfed16eeb24a1ad905eecda34ebd9
80cf28dhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/80cf28de60bbfed16eeb24a1ad905eecda34ebd9
https://patch-diff.githubusercontent.com/Bidski
Bidskihttps://patch-diff.githubusercontent.com/Bidski
Feb 12, 2025 https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162#pullrequestreview-2610410571
View reviewed changes https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/files/80cf28de60bbfed16eeb24a1ad905eecda34ebd9
src/util/ThreadPriority.cpphttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/files/80cf28de60bbfed16eeb24a1ad905eecda34ebd9#diff-6eba54d8738ed462d48cbe8ceb8e9fd1030b476863c0d5b95bda849205a56bfc
Please reload this pagehttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162
TrentHoulistonhttps://patch-diff.githubusercontent.com/TrentHouliston
February 12, 2025 11:00https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162#commits-pushed-24457d6
https://patch-diff.githubusercontent.com/TrentHouliston
fix datehttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/24457d6438f92151d8608d5723abc977d3222926
24457d6https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/24457d6438f92151d8608d5723abc977d3222926
https://patch-diff.githubusercontent.com/TrentHouliston
Should be realtimehttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/f59065ed20d9fdbebf4b57e339f3871644f7aebb
f59065ehttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/f59065ed20d9fdbebf4b57e339f3871644f7aebb
https://patch-diff.githubusercontent.com/TrentHouliston
Fix bug where priority isn't sethttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/d0c167b752603b3a0b46b656d0cd04384a6abca3
d0c167bhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/d0c167b752603b3a0b46b656d0cd04384a6abca3
https://patch-diff.githubusercontent.com/TrentHouliston
Test removing setting priority for the thread pool partshttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/504e2672f38a828853dbdab650fa63746b66ad96
504e267https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/504e2672f38a828853dbdab650fa63746b66ad96
https://patch-diff.githubusercontent.com/TrentHouliston
Undo changehttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/168221fcf2aab79a8111e50544346811a00e0292
168221fhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/168221fcf2aab79a8111e50544346811a00e0292
https://patch-diff.githubusercontent.com/TrentHouliston
Add a test that thread priorityhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/f25b758a9b875b9853e539f69c5d59f7a9ca672b
f25b758https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/f25b758a9b875b9853e539f69c5d59f7a9ca672b
https://patch-diff.githubusercontent.com/TrentHouliston
.https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/89971e0a636b1ad53ec27f911a77cdf228a6090f
89971e0https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/89971e0a636b1ad53ec27f911a77cdf228a6090f
https://patch-diff.githubusercontent.com/TrentHouliston
clang-tidyhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/b3a88cdfdba6a0e24e16fa8005330b32056eb15a
b3a88cdhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/b3a88cdfdba6a0e24e16fa8005330b32056eb15a
https://patch-diff.githubusercontent.com/TrentHouliston
Add the nice capability to the test binaries so they can use the real…https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/287130615271b24755afc9805ecefd09bac51ed8
2871306https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/287130615271b24755afc9805ecefd09bac51ed8
https://patch-diff.githubusercontent.com/TrentHouliston
Set priority to normal to start withhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/c850856908e84aba4daedbe55a95741547a11956
c850856https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/c850856908e84aba4daedbe55a95741547a11956
https://patch-diff.githubusercontent.com/TrentHouliston
add sudo to the containerhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/8fcd0a3defecb9c1349a925cb10724249f823d29
8fcd0a3https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/8fcd0a3defecb9c1349a925cb10724249f823d29
https://patch-diff.githubusercontent.com/WongAaronSW
Fix Get SCHED_FIFO Calculation.https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/44db792d6618cf74cef85f5cd1ab3dcab7f89c24
44db792https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/44db792d6618cf74cef85f5cd1ab3dcab7f89c24
https://patch-diff.githubusercontent.com/TrentHouliston
make the gcc runners privliged so they can use cap_sys_nicehttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/358bc2fc3469eb4f32ab50220b1d999a4226fb43
358bc2fhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/358bc2fc3469eb4f32ab50220b1d999a4226fb43
https://patch-diff.githubusercontent.com/TrentHouliston
clang-tidyhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/02c3091a16897d0c8cd0ca3eddd59f0083db9681
02c3091https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/02c3091a16897d0c8cd0ca3eddd59f0083db9681
https://patch-diff.githubusercontent.com/TrentHouliston
clang-tidyhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/0470de83398f84248afd8fad5e440d044049a338
0470de8https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/0470de83398f84248afd8fad5e440d044049a338
https://patch-diff.githubusercontent.com/TrentHouliston
clang-tidyhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/8309ea35ef7cf614ff4b20521dd009e0e0415fea
8309ea3https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/8309ea35ef7cf614ff4b20521dd009e0e0415fea
https://patch-diff.githubusercontent.com/WongAaronSW
Give SonarCloud more time to Run Tests.https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/b98332211bdc716abb86b3e92cde980108c9c460
b983322https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/b98332211bdc716abb86b3e92cde980108c9c460
https://patch-diff.githubusercontent.com/WongAaronSW
Drop the Number of Loops in IdleSingleGlobalhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/165d759b28a9e853a9ffc637c06527fb0a6a2203
165d759https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/165d759b28a9e853a9ffc637c06527fb0a6a2203
https://patch-diff.githubusercontent.com/WongAaronSW
Revert the SonarCloud TimeUnit Changehttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/bdd071b0c49cc5a55ac85a913ccf57939e084c85
bdd071bhttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/bdd071b0c49cc5a55ac85a913ccf57939e084c85
https://patch-diff.githubusercontent.com/WongAaronSW
Change ReactionStatistics and TimeTravel Timeout to use TimeUnits.https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/afb7483c614817ff147fa4bdd6e90d3783c52acc
afb7483https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/afb7483c614817ff147fa4bdd6e90d3783c52acc
https://patch-diff.githubusercontent.com/WongAaronSW
WongAaronSWhttps://patch-diff.githubusercontent.com/WongAaronSW
Feb 13, 2025https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162#issuecomment-2655488858
Please reload this pagehttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162
https://patch-diff.githubusercontent.com/TrentHouliston
Merge branch 'main' into houliston/priority-changeshttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/2c65b6cf40c9a7ec5d3d2915880a84187a559ff5
2c65b6chttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/commits/2c65b6cf40c9a7ec5d3d2915880a84187a559ff5
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FFastcode%2FNUClear%2Fpull%2F162
https://patch-diff.githubusercontent.com/Bidski
Bidski https://patch-diff.githubusercontent.com/Bidski
https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/files/80cf28de60bbfed16eeb24a1ad905eecda34ebd9
https://patch-diff.githubusercontent.com/CMurtagh-LGTM
CMurtagh-LGTM https://patch-diff.githubusercontent.com/CMurtagh-LGTM
https://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162/files/fd86199c4264efe55dcc8487784fde9bab456de7
Thread pinning/scheduling https://github.com/Fastcode/NUClear/issues/56
Please reload this pagehttps://patch-diff.githubusercontent.com/Fastcode/NUClear/pull/162
https://patch-diff.githubusercontent.com/TrentHouliston
https://patch-diff.githubusercontent.com/WongAaronSW
https://patch-diff.githubusercontent.com/Bidski
https://patch-diff.githubusercontent.com/CMurtagh-LGTM
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.